Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Skip s3 asset deletion when in readonly mode (#19611) 

In some situations (e.g. disaster recovery), it may make sense to spin up a temporary readonly version of a cluster. In that situation, the s3 `expire_missing_assets` job would delete assets which are still in use by the canonical read-write version of the cluster.

To avoid that, this commit will skip deletion if the site is currently in readonly mode.
This commit is contained in:
David Taylor 2022-12-30 11:35:40 +00:00 committed by GitHub
parent df1a0eaece
commit eebe2f256c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/tasks/s3.rake
View File

@ -206,6 +206,11 @@ task 's3:expire_missing_assets' => :environment do
puts "Checking for stale S3 assets..." puts "Checking for stale S3 assets..."
if Discourse.readonly_mode?
puts "Discourse is in readonly mode. Skipping s3 asset deletion in case this is a read-only mirror of a live site."
exit 0
end
assets_to_delete = existing_assets.dup assets_to_delete = existing_assets.dup
# Check that all current assets are uploaded, and remove them from the to_delete list # Check that all current assets are uploaded, and remove them from the to_delete list