Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: don't error out when updating a topic with no changes

This commit is contained in:
Régis Hanol 2014-12-02 02:16:30 +01:00
parent 9bdac79ba6
commit f226e4efc0
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/topics_controller.rb
View File

@ -123,8 +123,8 @@ class TopicsController < ApplicationController
guardian.ensure_can_edit!(topic) guardian.ensure_can_edit!(topic)
changes = {} changes = {}
changes[:title] = params[:title] if params[:title] changes[:title] = params[:title] if params[:title] && topic.title != params[:title]
changes[:category_id] = params[:category_id] if params[:category_id] changes[:category_id] = params[:category_id] if params[:category_id] && topic.category_id != params[:category_id].to_i
success = true success = true

6
spec/controllers/topics_controller_spec.rb
View File

@ -783,6 +783,12 @@ describe TopicsController do
expect(response).not_to be_success expect(response).not_to be_success
end end
it "doesn't call the PostRevisor when there is no changes" do
PostRevisor.any_instance.expects(:revise!).never
xhr :put, :update, topic_id: @topic.id, slug: @topic.title, title: @topic.title, category_id: @topic.category_id
expect(response).to be_success
end
context "allow_uncategorized_topics is false" do context "allow_uncategorized_topics is false" do
before do before do
SiteSetting.stubs(:allow_uncategorized_topics).returns(false) SiteSetting.stubs(:allow_uncategorized_topics).returns(false)