Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Switch back to Chrome for running QUnit tests (#28429) 

QUnit tests are failing in different ways on Chromium in Debian
bookworm. We have no interest in figuring out why as it is not a good
use of our time and the long term plan is to switch to Chrome for Testing
anyway.
This commit is contained in:
Alan Guo Xiang Tan 2024-08-20 13:12:33 +08:00 committed by GitHub
parent b42d6faef5
commit f41c4ccfc2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.github/workflows/tests.yml vendored
View File

@ -43,6 +43,7 @@ jobs:
MINIO_RUNNER_LOG_LEVEL: DEBUG MINIO_RUNNER_LOG_LEVEL: DEBUG
DISCOURSE_TURBO_RSPEC_RETRY_AND_LOG_FLAKY_TESTS: ${{ (matrix.build_type == 'system' || matrix.build_type == 'backend') && github.ref == 'refs/main/head' }} DISCOURSE_TURBO_RSPEC_RETRY_AND_LOG_FLAKY_TESTS: ${{ (matrix.build_type == 'system' || matrix.build_type == 'backend') && github.ref == 'refs/main/head' }}
CHEAP_SOURCE_MAPS: "1" CHEAP_SOURCE_MAPS: "1"
TESTEM_DEFAULT_BROWSER: Chrome
strategy: strategy:
fail-fast: false fail-fast: false
@ -150,7 +151,7 @@ jobs:
if: matrix.target == 'themes' if: matrix.target == 'themes'
run: bin/rake themes:clone_all_official themes:pull_compatible_all run: bin/rake themes:clone_all_official themes:pull_compatible_all
- name: Add hosts to /etc/hosts, otherwise Chromium cannot reach minio - name: Add hosts to /etc/hosts, otherwise Chrome cannot reach minio
if: matrix.build_type == 'system' && matrix.target == 'core' if: matrix.build_type == 'system' && matrix.target == 'core'
run: | run: |
echo "127.0.0.1 minio.local" | sudo tee -a /etc/hosts echo "127.0.0.1 minio.local" | sudo tee -a /etc/hosts
@ -363,7 +364,7 @@ jobs:
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
browser: ["Chromium", "Firefox ESR", "Firefox Evergreen"] browser: ["Chrome", "Firefox ESR", "Firefox Evergreen"]
env: env:
TESTEM_BROWSER: ${{ (startsWith(matrix.browser, 'Firefox') && 'Firefox') || matrix.browser }} TESTEM_BROWSER: ${{ (startsWith(matrix.browser, 'Firefox') && 'Firefox') || matrix.browser }}