From f432b9f5b7856aca2f201e19f15a1f311f71de76 Mon Sep 17 00:00:00 2001
From: Sam <sam.saffron@gmail.com>
Date: Tue, 3 Mar 2015 10:20:42 +1100
Subject: [PATCH] correct spec failure, only test code was affected

---
 app/services/random_topic_selector.rb |  1 +
 lib/topic_query.rb                    |  2 +-
 spec/components/topic_query_spec.rb   | 26 +++++++++++++++-----------
 3 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/app/services/random_topic_selector.rb b/app/services/random_topic_selector.rb
index 8ce962f760b..7c2026b5eff 100644
--- a/app/services/random_topic_selector.rb
+++ b/app/services/random_topic_selector.rb
@@ -72,6 +72,7 @@ class RandomTopicSelector
     Category.select(:id).each do |c|
       $redis.del cache_key(c)
     end
+    $redis.del cache_key
   end
 
   def self.cache_key(category=nil)
diff --git a/lib/topic_query.rb b/lib/topic_query.rb
index 8269050bf2d..0b21c04e76b 100644
--- a/lib/topic_query.rb
+++ b/lib/topic_query.rb
@@ -425,7 +425,7 @@ class TopicQuery
       max = (count*1.3).to_i
       ids = RandomTopicSelector.next(max) + RandomTopicSelector.next(max, topic.category)
 
-      result.where(id: ids)
+      result.where(id: ids.uniq)
     end
 
     def suggested_ordering(result, options)
diff --git a/spec/components/topic_query_spec.rb b/spec/components/topic_query_spec.rb
index 5478add669e..be4df3ae6db 100644
--- a/spec/components/topic_query_spec.rb
+++ b/spec/components/topic_query_spec.rb
@@ -432,6 +432,10 @@ describe TopicQuery do
 
     context 'when logged in' do
 
+      before do
+        RandomTopicSelector.clear_cache!
+      end
+
       let(:topic) { Fabricate(:topic) }
       let(:suggested_topics) { topic_query.list_suggested_for(topic).topics.map{|t| t.id} }
 
@@ -450,7 +454,6 @@ describe TopicQuery do
         let!(:fully_read_archived) { Fabricate(:post, user: creator).topic }
 
         before do
-          RandomTopicSelector.clear_cache!
           user.auto_track_topics_after_msecs = 0
           user.save
           TopicUser.update_last_read(user, partially_read.id, 0, 0)
@@ -463,6 +466,17 @@ describe TopicQuery do
           fully_read_archived.save
         end
 
+
+        it "returns unread, then new, then random" do
+          SiteSetting.suggested_topics = 7
+          expect(suggested_topics[0]).to eq(partially_read.id)
+          expect(suggested_topics[1,3]).to include(new_topic.id)
+          expect(suggested_topics[1,3]).to include(closed_topic.id)
+          expect(suggested_topics[1,3]).to include(archived_topic.id)
+          expect(suggested_topics[4]).to eq(fully_read.id)
+          # random doesn't include closed and archived
+        end
+
         it "won't return new or fully read if there are enough partially read topics" do
           SiteSetting.suggested_topics = 1
           expect(suggested_topics).to eq([partially_read.id])
@@ -476,16 +490,6 @@ describe TopicQuery do
           expect(suggested_topics[1,3]).to include(archived_topic.id)
         end
 
-        # it "returns unread, then new, then random" do
-        #   SiteSetting.suggested_topics = 7
-        #   expect(suggested_topics[0]).to eq(partially_read.id)
-        #   expect(suggested_topics[1,3]).to include(new_topic.id)
-        #   expect(suggested_topics[1,3]).to include(closed_topic.id)
-        #   expect(suggested_topics[1,3]).to include(archived_topic.id)
-        #   expect(suggested_topics[4]).to eq(fully_read.id)
-        #   # random doesn't include closed and archived
-        # end
-
       end
     end