Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: fix flakey spec (#26513) 

The fix is to actually wait for the bottom arrow to show before appending a new message, otherwise sometimes it goes too fast, and we create a new message while the scroll has not ended yet, making the arrow not visible yet.

This commit also uses this opportunity to move from `50.times.map {}` to `Fabricate.times(50, ...)` in this spec file.
This commit is contained in:
Joffrey JAFFEUX 2024-04-04 13:39:49 +02:00 committed by GitHub
parent 0ad4034c58
commit f45d96ebf4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
plugins/chat/spec/system/chat_channel_spec.rb
View File

@ -59,7 +59,7 @@ RSpec.describe "Chat channel", type: :system do
end end
context "when first batch of messages doesnt fill page" do context "when first batch of messages doesnt fill page" do
before { 30.times { Fabricate(:chat_message, user: current_user, chat_channel: channel_1) } } before { Fabricate.times(30, :chat_message, user: current_user, chat_channel: channel_1) }
it "autofills for more messages" do it "autofills for more messages" do
chat_page.prefers_full_page chat_page.prefers_full_page
@ -76,7 +76,7 @@ RSpec.describe "Chat channel", type: :system do
context "when sending a message" do context "when sending a message" do
context "with lots of messages" do context "with lots of messages" do
before { 50.times { Fabricate(:chat_message, chat_channel: channel_1) } } before { Fabricate.times(50, :chat_message, chat_channel: channel_1) }
it "loads most recent messages" do it "loads most recent messages" do
unloaded_message = Fabricate(:chat_message, chat_channel: channel_1) unloaded_message = Fabricate(:chat_message, chat_channel: channel_1)
@ -128,7 +128,7 @@ RSpec.describe "Chat channel", type: :system do
end end
context "when clicking the arrow button" do context "when clicking the arrow button" do
before { 50.times { Fabricate(:chat_message, chat_channel: channel_1) } } before { Fabricate.times(50, :chat_message, chat_channel: channel_1) }
it "jumps to the bottom of the channel" do it "jumps to the bottom of the channel" do
unloaded_message = Fabricate(:chat_message, chat_channel: channel_1) unloaded_message = Fabricate(:chat_message, chat_channel: channel_1)
@ -148,7 +148,7 @@ RSpec.describe "Chat channel", type: :system do
context "when returning to a channel where last read is not last message" do context "when returning to a channel where last read is not last message" do
it "jumps to the bottom of the channel" do it "jumps to the bottom of the channel" do
channel_1.membership_for(current_user).update!(last_read_message: message_1) channel_1.membership_for(current_user).update!(last_read_message: message_1)
messages = 50.times.map { Fabricate(:chat_message, chat_channel: channel_1) } messages = Fabricate.times(50, :chat_message, chat_channel: channel_1)
chat_page.visit_channel(channel_1) chat_page.visit_channel(channel_1)
expect(page).to have_css("[data-id='#{messages.first.id}']") expect(page).to have_css("[data-id='#{messages.first.id}']")
@ -157,16 +157,13 @@ RSpec.describe "Chat channel", type: :system do
end end
context "when a new message is created" do context "when a new message is created" do
fab!(:other_user) { Fabricate(:user) } before { Fabricate.times(50, :chat_message, chat_channel: channel_1) }
before do
channel_1.add(other_user)
50.times { Fabricate(:chat_message, chat_channel: channel_1) }
end
it "doesn’t append the message when not at bottom" do it "doesn’t append the message when not at bottom" do
visit("/chat/c/-/#{channel_1.id}/#{message_1.id}") visit("/chat/c/-/#{channel_1.id}/#{message_1.id}")
expect(page).to have_css(".chat-scroll-to-bottom__button.visible")
new_message = Fabricate(:chat_message, chat_channel: channel_1, use_service: true) new_message = Fabricate(:chat_message, chat_channel: channel_1, use_service: true)
expect(channel_page.messages).to have_no_message(id: new_message.id) expect(channel_page.messages).to have_no_message(id: new_message.id)