REFACTOR: Simplify git command execution

2023-04-18 10:58:57 +02:00 · 2023-04-18 10:58:57 +02:00 · f523dcf9df
parent af58dbeb24
commit f523dcf9df
1 changed files with 3 additions and 9 deletions
--- a/lib/discourse.rb
+++ b/lib/discourse.rb
@ -801,17 +801,11 @@ module Discourse
  end

  def self.try_git(git_cmd, default_value)
-    version_value = false
-
    begin
-      version_value = `#{git_cmd}`.strip
+      `#{git_cmd}`.strip
    rescue StandardError
-      version_value = default_value
-    end
-
-    version_value = default_value if version_value.empty?
-
-    version_value
+      default_value
+    end.presence || default_value
  end

  # Either returns the site_contact_username user or the first admin.