Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Add debug for ChatablesControllerSpec (#20909) 

We keep getting this failure on the spec but I
cannot reproduce locally, add this extra log line
to see if it helps:

```
>  Chat::Api::ChatablesController#index with chat permissions does not return DM channels for users who are not in the chat allowed group
>  Failure/Error: example.run
>
>    expected: 200
>         got: 500
>
>    (compared using ==)
>  # ./plugins/chat/spec/requests/chat/api/chatables_controller_spec.rb:158:in `block (4 levels) in <main>'
>  # ./spec/rails_helper.rb:358:in `block (2 levels) in <top (required)>'
>  # ./vendor/bundle/ruby/3.2.0/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
>  # ------------------
>  # --- Caused by: ---
>  #
>  #   expected: 200
>  #        got: 500
>  #
>  #   (compared using ==)
>  #   ./plugins/chat/spec/requests/chat/api/chatables_controller_spec.rb:158:in `block (4 levels) in <main>'

```
This commit is contained in:
Martin Brennan 2023-03-31 11:50:12 +10:00 committed by GitHub
parent 9fbe476262
commit f7997ae882
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/chat/spec/requests/chat/api/chatables_controller_spec.rb
View File

@ -155,6 +155,10 @@ RSpec.describe Chat::Api::ChatablesController do
GroupUser.create(user: other_user, group: group) GroupUser.create(user: other_user, group: group)
get "/chat/api/chatables", params: { filter: "janemay" } get "/chat/api/chatables", params: { filter: "janemay" }
if response.status == 500
puts "ERROR in ChatablesController spec:\n"
puts response.body
end
expect(response.status).to eq(200) expect(response.status).to eq(200)
expect(response.parsed_body["direct_message_channels"][0]["id"]).to eq(dm_chat_channel_2.id) expect(response.parsed_body["direct_message_channels"][0]["id"]).to eq(dm_chat_channel_2.id)
end end