Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Deprecate PluginOutlet tagName argument

This commit is contained in:
David Taylor 2023-01-31 11:09:54 +00:00
parent 15b546978f
commit f9d5203610
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/assets/javascripts/discourse/app/components/plugin-outlet.js
View File

@ -14,6 +14,8 @@ const PARENT_VIEW_DEPRECATION_MSG =
"parentView should not be used within plugin outlets. Use the available outlet arguments, or inject a service which can provide the context you need."; "parentView should not be used within plugin outlets. Use the available outlet arguments, or inject a service which can provide the context you need.";
const GET_DEPRECATION_MSG = const GET_DEPRECATION_MSG =
"Plugin outlet context is no longer an EmberObject - using `get()` is deprecated."; "Plugin outlet context is no longer an EmberObject - using `get()` is deprecated.";
const TAG_NAME_DEPRECATION_MSG =
"The `tagName` argument to PluginOutlet is deprecated. If a wrapper element is required, define it manually around the outlet call.";
/** /**
A plugin outlet is an extension point for templates where other templates can A plugin outlet is an extension point for templates where other templates can
@ -56,6 +58,18 @@ export default class PluginOutletComponent extends GlimmerComponentWithDeprecate
}, },
}; };
constructor() {
const result = super(...arguments);
if (this.args.tagName) {
deprecated(`${TAG_NAME_DEPRECATION_MSG} (outlet: ${this.args.name})`, {
id: "discourse.plugin-outlet-tag-name",
});
}
return result;
}
get connectors() { get connectors() {
return renderedConnectorsFor( return renderedConnectorsFor(
this.args.name, this.args.name,