Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Fixes for mobile "create account" modal (#24043) 

- Don't include login buttons on mobile
- Fix padding/spacing
This commit is contained in:
Penar Musaraj 2023-10-23 10:48:46 -04:00 committed by GitHub
parent 0934cc6ece
commit f9eec939e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/assets/javascripts/discourse/app/templates/modal/create-account.hbs
View File

@ -274,12 +274,13 @@
/> />
{{/if}} {{/if}}
{{#unless this.hasAuthOptions}} {{#if this.site.desktopView}}
<div class="create-account-login-buttons"> {{#unless this.hasAuthOptions}}
<LoginButtons @externalLogin={{action "externalLogin"}} /> <div class="create-account-login-buttons">
</div> <LoginButtons @externalLogin={{action "externalLogin"}} />
{{/unless}} </div>
{{/unless}}
{{/if}}
{{#if this.skipConfirmation}} {{#if this.skipConfirmation}}
{{loading-spinner size="large"}} {{loading-spinner size="large"}}
{{/if}} {{/if}}

6
app/assets/stylesheets/common/base/login.scss
View File

@ -333,6 +333,12 @@ body.invite-page {
.toggle-password-mask { .toggle-password-mask {
align-self: start; align-self: start;
line-height: 1.4; // aligns with input description text line-height: 1.4; // aligns with input description text
.ios-device & {
// reset form-item-sizing mixin styles
padding-top: 0;
padding-bottom: 0;
font-size: var(--font-0);
}
} }
// admin invite page // admin invite page

3
app/assets/stylesheets/mobile/login.scss
View File

@ -212,7 +212,8 @@
border-bottom: 1px solid var(--primary-low); border-bottom: 1px solid var(--primary-low);
} }
.login-form { .login-form {
margin-bottom: 0.75em; margin-bottom: 0;
padding-bottom: 0;
} }
} }