FIX: Don't notify topic author about small action posts (#18789)

app/services/post_alerter.rb

@@ -146,8 +146,8 @@ class PostAlerter
     # replies
     reply_to_user = post.reply_notification_target
 
-    if new_record
-      if reply_to_user && !notified.include?(reply_to_user) && notify_about_reply?(post)
+    if new_record && notify_about_reply?(post)
+      if reply_to_user && !notified.include?(reply_to_user)
         notified += notify_non_pm_users(reply_to_user, :replied, post)
       end
 

spec/services/post_alerter_spec.rb

@@ -1343,6 +1343,21 @@ RSpec.describe PostAlerter do
         read: false
       )).to eq(true)
     end
+
+    it "it doesn't notify about small action posts when the topic author is watching the topic " do
+      Jobs.run_immediately!
+
+      u1 = Fabricate(:admin)
+      u2 = Fabricate(:admin)
+
+      topic = create_topic(user: u1)
+
+      u1.notifications.destroy_all
+
+      expect do
+        topic.update_status("closed", true, u2, message: "hello world")
+      end.not_to change { u1.reload.notifications.count }
+    end
   end
 
   context "with category" do