Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove flaky setting deprecation logging specs (#24322) 

Followup to baeac8f105,
I tried to fix this in 6bf66ccd1a
but it is still not reliable, just removing since they are
too unreliable for value provided
This commit is contained in:
Martin Brennan 2023-11-10 10:46:28 +10:00 committed by GitHub
parent 620485ada2
commit fb2756537d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
spec/lib/site_setting_extension_spec.rb
View File

@ -832,54 +832,6 @@ RSpec.describe SiteSettingExtension do
expect(client_settings["with_html"]).to eq("<script></script>rest")
end
context "for deprecated settings" do
let(:fake_logger) { FakeLogger.new }
before do
@orig_logger = Rails.logger
Rails.logger = fake_logger
end
after { Rails.logger = @orig_logger }
it "does not log deprecation warnings" do
stub_const(
SiteSettings::DeprecatedSettings,
"SETTINGS",
[["use_https", "force_https", true, "0.0.1"]],
) do
SiteSetting.setup_deprecated_methods
SiteSetting.client_settings_json_uncached
expect(fake_logger.warnings).to eq([])
end
end
end
end
describe ".settings_hash" do
context "for deprecated settings" do
let(:fake_logger) { FakeLogger.new }
before do
@orig_logger = Rails.logger
Rails.logger = fake_logger
end
after { Rails.logger = @orig_logger }
it "does not log deprecation warnings" do
stub_const(
SiteSettings::DeprecatedSettings,
"SETTINGS",
[["use_https", "force_https", true, "0.0.1"]],
) do
SiteSetting.setup_deprecated_methods
SiteSetting.settings_hash
expect(fake_logger.warnings).to eq([])
end
end
end
end
describe ".setup_methods" do