DEV: Remove flaky setting deprecation logging specs (#24322)
Followup tobaeac8f105
, I tried to fix this in6bf66ccd1a
but it is still not reliable, just removing since they are too unreliable for value provided
This commit is contained in:
parent
620485ada2
commit
fb2756537d
|
@ -832,54 +832,6 @@ RSpec.describe SiteSettingExtension do
|
|||
|
||||
expect(client_settings["with_html"]).to eq("<script></script>rest")
|
||||
end
|
||||
|
||||
context "for deprecated settings" do
|
||||
let(:fake_logger) { FakeLogger.new }
|
||||
|
||||
before do
|
||||
@orig_logger = Rails.logger
|
||||
Rails.logger = fake_logger
|
||||
end
|
||||
|
||||
after { Rails.logger = @orig_logger }
|
||||
|
||||
it "does not log deprecation warnings" do
|
||||
stub_const(
|
||||
SiteSettings::DeprecatedSettings,
|
||||
"SETTINGS",
|
||||
[["use_https", "force_https", true, "0.0.1"]],
|
||||
) do
|
||||
SiteSetting.setup_deprecated_methods
|
||||
SiteSetting.client_settings_json_uncached
|
||||
expect(fake_logger.warnings).to eq([])
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe ".settings_hash" do
|
||||
context "for deprecated settings" do
|
||||
let(:fake_logger) { FakeLogger.new }
|
||||
|
||||
before do
|
||||
@orig_logger = Rails.logger
|
||||
Rails.logger = fake_logger
|
||||
end
|
||||
|
||||
after { Rails.logger = @orig_logger }
|
||||
|
||||
it "does not log deprecation warnings" do
|
||||
stub_const(
|
||||
SiteSettings::DeprecatedSettings,
|
||||
"SETTINGS",
|
||||
[["use_https", "force_https", true, "0.0.1"]],
|
||||
) do
|
||||
SiteSetting.setup_deprecated_methods
|
||||
SiteSetting.settings_hash
|
||||
expect(fake_logger.warnings).to eq([])
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe ".setup_methods" do
|
||||
|
|
Loading…
Reference in New Issue