Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Ensure event-handling reopens are only performed once (#18722) 

In test mode we reinitialize the Application for every test. We only want to apply the class reopens once to avoid performance regressions and memory leaks in the test suite.
This commit is contained in:
David Taylor 2022-10-24 17:13:54 +01:00 committed by GitHub
parent 28be5d3037
commit fcb4675415
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/assets/javascripts/discourse/app/lib/ember-events.js
View File

@ -2,6 +2,7 @@
import Component from "@ember/component"; import Component from "@ember/component";
import EmberObject from "@ember/object"; import EmberObject from "@ember/object";
import { actionModifier } from "./ember-action-modifier"; import { actionModifier } from "./ember-action-modifier";
import Ember from "ember";
/** /**
* Classic Ember components (i.e. "@ember/component") rely upon "event * Classic Ember components (i.e. "@ember/component") rely upon "event
@ -48,12 +49,17 @@ export function normalizeEmberEventHandling(app) {
}); });
} }
let eliminatedClassicEventDelegation = false;
/** /**
* Remove all events registered with Ember's EventDispatcher to reduce its * Remove all events registered with Ember's EventDispatcher to reduce its
* runtime overhead. * runtime overhead.
*/ */
function eliminateClassicEventDelegation() { function eliminateClassicEventDelegation() {
// eslint-disable-next-line no-undef if (eliminatedClassicEventDelegation) {
return;
}
eliminatedClassicEventDelegation = true;
Ember.EventDispatcher.reopen({ Ember.EventDispatcher.reopen({
events: {}, events: {},
}); });
@ -100,6 +106,7 @@ const COMPONENT_SETUP = new WeakMap();
const INTERNAL = Symbol("INTERNAL"); const INTERNAL = Symbol("INTERNAL");
let rewireDone = false;
/** /**
* Rewires classic component event handling to use `addEventListener` directly * Rewires classic component event handling to use `addEventListener` directly
* on inserted elements, instead of relying upon classic event delegation. * on inserted elements, instead of relying upon classic event delegation.
@ -112,6 +119,11 @@ const INTERNAL = Symbol("INTERNAL");
* @param {Application} app * @param {Application} app
*/ */
function rewireClassicComponentEvents(app) { function rewireClassicComponentEvents(app) {
if (rewireDone) {
return;
}
rewireDone = true;
const allEvents = { ...EVENTS }; const allEvents = { ...EVENTS };
if (app.customEvents) { if (app.customEvents) {