Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Pass a list of tag group names when using the search endpoint. (#12721) 

Accepting a list of names instead of ids is more convenient when searching for tag groups using data from the `category.allowed_tag_groups` method.
This commit is contained in:
Roman Rizzi 2021-04-16 08:41:10 -03:00 committed by GitHub
parent 2aed82e646
commit fd8441d6d5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/tag_groups_controller.rb
View File

@ -67,8 +67,8 @@ class TagGroupsController < ApplicationController
matches = matches.where('lower(name) ILIKE ?', "%#{params[:q].strip}%")
end
if params[:ids].present?
matches = matches.where(id: params[:ids])
if params[:names].present?
matches = matches.where(name: params[:names].map(&:downcase))
end
matches = matches.order('name').limit(params[:limit] || 5)

4
spec/requests/tag_groups_controller_spec.rb
View File

@ -83,7 +83,7 @@ RSpec.describe TagGroupsController do
it 'returns the tag group with the associated tag names' do
tag_group = tag_group_with_permission(everyone, readonly)
get '/tag_groups/filter/search.json', params: { ids: [tag_group.id] }
get '/tag_groups/filter/search.json', params: { names: [tag_group.name] }
expect(response.status).to eq(200)
results = JSON.parse(response.body, symbolize_names: true).fetch(:results)
@ -95,7 +95,7 @@ RSpec.describe TagGroupsController do
it 'returns an empty array if the tag group is private' do
tag_group = tag_group_with_permission(staff, full)
get '/tag_groups/filter/search.json', params: { ids: [tag_group.id] }
get '/tag_groups/filter/search.json', params: { names: [tag_group.name] }
expect(response.status).to eq(200)
results = JSON.parse(response.body, symbolize_names: true).fetch(:results)