From fd8fdb060fe9999766a360556e37009f7787c52e Mon Sep 17 00:00:00 2001
From: Jarek Radosz <jradosz@gmail.com>
Date: Tue, 22 Aug 2023 16:42:22 +0200
Subject: [PATCH] DEV: Clean up extraneous helper parens (#23186)

---
 .../app/components/search-menu/results/types.hbs      |  2 +-
 .../sidebar/edit-navigation-menu/categories-modal.hbs | 11 ++++++-----
 .../sidebar/edit-navigation-menu/tags-modal.hbs       |  7 ++++---
 .../discourse/app/components/user-stream-item.hbs     |  2 +-
 4 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs b/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs
index 4e1058ec212..aaf5d794e6d 100644
--- a/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs
+++ b/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs
@@ -8,7 +8,7 @@
         {{! template-lint-disable no-pointer-down-event-binding }}
         {{! template-lint-disable no-invalid-interactive }}
         <li class="item" {{on "keydown" this.onKeydown}}>
-          <a href={{(or result.url result.path)}} class="search-link">
+          <a href={{or result.url result.path}} class="search-link">
             <resultType.component @result={{result}} />
           </a>
         </li>
diff --git a/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/categories-modal.hbs b/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/categories-modal.hbs
index ee19297cc42..c5beecf2200 100644
--- a/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/categories-modal.hbs
+++ b/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/categories-modal.hbs
@@ -3,9 +3,10 @@
   @title="sidebar.categories_form_modal.title"
   @disableSaveButton={{this.saving}}
   @save={{this.save}}
-  @showResetDefaultsButton={{(gt
-    this.siteSettings.default_navigation_menu_categories.length 0
-  )}}
+  @showResetDefaultsButton={{gt
+    this.siteSettings.default_navigation_menu_categories.length
+    0
+  }}
   @resetToDefaults={{this.resetToDefaults}}
   @deselectAll={{this.deselectAll}}
   @deselectAllText={{i18n "sidebar.categories_form_modal.subtitle.text"}}
@@ -55,9 +56,9 @@
                     this.selectedSidebarCategoryIds
                     category.id
                   }}
-                  disabled={{(not
+                  disabled={{not
                     (includes this.filteredCategoryIds category.id)
-                  )}}
+                  }}
                   {{on "click" (action "toggleCategory" category.id)}}
                 />
               </label>
diff --git a/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/tags-modal.hbs b/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/tags-modal.hbs
index 1d999e98f61..329ed31a245 100644
--- a/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/tags-modal.hbs
+++ b/app/assets/javascripts/discourse/app/components/sidebar/edit-navigation-menu/tags-modal.hbs
@@ -3,9 +3,10 @@
   @title="sidebar.tags_form_modal.title"
   @saving={{this.saving}}
   @save={{this.save}}
-  @showResetDefaultsButton={{(gt
-    this.siteSettings.default_navigation_menu_tags.length 0
-  )}}
+  @showResetDefaultsButton={{gt
+    this.siteSettings.default_navigation_menu_tags.length
+    0
+  }}
   @resetToDefaults={{this.resetToDefaults}}
   @deselectAll={{this.deselectAll}}
   @deselectAllText={{i18n "sidebar.tags_form_modal.subtitle.text"}}
diff --git a/app/assets/javascripts/discourse/app/components/user-stream-item.hbs b/app/assets/javascripts/discourse/app/components/user-stream-item.hbs
index e26105f28aa..828a195cff0 100644
--- a/app/assets/javascripts/discourse/app/components/user-stream-item.hbs
+++ b/app/assets/javascripts/discourse/app/components/user-stream-item.hbs
@@ -1,7 +1,7 @@
 <div class="user-stream-item__header info">
   <a
     href={{this.userUrl}}
-    data-user-card={{(or @item.draft_username @item.username)}}
+    data-user-card={{or @item.draft_username @item.username}}
     class="avatar-link"
   >
     <div class="avatar-wrapper">