694b5f108b
DEV: Fix various rubocop lints ( #24749 )
...
These (21 + 3 from previous PRs) are soon to be enabled in rubocop-discourse:
Capybara/VisibilityMatcher
Lint/DeprecatedOpenSSLConstant
Lint/DisjunctiveAssignmentInConstructor
Lint/EmptyConditionalBody
Lint/EmptyEnsure
Lint/LiteralInInterpolation
Lint/NonLocalExitFromIterator
Lint/ParenthesesAsGroupedExpression
Lint/RedundantCopDisableDirective
Lint/RedundantRequireStatement
Lint/RedundantSafeNavigation
Lint/RedundantStringCoercion
Lint/RedundantWithIndex
Lint/RedundantWithObject
Lint/SafeNavigationChain
Lint/SafeNavigationConsistency
Lint/SelfAssignment
Lint/UnreachableCode
Lint/UselessMethodDefinition
Lint/Void
Previous PRs:
Lint/ShadowedArgument
Lint/DuplicateMethods
Lint/BooleanSymbol
RSpec/SpecFilePathSuffix
2023-12-06 23:25:00 +01:00
94649565ce
DEV: Correct `Style/RedundantReturn` rubocop issues ( #23052 )
2023-08-10 02:03:38 +02:00
436b3b392b
DEV: Apply syntax_tree formatting to `script/*`
2023-01-09 11:13:22 +00:00
59097b207f
DEV: Correct typos and spelling mistakes ( #12812 )
...
Over the years we accrued many spelling mistakes in the code base.
This PR attempts to fix spelling mistakes and typos in all areas of the code that are extremely safe to change
- comments
- test descriptions
- other low risk areas
2021-05-21 11:43:47 +10:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
ad5082d969
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
d82dbd565b
FIX: Remove dependency on `rest-client`.
2017-06-16 09:42:41 +09:00
ed627c8233
FEATURE: Socialcast Importer: Set category and tags based on group
2017-02-26 04:54:07 -08:00
f7f8226b4c
Add Socialcast importer
2016-08-20 17:25:19 -07:00
Jarek Radosz
David Taylor
Josh Soref
Sam Saffron
Guo Xiang Tan
Guo Xiang Tan
David McClure