Commit Graph

39 Commits

Author SHA1 Message Date
Loïc Guitaut 2a28cda15c DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
Kelv 2477bcc32e
DEV: lint against Layout/EmptyLineBetweenDefs (#24914) 2023-12-15 23:46:04 +08:00
Jarek Radosz 694b5f108b
DEV: Fix various rubocop lints (#24749)
These (21 + 3 from previous PRs) are soon to be enabled in rubocop-discourse:

Capybara/VisibilityMatcher
Lint/DeprecatedOpenSSLConstant
Lint/DisjunctiveAssignmentInConstructor
Lint/EmptyConditionalBody
Lint/EmptyEnsure
Lint/LiteralInInterpolation
Lint/NonLocalExitFromIterator
Lint/ParenthesesAsGroupedExpression
Lint/RedundantCopDisableDirective
Lint/RedundantRequireStatement
Lint/RedundantSafeNavigation
Lint/RedundantStringCoercion
Lint/RedundantWithIndex
Lint/RedundantWithObject
Lint/SafeNavigationChain
Lint/SafeNavigationConsistency
Lint/SelfAssignment
Lint/UnreachableCode
Lint/UselessMethodDefinition
Lint/Void

Previous PRs:
Lint/ShadowedArgument
Lint/DuplicateMethods
Lint/BooleanSymbol
RSpec/SpecFilePathSuffix
2023-12-06 23:25:00 +01:00
Loïc Guitaut f7c57fbc19 DEV: Enable `unless` cops
We discussed the use of `unless` internally and decided to enforce
available rules from rubocop to restrict its most problematic uses.
2023-02-21 10:30:48 +01:00
David Taylor 436b3b392b
DEV: Apply syntax_tree formatting to `script/*` 2023-01-09 11:13:22 +00:00
Peter Zhu c5fd8c42db
DEV: Fix methods removed in Ruby 3.2 (#15459)
* File.exists? is deprecated and removed in Ruby 3.2 in favor of
File.exist?
* Dir.exists? is deprecated and removed in Ruby 3.2 in favor of
Dir.exist?
2022-01-05 18:45:08 +01:00
Dan Ungureanu 69f0f48dc0
DEV: Fix rubocop issues (#14715) 2021-10-27 11:39:28 +03:00
Justin DiRose 6c948f27ea
FIX: Missing constant in SMF2 importer (#9178) 2020-03-11 10:19:59 -05:00
Justin DiRose f35ee5e887
DEV: Improvements to SMF2 script (#9006) 2020-02-24 12:51:45 -06:00
Penar Musaraj 067696df8f DEV: Apply Rubocop redundant return style 2019-11-14 15:10:51 -05:00
Gerhard Schlager 0f3c3bc309 Make import scripts work with frozen strings 2019-05-30 22:22:24 +02:00
Sam Saffron 30990006a9 DEV: enable frozen string literal on all files
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
Guo Xiang Tan 8dc1463ab3 Enable `Lint/ShadowingOuterLocalVariable` for Rubocop. 2018-09-04 10:16:42 +08:00
Jay Pfaffman cc46ab5bb1 smf2: deal with duplicate category names (#5435) 2017-12-27 16:56:36 +11:00
Guo Xiang Tan 5012d46cbd Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
michael@discoursehosting.com 17b5303449 Convert nested quotes 2017-04-02 20:38:23 +00:00
michael@discoursehosting.com 6168bcb4c4 Someone broke/disabled? the php check 2017-04-02 20:35:43 +00:00
michael@discoursehosting.com 7e27559f3e We need to get rid of the ignore_quotes thing as well 2017-04-02 20:33:48 +00:00
michael@discoursehosting.com 60be3e0d38 Get rid of the weird and broken message graph 2017-04-02 20:31:06 +00:00
michael@discoursehosting.com 7d09af141e Apparently need to save 2017-04-02 20:28:16 +00:00
michael@discoursehosting.com a72f56c3a7 Add migratepassword plugin hash 2017-04-02 20:27:57 +00:00
michael@discoursehosting.com 332d655a1d Use html_for_upload instead of broken v8 stuff 2017-04-02 20:25:08 +00:00
michael@discoursehosting.com e788ac3351 Add permalinks creator for PrettyURL plugin 2017-04-02 20:23:03 +00:00
Régis Hanol dcc4267490 FIX: base script import to handle category color/text color 2015-05-19 12:40:35 +02:00
Jens Maier f8e1c97441 Update existing user's create time 2015-03-27 14:38:27 +01:00
Jens Maier 1cc7db2370 Fix gem load order for SFM2 importer 2015-03-15 01:57:46 +01:00
Gerhard Schlager 53591ade00 Adds a few enhancements to the base importer
- Allows importing globally pinned topics
- Doesn't restore the original value of a SiteSetting anymore if an importer changed its value
- Allows all file extensions during the import
- Adds the ability to import bookmarks
2015-03-13 21:24:11 +01:00
Gerhard Schlager b5426763e4 FIX: Importers should allow categories with existing name if the parent category is different
This changes the content of `@categories_lookup` from `Category` objects
to IDs since the category names aren't needed anymore. The lookup
method has been renamed too.
2015-03-12 21:15:02 +01:00
Jens Maier 30710215bc FIX: handle timezone detection errors 2015-01-13 16:44:25 +01:00
Jens Maier b6bbfb907c FIX: quoting non-existing messages would break SMF2 importer 2014-10-02 00:44:03 +02:00
Jens Maier b74a7d271a FIX: made SMF2 importer compatible with Ruby 2.0 2014-09-30 21:01:50 +02:00
Jens Maier b075b9937f Fix: messages imported in wrong order 2014-08-05 17:40:26 +02:00
Jens Maier 31a517616c Feature: import attachments with support for SMF2 inline attachments mod 2014-07-30 06:19:46 +02:00
Jens Maier e93de81d32 Support more legacy SMF2 attachment naming schemes 2014-07-30 06:19:46 +02:00
Jens Maier 7f68cb5bb0 Allow multiple mysql connections 2014-07-30 06:19:46 +02:00
Jens Maier b17611f2db Fix: defaults should be defaults and not override parsed settings. 2014-07-30 06:19:46 +02:00
Jens Maier 44eb9fbd70 improved option handling 2014-07-16 23:18:52 +02:00
Jens Maier f40510b93e made postprocessing of posts with delay quotes conversion resumable 2014-07-16 21:40:52 +02:00
Jens Maier 7b5e6ff744 FEATURE: smf2 import script 2014-07-16 20:02:58 +02:00