discourse

Commit Graph

Author	SHA1	Message	Date
Martin Brennan	e708c99e12	FIX: Hide broken theme about/license URLs (#29930 ) At the top of the theme show page we have a link to the theme About and License, which are supposed to be URLs. However some themes have left placeholder text in these metadata fields, which leads to a wonky experience. Instead, we can just not serialize these fields if they are not valid URLs, then they will not show as links in the UI.	2024-11-26 13:53:10 +10:00
Mark VanLandingham	012aaf0ba3	PERF: Don't serialize value for theme_fields unnecessarily (#21201 ) The value field of ThemeField is only used when viewing a diff in the staff action logs and local theme editing. value is being serialized into the theme index as well, which is not used. It's a huge amount of JSON that we can cut by removing it. This also breaks up the various theme serializers into separate classes so they autoload properly (or at least restart the server on edit)	2023-04-24 09:30:51 -05:00

Author

SHA1

Message

Date

Martin Brennan

e708c99e12

FIX: Hide broken theme about/license URLs (#29930 )

At the top of the theme show page we have a link
to the theme About and License, which are supposed
to be URLs. However some themes have left placeholder
text in these metadata fields, which leads to a wonky
experience.

Instead, we can just not serialize these fields if they
are not valid URLs, then they will not show as links
in the UI.

2024-11-26 13:53:10 +10:00

Mark VanLandingham

012aaf0ba3

PERF: Don't serialize value for theme_fields unnecessarily (#21201 )

The value field of ThemeField is only used when viewing a diff in the staff action logs and local theme editing. value is being serialized into the theme index as well, which is not used. It's a huge amount of JSON that we can cut by removing it.

This also breaks up the various theme serializers into separate classes so they autoload properly (or at least restart the server on edit)

2023-04-24 09:30:51 -05:00

2 Commits