721fa86b24
Build(deps): Bump actionview_precompiler from 0.3.0 to 0.4.0 ( #25977 )
...
Bumps [actionview_precompiler](https://github.com/jhawthorn/actionview_precompiler ) from 0.3.0 to 0.4.0.
- [Commits](https://github.com/jhawthorn/actionview_precompiler/compare/v0.3.0...v0.4.0 )
---
updated-dependencies:
- dependency-name: actionview_precompiler
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 23:34:00 +01:00
1e666ddfd7
Build(deps-dev): Bump express from 4.18.2 to 4.18.3 ( #25974 )
...
Bumps [express](https://github.com/expressjs/express ) from 4.18.2 to 4.18.3.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.18.3 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 22:53:08 +01:00
db2f5ae51b
UX: simplify styles for image uploader ( #25970 )
2024-02-29 14:39:00 -05:00
47b8e98cf7
UX: enable badge title on mobile, style cleanup ( #25968 )
2024-02-29 13:55:13 -05:00
6847ed5be6
FIX: `import:rebake_uncooked_*` jobs couldn't be run in parallel ( #25969 )
...
If those jobs were started multiple times each process would have rebaked the same posts.
2024-02-29 19:54:19 +01:00
841b353d38
DEV: Close user menu after clicking view-all notifications ( #25966 )
...
We needed to call closeUserMenu after navigating to the show all notifications url.
2024-02-29 11:52:51 -07:00
6c2c690479
DEV: Add push notification filtering to MessageBus alerts ( #25965 )
2024-02-29 12:49:46 -06:00
f0baa0ddfe
DEV: Prefer defer_get_set over get/set on DistributedCache ( #25967 )
2024-02-29 11:10:24 -06:00
7aa3e15440
DEV: Deprecate FoundUserWithStatusSerializer ( #25883 )
...
A followup to b3a11994
2024-02-29 20:20:48 +04:00
0a58b18970
DEV: Move DiscourseEvent trigger in PostAlerter#push_notification ( #25931 )
2024-02-29 08:33:38 -06:00
03de0421af
DEV: Convert share-source to gjs ( #25964 )
2024-02-29 15:12:17 +01:00
f087234ff7
Build(deps-dev): Bump rubocop from 1.60.2 to 1.61.0 ( #25958 )
...
* Build(deps-dev): Bump rubocop from 1.60.2 to 1.61.0
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.60.2 to 1.61.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.60.2...v1.61.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* fix the issue
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2024-02-29 14:09:49 +01:00
11400bca1a
DEV: attempts to make last spec non flakey ( #25962 )
2024-02-29 13:15:00 +01:00
7043512b8d
Build(deps): Bump jwt from 2.8.0 to 2.8.1 ( #25959 )
...
Bumps [jwt](https://github.com/jwt/ruby-jwt ) from 2.8.0 to 2.8.1.
- [Release notes](https://github.com/jwt/ruby-jwt/releases )
- [Changelog](https://github.com/jwt/ruby-jwt/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jwt/ruby-jwt/compare/v2.8.0...v2.8.1 )
---
updated-dependencies:
- dependency-name: jwt
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 13:03:38 +01:00
25bba3fbda
Build(deps-dev): Bump rubocop-ast from 1.30.0 to 1.31.0 ( #25960 )
...
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast ) from 1.30.0 to 1.31.0.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.30.0...v1.31.0 )
---
updated-dependencies:
- dependency-name: rubocop-ast
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 12:58:18 +01:00
e74a9efee1
FIX: Show "no category" in category-chooser ( #25917 )
...
CategoryChooser component usually displays just categories, but
sometimes it can show two none values: a "no category" or Uncategorized.
This commit makes sure that these are rendered correctly.
The problem was that the "none" item was automatically inserted in the
list of options, but that should not always happen. Toggling option
`autoInsertNoneItem` requires setting `none` too.
2024-02-29 13:48:20 +02:00
0bb492c6b6
FIX: live updates threads from my threads page ( #25955 )
...
Prior to this fix if a user was answering to one of the listed screen it wouldn't update while you look at the list.
2024-02-29 12:31:20 +01:00
49e67d32fb
DEV: Convert second-factor-input to gjs ( #25946 )
2024-02-29 12:27:12 +01:00
5c54fbfdb1
DEV: Fix random typos ( #25957 )
...
February 2024 edition
2024-02-29 12:24:37 +01:00
8e4affec54
DEV: Update aws gems ( #25956 )
...
bundler hygiene 😉
2024-02-29 12:23:21 +01:00
8c22831672
UX: update appropriate `btn-flat` instances to `btn-transparent` ( #25945 )
...
With the adjustments of `btn-transparent` in https://github.com/discourse/discourse/pull/24666 , there are more buttons that could use this class instead of `btn-flat`. This mostly relates to `x` close buttons, but also includes composer and chat toggles.
The primary difference between these styles is that `btn-transparent` never has a background, where `btn-flat` may have a hover or focus background.
2024-02-29 11:47:07 +01:00
88f833418f
FIX: channel member status live updates ( #25925 )
2024-02-29 17:49:18 +08:00
8bec0ca083
FEATURE: Support boolean, enum and integer fields for schema theme settings ( #25933 )
...
Continue from https://github.com/discourse/discourse/pull/25673 and https://github.com/discourse/discourse/pull/25811 .
This commit adds support for boolean, integer and enum types for schema theme settings.
2024-02-29 11:11:32 +03:00
ef292d1fed
DEV: Shorten a condition ( #25951 )
2024-02-29 12:57:53 +08:00
5f119c57e8
DEV: Suppress verbose command failure output in plugin:turbo_spec ( #25952 )
...
Before this change, if the "Plugins backend" task on GitHub CI
failed, we would get a huge amount of extra output at the end
just to show the command that rake ran which failed (the bin/turbo_rspec
command). This is useless and just makes it hard to see the failing
specs. If you need the full command, it's already output at the
top of the "Plugins backend" task in the GitHub CI.
2024-02-29 14:35:31 +10:00
f562da3150
PERF: Reduce ActiveRecord allocations in `CategoryList#find_relevant_topics` ( #25950 )
...
Why this change?
Prior to this change, the `CategoryList#find_relevant_topics` method was
loading and allocating all `CategoryFeaturedTopic` records in the
database to eventually only just use its `category_id` and `topic_id`
column. On a site with many `CategoryFeaturedTopic` records, the loading
of the ActiveRecord objects is a source of bottleneck.
The other problem with the `CategoryList#find_relevant_topics` method is
that it is unconditionally loading all records from the database even if
the user does not have access to the category. This again is wasteful.
What does this change do?
This commit makes it such that `CategoryList#find_relevant_topics` is
called only after `CategoryList#find_categories` in the `CategoryList#initialize`
method so that we can filter featured topics against categories that the
user has access to.
The second change is that Instead of loading `CategoryFeaturedTopic` records, we make an
inner join agains the `topics` table instead and skip any allocation of
`CatgoryFeaturedTopic` ActiveRecord objects.
2024-02-29 12:19:04 +08:00
120a2f70a9
DEV: Fix hot topic flaky spec ( #25948 )
...
It's February 29th, you know what that means...date-based flaky specs! If today is
February 29th 2024:
```
freeze_time(1.year.ago) -> Tue, 28 Feb 2023 01:38:42.732875000 UTC +00:00
```
Then
```
freeze_time(1.year.from_now) -> Wed, 28 Feb 2024 01:38:42.732875000 UTC +00:00
```
So then our "now" for the insert query ends up being "yesterday"
```
WHERE topic_hot_scores.topic_id IS NULL
AND topics.deleted_at IS NULL
AND topics.archetype <> :private_message
AND topics.created_at <= :now
```
2024-02-29 11:54:36 +10:00
53069fcb8e
DEV: Silence header upgrade deprecations for now ( #25947 )
...
We'll unsilence once we've published a clear upgrade path.
2024-02-29 00:36:23 +00:00
9acb4f55f2
Build(deps): Bump the babel group with 2 updates ( #25939 )
...
* Build(deps): Bump the babel group with 2 updates
Bumps the babel group with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) and [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ).
Updates `@babel/core` from 7.23.9 to 7.24.0
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.0/packages/babel-core )
Updates `@babel/standalone` from 7.23.10 to 7.24.0
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.0/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: babel
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: babel
...
Signed-off-by: dependabot[bot] <support@github.com>
* Clean up accidentally duplicated deps
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2024-02-29 00:27:17 +01:00
df4197c8b8
FIX: Show deleted bookmark reminders in user bookmarks menu ( #25905 )
...
When we send a bookmark reminder, there is an option to delete
the underlying bookmark. The Notification record stays around.
However, if you want to filter your notifications user menu
to only bookmark-based notifications, we were not showing unread
bookmark notifications for deleted bookmarks.
This commit fixes the issue _going forward_ by adding the
bookmarkable_id and bookmarkable_type to the Notification data,
so we can look up the underlying Post/Topic/Chat::Message
for a deleted bookmark and check user access in this way. Then,
it doesn't matter if the bookmark was deleted.
2024-02-29 09:03:49 +10:00
dbc72aaca9
Build(deps): Bump logster from 2.18.1 to 2.19.0 ( #25941 )
...
Bumps [logster](https://github.com/discourse/logster ) from 2.18.1 to 2.19.0.
- [Changelog](https://github.com/discourse/logster/blob/main/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.18.1...v2.19.0 )
---
updated-dependencies:
- dependency-name: logster
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 00:00:09 +01:00
f0d47c1117
Build(deps-dev): Bump lefthook from 1.6.3 to 1.6.4 ( #25942 )
...
Bumps [lefthook](https://github.com/evilmartians/lefthook ) from 1.6.3 to 1.6.4.
- [Release notes](https://github.com/evilmartians/lefthook/releases )
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md )
- [Commits](https://github.com/evilmartians/lefthook/compare/v1.6.3...v1.6.4 )
---
updated-dependencies:
- dependency-name: lefthook
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-28 23:41:55 +01:00
62e5c96487
Build(deps-dev): Bump the embroider group with 3 updates ( #25940 )
...
Bumps the embroider group with 3 updates: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat ), [@embroider/core](https://github.com/embroider-build/embroider/tree/HEAD/packages/core ) and [@embroider/macros](https://github.com/embroider-build/embroider/tree/HEAD/packages/macros ).
Updates `@embroider/compat` from 3.4.4 to 3.4.5
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat )
Updates `@embroider/core` from 3.4.4 to 3.4.5
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/core )
Updates `@embroider/macros` from 1.13.5 to 1.14.0
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/macros )
---
updated-dependencies:
- dependency-name: "@embroider/compat"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/core"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/macros"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-28 23:40:46 +01:00
faec73e1e0
DEV: Override jsuites CSS in core ( #25944 )
2024-02-28 14:35:08 -08:00
b532c780c6
A11Y: markup sidebar form errors as live regions ( #25937 )
2024-02-28 15:31:57 -05:00
30c86ee21d
Build(deps-dev): Bump yard from 0.9.34 to 0.9.35 ( #25936 )
...
Bumps [yard](https://github.com/lsegal/yard ) from 0.9.34 to 0.9.35.
- [Release notes](https://github.com/lsegal/yard/releases )
- [Changelog](https://github.com/lsegal/yard/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lsegal/yard/compare/v0.9.34...v0.9.35 )
---
updated-dependencies:
- dependency-name: yard
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-28 20:36:05 +01:00
0e5307d8e2
DEV: Add glimmer header deprecation notice ( #25891 )
...
- Remove `_customHeaderClasses`. It was not supposed to have been a part of the glimmer header PR
- Add deprecation notice to `addHeaderPanel`
# Example
<img width="437" alt="Screenshot 2024-02-26 at 2 50 39 PM" src="https://github.com/discourse/discourse/assets/50783505/23fce1ee-fff9-4071-8c34-a480cec7e2e7 ">
2024-02-28 11:59:44 -07:00
80cc538e77
DEV: Fix flaky test ( #25935 )
...
Returned results are ordered by ID, but the fabricated category and
private_category IDs are not always generated in the same order. This
caused the expected and actual results to be in different orders.
2024-02-28 20:32:14 +02:00
c8133318b8
DEV: move chat scrollbar style to scollbar file ( #25934 )
2024-02-28 19:07:22 +01:00
6426eaff39
UX: increase chat pre scrollbar contrast ( #25930 )
2024-02-28 12:27:08 -05:00
337773b8ac
UX: chat > general fixes ( #25929 )
...
* UX: chat > keep send icon active when keyboard is hidden (mobile)
* FIX: chat > keep composer insert button at bottom
* UX: chat > give seperator equal padding
2024-02-28 15:12:13 +01:00
36a9b5d0fa
DEV: Introduce a helper for handling events ( #25433 )
...
Instead of
```hbs
{{on "input" (action this.foo value="target.value")}}
{{on "input" (action (mut this.bar) value="target.value")}}
```
you can use:
```hbs
{{on "input" (with-event-value this.foo)}}
{{on "input" (with-event-value (fn (mut this.bar)))}}
```
or in gjs:
```gjs
import { fn } from "@ember/helper";
import { on } from "@ember/modifier";
import withEventValue from "discourse/helpers/with-event-value";
…
{{on "input" (withEventValue (fn (mut this.bar)))}}
```
2024-02-28 14:00:53 +01:00
0e17ff8d09
FEATURE: introduces chat_preferred_mobile_index setting ( #25927 )
...
`chat_preferred_mobile_index` allows to set the preferred default tab when loading chat on mobile.
Current choices are:
- channels
- direct_messages
- my_threads
2024-02-28 12:05:05 +01:00
4116bd9595
DEV: Drop ember-functions-as-helper-polyfill ( #25926 )
...
No longer required on recent Ember
2024-02-28 10:06:36 +00:00
1a44c359b9
DEV: Fix reloading type map not clearing cache ( #25924 )
...
Why this change?
This is a follow up to 408d2f8e69
2024-02-28 14:56:15 +08:00
408d2f8e69
DEV: Adds a freedom patch to cache connection type map ( #25923 )
...
Why this change?
This patch has been added to address the problems identified in https://github.com/rails/rails/issues/35311 . For every,
new connection created using the PostgreSQL adapter, 3 queries are executed to fetch type map information from the `pg_type`
system catalog, adding about 1ms overhead to every connection creation.
On multisite clusters where connections are reaped more aggressively, the 3 queries executed
accounts for a significant portion of CPU usage on the PostgreSQL cluster. This patch works around the problem by
caching the type map in a class level attribute to reuse across connections.
2024-02-28 14:29:13 +08:00
9a07a9872f
FEATURE: Allow `rowspan` and `colspan` attributes on HTML tables ( #20973 )
...
Augment the `allowList` for HTML tables to allow the `rowspan` and
`colspan` attributes on `th` and `td` elements.
2024-02-28 16:59:36 +11:00
5bf06f2634
DEV: skip flaky channel member status test ( #25922 )
2024-02-28 12:00:51 +08:00
54a1fea74e
DEV: Refactor `ThemeSettingsObjectValidator#validate` ( #25904 )
...
What does this change do?
1. Reduce an additional loop through all the properties
2. Extract the validation of child objects into a dedicate method
2024-02-28 10:44:46 +08:00
afb0adf48d
DEV: Validate objects when updating typed objects theme settings ( #25902 )
...
Why this change?
This change ensures that we validate the value of the new objects
when updating typed objects theme settings.
2024-02-28 10:33:22 +08:00
dependabot[bot]
Kris
Gerhard Schlager
Isaac Janzen
Mark VanLandingham
Daniel Waterworth
Andrei Prigorshnev
Jarek Radosz
Joffrey JAFFEUX
Bianca Nenciu
David Battersby
Osama Sayegh
Natalie Tay
Martin Brennan
Alan Guo Xiang Tan
David Taylor
Keegan George
chapoi
John L. Clark