Ralph Rooding
04abf18194
Fixed typo in S3 rake task
2019-05-28 16:57:55 +08:00
Sam Saffron
3d2c3bd478
FIX: username suggester incorrectly skipping over whitelisted username
...
SSO uses a special param to username suggester that whitelists a username
due to previous work we amended our lookup logic and started ignoring this
whitelist.
The fix ensures we always respect it, and also improves on the original
implementation that forgot to normalize the username.
2019-05-28 16:48:46 +10:00
Sam Saffron
9a232e1a0a
FEATURE: use GIVE_UP=1 to inform rake posts:missing_uploads you are done
...
We need this give up for cases where uploads can not be recovered
This also improves the recovery routines
2019-05-28 14:44:59 +10:00
Sam Saffron
c780d36ddc
DEV: Correct posts:recover_uploads_from_index
...
Was creating a blank index file by mistake
2019-05-28 12:39:39 +10:00
Sam Saffron
3de8c58134
DEV: clean up backup maxmind path
...
This follows up on 6580025a
reuses a list and removes a map that was erronuously there.
2019-05-28 11:47:58 +10:00
Sam Saffron
769501c63a
FIX: exception which was meant to be ignored and logged was failing
...
Thanks to Darix!
2019-05-28 11:45:12 +10:00
Sam Saffron
7429700389
FIX: ensure we can download maxmind without redis or db config
...
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
2019-05-28 10:28:57 +10:00
Sam Saffron
e4e2acf148
FIX: rake maxminddb:get broke cause it required environment
2019-05-28 08:59:28 +10:00
Robin Ward
d95a68b837
FEATURE: When suspending a user, allow the Delete + Replies action
...
Previously you could only delete the post
2019-05-27 12:27:16 -04:00
Dan Ungureanu
6bd082feab
FIX: Update mapping between locales and Postgres dictionaries. ( #7606 )
2019-05-27 16:52:09 +03:00
Blake Erickson
373b8a2139
FIX: Consistently handle category param
...
See https://meta.discourse.org/t/api-post-to-posts-json-inconsistent-between-users/118571
for more info.
This commit removes a 5 year old temporary fix that is no longer needed.
bc1824a6ed (diff-d8c648926664f849aec050757bfcb6f9R72)
The web interface uses category_id when creating a topic so I think we
should unify on category_id when using the api.
2019-05-27 16:39:56 +08:00
Sam Saffron
6580025af9
FEATURE: add backup directory for mmdb files
...
This new `DISCOURSE_MAXMIND_BACKUP_PATH` can be used a secondary location
for maxmind db. That way a build machine, for example can cache it on the
host and reuse between builds.
Also per 5bfeef77
added proper error raising for download fails from
dedicated rake task
This also moves "refresh_maxmind_db_during_precompile_days" to a global
setting, it did not make sense in a site setting
2019-05-27 16:51:24 +10:00
Guo Xiang Tan
f54e4b71b1
DEV: Make `CookedPostProcessor#post_process_images` method private.
2019-05-27 11:28:37 +08:00
Dan Ungureanu
da39d66e83
DEV: Improve support for plugins. ( #7332 )
...
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
2019-05-25 16:53:03 +03:00
Régis Hanol
d6aacadc4e
make 🤖 happy
2019-05-25 00:32:29 +02:00
Régis Hanol
4e5305cb67
FIX: catch proper exception
2019-05-25 00:14:54 +02:00
Michael Brown
5bfeef7705
FIX: warn instead of excepting if MaxMind DBs can't be downloaded ( #7600 )
2019-05-25 00:08:00 +02:00
Régis Hanol
3bc99e5372
FIX: gunzip the downloaded file
2019-05-25 00:02:23 +02:00
Michael Brown
14c7aa8829
FIX: gz_file might be nil here
2019-05-24 16:11:10 -04:00
Robin Ward
89b84651c3
Migrate score settings to use sensitivities
...
We hide scores so these settings no longer made sense.
2019-05-24 15:44:24 -04:00
Régis Hanol
82f162962f
DEV: use different MaxMindDB download endpoint
2019-05-24 20:11:24 +02:00
Régis Hanol
2f5938c3bf
DEV: use FileHelper to download MaxMindDB
2019-05-24 18:11:39 +02:00
Régis Hanol
8c9ffee3af
TEMP: log more information when failing to download db
2019-05-24 17:33:52 +02:00
Régis Hanol
9ed2c54e27
TEMP: log information when failing to download db
2019-05-24 17:26:04 +02:00
Osama Sayegh
e20c30987c
FEATURE: detect theme errors and catch them ( #7589 )
...
* FEATURE: detect theme errors and catch them
* Bump COMPILER_VERSION
* Feedback
* Override eslint no console for one line
* Can't use our ajax method
* remove emoji from translation file
2019-05-24 17:25:55 +03:00
Régis Hanol
a51e2271af
DEV: remove temporary rescue when downloading MaxMindDB
...
follow-up 8c8c925d1b
2019-05-24 15:13:19 +02:00
Gerhard Schlager
c1e9a70d59
FIX: Fallback locale was not available for extra translations
...
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
2019-05-24 11:38:26 +02:00
Régis Hanol
0e24cb0f78
DEV: don't skip discourse-calendar plugin specs
2019-05-24 11:35:22 +02:00
Sam Saffron
9ce06d53d1
DEV: improve upload recovery rake task
...
- Better error handling
- Automatically generates index file if missing
- Improved output
2019-05-24 13:36:03 +10:00
Guo Xiang Tan
791241e0b2
DEV: Fix rake task to delete old export topics.
2019-05-24 11:20:53 +08:00
Sam Saffron
76f7e90e23
FEATURE: rake posts:recover_uploads_from_index improvements
...
We now recover more smartly based on failed db remaps as well.
2019-05-24 12:38:38 +10:00
Régis Hanol
f9bb8dde3c
TEMP: output the error to STDERR
2019-05-23 16:55:04 +02:00
Régis Hanol
8c8c925d1b
TEMP: catch exception when failing to download MaxMindDB
2019-05-23 16:30:21 +02:00
Régis Hanol
cb3ddeca40
DEV: remove unnecessary requires
2019-05-23 16:01:40 +02:00
Sam Saffron
1059aafc55
FEATURE: rake task for recovery of uploads from an index file
...
`rake posts:recover_uploads_from_index`
Searches through all missing uploads in the cluster, if it finds one it
tries to find it in the "upload index file" and creates a new upload for
it.
2019-05-23 17:08:22 +10:00
Sam Saffron
7ce58df7bf
lint the file
...
somehow I did not notice this on save
2019-05-23 15:28:41 +10:00
Sam Saffron
a5ce9cb470
FEATURE: fix_relative_upload_links now multisite safety
...
This also finds `<img src="/uploads/xyz` HTML images in raw and corrects
them. Also handles some cross multisite recovery and provides better output
2019-05-23 15:09:16 +10:00
Sam Saffron
96e58125a7
FEATURE: rename task to posts:destroy_old_data_exports
...
Previously we were only catching one type of data export, the new job will
catch every csv export we have
Job is pretty safe as it filters on system user id / pm with a particular
slug
2019-05-23 15:02:56 +10:00
Sam Saffron
954293655f
FEATURE: rake posts:destroy_old_user_data_exports
...
Historically we would keep the user data export posts around but delete
the uploads.
This leaves a lot of broken uploads in the system.
This rake task allows us to clean up old mess.
2019-05-23 11:11:37 +10:00
Bianca Nenciu
631b16ef86
FIX: Fix build.
...
Follow-up to 25453eb
.
2019-05-22 17:39:44 +03:00
Bianca Nenciu
25453eb922
FIX: Avoid logging a warn for 404s.
2019-05-22 15:18:38 +03:00
Gerhard Schlager
e224100023
FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled
2019-05-22 11:44:39 +02:00
Sam Saffron
e8799f0ba4
DEV: improve uploads:recover job so it stores a map of old to new sha
...
Previous attempt created broken images
2019-05-22 15:51:09 +10:00
Sam Saffron
ebcb571de7
FIX: allow upload recovery to recover uploads with sha mismatch
...
Filename on disk may mismatch sha of file in some old 1X setups. This will
attempt to recover file even if sha1 mismatches. We had an old bug that
caused this.
This also adds `uploads:fix_relative_upload_links` which attempts to replace
urls of the format `/upload/default/...` with `upload://`
2019-05-22 15:24:36 +10:00
Sam Saffron
f772ecc597
DEV: Correct missing output detailing failure
...
uploads:s3_migration_status was failing but not returning proper output
2019-05-22 12:58:54 +10:00
Guo Xiang Tan
5429c9b5e9
DEV: Fix incorrectly hardcoded value in rake task.
2019-05-22 09:01:25 +08:00
Sam Saffron
a9af77d650
PERF: ensure priority for rake rebake tasks is ultra low
...
Flooding the default queue with lots of jobs is never a good thing. This
reduces the risk of sidekiq going into a bad state post rebake
2019-05-22 10:31:49 +10:00
Sam Saffron
d6daa60d0a
FEATURE: multisite support for posts:rebake_uncooked_posts
2019-05-22 10:04:54 +10:00
Sam Saffron
a2428bd862
FEATURE: warn about sidekiq overload prior to migrating
...
Also makes pre-flight check ensure there is no giant backlog of posts that
need to be cooked
2019-05-22 10:04:33 +10:00
Sam Saffron
5fdc7b7ca2
Correct 59012fc0
...
Logic was flipped here by mistake, oops
2019-05-22 09:48:03 +10:00