Commit Graph

8 Commits

Author SHA1 Message Date
Sam Saffron 30990006a9 DEV: enable frozen string literal on all files
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
Guo Xiang Tan 5a9b029014 Improve error messaging in `SocketServer`. 2018-09-19 09:11:10 +08:00
Guo Xiang Tan 142571bba0 Remove use of `rescue nil`.
* `rescue nil` is a really bad pattern to use in our code base.
  We should rescue errors that we expect the code to throw and
  not rescue everything because we're unsure of what errors the
  code would throw. This would reduce the amount of pain we face
  when debugging why something isn't working as expexted. I've
  been bitten countless of times by errors being swallowed as a
  result during debugging sessions.
2018-04-02 13:52:51 +08:00
Sam 405fd9c15d Merge pull request #4870 from tgxworld/fix_cleanup_sockets_servers
FIX: Ensure we clean up socket servers.
2017-05-24 12:33:34 -04:00
Guo Xiang Tan 0306863d71 Fix the build on travis. 2017-05-17 21:35:22 +08:00
Guo Xiang Tan 4b3b54da70 Make sure we log the backtrace as well. 2017-05-17 16:31:53 +08:00
Robin Ward 1b526ebd91 FIX: Catch broken pipe errors 2017-05-04 15:50:35 -04:00
Sam Saffron f04fbf911a FEATURE: in vim dev you can focus on spec line in autospec
instructions in bin/notify_file_change
2017-04-25 09:13:29 -07:00