Commit Graph

17135 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 4b604b1e68
FIX: displays correct upload icon when only images are allowed 2018-06-18 11:16:34 +02:00
Arpit Jalan f1d1207725 FIX: improve context when user deletes self 2018-06-18 11:36:22 +05:30
Joe e8e8d540d3
FIX: desktop pin-topic modal not wide enough for date-picker 2018-06-16 15:19:08 +08:00
Arpit Jalan a30165ab8d FIX: show time on activity column instead of random number 2018-06-16 07:12:43 +05:30
Jeff Wong 9e55767f6a FIX: don't punish a user for being previously staged for spam flags. 2018-06-15 12:25:25 -07:00
Rafael dos Santos Silva 51cb38783e FIX: start_url was wrong in non-subfolder 2018-06-15 14:29:33 -03:00
Joffrey JAFFEUX 60ff0e9b8c
missing prettified files 2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX 03a7d532cf
DEV: introduces prettier for es6 files 2018-06-15 17:03:24 +02:00
Arpit Jalan c7ee70941e FEATURE: show category page options on wizard 'homepage' step 2018-06-15 19:11:41 +05:30
Joe 4645cf6b28
FIX: remove unwanted space in user notification items 2018-06-15 15:44:51 +08:00
Kris a8660b8be9 formatting build fix 2018-06-15 00:09:09 -04:00
OsamaSayegh 06777aa47d FIX: use the correct notification levels descriptions for PMs 2018-06-15 14:04:14 +10:00
Kris 872656fe52 Give admin list more horizontal space 2018-06-14 23:50:46 -04:00
Robin Ward 4a4406de8c FIX: Properly avoid n+1 query on flagged posts
This code was in here previously but some columns were included that
were not used.
2018-06-14 09:46:52 -04:00
Joffrey JAFFEUX c82887a0f0 Revert "tests prettier trigger"
This reverts commit f74d86639f.
2018-06-14 15:46:03 +02:00
Joffrey JAFFEUX f74d86639f
tests prettier trigger 2018-06-14 15:15:25 +02:00
Jeff Wong 160898acf3 Feature: add jump to post modal on mobile 2018-06-13 22:01:35 -07:00
Rafael dos Santos Silva 8fc08aad09 FEATURE: Update the webmanifest
- Remove share target because the spec is changing
- Allow any orientation again because natural is too restrictive
- Use correct file and mime types for the manifest
2018-06-14 00:13:28 -03:00
Arpit Jalan 94ae89f61f FIX: properly retrieve user custom fields 2018-06-14 07:33:25 +05:30
Joffrey JAFFEUX 276526e30e
FIX: improves micro data support 2018-06-13 23:20:48 +02:00
Régis Hanol ff06ce4cce fix the build 2018-06-13 23:05:23 +02:00
Régis Hanol 051d1a3c36 PERF: faster Screened IP Address roll up 2018-06-13 22:47:23 +02:00
Robin Ward fd54c92a52 FEATURE: New site setting, whitelisted_link_domains
If provided, users who normally couldn't post links (say, due to a
low trust level), can post links to those specific hosts.
2018-06-13 16:11:22 -04:00
Neil Lalonde debbb5be16 FIX: staff see the wrong message when changing another user's email address 2018-06-13 15:18:48 -04:00
Robin Ward ae728702a6 Revert "Revert "Preload custom user fields when viewing flag queue""
This reverts commit 1bb12ee1b6.
2018-06-13 11:44:13 -04:00
Arpit Jalan 4107a02ae8
Merge pull request #5991 from jjaffeux/plugin-sharing-api
FEATURE: adds plugin sharing api
2018-06-13 17:24:03 +05:30
Joffrey JAFFEUX eddcb07f03 FEATURE: adds plugin sharing api 2018-06-13 13:25:51 +02:00
Régis Hanol f93ba5694e UX: show quote button at end of selection on Opera 2018-06-13 11:07:19 +02:00
Joffrey JAFFEUX 4e0c06a0b1
FIX: focusing input displayed after clicking on a link more reliable 2018-06-13 10:31:46 +02:00
Maja Komel 6c9190357c fix get from url for external uploads without CDN 2018-06-13 16:21:28 +10:00
Jeff Wong 0c2f590c64 Feature - allow user and group specific cards styling (#5989) 2018-06-13 14:08:03 +08:00
Sam 12fd0b827e PERF: release results in a couple of cases 2018-06-13 15:11:43 +10:00
Jeff Wong 3d1ff8e0ad FIX: correct group membership on cards for admins 2018-06-12 14:57:26 -07:00
Joshua Rosenfeld 1bb12ee1b6 Revert "Preload custom user fields when viewing flag queue"
This reverts commit 5bd1c5cc95.
2018-06-12 16:46:31 -04:00
Robin Ward 5bd1c5cc95 Preload custom user fields when viewing flag queue 2018-06-12 16:17:22 -04:00
Régis Hanol d8063d09d5 FIX: Add members button wasn't working on mobile for non-admin group owners 2018-06-12 15:05:22 +02:00
Joffrey JAFFEUX 3381a0a42a
UX: reworks dashboard problems section to be in line with new style 2018-06-12 12:47:03 +02:00
Sam Saffron 030e322a39 FEATURE: block top level /my/ routes 2018-06-12 19:47:45 +10:00
Arpit Jalan 59a8471308 FIX: do not show SSO external_email to moderators 2018-06-12 14:20:44 +05:30
Vinoth Kannan 72196ee951 Move the dashboard-problems block outside the condition 2018-06-12 12:01:41 +05:30
Guo Xiang Tan c06824e9c2 FIX: Clients get stucked in readonly mode if messageBus fails. 2018-06-12 12:02:37 +08:00
kleinfreund 4ce1d230c7 Prefer throwing a new Error object instead of just a string expression 2018-06-12 12:56:22 +10:00
Angus McLeod 0997eb6486 Add theme stylesheet(s) to the crawler layout 2018-06-12 12:47:48 +10:00
riking 94f70c7b5c FIX: TopicViewItem: do not store IP of logged in users 2018-06-12 12:43:56 +10:00
riking 4b2e2ea8ef Change TopicViewItem to allow null IP address 2018-06-12 12:43:56 +10:00
Shoshana Berleant f48338df54 add plugin outlet create-account-after-password 2018-06-12 12:42:37 +10:00
Jeff Wong 4599cc8435 FIX: PM participants listed inline 2018-06-11 18:14:25 -07:00
Jeff Wong 44ee26721a FIX: add check for missing assets file in development 2018-06-11 11:18:34 -07:00
Gerhard Schlager 150ae21489 FEATURE: Log user merge in staff logs 2018-06-11 18:43:56 +02:00
Joffrey JAFFEUX 73731463a3
UX: makes sure close modal icon is aligned with title 2018-06-11 13:38:57 +02:00
Vinoth Kannan a6303073a0 Strip images from cooked for topic excerpt 2018-06-11 14:43:53 +05:30
Joe 2ec53a9628
FIX: adjust 2FA input width in mobile login form 2018-06-10 21:33:41 +08:00
Joe 5eb0066be9
FIX: adjust max-width of social login buttons for non-English locals 2018-06-09 14:14:59 +08:00
Gerhard Schlager a26889ada2 FIX: Don't delete profile views during user anonymization
There's no need for that and it can take a lot of time.
2018-06-08 15:50:07 +02:00
Gerhard Schlager 4ba910ac54 Update username only after successful user anonymization 2018-06-08 15:50:07 +02:00
Gerhard Schlager 2564a8285d REFACTOR: Run some parts of user anonymizing in background job 2018-06-08 15:50:07 +02:00
Gerhard Schlager cf038cf72a FEATURE: Remove more PII during user anonymizing
Removes
  * invite if the user was invited
  * email tokens
  * incoming emails
  * email log entries
  * raw emails from posts
2018-06-08 15:50:07 +02:00
Joffrey JAFFEUX 174d392e5a
DEV: adds prettier (#5956)
Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn`

It's recommended to configure your editor to run prettier on file save.
2018-06-08 11:49:31 +02:00
Arpit Jalan 8bd4c11f53 FIX: do not show email disabled notice to staff when they can receive emails 2018-06-08 11:22:26 +05:30
Jeff Wong b7d92061e2 FEATURE: add an option to create undismissable modals 2018-06-07 20:49:33 -07:00
Angus McLeod f10b663eb4 BUGFIX: string in server_plugin_outlet needs to be mutable 2018-06-07 18:27:34 +02:00
Arpit Jalan f9ab3848ed FEATURE: support disabling emails for non-staff users 2018-06-07 18:31:08 +05:30
Joffrey JAFFEUX d556975cdc
FIX: do not use number helper for charts Y value 2018-06-07 14:56:49 +02:00
Joffrey JAFFEUX 74ced977be
FIX: incorrect backup and update times on dashboard 2018-06-07 11:18:17 +02:00
Joffrey JAFFEUX 1071aa21ab
FIX: slightly safer rounding 2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX ab089cd68b
FIX: makes format number round the value before using parseInt 2018-06-07 10:44:21 +02:00
Joe c3ac32d991
FIX: user-fields layout in desktop create account form 2018-06-07 14:03:54 +08:00
Guo Xiang Tan ad5082d969 Make rubocop happy again. 2018-06-07 13:28:18 +08:00
Sam 89ad2b5900 DEV: Rails 5.2 upgrade and global gem upgrade
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated

Performance testing shows that performance has not regressed
if anything it is marginally faster now.
2018-06-07 14:21:33 +10:00
Joe 56dbbfbd2a
FIX: user-fields layout in mobile create account form 2018-06-06 21:02:35 +08:00
Vinoth Kannan d8e641cd98 FIX: avatar_url includes upload_path twice when local storage used 2018-06-06 18:27:30 +05:30
Guo Xiang Tan a83ab01264 REFACTOR: Remove extra param for group mentionable and messableable route. 2018-06-06 09:42:09 +08:00
Arpit Jalan ccbaa719ee
Merge pull request #5923 from techAPJ/group-messageable
FIX: do not verify group visibility when checking for mentionable/messageable
2018-06-06 06:45:22 +05:30
Neil Lalonde 9ba9ff187c Add plugin outlet to admin plugins index 2018-06-05 17:47:30 -04:00
Arpit Jalan f8d82f135f FIX: do not verify group visibility when checking for mentionable/messageable 2018-06-05 16:59:21 +05:30
Guo Xiang Tan d600e71b3d FIX: Clean up stale `UserExport` records daily.
* Add tests for `UserExport.remove_old_exports`
2018-06-05 09:43:40 +08:00
Rafael dos Santos Silva 74c33a5316
Merge pull request #5915 from jjaffeux/sharing-macos-chrome
FIX: sharing popup not showing on macos/chrome
2018-06-04 20:38:10 -03:00
Joffrey JAFFEUX 40b3efacaa FIX: sharing popup not showing on macos/chrome
Despite `navigator.share` being defined the call was failing with this error:

```
sharing DOMException: Internal error: could not connect to Web Share interface.
```
2018-06-05 01:18:57 +02:00
Robin Ward fab59c66f0 FIX: Protection against dangling category group records 2018-06-04 15:43:26 -04:00
Régis Hanol 6024fb84cc make rubocop happy 2018-06-04 19:06:52 +02:00
Régis Hanol ab8cdd6b5b
Upload.url can't be NULL 2018-06-04 18:43:00 +02:00
Régis Hanol 085eaaf18d
FIX: always delete invalid upload records 2018-06-04 18:40:57 +02:00
Arpit Jalan 46fc57222f FEATURE: improve handling of site setting secrets 2018-06-04 21:31:34 +05:30
Arpit Jalan 36f9af4fa4 minor optimizations for post rejected logs 2018-06-02 09:44:55 +05:30
Robin Ward 597ffd7e3f FIX: Keyboard shortcuts didn't work on subfolders 2018-06-01 14:38:09 -04:00
Arpit Jalan 89eca87f16 FEATURE: add staff action log for post rejections 2018-06-01 21:48:27 +05:30
Kris 41999b9949 Limiting history modal height and width 2018-06-01 11:59:29 -04:00
Gerhard Schlager b970b072f6 FIX: User merge should not fail when primary email address is missing
The merge process might move all email addresses of the source user to the target user. Destroying the source user failed in that case.
2018-06-01 16:23:21 +02:00
Joe 560a950da9
FIX: alignment for instructions on change email and 2FA fields 2018-06-01 09:51:46 +08:00
Guo Xiang Tan 9ef61e0af5 PERF: Prefer `exists?` instead of loading AR object. 2018-06-01 09:44:14 +08:00
Kris ba7aff62db safety so pre blocks can't break modal width 2018-05-31 18:19:27 -04:00
Kris 6c15effca2 envelope missing on invite page, long pre lines making modals wide 2018-05-31 18:11:24 -04:00
Guo Xiang Tan 95f9b72351 FIX: Update activation email route was returning a generic json error. 2018-05-31 14:19:43 +08:00
Kris 3e9f1d5cf6 Few small modal fixes 2018-05-30 23:24:43 -04:00
Kris 57cef06192 incoming email modal width too narrow 2018-05-30 15:28:29 -04:00
Joffrey JAFFEUX 8128cbd7db
UX: adds subtitle support for modals 2018-05-30 17:14:00 +02:00
Joffrey JAFFEUX 43b1768987
UX: ceil dahsboard values 2018-05-30 16:32:43 +02:00
Arpit Jalan 704cca3de2 FIX: add proper search context for personal messages 2018-05-30 14:47:46 +05:30
Guo Xiang Tan 21e9315416 FIX: Use user account email instead of auth email when totp is enabled.
https://meta.discourse.org/t/github-2fa-flow-broken/88674
2018-05-30 12:15:12 +08:00
Gerhard Schlager 864ada835b FEATURE: Add Bulgarian language 2018-05-29 21:07:17 +02:00
Kris 7483805f0c Increasing min-width of modals for larger screens 2018-05-29 13:13:35 -04:00
Neil Lalonde e26a14dc29 FIX: error when flagging to notify moderators because message title is too long 2018-05-29 12:21:47 -04:00
Joffrey JAFFEUX ee8cda691d
FIX: simplifies and corrects new collection header tag/drop behaviour 2018-05-29 17:34:34 +02:00
Gerhard Schlager ce687f334b UX: The "enable 2FA" string was hard to translate 2018-05-29 16:25:43 +02:00
Joffrey JAFFEUX a8079ab679
FIX: show none/all on cat/tag drop only when needed 2018-05-29 16:08:31 +02:00
Joffrey JAFFEUX 597095f56f
UX: adds visual feedback when hovering info 2018-05-29 13:31:57 +02:00
Joffrey JAFFEUX 87edde3113
UX: improves dashboard UI for RTL locales 2018-05-29 10:22:31 +02:00
Arpit Jalan 277e216d25 FIX: link to pm tags when searching in personal messages 2018-05-29 12:32:20 +05:30
Sam df815d6c0e DEV: prefer using ordering in relation over default scope 2018-05-29 09:34:12 +10:00
Joffrey JAFFEUX 16d0ab5654 Revert "UX: localizes titles in dashboard table reports"
This reverts commit 409c0ddf85.
2018-05-28 20:35:22 +02:00
Joffrey JAFFEUX 409c0ddf85
UX: localizes titles in dashboard table reports 2018-05-28 20:03:05 +02:00
Joffrey JAFFEUX 4b9c713581
FIX: avoids hidding mobile keyboard on each keystroke 2018-05-28 16:18:25 +02:00
Joffrey JAFFEUX a585c19f2e
FIX: prevents collection header from going under rows 2018-05-28 15:47:07 +02:00
Arpit Jalan 8d9c77e113 optimize group invitation code 2018-05-28 17:59:14 +05:30
Joffrey JAFFEUX 478ccb6698
UX: lower no-change trend emphasis in charts 2018-05-28 13:55:25 +02:00
Arpit Jalan c8bc942333 FIX: do not add invited user to automatic groups 2018-05-28 17:17:48 +05:30
Gerhard Schlager ed2ae3cb0a FIX: Load post revisions in correct order 2018-05-28 11:25:24 +02:00
Joffrey JAFFEUX 82e5727287
UX: -2/+2% change in stats should be no-change in dashboard 2018-05-28 10:55:42 +02:00
Guo Xiang Tan 754458e6a2 PERF: Minor but we can just pass a hash to `where`.
```
Warming up --------------------------------------
          4 x .where     1.040k i/100ms
          1 x .where     1.677k i/100ms
Calculating -------------------------------------
          4 x .where     10.321k (± 5.2%) i/s -     52.000k in
5.053803s
          1 x .where     17.117k (± 3.8%) i/s -     85.527k in
5.004107s

Comparison:
          1 x .where:    17117.1 i/s
          4 x .where:    10321.3 i/s - 1.66x  slower
```
2018-05-28 16:41:38 +08:00
Arpit Jalan 54338cfdcb FEATURE: add support for `group_name` parameter in `/new-message` route 2018-05-28 13:26:41 +05:30
Guo Xiang Tan a081771950
Merge pull request #5872 from OsamaSayegh/users-controller-specs-to-request
REFACTOR: users contollers specs => request specs
2018-05-28 13:32:37 +08:00
Guo Xiang Tan 0b55416742 UX: Don't display `all groups` option if group directory is disabled.a
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
2018-05-28 11:32:55 +08:00
Sam 5a32a70d6c FIX: ColorScheme color missing was returning "nil" 2018-05-28 11:46:00 +10:00
Kris 4bd24e78fc padding fix, small phone fix 2018-05-26 01:12:33 -04:00
OsamaSayegh 449399bef3 return 403 forbidden when local logins disabled 2018-05-26 05:18:19 +03:00
Régis Hanol 5b2e7c8d10 fix the build 2018-05-26 03:11:10 +02:00
Régis Hanol 338d39265a FIX: don't publish notifications_state when user has been deleted 2018-05-26 02:27:54 +02:00
Régis Hanol d23229df85 Let's use the same method 2018-05-26 02:16:53 +02:00
Régis Hanol f988fa31aa FIX: ensure 'notifications_state' is up to date after creating a notification 2018-05-26 02:09:48 +02:00
Kris cc0a5f4526 login fixes, auth message and alignment 2018-05-25 19:15:39 -04:00
Kris 6fc292fef5 reducing some specificty 2018-05-25 17:33:45 -04:00
Robin Ward 587a9c82f5 FIX: Use the username formatter when updating cooked usernames 2018-05-25 17:29:06 -04:00
Kris 3b2af4b91f Adjustments and fixes to updated login design 2018-05-25 16:44:44 -04:00
Robin Ward 4195c7c9ea FEATURE: Ability to clear a user's penalty history
You can do this manually if you want to allow them to reach TL3 without
their penalty history counting against them.
2018-05-25 12:54:22 -04:00
Robin Ward c658fb6e31 Move some display logic out of model, upgrade old code patterns 2018-05-25 12:54:22 -04:00
Neil Lalonde fdce116838 UX: mobile watched words UI in admin needs a way to see all word lists 2018-05-25 11:13:38 -04:00
Robin Ward 3c8369def6 The `isSilenced` and `isSuspended` aliases were useless
We already had `silenced` and `suspended` on the model with the same
effect!
2018-05-25 10:29:26 -04:00
Joe 4a2931f43d
FEATURE: New login / create account form layout 2018-05-25 20:16:38 +08:00
Joe 1948a9912c
FEATURE: Horizontal login / create accout layout 2018-05-25 20:15:34 +08:00
Joe 7f6f61cff2
FIX: Move tips into instructions div 2018-05-25 20:13:06 +08:00
Joe 1a9aeca93b
FIX: Move tips into instructions div 2018-05-25 20:12:08 +08:00
Joe 9e546e9ddc
FIX: Move tips into instructions div 2018-05-25 20:11:22 +08:00
Joffrey JAFFEUX a8901efafe
FIX: flags report is now a lower is better kind of report 2018-05-25 12:59:39 +02:00
Joffrey JAFFEUX acc5e42066
removes logging 2018-05-25 12:12:28 +02:00
Joffrey JAFFEUX e67ac93e6c
UX: makes table report trend icons as charts
This commit will also reverse icon orientation if higher_is_better = false
2018-05-25 12:09:30 +02:00
Gerhard Schlager 20b94bc714 FIX: Extraction of quoted posts failed in some cases
* It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed.
* Revising a post didn't add or remove records from the quoted_posts table.
2018-05-25 12:00:17 +02:00
riking 501bc0e9af FIX: UserProfileView: Do not log IP of logged-in users 2018-05-25 15:54:14 +10:00
Guo Xiang Tan 9d307a9977 FIX: Destroy notifications and sync notifications count in transaction.
* Seeing errors where the user is destroyed right when the call to
  reload is made.
2018-05-25 12:01:36 +08:00
Guo Xiang Tan 755b511b5c PERF: Destroy collapsed notifications in 1 query instead of 3. 2018-05-25 12:01:36 +08:00
Guo Xiang Tan 569f63b8a2
Merge pull request #5825 from featheredtoast/extend-service-worker-cache
FIX: update cache times for service workers
2018-05-25 09:28:17 +08:00
Joffrey JAFFEUX 1be76d066c
FIX: forces boolean when content is only "true" && "false" 2018-05-24 23:41:39 +02:00
Robin Ward a31a458a67 Trivially fix some odd whitespace, indentation 2018-05-24 12:29:55 -04:00
Régis Hanol bb8f0087f4 Add a warning when PostAlerter isn't running in sidekiq 2018-05-24 17:52:59 +02:00
Régis Hanol 71f66cd679 FIX: ensure PostAlerter is always run in sidekiq 2018-05-24 17:27:43 +02:00
Kris c5dbfe1886 liked icon should use d-icon 2018-05-24 11:08:13 -04:00
Arpit Jalan cafd1241b9 FIX: make report data export more resilient to inconsistent date format
The DAU/MAU report export was failing because of date being a string
and not a valid Date value
2018-05-24 17:14:08 +05:30
Guo Xiang Tan 3bfd9698c7 PERF: Avoid running the same query twice in `TopicViewSerializer#details`. 2018-05-24 16:46:13 +08:00
Joe 5ec896d163
FIX: align categories with menu panel links 2018-05-24 16:15:57 +08:00
Guo Xiang Tan 0e284e54f3
Merge pull request #5832 from featheredtoast/safari-no-serviceworkers
Fix: Safari failing to download backups from email links
2018-05-24 15:44:51 +08:00
Guo Xiang Tan 43f7cb05c9 FIX: Broken ping event for web hooks due to missing payload. 2018-05-24 15:16:52 +08:00
Guo Xiang Tan b3860c82da FIX: Don't enqueue web hooks inside a deferred queue.
* The deferred queue is meant for short lived jobs
  and does not guarantee execution. We need to ensure
  that web hooks are always run.
2018-05-24 15:03:17 +08:00
Guo Xiang Tan 8a1aab4e8a PERF: Select distinct active web hooks at the db level. 2018-05-24 14:56:40 +08:00
Sam 4fef9e95d2 should not be a const 2018-05-24 15:42:00 +10:00
Sam 53b97b28f0 FIX: in rare conditions post timing would miss the user 2018-05-24 15:38:33 +10:00
Sam 70179290f3 clean up callbacks during acceptance tests 2018-05-24 15:28:54 +10:00
Sam 4194886b62 correct failing test 2018-05-24 13:02:20 +10:00
Sam ed08545d1f FEATURE: allow searching in title in advanced search
Add UI for matching in title only in advanced search options
2018-05-24 12:34:53 +10:00
Sam 11b544ef4e DEV: add support for custom post message callbacks
Allows for cleaner subscription to changes by plugins, polls will move to
it.
2018-05-24 12:34:53 +10:00
Guo Xiang Tan 2aad91d4a2 PERF: Don't bloat the Sidekiq queue with `Jobs::SendPushNotification`. 2018-05-24 10:04:09 +08:00
Guo Xiang Tan be49da9105 FIX: Don't silently fail if notification fails to create. 2018-05-24 10:04:09 +08:00
Jeff Wong ebd966fbdb Feature: Add warning banner in email settings when mailing list mode enabled 2018-05-23 18:54:10 -07:00
Kris 15f7d06108 User metric badge alignment fix 2018-05-23 18:46:25 -04:00
Régis Hanol 232ed64865 UX: Add category & tags in mobile topic timeline 2018-05-23 23:05:34 +02:00
Neil Lalonde 3db1032bfd FIX: not found page shouldn't include the Google search form for sites with login_required enabled 2018-05-23 16:59:02 -04:00
Kris b519beb314 Turning admin dashboard user counts into badges 2018-05-23 16:55:57 -04:00
Joffrey JAFFEUX a45d8a69f9
FIX: prevents &hellip from being displayed in title attribute 2018-05-23 19:04:26 +02:00
Joffrey JAFFEUX 7232a6e5a9
FIX: do not show composer actions if irrelevant 2018-05-23 18:25:58 +02:00
Joffrey JAFFEUX dd76ba90b3
FIX: bbcode regex was greedy and preventing quotes 2018-05-23 11:55:02 +02:00
Guo Xiang Tan ad9e0d6bea
Merge pull request #5848 from OsamaSayegh/fix-social-login-groups
FIX: apply automatic group rules when using social login providers
2018-05-23 08:17:42 +08:00
OsamaSayegh f6d412465b FIX: apply automatic group rules when using social login providers 2018-05-23 02:26:07 +03:00
Blake Erickson 3edca8b104 Return a 403 instead of 200 when trying to delete a user with posts
See [this commit][1] for more info

[1]: bd352a17bf
2018-05-22 17:02:02 -06:00
Sam 45f65859c9 improve erraticly failing spec 2018-05-23 08:39:15 +10:00
Gerhard Schlager beed676b04 FIX: Check group names when checking username availability 2018-05-22 21:55:54 +02:00
Kris d19d491d65 Styling dashboard user tables 2018-05-22 15:33:06 -04:00
Joshua Rosenfeld cd8d512429
Fix user tag preferences icon 2018-05-22 11:37:18 -04:00
Joffrey JAFFEUX 508b65b76a
UX: refactoring/refining tables of new dashboard 2018-05-22 16:47:23 +02:00
Gerhard Schlager 95db5f0c8c FIX: Do not replace wrong avatars when renaming user 2018-05-22 13:41:51 +02:00
Guo Xiang Tan f6becd6a4e
Merge pull request #5838 from discourse/fix-for-s3-subfolders
FIX for bucket name in GlobalSetting with folder
2018-05-22 18:10:44 +08:00
Joe 48c4f192e9
FIX: make the image field use its own help string 2018-05-22 16:06:25 +08:00
Sam 1ac1ee4287 FEATURE: allow registration of an array custom field 2018-05-22 16:48:39 +10:00
riking 9b0efe9c84 FIX: TopicLinkClick: do not log IP of logged in users 2018-05-22 16:05:38 +10:00
Sam 24abf38d38 PERF: lower the priority on user emails
User emails can wait behind other regular jobs, they are usually somewhat
slower as they involve smtp transactions
2018-05-22 15:20:55 +10:00
Kris 209a8d5e31 Reucing vertical spacing for github onebox pre 2018-05-21 23:29:36 -04:00
Sam 3e06def856 FIX: If we have no logo defined use sketch in manifest 2018-05-22 12:10:59 +10:00
Sam 788ca1f112 FIX: stop adding email to unsubscribe url
Instead of adding email to unsubscribe url store it in redis for 1 hour
rate limit calls to unsubscribe endpoint to ensure there is no risk of
bloating redis

Also move controller to request specs
2018-05-22 09:07:03 +10:00
Guo Xiang Tan ae3a7ca08d Fix unexpected return error. 2018-05-21 22:28:44 +08:00
Guo Xiang Tan 467d91347a Missing specs for `Group`, `Tag`, `Category` and `Flag` web hooks. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan bf84037f79 FIX: Payload for webhooks should be current as of the time the event was triggered.
https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752
2018-05-21 17:29:58 +08:00
Guo Xiang Tan cba3942850 Refactor `WebHookFlagSerializer`. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan f0024f5ec7 Inherit from `BasicGroupSerializer` for `WebHookGroupSerializer`. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan 00c6b078e3 Trim `WebHookUserSerializer`. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan 60e7b13f59 Trim `WebHookPostSerializer` further. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan 3ff0074e9d Trim `WebHookTopicSerializer` further. 2018-05-21 17:29:58 +08:00
Arpit Jalan 1841dd48dc FIX: revert utf-8 encode changes 2018-05-20 17:50:36 +05:30
Arpit Jalan 9f422c93f6 FIX: restrict updates on `confirm_old_email` email templates 2018-05-19 12:19:59 +05:30
Kris 8b96d9a52d fixing group filter 2018-05-18 15:18:10 -04:00
Régis Hanol e209faa6cf UX: ensure whitespace isn't removed when playing with quotes 2018-05-18 19:32:10 +02:00
Arpit Jalan 290ee312e6 FIX: handle invalid mailto links 2018-05-18 18:02:52 +05:30
Arpit Jalan 9512796ef6 FIX: check for blank response when polling feed 2018-05-18 17:00:44 +05:30
Guo Xiang Tan 2fecb4b46e FIX: Client not setting `TopicTimer#based_on_last_post`.
https://meta.discourse.org/t/incorrect-message-key-in-temporarily-closed-topic/87773
2018-05-18 16:32:12 +08:00
OsamaSayegh 0800098f1a FIX: don't allow duplicate watched words (#5844)
We already have logic in place for server side, this'll just display a little message that says the word already exists
2018-05-18 10:11:08 +02:00
David Taylor c168639be2 Add plugin outlet in admin theme list (#5837)
This will be used by discourse-theme-creator to add avatars next to each theme.
2018-05-18 10:09:21 +02:00
Guo Xiang Tan 1ff767559d Fix incorrect param. 2018-05-18 14:05:45 +08:00
Guo Xiang Tan c42b65df5f `find` raises an error if the record is missing. 2018-05-18 13:37:07 +08:00
Arpit Jalan 003b7f06ad FIX: rescue specific error 2018-05-18 09:52:16 +05:30
Guo Xiang Tan 416d19af27 FIX: Wrong target user displayed for user actions in activity stream.
https://meta.discourse.org/t/wrong-assigned-username-in-activity-list/73816
2018-05-18 11:28:13 +08:00
Jeff Wong 04c7dbafa3 FIX: manifest.json better detection at mime type. Find size if uploaded 2018-05-17 14:45:24 -07:00
Joffrey JAFFEUX 4fd17abb76
linting 2018-05-17 23:44:38 +02:00
Kris c1f13ce6a6 adding icons, updating style 2018-05-17 17:03:56 -04:00
Joffrey JAFFEUX af548c23c4
new dashboard quality pass (code, tests and UI) 2018-05-17 22:44:33 +02:00
Jeff Wong 41ffafb65e FIX: best effort at returning correct mime types in manifest.json 2018-05-17 12:14:39 -07:00
Andrew Schleifer bc89674b58 FIX for bucket name in GlobalSetting with folder
When `s3_bucket="bucket/folder` in discourse.conf, absolute_base_url
was bucket/folder.s3-region.amazonaws.com

These names are bad, but this mirrors the s3_bucket/s3_bucket_name in
S3Store

N.B. that nearby s3_upload_bucket _should_ include the folder
2018-05-17 12:59:34 -05:00
Régis Hanol 53f8f6095d FEATURE: staff action logs when creating/updating/deleting badges 2018-05-17 18:09:27 +02:00
Kris 7ab7696c94 fine-tuning dashboard alignment 2018-05-17 11:41:58 -04:00
Arpit Jalan 9532d9a555 FIX: handle invalid tags 2018-05-17 19:33:12 +05:30
Guo Xiang Tan b74c108c09 UX: Display group tabs in user's messages tab for non-staff as well.
https://meta.discourse.org/t/group-inboxes-in-user-messages/86787
2018-05-17 18:10:17 +08:00
Guo Xiang Tan b3981ddc43 Shorten `User.suggest_name` further. 2018-05-17 16:35:03 +08:00
Guo Xiang Tan 147ea37115 FIX: Missing notification for watching first post users when topic is recategorized.
https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2?u=tgxworld
2018-05-17 16:15:29 +08:00
Arpit Jalan 33899664ce FIX: handle bad user profile website 2018-05-17 13:21:24 +05:30
Arpit Jalan 238a13643d FIX: handle missing users when sending push notifications 2018-05-17 12:53:19 +05:30
Arpit Jalan 539cf32f87 FIX: handle encoded mailto links when looking for upload record 2018-05-17 12:44:53 +05:30
Guo Xiang Tan 117763493b Refactor `User#suggest_name`.
* Rename `email` to `string` as variable can be an email, username
  or any valid string.
2018-05-17 14:54:14 +08:00
Arpit Jalan 392f184b24 FIX: check for existence of topic before looking for category 2018-05-17 10:49:01 +05:30
Arpit Jalan aee4045dd0 FIX: suggest name when username/name is provided 2018-05-17 10:36:36 +05:30
Sam 560a16d864 correct resizing in firefox 2018-05-17 14:47:10 +10:00
Barry van Oudtshoorn b6322a35f2 Fix super-wide tables in Firefox
In Firefox (tested in Fx61), the "activity metrics" and related tables can become stupendously wide. Adding a `max-width` resolves this issue.
2018-05-17 14:41:39 +10:00
Sam cc7ecb8a06 FIX: hyperlinks did not work in category boxes 2018-05-17 12:02:24 +10:00
Sam f6c35e5abc FIX: destroy picker if it was loaded 2018-05-17 11:18:04 +10:00
Sam e0695b02d9 Stabalize order of tables in dashboard 2018-05-17 11:05:01 +10:00
Sam c381d60471 Replace the "posts" line with message count 2018-05-17 10:26:30 +10:00
Sam 0b14e6b556 Resizing dashboard should not break graphs 2018-05-17 10:26:30 +10:00
Régis Hanol a9ebde5111 FEATURE: new 'staged' users list for admins 2018-05-17 01:52:49 +02:00
Régis Hanol bfbdee6a57 UX: show footer on groups pages 2018-05-17 01:34:44 +02:00
Régis Hanol 4f945abba2 FIX: infinite loading was broken on group activity posts/mentions pages 2018-05-17 01:34:13 +02:00
Régis Hanol 674318e127 UX: don't show 'auto delete' option for TL4 2018-05-17 00:42:48 +02:00
Kris 98f8f74f37 dashboard column alignment 2018-05-16 17:18:13 -04:00
Kris 91af7cf46c dashboard alignment fix 2018-05-16 16:04:22 -04:00
Kris 827ba2d3cf styling misc section of dashboard 2018-05-16 15:49:02 -04:00
Kris 4b0bf35cd7 dashboard style updates 2018-05-16 15:07:35 -04:00
Régis Hanol b284464a91 FIX: PostOwnerChange should update 'topic.last_poser' 2018-05-16 19:48:04 +02:00