f40249faad
FEATURE: make trust level 3 time period admin setting
2015-12-22 23:26:19 +05:30
cca0896b9e
FIX: Update all does not trigger callbacks.
2015-12-17 00:07:04 +08:00
e52852dd0f
FIX: Autoclose message was not correct when immediate
...
FEATURE: Warn when setting auto-close for right now
2015-12-08 18:16:48 +05:30
578f606a1a
add 'incoming_email' to groups
2015-12-07 12:39:28 +01:00
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
ad3dd161e7
FEATURE: first class group mentions built in
...
If you allow a group to be mentioned it can be mentioned with the @ symbol.
Keep in mind as a safety mechanism max_users_notified_per_group_mention is set to 100
2015-11-30 17:08:43 +11:00
914b854d92
send invite & message notification emails immediately
2015-11-27 19:09:35 +01:00
5e93140f85
FEATURE: Can override any translation via an admin interface
2015-11-27 11:35:19 -05:00
6354324f2f
FIX: validate automatic membership email domains
2015-11-27 12:35:33 +05:30
43d63367fd
PERF: stop loading handlebars and ember compilers in prod
...
(this removes a nice 50K from our initial payload and saves memory)
Also fixes invalid HTML automatically if added to HEAD or /BODY
2015-11-27 11:59:01 +11:00
0d54c18c8b
new hidden 'allow_staged_accounts' setting
2015-11-26 18:31:23 +01:00
d65ec1af2e
Rename `ninja_edit_window` to `editing_grace_period` :'(
2015-11-24 14:28:42 -05:00
88f1a8f0b1
Merge pull request #3821 from mpalmer/letter-avatar-proxy
...
Proxy letter avatars by default
2015-11-19 20:02:16 +11:00
85580cd243
fix user_search spec
2015-11-18 21:08:50 +01:00
ff10eb32a6
don't return staged users in mentions
2015-11-18 20:57:49 +01:00
92ba6125c4
FEATURE: new 'automatically_unpin_topics' user preference
2015-11-17 18:21:40 +01:00
448a1413d3
left over specs
2015-11-10 00:56:57 +11:00
6dd4bc7d57
FEATURE: support group owner, capable of controlling group membership
...
Group owners are regular users that can add or remove users to a group
The Admin UX allows admins to appoint group owners
The public group UX will display group owners first and unlock UI to
add and remove members
Group owners can only be appointed on non automatic groups
Group owners may not appoint another group owner
2015-11-10 00:56:57 +11:00
ffa523a543
FIX: when moving posts, retain creator and date from OP
2015-11-07 15:17:47 +11:00
c09f345cff
Proxy letter avatars by default
...
On sites that don't otherwise configure an avatar fallback, Discourse will
now tell the client to get its letter avatars from a location which nginx
proxies to the centralised `avatars.discourse.org` service. This alleviates
privacy concerns, whilst still providing some degree of performance benefit
(no need for every site to delay avatar response by 300ms for image
rendering).
It is still possible to gain the benefits of global image caching and the
lower latency of requesting directly from a CDN, by explicitly changing the
`external_system_avatars_url` site setting to
`https://avatars.discourse.org/letter/{first_letter}/{color}/{size}.png `.
2015-11-06 14:13:44 +11:00
b7803fc68e
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers
2015-11-05 18:51:26 -08:00
2fc52e26a6
Optimize all_allowed_users query
2015-10-29 19:39:30 +02:00
a439500bac
FIX: do not mark post as spam if the previous flag was disagreed
2015-10-17 01:30:53 +05:30
de344bcd7e
Merge pull request #3854 from tgxworld/fix_transactional_race_condition
...
FIX: Race condition when wrapping `PostCreator#create` in a transaction.
2015-10-15 11:07:20 +02:00
600e42c2ba
FIX: Race condition when wrapping `PostCreator#create` in a transaction.
2015-10-15 14:42:40 +08:00
b60bceba36
fix the build
2015-10-14 19:20:30 +05:30
6f43b575a8
FEATURE: no need to cap new and unread together anymore
...
- leave unread alone
- cap new at 500 per site, with a site setting
2015-10-01 17:17:15 +10:00
6c37b26b24
Correct site spec
2015-09-28 16:50:24 +10:00
43c7320f55
FIX: Allow really long links to work
2015-09-25 14:07:20 -04:00
ffb8cb8cac
FEATURE: remove dependency of Redcarpet
...
PERF: cache fancy_title in topics table
New pure ruby implementation is far more flexible and easier to amend.
2015-09-24 13:37:53 +10:00
5ca26a7707
FEATURE: add site setting use_admin_ip_whitelist to enable/disable the whitelisting of admins by IP address
2015-09-23 12:15:08 -04:00
36309e50cc
Merge pull request #3767 from tgxworld/track_user_profile_views
...
Track user profile views
2015-09-23 11:38:18 +02:00
1aad58b642
Merge pull request #3781 from tgxworld/feature_log_category_settings
...
Feature log category settings
2015-09-23 11:34:08 +02:00
3853e3cfdc
PERF: omit 2 queries on every full page load
2015-09-23 16:47:17 +10:00
613761d1cd
FEATURE: upgrade to Rails 4.2.4
2015-09-23 15:24:30 +10:00
4f7140fb32
FIX: properly filter whispers in user stream
2015-09-22 00:50:52 +02:00
2ae032c9b0
FIX: categories page would sometimes show no topics, even if there are some visible topics to show
2015-09-21 18:13:14 -04:00
fe656fb04d
FIX: select appropriate period when redirecting to top
2015-09-21 20:28:20 +02:00
f39b9124b6
FEATURE: Log staff actions for Category changes.
2015-09-18 10:53:08 +08:00
7acc93b2a0
FEATURE: Track user profile views.
2015-09-16 14:48:31 +08:00
83efde79f0
specs to account for new default letter avatar location
2015-09-15 13:25:15 +10:00
b9a9a91335
FIX: couldn't set 'never' for the default email digest frequency setting
2015-09-14 10:36:25 +02:00
5af0f5f80e
FEATURE: Whisper posts
2015-09-11 14:05:21 -04:00
b6343b1e10
Merge pull request #3697 from riking/patch-6
...
FEATURE: Allow plugins to add admin dashboard warnings
2015-09-08 16:49:58 -04:00
335be272ff
FEATURE: implement capping of new/unread
...
We cap new and unread at 2/5th of SiteSetting.max_tracked_new_unread
This dynamic capping is applied under 2 conditions:
1. New capping is applied once every 15 minutes in the periodical job, this effectively ensures that usually even super active sites are capped at 200 new items
2. Unread capping is applied if a user hits max_tracked_new_unread,
meaning if new + unread == 500, we defer a job that runs within 15 minutes that will cap user at 200 unread
This logic ensures that at worst case a user gets "bad" numbers for 15 minutes and then the system goes ahead and fixes itself up
2015-09-07 12:03:17 +10:00
5984b62347
FIX: ensure we remove 'category_users' records when a user is deleted
2015-09-02 20:43:15 +02:00
262f561a87
FEATURE: relax username rules to allow - and . and leading _
...
This relaxes our very strict username rules to allow for some long asked for requests
- leading _ is now allowed
- . is allowed except for trailing char and confusing extensions like .gif .json
- dash (-) is now permitted
2015-09-02 12:13:44 +10:00
1bd0f5b015
FEATURE: group can grant a trust level when a user is added
2015-09-01 16:52:12 -04:00
65790452d8
Clean up the test checks when done
2015-09-01 13:32:35 -07:00
4e5228dc9e
FIX: don't send notification emails to deactivated user
2015-08-31 12:35:12 +05:30
3cbfc45bf6
FEATURE: Allow plugins to add admin dashboard warnings
2015-08-25 17:20:14 -07:00
bef80633b1
FEATURE: global admin override of most of the user preferences
2015-08-21 20:39:21 +02:00
d1c69189f3
FEATURE: Can edit category/host relationships for embedding
2015-08-20 15:56:04 -04:00
9ae9aed010
FIX: change **default** notification state when a topic is recategorized within 5 days of creation
2015-08-19 22:40:20 +02:00
e82f892c2d
FIX: allow global settings to include keys that have numbers in them
2015-08-14 17:01:21 +10:00
a3c6cd7b38
FIX: handle link tracking correctly for cdn based urls
...
(usually attachments)
2015-08-05 12:15:08 +10:00
54b780439d
FIX: CDN should always be whitelisted correctly
2015-08-05 11:49:11 +10:00
7b8b96446e
FEATURE: track statistics around post creation
...
- how long were people typing?
- how long was composer open?
- how many drafts were created?
- correct, draft saved to go away after you continue typing
store in Post.find(xyz).post_stat
2015-08-03 14:29:15 +10:00
bb93a345eb
UX: Use smaller messages for moderator actions.
2015-07-27 10:09:21 -04:00
3b61b098ab
PERF: optimise original query instead of huge rewrite
...
better perf for all cases
2015-07-21 21:53:54 +10:00
4491813d22
Revert "Revert "PERF: optimise query that gathers topic tracking state""
...
This reverts commit 909be09f1a
2015-07-21 21:48:07 +10:00
909be09f1a
Revert "PERF: optimise query that gathers topic tracking state"
...
This reverts commit 343e417a55
2015-07-21 17:35:50 +10:00
343e417a55
PERF: optimise query that gathers topic tracking state
...
(this query runs on the front page to figure out new and unread topics)
2015-07-21 17:14:30 +10:00
e3d6c476f5
Merge pull request #3593 from tgxworld/cache_results_on_about_page
...
Cache results on about page
2015-07-21 10:04:51 +10:00
b0ea6764e0
PERF: Cache About#stats.
2015-07-20 22:45:05 +08:00
b0802abae2
FIX: crop & optimize user background profile/card images
2015-07-15 17:15:43 +02:00
b772d96f7a
FEATURE: permalink normalization
...
Optionally allow admins to apply regex based normalization
to permalinks prior to matching.
This allows us to drop query string, or cleanly ignore slugs, etc.
2015-07-15 15:34:25 +10:00
e0c9054748
FEATURE: invite page tabs
2015-07-13 09:42:51 +05:30
782dd13e78
FEATURE: track user visits on mobile and display on admin dashboard in a new Mobile section
2015-07-07 14:06:42 -04:00
00e1659a57
remove some intermittently failing report specs. they aren't worth the cost of maintaining them.
2015-07-06 15:01:43 -04:00
8c84e60df6
FIX: application request numbers for prev 30 day period was for current 30 day period minus today, not previous 30 days
2015-07-06 15:01:43 -04:00
03665e8466
FIX: mark user as approved if an invite is already present
2015-06-26 01:57:29 +05:30
80f258e51c
FIX: don't count mentions in oneboxes
2015-06-24 11:44:58 +02:00
9f88d6e252
fix regression in visible notification detection
2015-06-23 06:14:22 +10:00
5eabf01c29
FIX: don't allow storage of post timings batch larger than 60 secs
2015-06-19 10:35:55 +10:00
611b5f996e
FIX: unpinned topics shouldn't remain pinned on categories page
2015-06-10 14:36:55 -04:00
7b6d6b76eb
FEATURE: Multiple embeddable hosts
...
- Also refactors two site settings components into one, with tests
2015-06-09 13:25:43 -04:00
545f19500d
FIX: when sending private message emails do not check email_direct setting
2015-06-09 13:05:26 +05:30
feeb509a97
SECURITY: expire all existing email tokens on password reset
2015-06-06 03:50:06 +10:00
4171eb758c
SECURITY: expire all existing sessions if user changes passwords
2015-06-06 03:09:19 +10:00
b33654ac31
Remove site setting stubbing (Round 1)
2015-06-03 15:44:00 +05:30
725861f344
FIX: move draft cleanup to the dedicated method and add test
2015-06-03 14:35:54 +05:30
40882a9576
add another test
2015-06-02 20:28:33 +10:00
0fd1974838
FIX: leaving around useless drafts after posting
2015-06-02 20:28:33 +10:00
d459cb95dc
FIX: when advancing draft sequence remove old drafts
2015-06-02 20:28:33 +10:00
64e73e98fb
FIX: allow the cooked_post_processor to download external uploads
2015-06-01 20:08:41 +02:00
97f03e699d
FIX: mixed local s3 store missing avatars
2015-06-01 11:17:42 +10:00
acafa491b2
user avatar urls/templates refactor
2015-05-29 18:51:17 +02:00
5a143c0c6e
storage engines refactor
2015-05-29 18:39:47 +02:00
0aa552cf61
remove fragile assertion
2015-05-29 16:53:27 +02:00
ea8cf1a208
FIX: topic auto-close uses the client's time zone
2015-05-27 18:01:46 -04:00
147ea002f7
FIX: allow handling for avatars that are not in the set of "resized sizes"
2015-05-26 15:41:50 +10:00
eeda367e70
FIX: should be able to serve optimized image from local if its ... local...
2015-05-26 12:32:52 +10:00
bb0c2813ac
FEATURE: generate (avatar) thumbnails in a background task
...
FIX: keep the "uploading..." indicator until the server replies via the MessageBus
FIX: text was disapearing when uploading an avatar
PERF: always use a region for S3 (defaults to 'us-east-1')
FEATURE: ApplyCDN middleware when using S3
FIX: use the same pattern to store files on S3 and locally
PERF: keep a local cache of uploads when generating thumbnails
FEATURE: migrate_to_s3 rake task
2015-05-25 17:59:00 +02:00
1c926d22c6
Correctly parse `require_activation` field of SSO
2015-05-21 16:50:54 -05:00
1c34341f31
Replace site setting with a payload attribute
2015-05-19 11:16:02 -05:00
4c26c4d9bc
Add a SiteSetting to not trust sso emails by default
2015-05-15 12:15:06 -05:00
e074651fdc
PERF: refactor user search so works more efficiently
...
Stop scanning entire user table
2015-05-14 14:38:47 +10:00
e6f73a1c80
PERF: optimise front page category security lookup query
2015-05-14 12:19:22 +10:00
bb29bff5d8
Merge pull request #3463 from techAPJ/patch-2
...
FIX: match subdomain with email domain blacklist
2015-05-13 17:56:54 +02:00
220b9c5abe
FIX: match subdomain with email domain blacklist
2015-05-13 21:02:02 +05:30
d90e0fe66b
Merge pull request #3460 from techAPJ/patch-3
...
FIX: rate limit topic invitations
2015-05-13 12:55:20 +02:00
4324a157e0
FIX: rate limit topic invitations
2015-05-13 14:44:37 +05:30
51d82fc25d
PERF: Active Record #pluck is twice faster
...
PERF: SqlBuilder bypasses AR converters and uses PG directly
2015-05-13 16:46:17 +10:00
5ef641126f
remove s3 deprecation warning, we will continue to support it
2015-05-12 08:27:25 +10:00
0f53fc8328
correct emergency regeneration in the controller
2015-05-06 07:33:32 +10:00
a48dd1cc28
store the slug as the title is, only sanitize the slug
...
and prettify code
2015-05-05 18:33:16 +08:00
b772ff6e13
FEATURE: add slug geneartion options
2015-05-05 18:08:30 +08:00
f58d85edea
FEATURE: move stylesheet cache out of the uploads directory
2015-05-05 15:50:13 +10:00
963ebf5963
FIX: if approving a user when must_approve_users is false, don't send an email
2015-05-04 15:30:25 -04:00
803feefd54
MessageBus handles readonly redis now, no need to wrap it
2015-05-04 12:21:00 +10:00
b8cbe51026
Convert specs to RSpec 2.99.2 syntax with Transpec
...
This conversion is done by Transpec 3.1.0 with the following command:
transpec
* 424 conversions
from: obj.should
to: expect(obj).to
* 325 conversions
from: == expected
to: eq(expected)
* 38 conversions
from: obj.should_not
to: expect(obj).not_to
* 15 conversions
from: =~ /pattern/
to: match(/pattern/)
* 9 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 5 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 4 conversions
from: lambda { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should_not
to: expect { }.not_to
* 1 conversion
from: === expected
to: be === expected
* 1 conversion
from: =~ [1, 2]
to: match_array([1, 2])
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2015-04-25 11:18:35 -04:00
151b559e4c
FIX: If you delete a user, delete their queued posts as well.
2015-04-24 16:04:44 -04:00
3660fe4f60
FIX: When approving/rejecting a post it should delete the user action
2015-04-24 15:25:47 -04:00
5b3f99aa50
Don't blow up if Redis switches to READONLY
2015-04-24 14:37:16 -04:00
a737090442
- FEATURE: revamped poll plugin
...
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
f600ead587
FIX: Don't validate approved posts.
...
A moderator has already validated them. Otherwise we hit things like
rate limits.
2015-04-21 11:59:35 -04:00
2cdd967188
Adds support for invisible approval queues, which we'll need for Akismet
2015-04-20 17:19:05 -04:00
296add56e6
correct letter avatar template
2015-04-20 13:07:12 +10:00
51b747346e
PREF: speed up grabbing unread counts
2015-04-17 16:01:20 +10:00
832cb9fdc3
FIX: admin check missing from topic tracking state
...
FIX: handle muted categories correctly
2015-04-17 14:03:08 +10:00
4387e05162
PERF: speed up query
2015-04-16 17:29:37 +10:00
a5b25ad2af
FEATURE: scale up likes per day as users increase trust level
...
tl2 = 1.5 times the likes
tl3 = 2 times the likes
tl4 = 3 times the likes
configurable via tl[234]_additional_likes_per_day_multiplier site setting
2015-04-16 09:44:30 +10:00
d2ed64751e
UX: Show category badge on enqueued posts
2015-04-15 15:29:37 -04:00
9ffec28076
Allow posts in any queue to support topic/post attributes
2015-04-15 14:54:37 -04:00
0c233e4e25
Interface is wired up for Approving/Rejecting posts
2015-04-15 14:54:37 -04:00
a5ee45ccbe
`PostEnqueuer` object to handle validation of enqueued posts
2015-04-15 14:54:36 -04:00
8ba6a45cd7
Post Queue model to enqueue creation of posts
2015-04-15 14:54:35 -04:00
eaf5d21c41
Don't store post timings that are greater than the account lifetime
2015-04-14 11:49:44 -04:00
5650428052
FIX: Sort page views report records
...
Adding a sort ascending by date to the page views report.
2015-04-12 10:46:13 -07:00
75890aed26
FEATURE: allow admins to choose a group as a primary group
...
FEATURE: allow admins to set a default title for a group
2015-04-10 12:17:28 +10:00
0e1c4a0a44
Merge pull request #3313 from techAPJ/patch-1
...
FEATURE: invite existing user to a topic
2015-04-03 11:41:10 +02:00
8c2d7dcaac
FEATURE: invite existing user to a topic
2015-04-03 15:00:04 +05:30
682656fa6c
FIX: only redirect to whitelisted hostnames
2015-04-01 22:59:25 +02:00
0f4a4651a9
FIX: youtube preview video title link doesn't work
2015-04-01 18:23:27 +02:00
eec1921ba9
FIX: notifications inconsistencies + never notify system user
2015-04-01 11:55:59 +02:00
05737effef
FIX: stop stripping dots from SSO names
...
This could upset Louis C.K.
2015-03-27 10:25:51 +11:00
0c287d7d6b
ensure usernames do not keep cycling
2015-03-27 10:04:16 +11:00
4566a1e30a
FIX: sso override code not triggered when attaching to existing user
2015-03-27 09:39:35 +11:00
5aa1272f05
clean up first day user definition and object model
2015-03-26 16:48:36 +11:00
9834d11503
Staff and TL2 up are immune to newuser checks and not considered new users
2015-03-26 16:04:46 +11:00
cfa511e35d
FIX: correctly mute likers
...
FEATURE: disallow all muting of staff
2015-03-26 12:08:04 +11:00
fb0e7dc0b2
FIX: do not delete already redeemed invite
2015-03-25 23:30:09 +05:30
90de61ee3d
S3 deprecation warning
2015-03-25 18:34:07 +01:00
4862a93804
FIX: delete duplicate invites
2015-03-25 22:43:41 +05:30
853c91d7d0
Merge pull request #3289 from fullfatthings/suppress_sso_welcome_emails
...
Add an sso option to suppress welcome emails
2015-03-23 10:36:58 +11:00
3c0fee1786
Fixes broken spec
2015-03-20 13:24:03 -04:00
e8648350eb
Add an sso option to suppress welcome emails
...
As discussed here: https://meta.discourse.org/t/create-new-sso-users-without-sending-welcome-emails/24894
2015-03-20 17:04:52 +00:00
5084e2bdf1
Merge pull request #3284 from techAPJ/patch-1
...
FEATURE: new site setting min_first_post_length
2015-03-19 19:55:27 +01:00
b706307ac7
FEATURE: new site setting min_first_post_length
2015-03-20 00:20:38 +05:30
Arpit Jalan
Guo Xiang Tan
Régis Hanol
Andy Waite
Sam
Robin Ward
Matt Palmer
kerryliu
James Kiesel
Neil Lalonde
Kane York
Paul Kaplan
Erick Guan
Arthur Neves
Ed Gibbs
Dan Singerman
