839916aa49
DEV: Debundle plugin javascript assets and don't load if disabled ( #7566 )
...
And don't load javascript assets if plugin is disabled.
* precompile auto generated plugin js assets
* SPEC: remove spec test functions
* remove plugin js from test_helper
Co-Authored-By: Régis Hanol <regis@hanol.fr>
* DEV: using equality is slightly easier to read than inequality
Co-Authored-By: Régis Hanol <regis@hanol.fr>
* DEV: use `select` method instead of `find_all` for readability
Co-Authored-By: Régis Hanol <regis@hanol.fr>
2019-07-15 20:22:54 +05:30
cbb4af124b
Fix the build.
...
Follow up to 4b0cf7f6dd
2019-07-15 16:38:54 +08:00
4b0cf7f6dd
SECURITY: XSS when displaying watched words in admin panel.
...
The XSS here is only possible if CSP is disabled. Low impact since CSP
is enabled by default in SiteSettings.
2019-07-15 10:55:50 +08:00
c4d1833588
FIX: Do not show bootbox if post has no replies. ( #7866 )
...
When we delete a post that has replies, we show a modal asking if the user wants to delete the post, the post and its direct replies or the post and all its replies.
If replies are deleted before a post, that modal would ask the user if they want to delete the post and 0 replies.
That commit ensure we skip the modal and directly delete the post in this case.
2019-07-12 11:42:57 +02:00
1bb258ab49
DEV: use upload short-url in html to markdown conversion if 'base62-sha1' data attr available.
2019-07-05 10:06:41 +05:30
c78634284c
UI: when in a different topic context, allow dismissing draft without destroying it
...
This changes the label and behaviour of the "No, keep" button in the confirmation modal when user cancels a draft while on a different topic. The new button label is "No, save draft", and when clicked, the composer will be dismissed without destroying the draft.
2019-07-04 11:45:57 -04:00
a60ec00f7a
fix tests ( #7853 )
2019-07-03 16:32:27 +02:00
d521959768
DEV: simpler report page test ( #7851 )
2019-07-03 16:08:48 +02:00
f9f1df7611
DEV: prevents reports key to be time dependant when testing ( #7850 )
2019-07-03 15:43:01 +02:00
bfdf740a05
FIX: Show 'Export' button for all tabular reports. ( #7838 )
2019-07-03 14:47:36 +02:00
1c6bb8748b
fix tests ( #7849 )
2019-07-03 13:45:03 +02:00
3d64532273
FEATURE: allow disabling theme components ( #7812 )
...
This allows you to temporarily disable components without having to remove them from a theme.
This feature is very handy when doing quick fix engineering.
2019-07-03 18:18:11 +10:00
39e3162323
DEV: skip click-track to attempt to reduce timeouts in tests ( #7836 )
2019-07-02 10:08:28 +02:00
4ba35472e6
Don't check for second factor when switching to anonymous account ( #7803 )
2019-06-27 15:01:26 -07:00
a61147d838
FEATURE: displays tags in search menu results when enabled ( #7819 )
2019-06-27 19:26:14 +02:00
fe870a1e54
DEV: Respond with error 400 to uploads requested via XHR
...
follow-up to 13f38055
2019-06-27 11:15:35 +02:00
df9b295510
DEV: skip load-script to prevent timeouts ( #7817 )
2019-06-27 10:57:40 +02:00
5b9a3f8acd
DEV: attempts to make load-script more reliable ( #7816 )
...
We don't check on script anymore, but we still check on window.ace making very unlikely to regress.
2019-06-27 10:19:55 +02:00
79d657203d
fix tests
2019-06-26 17:44:23 -07:00
88ef5e55fe
FEATURE: add ability to have multiple totp factors ( #7626 )
...
Adds a second factor landing page that centralizes a user's second factor configuration.
This contains both TOTP and Backup, and also allows multiple TOTP tokens to be registered and organized by a name. Access to this page is authenticated via password, and cached for 30 minutes via a secure session.
2019-06-26 16:58:06 -07:00
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
cea3a027f3
FIX: category-chooser search should be scoped to category ( #7794 )
2019-06-24 10:45:30 +02:00
59e84e8e05
DEV: skip tests instead of commenting them ( #7774 )
2019-06-17 10:24:20 +02:00
035e63c81f
FIX: Allow the clear callbacks to execute in acceptance tests
2019-06-14 13:29:13 -04:00
a8793d0d9a
REFACTOR: Test Memory Usage Fixes ( #7769 )
...
* Calling `Discourse.reset()` creates a new container
We should run our de-initializers only after acceptance tests,
since initializers are not run outside of acceptance tests anyway,
and the container at this point can be passed properly to the
`teardown()` method.
* Remove `Discourse.reset` from tests
This would cause a new container to be created which leaks many objects.
* `updateCurrentUser` is more accurate than `replaceCurrentUser`
2019-06-14 14:54:20 +02:00
7bb94e8716
DEV: Increase wait duration between smoke test further during edit.
...
Otherwise, the app detects that we're replying too quickly.
2019-06-14 12:21:54 +08:00
62f4284865
DEV: 302 status is normal in smoke test
...
Login can redirect there are potentially other cases
2019-06-14 14:21:07 +10:00
5b55252e10
DEV: Add more wait between edit so we don't end up replying too quickly.
2019-06-13 09:14:17 +08:00
19ca2d4772
DEV: reset widget clean callback between tests ( #7761 )
2019-06-12 17:49:02 +02:00
9daba50d48
FIX: Unsubscribe seemed to be missing some events ( #7762 )
...
This forces an unsubscribe from all events.
2019-06-12 17:48:01 +02:00
621b6493f7
DEV: test badge titles presence on badge page
...
follow-up on 2863e7c
2019-06-12 15:04:21 +02:00
f60451a89d
DEV: Fix linting error
2019-06-12 00:19:52 +01:00
23f457b87d
DEV: disables d-editor emoji test to attempt to fix timeouts ( #7755 )
2019-06-12 00:30:11 +02:00
5da91fa8f8
DEV: disable emoji-picker test to attempt to fix timeouts ( #7754 )
2019-06-12 00:11:21 +02:00
1feaacaecb
DEV: skip emoji picker opening test to attempt to fix timeouts ( #7753 )
2019-06-11 23:54:20 +02:00
58057484fe
DEV: skip ace-editor to attempt to avoid timeouts ( #7752 )
2019-06-11 23:38:43 +02:00
cb08d3cc26
DEV: adds module debugging to js tests ( #7751 )
2019-06-11 23:14:42 +02:00
3d7c26c15e
FIX: Memory Leaks w/ Container ( #7750 )
...
Gives instance initializers the ability to add a `teardown` method that
will be called between tests to clean up after themselves.
2019-06-11 18:41:27 +02:00
dc15486f0a
Revert "DEV: resets csrf ajax prefilter only if present ( #7747 )"
...
This reverts commit 6612218a4e
2019-06-11 13:34:25 +02:00
000a35b219
FIX: Do not live-load posts from ignored users
2019-06-11 12:07:14 +01:00
6612218a4e
DEV: resets csrf ajax prefilter only if present ( #7747 )
2019-06-11 12:50:20 +02:00
ebf77f74b7
Revert "DEV: prevents csrf token to leak state between tests ( #7746 )"
...
This reverts commit b29d63a52d
2019-06-11 12:19:49 +02:00
b29d63a52d
DEV: prevents csrf token to leak state between tests ( #7746 )
2019-06-11 11:54:23 +02:00
4deb0f6d59
DEV: prevents post-cooked decorators to leak between tests ( #7744 )
2019-06-11 10:02:10 +02:00
e5cace9185
FIX: File size text should not be part of link.
2019-06-11 15:21:06 +08:00
d20ea38f02
Fix the build.
...
Follow up to bd538f7437
2019-06-11 10:05:57 +08:00
06d974d55c
FEATURE: Add base62 sha1 to cooked data attribute
...
* FEATURE: Add base62 sha1 to data attribute in `Post#cooked`.
* FIX: Use `Upload#short_url` when quoting an image.
2019-06-11 11:15:45 +10:00
bd538f7437
FIX: Composer preview not caching inline onebox.
2019-06-11 09:14:53 +08:00
Vinoth Kannan
Guo Xiang Tan
Bianca Nenciu
Penar Musaraj
Joffrey JAFFEUX
Osama Sayegh
Ralph Rooding
Gerhard Schlager
Jeff Wong
Robin Ward
Sam Saffron
Maja Komel
David Taylor