a7628c1d74
FIX: use ordered_posts for last post check, not the posts relation
...
The `posts` relation on `Topic` is not ordered. Using `Topic.posts.first`
is basically the same as asking for a random post, it will depend on DB
order. This breaks on Topic merge and split for example.
Additionally, a huge problem with that is that it forces active record down
a slow path. `Topic.posts.first` is extremely slow on giant topics, since
it has no default ordering it appears AR materializes the entire set prior
to doing `first`.
This commit also illustrates the importance of testing, initially I only
fixed the second instance of the problem in `post_validator.rb` but testing
revealed that the problem was repeated at the top of the file.
Longer term we should consider a larger change of default ordering the posts
relations so people do not fall down this trap anymore.
2019-01-18 13:18:40 +11:00
4831c4c2ee
FIX: Use safe navigation operator throughout statement
2018-12-03 20:00:28 +00:00
e32cdb00cb
Fix the build
2018-12-03 18:51:07 +00:00
b373ff47e2
FIX: Topic is nil when first post is being created
2018-12-03 18:30:52 +00:00
3f8fa4ad4e
FEATURE: Do not check consecutive replies for original poster. ( #6714 )
2018-12-03 02:32:29 -08:00
b6576d9473
FEATURE: Add new setting to force user edit last post. ( #6571 )
2018-11-14 15:48:16 +01:00
68e4e6a575
FIX: staged users are still tl0 but do not trigger spam if 1 week old.
2018-06-18 17:20:04 -07:00
9e55767f6a
FIX: don't punish a user for being previously staged for spam flags.
2018-06-15 12:25:25 -07:00
fd54c92a52
FEATURE: New site setting, whitelisted_link_domains
...
If provided, users who normally couldn't post links (say, due to a
low trust level), can post links to those specific hosts.
2018-06-13 16:11:22 -04:00
e27edfe597
FIX: Don't give two errors about not being able to post links
2018-04-05 12:54:48 -04:00
10759677db
FIX: when uploading image newuser restrictions should not apply to staff
2018-04-05 09:51:03 +05:30
baf1c385eb
UX: when a post is blocked due to a watched word, message includes the word being blocked
2018-02-28 11:22:18 -05:00
3ea272f4f1
New setting: minimum trust level to embed images in a post
2018-02-20 20:00:06 -05:00
5466389f4e
FIX: Consider oneboxes links wrt to `min_trust_level_to_post_links`
2018-02-08 18:27:40 -05:00
dedeb2deb8
FIX: Don't show the link button in the composer if linking is disabled
2018-02-08 12:56:10 -05:00
6a5dad0b86
FIX: Too much Javascript :)
2018-02-07 11:46:05 -05:00
016b9cd0e9
FIX: Count the links in the post
2018-02-06 20:16:48 -05:00
1bab15c757
FEATURE: A site setting for a minimum TL to post links
2018-02-06 18:07:58 -05:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
68b3dd43ce
fix intermittent failing tests, some watched word refactoring
2017-07-27 12:27:01 -04:00
59b906ab0d
FEATURE: Disable minimum post length check when in PM with non human users.
...
https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld
2017-04-27 16:00:22 +08:00
fb2633366a
FIX: featured link topics shouldn't require the same min post length
2016-12-09 15:46:26 -05:00
52763f5115
FEATURE: Allow posting a link with topics
2016-12-05 17:20:54 +01:00
64094954bc
FIX: Broken posting
2016-09-16 13:12:05 -04:00
de9136a8f2
FIX: bypass TL0-specific validations on posts in a PM
2016-04-18 22:08:42 +02:00
99c4252ba6
FEATURE: Staff should be exempt from user mention limit
2016-02-01 21:19:56 +05:30
5b9594277a
skip most post validations for staged accounts
2015-12-01 10:40:23 +01:00
7c694139ec
trust staged accounts when validating posts
2015-11-30 19:08:35 +01:00
6e33a21a7a
FIX: Replace invalid pluralizations in locale files
2015-11-13 21:25:15 +01:00
a5ee45ccbe
`PostEnqueuer` object to handle validation of enqueued posts
2015-04-15 14:54:36 -04:00
b706307ac7
FEATURE: new site setting min_first_post_length
2015-03-20 00:20:38 +05:30
59d04c0695
Internal renaming of elder,leader,regular,basic to numbers
...
Changed internals so trust levels are referred to with
TrustLevel[1], TrustLevel[2] etc.
This gives us much better flexibility naming trust levels, these names
are meant to be controlled by various communities.
2014-09-05 15:20:52 +10:00
e64d3b8a42
FIX: disagree flag should unhide hidden post
2014-08-11 10:48:00 +02:00
443caaa8f7
FIX: don't let admins skip post validations, unless it's faq, tos, or privacy
2014-08-01 14:53:35 -04:00
e1be478ef4
FIX: admins bypass some post validations. This allows them to edit legal docs even if those docs are longer than max post length, for example.
2014-07-28 16:40:14 -04:00
14ec64a36a
Give a better error message from the server if you've been replying too much.
2014-01-06 11:10:37 -05:00
0c45eba037
FIX: Users can edit posts when they've reached the `newuser_max_replies_per_topic` threshold.
2013-12-20 11:30:51 -05:00
1cac9fa257
New users can only post `newuser_max_replies_per_topic` times per topic.
2013-12-19 13:45:55 -05:00
78c15d5810
Move the unique post key storage code into the Post model
2013-09-09 16:17:31 -04:00
eae7e75611
FIX: recover post by a non-staff user fails because the post is not unique. Uniqueness check shouldn't happen when recovering a deleted post.
2013-09-06 11:50:15 -04:00
117fc8db58
Change the way nuked users' posts are handled. Allow null in the user_id column of posts. Show these posts in the posts stream.
2013-09-04 15:42:21 -04:00
2986798ba7
add newuser-max-attachments setting
2013-07-22 02:39:17 +02:00
f7de9f17d5
refactor validators
...
add a new setting for min pm body length
use that setting for flags
scale entropy check down for pms
2013-06-13 18:18:43 +10:00
3fdba0019b
Extract callbacks and validations for Post
...
Move Post create callbacks to PostCreate
Extract Post validations
Move stripped_length_validator to lib/validators
2013-06-09 20:47:04 +02:00
Sam
David Taylor
Bianca Nenciu
Jeff Wong
Robin Ward
Arpit Jalan
Neil Lalonde
Guo Xiang Tan
Guo Xiang Tan
Erick Guan
Régis Hanol
Gerhard Schlager
Navin