Bianca Nenciu
b5008586c5
DEV: Remove HTML parser from Tautologistics. ( #7344 )
2019-04-10 11:21:22 +02:00
Robin Ward
4552d86605
FIX: Broken tests
2019-04-09 08:33:10 -04:00
Arpit Jalan
55d62471a5
Fix the build
...
Skipping failing tests for now.
2019-04-09 11:30:32 +05:30
David Taylor
f524f8f811
Remove Yahoo login support from core and deprecate OpenID2.0 ( #7310 )
...
- Plugin developers using OpenID2.0 should migrate to OAuth2 or OIDC. OpenID2.0 APIs will be removed in v2.4.0
- For sites requiring Yahoo login, it can be implemented using the OpenID Connect plugin: https://meta.discourse.org/t/103632
For more information, see https://meta.discourse.org/t/113249
2019-04-08 10:38:25 +01:00
Guo Xiang Tan
33fa249fa5
SECURITY: Remove XSS in composer preview when applying image scale buttons.
2019-04-08 11:22:14 +08:00
Robin Ward
62956003c3
FEATURE: Allow users to customize bonuses for reviewable types
...
A new settings section in the review queue allows admins to specify that
certain types of flags should be weighted higher than others.
2019-04-03 11:18:34 -04:00
Guo Xiang Tan
d1fa2b71cf
FIX: Letters between words incorrectly highlighted within post.
2019-04-03 15:57:51 +08:00
Tim Lange
a9a35d2c19
FIX: Uncategorized pm not allowing edit ( #7276 )
2019-04-02 12:54:53 +08:00
Joffrey JAFFEUX
e986e96227
DEV: removes old dashboard ( #7295 )
2019-04-01 12:39:49 +02:00
Dan Ungureanu
d59abff2d8
UX: Always use relative age for post notices.
2019-03-31 18:07:05 +03:00
Bianca Nenciu
e32af7fb0f
DEV: Add test for 8aff99761a
.
2019-03-31 15:09:30 +03:00
Tim Lange
2c4b3c21a9
UX: Unified emoji escape regex
2019-03-29 12:17:11 -04:00
Guo Xiang Tan
947495e70d
Follow up to 8c2fa99f78
.
...
`/search_logs/term?term` is alittle weird looking but unless we add
proper slug support to term, we're going to have to live with this
first.
2019-03-29 10:39:44 +08:00
Guo Xiang Tan
8c2fa99f78
FIX: Remove `:term` from `admin/search_logs/term/:term` route.
...
Search log terms is a string that can contain characters like `/` which
messes with the route.
2019-03-29 09:48:20 +08:00
Guo Xiang Tan
c836d67cac
UX: Collapse advanced search on mobile when searching.
...
On smaller mobile devices, the height of the advanced search filters takes up
the whole real estate that it requires the user to scroll down
significantly in order to view the results.
2019-03-29 08:59:02 +08:00
Robin Ward
3660b85614
FIX: Regressions in JS test suite
2019-03-28 14:15:52 -04:00
Robin Ward
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
Tim Lange
1b0267b077
FIX: Switching composer action shouldn't trigger abandon popup ( #7261 )
2019-03-27 21:55:09 +01:00
Bianca Nenciu
a9798f0c47
FEATURE: Add page for all group membership requests. ( #6909 )
2019-03-27 13:30:59 +02:00
Guo Xiang Tan
e0cb2a434a
Fix regression introduced in dae0bb4c67
.
...
Add tests so it doesn't bite me again.
2019-03-26 17:52:37 +08:00
Penar Musaraj
528a7c577a
Remove flaky test
2019-03-25 15:31:25 -04:00
Penar Musaraj
e89cec7550
Fix Prettier
2019-03-25 15:03:28 -04:00
Penar Musaraj
47a0e4b906
UX: improve mobile search
...
Improves usability of header search icon while user is already in full page search in mobile.
Currently, hitting search icon a second time empties input and does not scroll up to show search form.
This commit scrolls up to show form and sets focus on input.
2019-03-25 14:42:54 -04:00
Kris
df279251b7
REFACTOR: More consistent user/group page layouts
2019-03-25 14:40:22 -04:00
Joe
ec2123809f
FEATURE: user and group cards on mobile ( #7246 )
2019-03-25 13:37:17 +01:00
Tim Lange
dcd56cf593
FIX: Fixed changing composer mode escaping title ( #7191 )
2019-03-25 13:14:26 +05:30
Tim Lange
da187f0967
FIX: Clear unsaved groups when switching user ( #7236 )
2019-03-22 12:46:36 +01:00
Joffrey JAFFEUX
eec7822d7c
DEV: warns instead of raise exception, test should fail if legit error anyways ( #7239 )
2019-03-22 09:23:20 +01:00
Guo Xiang Tan
7aab7e9062
Revert "UX: Don't reload page after saving settings when editing category."
...
This reverts commit dd142eec03
.
We need a fully reload when reordering.
2019-03-22 13:10:30 +08:00
Sam Saffron
2f8f801970
DEV: use Qunit.skip to skip a test
...
commented out code tends to get forgotten, at least with skip we can alert
on it.
2019-03-22 10:09:11 +11:00
Joffrey JAFFEUX
5b465ce053
fix tests ( #7234 )
2019-03-21 13:16:55 +01:00
Guo Xiang Tan
6cd42629e1
Fix failing qunit test.
2019-03-21 18:04:19 +08:00
Tim Lange
d16a0db4e1
UX: Enabled sorting for more columns in admin user list ( #7208 )
2019-03-21 17:16:58 +08:00
Tim Lange
f7b156ffbd
UX: Better emoji escaping for topic title ( #7218 )
...
* FIX: Fixed failing discourse-prometheus-alert-receiver plugin specs
2019-03-21 09:11:33 +01:00
Sam Saffron
5b36fadec9
DEV: correct qunit runner for autospec
...
Was no longer working on latest nodes, unlink expects a callback
Also cleans up eslint warnings.
2019-03-20 16:44:00 +11:00
Régis Hanol
6fb49e74a1
Revert "UX: Better emoji escaping for topic title ( #7176 )" ( #7201 )
...
This reverts commit 0d9bc0aaa6
.
2019-03-19 12:02:47 +01:00
Tim Lange
0d9bc0aaa6
UX: Better emoji escaping for topic title ( #7176 )
2019-03-19 09:33:10 +01:00
Guo Xiang Tan
dd142eec03
UX: Don't reload page after saving settings when editing category.
2019-03-19 16:08:32 +08:00
Gerhard Schlager
3fd04df781
FEATURE: Locale support for seeded categories and topics ( #7110 )
2019-03-18 21:09:13 +01:00
David Taylor
e2d6edd5ff
DEV: Correct email disabled banner tests
...
Followup to acc121fd27
2019-03-18 17:06:29 +00:00
Dan Ungureanu
976ea160e9
FEATURE: Post notices become old after 14 days. ( #7197 )
2019-03-18 18:20:49 +02:00
David Taylor
acc121fd27
FIX: Show 'emails disabled' to staff users when disabled for non-staff ( #7187 )
2019-03-18 16:26:18 +01:00
Tim Lange
22c75e1c04
FIX: Fixed edit category description redirecting without saving ( #7192 )
2019-03-18 16:14:17 +01:00
venarius
ad363f45f0
FIX: Fixed reorder categories by number not working correctly
2019-03-18 10:54:20 -04:00
David Taylor
4e8c174ee5
FEATURE: Display notification count in title for logged in users ( #7184 )
...
This replaces the 'contextual' counters for logged in users. We will still use the old method for anon users
2019-03-18 12:59:47 +00:00
Guo Xiang Tan
5e410dc5e0
FEATURE: Ability to exclude category from search results. ( #7194 )
...
This commit also adds `Category#search_priority` which sets the ground
work to enable prioritizing of posts for certain categories when searching.
2019-03-18 15:25:45 +08:00
Joffrey JAFFEUX
de6a7e32bd
FIX: brings back [+ New Topic] btn from share-popup post action ( #7182 )
2019-03-18 07:30:10 +01:00
Joffrey JAFFEUX
e57138354d
fix emoji tests ( #7181 )
2019-03-15 17:15:36 +01:00
Penar Musaraj
9334d2f4f7
FEATURE: add more granular user option levels for email notifications ( #7143 )
...
Migrates email user options to a new data structure, where `email_always`, `email_direct` and `email_private_messages` are replace by
* `email_messages_level`, with options: `always`, `only_when_away` and `never` (defaults to `always`)
* `email_level`, with options: `always`, `only_when_away` and `never` (defaults to `only_when_away`)
2019-03-15 10:55:11 -04:00
Bianca Nenciu
d352baa1a2
FEATURE: Enforce two-factor authentication. ( #6348 )
2019-03-15 13:09:37 +02:00
Tim Lange
37c613dde2
FIX: Outsourced erb part from emoji.js.es6 ( #7168 )
2019-03-15 15:44:49 +11:00
Dan Ungureanu
18ff790e79
FIX: Use prioritize_username_in_ux in post notices.
2019-03-13 21:17:41 +02:00
Vinoth Kannan
c773f82ba1
DEV: Added qunit test functions and did minor refactoring
...
135191d1d1
2019-03-13 18:38:27 +05:30
Joffrey JAFFEUX
d32557ea32
Revert "FIX: Better emoji escaping for topic title"
...
This reverts commit 35426b5ad6
.
2019-03-13 13:02:56 +01:00
Tim Lange
35426b5ad6
FIX: Better emoji escaping for topic title
...
This commit also puts emojiVersion in its own erb file.
2019-03-13 11:17:59 +01:00
Guo Xiang Tan
b0c8fdd7da
FIX: Properly support defaults for upload site settings.
2019-03-13 16:36:57 +08:00
Bianca Nenciu
e6c2faf186
FIX: Disable 'Create Topic' button if tag is staff-only. ( #6984 )
...
* FIX: Disable 'Create Topic' button if tag is staff-only.
* FIX: Staff-only tags should always return 404.
2019-03-12 19:23:36 +11:00
Dan Ungureanu
35942f7c7c
FEATURE: Special call-out for new / returning posters. ( #7115 )
2019-03-08 10:48:35 +02:00
Bianca Nenciu
733deba585
FIX: Loading draft also replaces the recipients ( #7122 )
2019-03-07 08:14:55 +11:00
Tarek Khalil
190b19f3c2
FEATURE: Add ignored user list to the User's preference page ( #7107 )
...
* FEATURE: Add ignored user list to the User's preference page
## Why?
Part of: https://meta.discourse.org/t/ability-to-ignore-a-user/110254
We want to add list of Ignored users under or along with the muted users preferences section.
This way Users can find and update their list of ignored users.
## UI
![gif](https://user-images.githubusercontent.com/45508821/53746179-8e9b3c00-3e98-11e9-9e90-94b8520896a6.gif )
## Open questions
Two of many options to represent a list of ignored users is that we can:
1. We can represent the ignored user list as a table with the ability to `un-ignore` but NOT to add new ignored users.
2. We can keep it functioning as the `muted user list` where you can `un-ignore` or `ignore` users.
2019-03-05 14:47:51 +00:00
Joffrey JAFFEUX
aaf106fc2d
DEV: simplify test to avoid time related failures ( #7092 )
2019-03-03 12:13:02 +01:00
Sam
03a70ef69c
FIX: allow underscore and dash in username search
...
_ and - are technically punctuations, but we allow them in usernames so
accept them in search
2019-03-01 15:23:45 +11:00
Sam
63cba2055f
DEV: workaround test value changing due time marching forward
...
This is a quick fix to get the tests to pass we will follow up with a commit
to stabalize this.
2019-03-01 13:26:36 +11:00
Joffrey JAFFEUX
883a18547e
FIX: shows invite panel on mobile from topic footer buttons ( #7080 )
2019-02-28 14:56:22 +01:00
Régis Hanol
6b006c383b
FIX: polls acceptance tests
2019-02-27 19:16:24 +01:00
Maja Komel
7d2ea2d4dd
FEATURE: image resizing discoverability ( #6804 )
2019-02-27 11:46:16 +01:00
Erick Guan
e1d1073273
FIX: use * when apply italics in the editor instead of _ ( #7063 )
2019-02-27 10:36:14 +01:00
Vinoth Kannan
59c66fd226
REFACTOR: Improve the readability of code ( #7076 )
2019-02-26 23:03:49 +05:30
Joffrey JAFFEUX
8c706b0ff7
fix tests ( #7073 )
2019-02-26 16:49:29 +01:00
Joffrey JAFFEUX
d04c4bf8e7
UX: puts back share-panel as floating pane on post actions ( #7066 )
2019-02-26 14:15:25 +01:00
Arpit Jalan
6ea9f5c9c5
FIX: do not update tag name on /tags/intersection
2019-02-26 16:43:39 +05:30
Joffrey JAFFEUX
71360436ff
FIX: users list show was loading multiple times with different params ( #7058 )
...
A first load was happening in route, which was setting properties on controller. These properties were observed on the controller and were triggering a reload of the AdminUser model.
Not only was it doing loading two times it was also sometimes resulting on the controller model refresh end to happen after route has been changed, resulting in a wrong model.
2019-02-26 10:43:24 +01:00
Vinoth Kannan
ed0120171c
FIX: Hide 'show associated accounts' button if moderators can't see emails
...
And minor prettier code alignments
2019-02-26 13:49:27 +05:30
Joffrey JAFFEUX
5952a6c0ad
DEV: uses find() helper instead of this.$() in js tests ( #7062 )
2019-02-25 16:04:55 +01:00
Joffrey JAFFEUX
919839fd97
FIX: allows {{d-button}} to set a form attribute ( #7056 )
...
This attribute is used when a submit button is out of a form. It makes it explicit which form this button is submitting.
It's currently used in our login modal form.
2019-02-25 09:49:49 +01:00
Joffrey JAFFEUX
70aec8d02a
simpler post-date test to avoid tz differences ( #7050 )
2019-02-21 14:39:51 +01:00
Joffrey JAFFEUX
81c31b331d
DEV: adds tests to verify post date sharing modal behaviour ( #7049 )
2019-02-21 14:04:56 +01:00
Guo Xiang Tan
46e62c0d22
UX: Default user facing routes to `/g` instead of `/groups`. ( #7042 )
2019-02-21 13:44:25 +08:00
Sam
07b856700d
REFACTOR: remove disallowEmails option from user-selector
...
Negative option was leading to a fair amount of confusion, going forward
if we want to allow selection of emails from user selector it must be
supplied with `allowEmails=true`
This corrects a regression in 1f4ace4f
which broke invite by emails and
start PM to email
2019-02-21 16:37:26 +11:00
Guo Xiang Tan
58b0e945bd
UX: Lightbox support for image uploader. ( #7034 )
2019-02-21 10:13:37 +08:00
Penar Musaraj
3cb676bf42
Fix Prettier offense
2019-02-20 17:07:32 -05:00
Penar Musaraj
cc1f9e7be6
Fix share button in post menu
2019-02-20 16:27:59 -05:00
Penar Musaraj
bbd00a3488
Fix desktop test too
2019-02-20 16:08:36 -05:00
Joffrey JAFFEUX
b7953af5a1
fix tests ( #7040 )
2019-02-20 21:41:03 +01:00
Joffrey JAFFEUX
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together ( #7021 )
...
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
2019-02-20 15:42:44 +01:00
Guo Xiang Tan
31ffa5f64e
UX: Allow users to see filename in image-uploader component. ( #7022 )
...
https://meta.discourse.org/t/downsides-of-the-new-logo-ui-in-site-settings/102247/23?u=tgxworld
2019-02-20 13:55:55 +08:00
Sam
fa35b555b7
Correct failing test
...
WARNING: forEach is a trap when async is involved cause it leaks promises
for X of Y is a very clean workaround that keeps the code ver readable
2019-02-20 16:15:10 +11:00
Sam
1f4ace4f56
FEATURE: autocomplete usernames early in topic based on participation
...
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic
This is somewhat experimental, we may tweak this, or make it optional.
Also, a regression in a423a938
where hitting TAB would eat a post you were writing:
Eg this would eat a post:
``` text
@hello, testing 123 <tab>
```
2019-02-20 13:34:43 +11:00
Dan Ungureanu
a423a9383f
FIX: Stop autocomplete for invalid usernames. ( #7005 )
2019-02-15 11:29:26 +11:00
Régis Hanol
b8b1759de9
UX: show envelope when tag is only used in PM
...
UX: use regular envelope instead of solid envelope
REFACTOR: %s/enveloppe/envelope/g
2019-02-12 11:34:25 +01:00
Penar Musaraj
c50db76f5d
FIX: do not treat TIFF, BMP, WEBP as images
...
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.
You can still upload these files they will simply not be displayed in IMG tags.
2019-02-11 16:28:43 +11:00
David Taylor
95eb4c67f2
FIX: Allow reverting theme/text settings from cookie back to default
2019-02-08 15:39:44 +00:00
Joffrey JAFFEUX
6c195640b9
FEATURE: adds an API to register topic footer buttons
2019-02-07 14:43:33 +01:00
Dan Ungureanu
6c2fe7eaec
DEV: Fix lint.
2019-02-06 23:55:05 +02:00
Dan Ungureanu
fc4c015bee
FEATURE: Shortcut 'g s' goes to first suggested topic
2019-02-07 08:43:07 +11:00
Bianca Nenciu
e0e91fad87
FIX: Fix delete button for Tag Groups. ( #6965 )
2019-02-04 12:46:39 +01:00
David Taylor
5c9426be48
SECURITY: Escape HTML in dashboard report tables
2019-02-01 13:10:59 +00:00
Penar Musaraj
ee437ef53b
Fix prettier offence
2019-01-28 22:47:11 -05:00
Penar Musaraj
530eeba855
Add test for user drafts stream
...
Followup to 84a3da4b18
2019-01-28 22:30:01 -05:00
David Taylor
aca0b32fda
FEATURE: Allow overriding text size from a different device ( #6955 )
...
This brings the feature in line with the theme selection system
2019-01-28 11:19:50 +00:00
Vinoth Kannan
7e4edcfae8
FIX: Convert lightbox html into proper image markdown
2019-01-27 01:21:56 +05:30
David Taylor
d338e54f59
FEATURE: Allow setting font size per-device using a cookie ( #6947 )
2019-01-25 15:06:06 +00:00
David Taylor
a48731e359
FEATURE: Support additional metadata in theme about.json ( #6944 )
...
New `about.json` fields (all optional):
- `authors`: An arbitrary string describing the theme authors
- `theme_version`: An arbitrary string describing the theme version
- `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
- `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
A localized description for a theme can be provided in the language files under the `theme_metadata.description` key
The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
2019-01-25 14:19:01 +00:00
David Taylor
337545f4f6
DEV: Restore skipped JS test
...
This works for me locally, so the issue has likely been fixed since the test was skipped
2019-01-24 16:58:23 +00:00
Bianca Nenciu
d589c66f3e
FIX: Fix URL to user profile. ( #6881 )
2019-01-23 18:27:21 +01:00
David Taylor
2e59a37687
FEATURE: List unused theme components ( #6924 )
2019-01-23 09:20:13 +00:00
Penar Musaraj
9886934ef5
DEV: fix some deprecated SVG icon refs
2019-01-22 14:42:00 -05:00
Robin Ward
a834245683
FIX: Keep tags when switching to shared draft
2019-01-22 11:26:52 -05:00
Joffrey JAFFEUX
80d42b4ea2
icons deprecations fixes ( #6920 )
2019-01-22 12:02:02 +01:00
Joffrey JAFFEUX
1ac4dc5b73
FIX: makes whisper state more resilient ( #6889 )
...
This commit also moves some logic from model to controller.
2019-01-16 15:23:06 +01:00
Guo Xiang Tan
0b47ef6e86
Fix the build.
...
Ideally, I'll like to test with a different user but that is proving to
be a huge challenge in our acceptance test.
2019-01-16 16:34:48 +08:00
Guo Xiang Tan
f8db93df5f
FIX: Consolidated like notifications links to wrong user on user page.
2019-01-16 15:55:18 +08:00
Guo Xiang Tan
ed2be6a3c8
DEV: Make prettier happy.
2019-01-16 10:58:11 +08:00
Guo Xiang Tan
ebe65577ed
FEATURE: Consolidate likes notifications. ( #6879 )
2019-01-16 10:40:16 +08:00
Arpit Jalan
690022678c
DEV: update about.json fixtures
2019-01-15 19:23:43 +05:30
Arpit Jalan
93e9ffd942
fix the build
2019-01-15 18:10:45 +05:30
Arpit Jalan
c4422fdc13
UX: sort admins and moderators by last seen date on /about page
...
UX: only show active admins and moderators on /about page
2019-01-15 17:26:11 +05:30
Robin Ward
f75915efa4
FIX: `expandAllPinned` was not resetting after visiting a category
...
This resulted in a bug where if you saw a pinned topic in a category,
then went back to latest, the same topic would show an excerpt even
though it shouldn't on the latest view.
See:
https://meta.discourse.org/t/pinned-post-excerpt-no-longer-appears-after-refreshing-the-page/106222
2019-01-14 13:02:25 -05:00
David Taylor
49593d1a00
FIX: Fix registration dialog popup for 'full screen' social logins
...
Regression following the ember3 upgrade. In addition to fixing, this commit consolidates our social registration logic into one place, and adds tests for the behaviour.
2019-01-12 12:08:13 +00:00
Joffrey JAFFEUX
1a3655b787
DEV: s/Em/Ember ( #6874 )
2019-01-11 17:54:23 +01:00
Guo Xiang Tan
0fa92699e2
UX: Don't save automatically when resetting site settings in admin page.
2019-01-11 16:39:21 +08:00
Guo Xiang Tan
656d82665d
Fix the build.
...
Follow up to 2956c52e57
.
2019-01-11 16:00:41 +08:00
Vinoth Kannan
a8ff4a8a78
UX: search all categories even if category-chooser is scoped to particular category
2019-01-10 21:19:53 +05:30
Joffrey JAFFEUX
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 ( #6808 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 11:06:01 +01:00
Zach Whitehead
2748822576
FEATURE: Remove option for Google Plus sharing ( #6864 )
...
* Remove option for Google Plus sharing
* remove google+ share translations
2019-01-09 10:17:50 +08:00
Gerhard Schlager
dc477d1228
FIX: "Toggle topic bump" wasn't visible for TL4 users
2019-01-02 20:16:55 +01:00
Arpit Jalan
70fdc10365
FEATURE: move posts to new/existing PM ( #6802 )
2018-12-31 17:17:22 +05:30
Joffrey JAFFEUX
f1269fa807
FEATURE: Add `Top Uploads` report ( #6825 )
...
Co-Authored-By: I am very Pro-Grammer. <khalilovcmded@users.noreply.github.com>
2018-12-28 20:48:54 +01:00
Vinoth Kannan
2076f371b3
FIX: Hashtags should work for non-english characters
2018-12-26 22:12:40 +05:30
Joffrey JAFFEUX
0402f0f357
UX: new site setting to define activity metrics displayed on dashboard
2018-12-26 10:29:07 +01:00
Vinoth Kannan
b3df4bee9c
FIX: Hide group membership request button for existing members
2018-12-24 13:49:05 +05:30
Joffrey JAFFEUX
e655e1863f
UX: Adding reports dashboard tab, new layout, report descriptions ( #6790 )
...
Co-Authored-By: Kris <shout@k-ris.com>
2018-12-19 14:44:43 +01:00
Bianca Nenciu
7050ce4638
FIX: Bypass draft check when switching to shared draft. ( #6782 )
2018-12-19 10:25:33 +01:00
Bianca Nenciu
f0027961c7
FIX: Properly reset controller of admin-user-index. ( #6760 )
2018-12-17 15:28:29 +01:00
Gerhard Schlager
1a8ca68ea3
FEATURE: Improve backup stats on admin dashboard
...
* Dashboard doesn't timeout anymore when Amazon S3 is used for backups
* Storage stats are now a proper report with the same caching rules
* Changing the backup_location, s3_backup_bucket or creating and deleting backups removes the report from the cache
* It shows the number of backups and the backup location
* It shows the used space for the correct backup location instead of always showing used space on local storage
* It shows the date of the last backup as relative date
2018-12-17 11:35:11 +01:00
Kyle Zhao
c9279a118e
FIX: always show filtered site settings
2018-12-13 13:00:13 +11:00
Joffrey JAFFEUX
3a799ed922
FEATURE: Check if draft exists before starting a new one ( #6755 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: zogstrip <regis@hanol.fr>
2018-12-12 10:21:51 +01:00
David Taylor
414aa1fe7a
DEV: Correct qunit test description
2018-12-10 15:44:05 +00:00
David Taylor
071bd15463
FIX: Redirect to default homepage when visiting `/login`
...
Previously this was hard-coded to redirect to `/latest`
2018-12-10 15:39:05 +00:00
Joffrey JAFFEUX
e06a8980fb
FIX: category-drop initial state was incorrect ( #6743 )
2018-12-10 14:05:00 +01:00
Penar Musaraj
67450ba402
UX: when composer is minimized, let user open composer in regular size instead of full screen
2018-12-07 17:45:13 -05:00
Bianca Nenciu
79d987e483
FEATURE: Show autocomplete when enable_inline_emoji_translation is true.
2018-12-05 21:58:55 +01:00
Bianca Nenciu
e9bbdef156
FEATURE: Add support for inline emoji translation.
2018-12-05 21:58:55 +01:00
Bianca Nenciu
b585f7f336
DEV: Apply code review.
2018-12-05 21:56:18 +01:00
David Taylor
404acef6e3
DEV: Move `run-qunit.js` out of the vendor directory
2018-12-03 16:16:37 +00:00
Penar Musaraj
923692d45a
FIX: tooltip regression in admin dashboard
...
- adds registerHoverTooltip in tooltip qunit test
2018-12-03 11:15:31 -05:00
Maja Komel
142361d6da
FIX: don't steal focus when text in editor is replaced ( #6712 )
2018-12-03 09:49:17 +01:00
Joffrey JAFFEUX
4f24d7dec8
FIX: more resilient whisper state between composer states ( #6687 )
2018-11-29 16:16:34 +01:00
Joffrey JAFFEUX
8da8f5d0f7
FIX: call onSelect plugin callbacks for noop rows ( #6682 )
2018-11-29 15:56:19 +01:00
Joffrey JAFFEUX
4c7dfed32e
FIX: error with tags enabled and no tags created ( #6701 )
2018-11-29 10:39:09 +01:00
Guo Xiang Tan
ceaf234f89
DEV: Add tests for c92c56d986
.
2018-11-29 13:51:31 +08:00
Maja Komel
a2bff038e8
FIX: set overridden param for customize site text query only when checkbox value changes
2018-11-27 14:29:48 +01:00
Guo Xiang Tan
a1e77aa2ed
FEATURE: Reimplement `SiteSetting.max_oneboxes_per_post`. ( #6668 )
...
Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
2018-11-27 16:00:31 +08:00
Bianca Nenciu
92af202d29
DEV: Add test for edit conflicts.
2018-11-27 13:07:45 +11:00
Dan Ungureanu
147c6b1e8a
DEV: Fix tests.
2018-11-27 13:05:27 +11:00
Penar Musaraj
03deda2147
Upgrade to FontAwesome 5 (take two) ( #6673 )
...
* Add missing icons to set
* Revert FA5 revert
This reverts commit 42572ff
* use new SVG syntax in locales
* Noscript page changes (remove login button, center "powered by" footer text)
* Cast wider net for SVG icons in settings
- include any _icon setting for SVG registry (offers better support for plugin settings)
- let themes store multiple pipe-delimited icons in a setting
- also replaces broken onebox image icon with SVG reference in cooked post processor
* interpolate icons in locales
* Fix composer whisper icon alignment
* Add support for stacked icons
* SECURITY: enforce hostname to match discourse hostname
This ensures that the hostname rails uses for various helpers always matches
the Discourse hostname
* load SVG sprite with pre-initializers
* FIX: enable caching on SVG sprites
* PERF: use JSONP for SVG sprites so they are served from CDN
This avoids needing to deal with CORS for loading of the SVG
Note, added the svg- prefix to the filename so we can quickly tell in
dev tools what the file is
* Add missing SVG sprite JSONP script to CSP
* Upgrade to FA 5.5.0
* Add support for all FA4.7 icons
- adds complete frontend and backend for renamed FA4.7 icons
- improves performance of SvgSprite.bundle and SvgSprite.all_icons
* Fix group avatar flair preview
- adds an endpoint at /svg-sprites/search/:keyword
- adds frontend ajax call that pulls icon in avatar flair preview even when it is not in subset
* Remove FA 4.7 font files
2018-11-26 16:49:57 -05:00
Joffrey JAFFEUX
3453707784
FEATURE: allows html tooltips ( #6665 )
2018-11-26 11:15:23 +01:00
Guo Xiang Tan
57e2f4990d
PERF: Move processing of inline onebox out of V8 context. ( #6658 )
2018-11-26 09:21:38 +08:00
Vinoth Kannan
06b3621e80
Revert "DEV: Use equal method instead of deepEqual"
...
This reverts commit 5969a31d73
.
2018-11-23 04:08:51 +05:30
Vinoth Kannan
5969a31d73
DEV: Use equal method instead of deepEqual
2018-11-23 01:53:13 +05:30
David Taylor
f645cb9c14
FEATURE: Use translated name for 'your email has been authenticated by' ( #6649 )
2018-11-22 19:12:04 +00:00
Vinoth Kannan
036790d13c
FIX: Assign default value for category.findByIds method
2018-11-22 12:51:04 +05:30
Guo Xiang Tan
c5a70eca6e
PERF: Move mention lookups out of the V8 context. ( #6640 )
...
We were looking up each mention one by one without any form of caching and that results
in a problem somewhat similar to an N+1. When we have to do alot of DB
lookups, it also increased the time spent in the V8 context which may
eventually lead to a timeout. The change here makes it such that mention lookups only does a single
DB query per post that happens outside of the V8 context.
2018-11-22 14:28:48 +08:00
Joffrey JAFFEUX
58c795ef30
DEV: adds test for image-short-url ( #6642 )
2018-11-22 07:48:52 +11:00
Joffrey JAFFEUX
9672c92045
DEV: removes _.each from codebase ( #6629 )
2018-11-20 14:46:58 +01:00
Joffrey JAFFEUX
c4ed353fae
DEV: removes _.map from codebase ( #6616 )
2018-11-19 10:46:46 +01:00
Bianca Nenciu
f2c227432c
FIX: Do not show nested user cards. ( #6621 )
2018-11-19 10:01:22 +01:00
Joffrey JAFFEUX
9911a41f4c
FIX: improves category/tag drops header shortcuts ( #6610 )
...
- wont appear when filtering
- can now be selected with keyboard
- fix bugs on click with safari/firefox
2018-11-15 15:21:40 +01:00
Guo Xiang Tan
44391ee8ab
FEATURE: Upload Site Settings. ( #6573 )
2018-11-14 15:03:02 +08:00
Joffrey JAFFEUX
7fa21ce199
UX: minor tweaks to theme components selection UI ( #6596 )
2018-11-13 14:57:50 +01:00
Joffrey JAFFEUX
9c616e0679
FIX: handles not found reports in bulk loading ( #6582 )
2018-11-12 13:47:24 +01:00
Guo Xiang Tan
c7377e2f2d
UX: Trash icon displaying when there is no upload take 2.
2018-11-12 16:19:17 +08:00
Guo Xiang Tan
10c6211cdf
UX: Trash icon displaying when there is no upload.
2018-11-12 16:06:32 +08:00
Guo Xiang Tan
12da912c73
DEV: Avoid Discourse specific code in fixtures.
2018-11-09 17:15:37 +08:00
Guo Xiang Tan
7a53e0b186
DEV: Remove fields from fixtures that are no longer valid.
2018-11-09 13:52:40 +08:00
Sam
42572ff138
Revert font awesome 5 changes
...
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
2018-11-08 16:12:18 +11:00
Penar Musaraj
09dc922b3b
Fix several FontAwesome 5 issues
...
add missing icons, update SvgSprite methods (to fix ruby 2.4 issues), update whisper icon in composer, fix alignment issues
2018-11-07 22:20:53 -05:00
Penar Musaraj
005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs ( #6557 )
...
* First take on subsetting svg icons
* FontAwesome 5 svg subset WIP
* Include icons from plugins/badges into svg sprite subset
* add svg icon support to themes
* Add spec for SvgSprite
* Misc. SVG icon fixes
* Use FA5 svgs in local-dates plugin
* CSS adjustments, fix SVG icons in group flair
* Use SVG icons in poll plugin
* Add SVG icons to /wizard
2018-11-07 13:05:43 -05:00
Jeff Atwood
afbdf9c2d2
Merge pull request #6558 from pmusaraj/disallow-flagging-deleted-post
...
FIX: disable flagging hidden posts
2018-11-05 11:05:32 -08:00
Maja Komel
ae9eddb002
FIX: don't allow adding a value containing vertical bar char to the secret list
2018-11-05 12:14:56 +01:00
Penar Musaraj
94f628fb4c
FIX: disable flagging hidden posts
2018-11-02 13:54:45 -04:00
Joffrey JAFFEUX
398f98c568
FIX: ensures reports links are correct on subfolder installs
2018-10-26 12:32:02 +02:00
Bianca Nenciu
2a77550f8c
FIX: Do not track right clicks. ( #6530 )
2018-10-25 09:46:04 +00:00
Jeff Wong
0ead513fb0
PERF: remove total unread notifications from message bus ( #6529 )
2018-10-25 12:14:34 +11:00
Matthew Campbell
05438d99a8
FIX: Ensure the like button always has a title, for accessibility ( #6525 )
...
The like button previously didn't have a title for anonymous users,
because the `canToggleLike` flag wasn't set, but the `liked` flag wasn't
set either. This made the button inaccessible to blind users.
2018-10-24 13:58:42 +00:00
David Taylor
37b7afa522
FIX: Sanitize tags before creation
2018-10-22 10:53:42 +01:00
David Taylor
0dd717e641
Revert "FIX: Sanitize tags before creation"
...
This reverts commit 18ae8de9e5
.
2018-10-19 15:49:05 +01:00
David Taylor
18ae8de9e5
FIX: Sanitize tags before creation
2018-10-19 15:43:31 +01:00
Bianca Nenciu
22ada32d4d
FIX: Strip @ when searching for users and groups. ( #6506 )
2018-10-19 11:56:10 +11:00
Guo Xiang Tan
287e780f22
DEV: Skip tests instead of commenting out.
2018-10-18 11:06:03 +08:00
Bianca Nenciu
69dbd9b069
DEV: Comment test causing issues.
2018-10-17 20:29:21 +03:00
Bianca Nenciu
21d804fc92
DEV: Fix build. ( #6500 )
2018-10-17 17:39:25 +02:00
Bianca Nenciu
f60b10d090
UX: Warn users if the post that's currently edited has changed. ( #6498 )
2018-10-17 15:35:32 +02:00
Maja Komel
27e732a58d
FEATURE: allow multiple secrets for Discourse SSO provider
...
This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site.
This allows for better auditing of the SSO provider feature
2018-10-15 16:03:53 +11:00
Maja Komel
57b52cd1de
FIX: keep emoji syntax for custom emojis in quotes ( #6488 )
2018-10-15 10:57:15 +08:00
Guo Xiang Tan
84d4c81a26
FEATURE: Support backup uploads/downloads directly to/from S3.
...
This reverts commit 3c59106bac
.
2018-10-15 09:43:31 +08:00
Bianca Nenciu
ded5ff90aa
FIX: Groups list does not refresh when query changes. ( #6481 )
2018-10-11 21:20:17 +08:00
Bianca Nenciu
6275e745a7
FIX: Fix open quote links in new window. ( #6477 )
2018-10-11 15:51:14 +08:00
Guo Xiang Tan
3c59106bac
Revert "FEATURE: Support backup uploads/downloads directly to/from S3."
...
This reverts commit c29a4dddc1
.
We're doing a beta bump soon so un-revert this after that is done.
2018-10-11 11:08:23 +08:00
Gerhard Schlager
c29a4dddc1
FEATURE: Support backup uploads/downloads directly to/from S3.
2018-10-11 10:38:43 +08:00
Bianca Nenciu
1d26a473e7
FEATURE: Show "Recently used devices" in user preferences ( #6335 )
...
* FEATURE: Added MaxMindDb to resolve IP information.
* FEATURE: Added browser detection based on user agent.
* FEATURE: Added recently used devices in user preferences.
* DEV: Added acceptance test for recently used devices.
* UX: Do not show 'Show more' button if there aren't more tokens.
* DEV: Fix unit tests.
* DEV: Make changes after code review.
* Add more detailed unit tests.
* Improve logging messages.
* Minor coding style fixes.
* DEV: Use DropdownSelectBoxComponent and run Prettier.
* DEV: Fix unit tests.
2018-10-09 22:21:41 +08:00
Guo Xiang Tan
43512e9865
Merge pull request #6457 from pmusaraj/yarn-manage-test-vendor-dependencies
...
DEV: Use Yarn managed test vendor dependencies
2018-10-08 09:26:26 +08:00
David Taylor
75488257c5
FIX: Redirect users to top when `latest` is the homepage
2018-10-05 12:14:57 +01:00
David Taylor
9bf522f227
FEATURE: Mixed case tagging ( #6454 )
...
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.
- If force_lowercase_tags is disabled, then mixed case tags are allowed.
- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.
- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.
- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.
- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
2018-10-05 10:23:52 +01:00
David Taylor
9554d657c5
DEV: Remove underscore from tags-test
2018-10-04 21:14:52 +01:00
Penar Musaraj
4ae9cb28e4
remove probes.js, highlight.pack.js
2018-10-04 13:50:54 -04:00
Penar Musaraj
cd82107976
use yarn to manage test vendor dependencies, upgrade sinon to v6.3.5
2018-10-04 11:06:14 -04:00
David Taylor
3c2608d41c
FIX: Correctly censor strings starting or ending with non-word characters ( #6445 )
2018-10-04 15:15:10 +01:00
Bianca Nenciu
6ad13e5ae9
FIX: Avoid redirection when not leaving forum. ( #6419 )
...
* FIX: Avoid redirection when not leaving forum.
* DEV: Updated click-track's tests.
2018-10-04 22:06:31 +08:00
Sam
41eacd859e
temporarily comment out test
2018-10-03 14:07:30 +10:00
Maja Komel
73443d889c
FIX: keep files in order when adding multiple uploads ( #6306 )
...
* FIX: keep files in order when adding multiple uploads
* use filename in the placeholder when uploading files
* add tests
* add consecutive nr to the placeholder when multiple uploads with the same filename
2018-10-03 11:12:36 +10:00
Kris
cb519a3bec
Fix test
2018-10-02 15:20:11 -04:00
Bianca Nenciu
719a433c03
FIX: Sync client & server rules regarding tag names. ( #6400 )
2018-10-01 21:45:44 -07:00
Kyle Zhao
4b517d460d
FIX: dashboard test depended on the last month has 31 days
2018-10-01 12:31:27 +08:00
Kyle Zhao
373d6e3fe6
always `loadScript` with a script tag ( #6411 )
...
to avoid Content Security Policy unsafe-line violations
2018-10-01 10:06:01 +08:00
Joffrey JAFFEUX
a713c0d366
FIX: ensures onSelect/onDeselect are called
...
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
Joffrey JAFFEUX
2ff2c49908
Revert "FIX: ensures onSelect/onDeselect are called"
...
This reverts commit 52eed73294
.
2018-09-17 22:14:41 +02:00
Joffrey JAFFEUX
52eed73294
FIX: ensures onSelect/onDeselect are called
2018-09-17 10:36:14 +02:00
Sam
e15a1e7c38
lint code
2018-09-17 11:10:09 +10:00
pmusaraj
03edb31a4d
add tag-drop component test
2018-09-17 10:40:47 +10:00
Sam
bc4e2aa07c
correct prettier offence
2018-09-17 10:30:36 +10:00
Bianca Nenciu
8f39cf6bfc
FIX: Permit unpinning an unlisted topic.
2018-09-17 10:03:06 +10:00
OsamaSayegh
ca28548762
feedback (see commit description for details)
...
* fill blank space when no theme is selected
* animate row's height in themes/components list when selecting, and hide children list
* show warning when you move to a different page and have unsaved changes
* refactor `adminCustomizeThemes.show` controller
* allow collapsing/expanding children lists
* fix a bug when adding components to a theme (changed the way it works slightly)
* a bunch of other minor things
2018-09-17 09:49:53 +10:00
OsamaSayegh
a4f057a589
UX: improvements to admin theme UI
2018-09-17 09:49:53 +10:00
Joffrey JAFFEUX
754d5b62a8
makes mini-tag-chooser test use can_create_tag ( #6402 )
2018-09-14 13:30:55 +02:00
Joffrey JAFFEUX
d2ea618af1
adds a test for mini-tag-chooser
2018-09-14 12:13:00 +02:00
Joffrey JAFFEUX
38668818a5
FIX: allows forcing unsafe string in select-kit ( #6386 )
...
forceEscape will be defaulted to true before next release.
2018-09-12 12:19:04 +02:00
Guo Xiang Tan
a033327b93
Manage qunit via yarn.
2018-09-11 15:07:28 +08:00
Guo Xiang Tan
4ee8e77073
Apply prettier.
2018-09-11 09:16:03 +08:00
Guo Xiang Tan
d788555994
DEV: Manage pretender with yarn.
2018-09-07 16:01:49 +08:00
Guo Xiang Tan
039afe0d2c
Apply prettier.
2018-09-07 15:19:34 +08:00
Joffrey JAFFEUX
6c1e70d554
FIX: do no reset tags selection on category selection ( #6369 )
...
We will instead implement a server side solution to this in the future.
2018-09-06 10:35:07 +02:00
Joffrey JAFFEUX
17087eff2a
FIX: Reset tags on category change ( #6363 )
2018-09-05 17:18:52 +02:00
Sam
fcae21c4fc
remove test that is no longer relevant
2018-09-04 10:52:12 +10:00
Sam
3748d3e281
UX: hide associate accounts if second factor is enabled
...
Once second factor is enabled all login via associated accounts is banned
showing this section just leads to confusion
2018-09-04 10:42:39 +10:00
Bianca Nenciu
f5e0356fb2
correct miscellaneous issues with user login history
2018-09-02 17:24:54 +10:00
Gerhard Schlager
16974df1e9
FIX: Resetting site setting didn't remove "overriden" state
2018-09-01 02:09:23 +02:00
Joffrey JAFFEUX
ceae3d0a93
fix js tests ( #6343 )
2018-08-30 15:09:08 +02:00
Guo Xiang Tan
f39c38d281
DEV: Support stable branch tests for `discourse-spoiler`.
2018-08-30 17:20:42 +08:00
Guo Xiang Tan
0f812aa768
Make prettier happy.
2018-08-30 15:56:30 +08:00
Vinoth Kannan
092fb0c170
Merge pull request #6333 from vinothkannans/rich-text-pasting
...
FIX: Use tight list format for GDocs html to markdown
2018-08-30 12:14:50 +05:30
Bianca Nenciu
c1a5a7504e
FIX: Reset email preferences controller. ( #6316 )
2018-08-29 23:10:56 +02:00
Vinoth Kannan
4c99acea1b
FIX: Use tight list format for GDocs html to markdown
2018-08-29 16:21:31 +00:00
Kris
afec673c2b
Fixing test
2018-08-29 11:44:04 -04:00
Vinoth Kannan
26f17150e1
Merge pull request #6327 from vinothkannans/rich-text-pasting
...
FIX: Keep emojis and remove clicks count on html to markdown
2018-08-29 13:38:55 +05:30
Vinoth Kannan
fb35b0b3c3
FIX: Keep emojis and remove clicks count
2018-08-29 07:26:25 +00:00
Sam
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
Kris
faf09bb8c8
Replacing default brown category color
2018-08-24 14:18:14 -04:00
Joffrey JAFFEUX
82dcc5cbfa
FEATURE: makes reports loadable in bulk ( #6309 )
2018-08-24 15:28:01 +02:00
Osama Sayegh
e0cc29d658
FEATURE: themes and components split
...
* FEATURE: themes and components split
* two seperate methods to switch theme type
* use strict equality operator
2018-08-24 11:30:00 +10:00
Arpit Jalan
7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
...
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
Arpit Jalan
1a7cd6648b
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
Joffrey JAFFEUX
07e11a223c
FIX: prefills username for new message on first post ( #6305 )
2018-08-23 11:09:35 +02:00
Guo Xiang Tan
bd66fbef7f
FIX: Post time query filter not set correctly when loaded from params.
...
https://meta.discourse.org/t/before-and-after-are-not-implemented-right-in-search/92515
2018-08-23 14:06:28 +08:00
James Kiesel
b2ce33be26
FIX: tag intersection not populating ( #6296 )
...
* Fix for tag intersection not populating
* Fix prettier
* Add acceptance test for tags intersection
2018-08-23 14:22:47 +10:00
Joffrey JAFFEUX
87d443f070
FIX: counters were showing future instead of past ( #6299 )
2018-08-22 12:37:05 +02:00
Joffrey JAFFEUX
599cebf8ad
FIX: better message if request for report is rate limited ( #6298 )
2018-08-22 11:25:12 +02:00
Sam
5d96809abd
FIX: improve support for subfolder S3 CDN
2018-08-22 12:31:13 +10:00
Guo Xiang Tan
de2243319e
Fix the build.
2018-08-20 16:25:59 +08:00
Guo Xiang Tan
658b55c406
FIX: Search does not retrigger when context has changed. Take 2.
...
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-20 15:46:02 +08:00
Guo Xiang Tan
9c3ba98ef1
FIX: User can't save gravatar as profile picture after refresh.
...
https://meta.discourse.org/t/gravatar-issue-cant-save-changes/95076
2018-08-20 10:29:50 +08:00
Joffrey JAFFEUX
37d4f27c44
FIX: quality/bugfix dashboard/reports pass ( #6283 )
2018-08-17 16:19:25 +02:00
Joffrey JAFFEUX
edf26a0931
uses emoji version for tests ( #6277 )
2018-08-16 14:06:56 +02:00
Gerhard Schlager
448e95b97d
UX: Show anchor icon instead of text when topic bump is disabled
2018-08-11 21:51:13 +02:00
Gerhard Schlager
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
Neil Lalonde
f7b4a2b3ba
FIX: ensure URLs include subfolder in admin emails UI
2018-08-08 16:48:03 -04:00
Joffrey JAFFEUX
7f2f3b8b22
FIX: improves reports resilience ( #6239 )
...
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
Joffrey JAFFEUX
c301111461
FIX: display select kit body if no choices ( #6237 )
2018-08-06 11:22:48 -04:00
David Taylor
812add18bd
REFACTOR: Serve auth provider information in the site serializer.
...
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
Joffrey JAFFEUX
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
Joffrey JAFFEUX
9073e11943
FIX: improves number/percent support in reports
2018-08-01 18:40:59 -04:00
Penar Musaraj
1f45215537
FEATURE: Drafts view in user profile
...
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Guo Xiang Tan
b6939093eb
Fix JS tests.
2018-08-01 11:21:46 +08:00
Joffrey JAFFEUX
2b2a506a7b
FIX: makes dashboard more resilient to errors ( #6217 )
...
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX
0715aa18da
UI: uses tiny avatars for reports ( #6215 )
2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX
37252c1a5e
UI: improves dashboard table reports
...
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
Vinoth Kannan
ece3cb73df
Rename humburger_menu_categories_count site setting to header_dropdown_category_count
2018-07-31 09:12:30 +05:30
Vinoth Kannan
b852275ced
Test method for site categories random order fix
2018-07-31 01:36:37 +05:30
Vinoth Kannan
c54b5824d4
REFACTOR: Prioritize unread categories in hamburger menu
2018-07-30 20:20:10 +05:30
Maja Komel
c7c84606d9
fix prettier offense
2018-07-30 12:43:10 +02:00
Maja Komel
04baddf731
DEV: migrate tests to async/await
2018-07-30 12:21:05 +02:00
Vinoth Kannan
249b16e8e3
FIX: Hide muted categories from hamburger menu top categories block
2018-07-30 15:37:41 +05:30
Vinoth Kannan
78d91b1daf
UX: Changes in top categories of hamburger menu ( #6200 )
2018-07-30 14:13:00 +05:30
Arpit Jalan
fc3b904e1f
remove "track external right clicks" feature
2018-07-29 15:01:33 +05:30
Vinoth Kannan
dac29b5ebc
UX: Display only top categories in hamburger menu ( #6146 )
2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX
330cf78c83
FIX: don’t break browser history on dashboard visit ( #6186 )
2018-07-26 14:59:28 -04:00
Maja Komel
a89dd51cae
DEV: migrate acceptance tests to async/await
2018-07-26 12:51:16 +02:00
Kyle Zhao
1ed3a89ac9
UX: clear topic timer text when manually closing/opening ( #6123 )
...
* UX: clear topic timer text when manually closing/opening
* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Joffrey JAFFEUX
ad95c24307
FEATURE: displays a notice if report has no data ( #6178 )
2018-07-25 14:28:41 -04:00
Régis Hanol
637850d867
REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal
2018-07-25 12:38:15 +02:00
Dan Ungureanu
44a5c29d42
Clear old text and URL when showing up the "Insert Hyperink" modal. ( #6138 )
2018-07-25 17:12:49 +10:00
Maja Komel
3a52c2fa64
DEV: migrate widgets tests to async/await
2018-07-24 23:22:03 +02:00
Maja Komel
d16a2c776a
DEV: migrate components tests to async/await
2018-07-24 22:41:14 +02:00
Sam
95720e3873
lint files
2018-07-24 10:57:16 +10:00
Kyle Zhao
c9d4288214
UX: auto fix order when reordering categories ( #6149 )
...
* set correct position number when moving up/down
* UX: drop 'fix order' and auto re-order subcategory
- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
2018-07-24 10:25:40 +10:00
David Taylor
eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 ( #6099 )
...
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX
9ed4071713
fixes dashboard next spec ( #6132 )
2018-07-21 10:29:58 -04:00
Guo Xiang Tan
863de8cb76
Make prettier happy.
2018-07-21 18:03:39 +08:00
Guo Xiang Tan
096e8ee21c
Disable broken JS test for now.
2018-07-21 17:48:20 +08:00
Arpit Jalan
44e7f63d65
temporarily disable test for new-topic page
2018-07-20 17:49:16 +05:30
Joffrey JAFFEUX
194844fc66
fixes tests
2018-07-19 14:44:42 -04:00
Joffrey JAFFEUX
1a78e12f4e
FEATURE: part 2 of dashboard improvements
...
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
Maja Komel
73739060f3
DEV: migrate acceptance tests to async await - plugin, reports, user, topic
2018-07-19 16:40:12 +02:00
Maja Komel
2e96646659
DEV: migrate acceptance tests to async await - invite, login, mobile
2018-07-19 16:38:37 +02:00
Joffrey JAFFEUX
a2281fbb19
FEATURE: allows to jump to a date in a topic
2018-07-19 16:00:13 +02:00
Maja Komel
7f7944bc3a
DEV: migrate acceptance tests to async await - dashboard, emoji, group
2018-07-19 14:00:03 +02:00
Maja Komel
e36d1c72f1
DEV: migrate acceptance tests to async await - badges, category, composer, customHTML
2018-07-19 13:52:48 +02:00
Maja Komel
6aa2eb19d4
DEV: migrate acceptance tests to async await - admin, about, account created ( #6111 )
2018-07-19 17:35:10 +08:00
Maja Komel
fa38891a98
FEATURE: show modal when user without permissions tries to delete their own topic ( #6086 )
2018-07-18 23:31:37 +02:00
Neil Lalonde
afc94ac9e4
FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity
2018-07-18 16:39:16 -04:00
Régis Hanol
f55ac892e4
make code prettier 🎀
2018-07-18 13:09:16 +02:00
Régis Hanol
6d6e026e3c
FEATURE: selectable avatars
2018-07-18 12:57:43 +02:00
Philipp Rudloff
79b08b2679
Set result.target for update (matching _saveNew) ( #6094 )
...
* Set result.target for update (matching _saveNew)
* Add tests for update result including a target property
2018-07-17 11:56:32 -04:00
Sam
e7102c73fb
correct test and move to async
2018-07-17 09:10:55 +10:00
Sam
ac0053f491
FEATURE: navigate to first post and auto bump category settings
...
### navigate_to_first_post_after_read setting for categories
When enabled on categories logged on users will return to OP after
reading the entire category. (useful for documentation categories)
### num_auto_bump_daily
Set a number of topics that will automatically bump daily on a category.
- Every 15 minutes we will check if any category has this setting
- Categories with the setting are shuffled
- We exclude pinned, closed, category description and archived topics
- Maximum of 1 topic for the list of categories is bumped till limit reached per category
- We always try to bump oldest first
- Limit is elastic using a RateLimiter that ensures that we only bump N per day
Also some minor organisation on category settings
Froze strings on category.rb
2018-07-16 18:10:35 +10:00
Guo Xiang Tan
767395449f
Make prettier happy.
2018-07-16 11:31:23 +08:00
Leo McArdle
21ebb1cd54
FEATURE: Secondary emails support.
2018-07-16 11:09:49 +08:00
Neil Lalonde
8ceed642cb
FIX: wrong url for default logos in header on subfolder installs
2018-07-13 14:21:15 -04:00
Guo Xiang Tan
711371e8c8
FIX: Select+below will ask server for post ids on megatopics.
2018-07-13 15:10:39 +08:00
Guo Xiang Tan
409a30ce1c
FIX: Selecting & moving posts not working on megatopics.
2018-07-13 11:16:43 +08:00
Guo Xiang Tan
18e281606a
UX: Clicking admin menu does not hide select posts box.
2018-07-13 10:56:14 +08:00
Sam
1f0bbca87e
FIX: on initial load category subcategories were not mapped correctly
2018-07-12 17:59:56 +10:00
Guo Xiang Tan
258e9e35ca
PERF: Make mega topics work without a stream.
...
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld .
2018-07-12 12:46:12 +08:00
OsamaSayegh
f13a7226db
FIX: display tables in posts history diff ( #6032 )
2018-07-12 14:13:52 +10:00
Guo Xiang Tan
8f4cb1a742
UX: Timeline lookup on mega topics should use date of current post.
2018-07-10 16:43:20 +08:00
Sam
d9a9682f72
FIX: also count sub categories in hamburger when needed
...
previously there were cases where we suppress subcategories yet don't count them
this leads to confusion
2018-07-09 16:52:55 +10:00
Maja Komel
7cba4cbcc6
FEATURE: allow selecting a tag when moving posts to a new topic ( #6074 )
2018-07-06 18:21:00 +02:00
Joe
98478d78d7
FIX: update test to match new admin layout
2018-07-03 17:03:43 +08:00
Joe
9834263687
FIX: update test to match admin layout changes
2018-07-03 16:28:57 +08:00
Joffrey JAFFEUX
c754ece8f5
FEATURE: drops with-email-link and replaces it by with-email-button
2018-07-02 14:35:50 +02:00
Maja Komel
3ddfc12307
unify user preferences views
2018-07-02 15:38:36 +10:00
Guo Xiang Tan
d1c3eb6bfa
FIX: Recovering a post does not insert it back into the stream correctly.
2018-06-29 11:41:44 +08:00
Joffrey JAFFEUX
9f4e814dbc
tests for XSS injection in tooltips
2018-06-28 14:24:21 +02:00
Maja Komel
ec3e6a81a4
FEATURE: Second factor backup
2018-06-28 10:12:32 +02:00
Jeff Atwood
7dce8290ed
copyedit on category drop down
2018-06-26 12:43:45 -07:00
OsamaSayegh
d81f8ea378
fix prettier
2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270
FIX: use the correct notification levels titles for PMs
2018-06-26 14:01:52 +02:00
Joffrey JAFFEUX
eb9b99e519
FIX: makes select-kit match searches with accents (filter and content)
2018-06-26 12:19:14 +02:00
Joffrey JAFFEUX
f2dbe66367
FEATURE: adds a /admin/reports route to list all reports
2018-06-18 12:31:56 +02:00
Joffrey JAFFEUX
60ff0e9b8c
missing prettified files
2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX
2268e29c26
fix linting removed by prettier
2018-06-15 18:18:45 +02:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files
2018-06-15 17:03:24 +02:00
OsamaSayegh
629a2fbc2b
add JS tests
2018-06-15 14:04:14 +10:00
Joffrey JAFFEUX
eddcb07f03
FEATURE: adds plugin sharing api
2018-06-13 13:25:51 +02:00
Joffrey JAFFEUX
3381a0a42a
UX: reworks dashboard problems section to be in line with new style
2018-06-12 12:47:03 +02:00
kleinfreund
4ce1d230c7
Prefer throwing a new Error object instead of just a string expression
2018-06-12 12:56:22 +10:00
Jeff Wong
b7d92061e2
FEATURE: add an option to create undismissable modals
2018-06-07 20:49:33 -07:00
Joffrey JAFFEUX
1071aa21ab
FIX: slightly safer rounding
2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX
ab089cd68b
FIX: makes format number round the value before using parseInt
2018-06-07 10:44:21 +02:00
Guo Xiang Tan
bc7d9c61e6
Revert smoke test accidentally default to non headless mode.
2018-06-05 19:21:46 +08:00
Guo Xiang Tan
a276ffc7b3
Run smoke test without sandbox for now.
2018-06-05 19:08:36 +08:00
Guo Xiang Tan
478c86e0a4
DEV: Update preview step to be more reliable.
2018-06-05 16:58:15 +08:00
Guo Xiang Tan
c27863aad2
DEV: Better output when assertion fails in smoke test.
2018-06-05 10:54:56 +08:00
Joffrey JAFFEUX
43b1768987
UX: ceil dahsboard values
2018-05-30 16:32:43 +02:00
Guo Xiang Tan
db4af262dc
DEV: Create smoke test screenshot directory in rake task.
2018-05-30 16:20:18 +08:00
Guo Xiang Tan
fe5a48997c
DEV: Store smoke tests failure image in a dedicated tmp folder.
2018-05-30 15:59:07 +08:00
Guo Xiang Tan
30279a4843
DEV: Allow smoke test failure screenshot path to be configured.
2018-05-30 15:42:46 +08:00
Joffrey JAFFEUX
82e5727287
UX: -2/+2% change in stats should be no-change in dashboard
2018-05-28 10:55:42 +02:00
Guo Xiang Tan
9788ea9cb7
DEV: Write into Rails's tmp instead of system tmp for somke test screenshot.
2018-05-28 16:14:22 +08:00
Guo Xiang Tan
9d6d161628
DEV: Take screenshot when smoke test fails.
2018-05-28 14:19:43 +08:00
Guo Xiang Tan
0b55416742
UX: Don't display `all groups` option if group directory is disabled.a
...
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
2018-05-28 11:32:55 +08:00
Guo Xiang Tan
857a4e0006
FIX: Viewport in smoke test configured incorrectly.
2018-05-28 10:58:36 +08:00
Joffrey JAFFEUX
1be76d066c
FIX: forces boolean when content is only "true" && "false"
2018-05-24 23:41:39 +02:00
Sam
70179290f3
clean up callbacks during acceptance tests
2018-05-24 15:28:54 +10:00
Sam
4194886b62
correct failing test
2018-05-24 13:02:20 +10:00
Joffrey JAFFEUX
db91d71bf1
fix category chooser spec
2018-05-23 21:07:39 +02:00
Joffrey JAFFEUX
ae004d8b2b
attempts of making composer actions test more resilient
2018-05-23 19:57:12 +02:00
Joffrey JAFFEUX
7232a6e5a9
FIX: do not show composer actions if irrelevant
2018-05-23 18:25:58 +02:00
Joffrey JAFFEUX
d2efd338e6
rewrites all composer actions tests using await
2018-05-23 15:52:15 +02:00
Joffrey JAFFEUX
dd76ba90b3
FIX: bbcode regex was greedy and preventing quotes
2018-05-23 11:55:02 +02:00
Sam
930ebb5684
skip failing test
2018-05-23 13:26:42 +10:00
Sam
41d37fd498
improve erratic test
2018-05-23 10:16:52 +10:00
Sam
8e9531657a
skip erratic test
2018-05-23 08:28:00 +10:00
Joffrey JAFFEUX
a0c5b48558
fix failing spec
2018-05-22 10:50:54 +02:00
Sam
9e2131ace8
improve erratic test
2018-05-22 13:58:12 +10:00
Sam
99088f4d77
skip slow erratic test
2018-05-22 13:03:26 +10:00
Jeff Atwood
4329b484e8
minor copyedit on dashboard chart title
2018-05-18 16:04:33 -07:00
Joffrey JAFFEUX
af548c23c4
new dashboard quality pass (code, tests and UI)
2018-05-17 22:44:33 +02:00
Guo Xiang Tan
3f8e3a6f73
Don't intercept requests in smoke tests.
2018-05-17 16:56:39 +08:00
Sam
17a7bb8e23
use async test
2018-05-17 17:18:22 +10:00
Sam
441a52ad17
DEV: add more information about failed smoke test
...
log the http status code and path that failed
2018-05-17 16:43:00 +10:00
Régis Hanol
674318e127
UX: don't show 'auto delete' option for TL4
2018-05-17 00:42:48 +02:00
Régis Hanol
938934f5e9
FIX: keep '<kbd>' formatting when quoting posts
2018-05-16 17:40:45 +02:00
Joffrey JAFFEUX
9554d9c56a
UX: tooltips and improvements to new dashboard
...
- tooltips
- revert chart title UI
- reduce period chooser font-size
- localize dates of data points
- fix a bug where multiple reports were loaded at the same time
- fix a bug where % was not showing anymore
- remove spacing at the top
- remove loadingTitle feature (Loading...%report name%) incompatible with new hijack design
2018-05-16 16:45:21 +02:00
Joe Buhlig
3cd4c82c49
Allow parameters for group and username filters on directory ( #5815 )
2018-05-16 16:20:17 +02:00
Sam
f08ff84c5c
missing a fixture for acceptance test
2018-05-15 15:34:40 +10:00
Joffrey JAFFEUX
e474351ae4
inactive users report is not used anymore
2018-05-14 21:31:14 +02:00
Régis Hanol
b004503c62
fix the build
2018-05-14 20:07:00 +02:00
Sam
e1d7f3bb94
correct fixture
2018-05-14 15:46:58 +10:00
Sam
a6aa986d3b
correct spec
2018-05-14 15:41:19 +10:00
Régis Hanol
81f4da7dd2
FIX: remove unneeded escape when building a Quote
2018-05-12 01:16:05 +02:00
Sam
8a783412b7
UX: improvements to new dashboard
...
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
2018-05-11 13:30:32 +10:00
Régis Hanol
deaf3682e9
FIX: clicking a group mention on mobile was 404ing
...
(cc @featheredtoast)
2018-05-09 17:27:59 +02:00
Régis Hanol
3483c7bc58
FIX: supports user/group mentions and category hashtags when quoting posts
2018-05-09 12:42:12 +02:00
Guo Xiang Tan
32147d4ff9
FIX: Search term scoped to topic should be highlighted in widget dom era.
...
https://meta.discourse.org/t/highlight-the-search-results/10322/4?u=tgxworld
2018-05-07 15:17:34 +08:00
Neil Lalonde
3a145b7551
fix group-test.js
2018-05-03 16:00:56 -04:00
Joffrey JAFFEUX
980972182f
dashboard next: caching, mobile support and new charts
2018-05-03 15:41:41 +02:00
Joffrey JAFFEUX
37a0ceb4e7
Adds fixture for new contributors
2018-04-26 17:39:00 +02:00
Joffrey JAFFEUX
a9c3437d51
dashboard next: adds basic spec
2018-04-25 10:28:41 +02:00
Joffrey JAFFEUX
59d4123316
PERFORMANCE: disables jquery animations during testing
2018-04-24 18:29:26 +02:00