Penar Musaraj
17ba00c395
FIX: icon toggles saerch menu display on click ( #20950 )
...
Using the `mouseDownOutside` event was problematic here because two
events were being triggered consecutively: `mouseDown`
would toggle the menu off and `click` would then toggle it back on. This
switches the logic to use `clickOutside` again, but with two changes:
- it limits the action to the `search-menu` key (so that theme component
overrides can do their own handling)
- it does not trigger the event when there is an active text selection
(this was the original reason for switching to `mouseDownOutside`, see
https://github.com/discourse/discourse/pull/14788 )
2023-04-04 09:49:55 -04:00
Kris
7658341b0b
UX: use relative units to prevent timeline crop ( #20943 )
2023-04-04 09:40:43 -04:00
Bianca Nenciu
6da2fbbf76
FIX: Use correct translation key ( #20958 )
...
The translation key is built using the name of the reviewable as it was
defined in Ruby. The chat plugin uses the `Chat` namespace and defines
`Chat::ReviewableMessage`. This was then transformed to
`chat::reviewable_message`, but it should be `chat_reviewable_message`
to resemble the other translation keys.
2023-04-04 16:28:04 +03:00
Joffrey JAFFEUX
8de45602ff
DEV: allows <UserStatusMessage /> to accept custom css class ( #20954 )
...
This will now allow:
```
<UserStatusMessage @status={{@message.user.status}} @class="foo" />
```
2023-04-04 10:04:40 +02:00
Alan Guo Xiang Tan
e792f779d0
UX: Make input on `/filter` route full width ( #20952 )
2023-04-04 14:10:39 +10:00
Alan Guo Xiang Tan
b82cd6c148
DEV: Nuke plugin related code from core ( #20928 )
...
Plugin related code should be not polluting core's code base.
2023-04-04 07:33:31 +08:00
Jarek Radosz
3b28d03780
DEV: Fix a use-after-destroy issue ( #20948 )
2023-04-04 01:29:27 +02:00
Jarek Radosz
29e2e3ff3b
DEV: Fix random typos ( #20937 )
2023-04-03 19:27:32 +02:00
dependabot[bot]
b042e1cbf7
Build(deps): Bump eslint in /app/assets/javascripts ( #20883 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.36.0 to 8.37.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.36.0...v8.37.0 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-03 11:37:48 +02:00
dependabot[bot]
5ec169725b
Build(deps): Bump @babel/standalone in /app/assets/javascripts ( #20920 )
...
Bumps [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ) from 7.21.3 to 7.21.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-03 11:37:16 +02:00
dependabot[bot]
42a6d0c5b1
Build(deps): Bump webpack in /app/assets/javascripts ( #20885 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.76.3 to 5.77.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.76.3...v5.77.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-03 11:36:53 +02:00
dependabot[bot]
0e04404e6b
Build(deps): Bump @babel/core in /app/assets/javascripts ( #20923 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.21.3 to 7.21.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-03 11:01:24 +02:00
chapoi
df31b8dd2e
UX: reviewq flagging ( #20913 )
...
* DEV: add context question to flagged chat messages too
* UX: added -ai-flagged badge colour + grey fallback
* UX: add one more badge name
2023-04-02 12:16:26 +02:00
Roman Rizzi
ea4f7fb660
FEATURE: Experimental API for custom full-page search types. ( #20915 )
...
This change adds an experimental API tagged as "Do not use", only intended to conduct a PoC to test semantic search in the AI plugin.
2023-03-31 15:13:24 -03:00
Martin Brennan
ef1b781ced
FIX: Prevent errors from uppy performance logging ( #20910 )
...
Back in d0e1c222f7
we added
performance measuring for uppy uploads using the Performance
API in the browser. However we recently discovered that
sometimes performance.measure can fail if for whatever reason
one of the marks passed to it does not exist:
> Failed to upload ... Performance.measure: Given mark name, upload-uppy-....-create-multipart-success, is unknown
This would cause the entire upload to fail, which is unnecessary
for a debugger. Improve the situation so if this happens again
the error does not stop the upload.
2023-03-31 14:29:07 +10:00
Kris
1ff9bc6e55
UX: onebox site icon needs a right margin ( #20902 )
2023-03-31 11:06:46 +11:00
Krzysztof Kotlarek
fd718c1a42
FIX: use unselectable mixin in sidebar drag and drop ( #20886 )
...
7dcaaec90c/app/assets/stylesheets/common/foundation/mixins.scss (L122)
2023-03-31 09:28:22 +11:00
Canapin
58270954b6
Fix keyboard shortcut button hover color for WCAG color schemes ( #20431 )
2023-03-30 14:18:20 -04:00
Alan Guo Xiang Tan
49e7e639cc
DEV: Update experimental `/filter` route with tags support ( #20874 )
...
The following are the changes being introduced in this commit:
1. Instead of mapping the query language to various query params on the
client side, we've decided that the benefits of having a more robust
query language far outweighs the benefits of having a more human readable query params in the URL.
As such, the `/filter` route will just accept a single `q` query param
and the query string will be parsed on the server side.
1. On the `/filter` route, the tags filtering query language is now
supported in the input per the example provided below:
```
tags:bug+feature tagged both bug and feature
tags:bug,feature tagged either bug or feature
-tags:bug+feature excluding topics tagged bug and feature
-tags:bug,feature excluding topics tagged bug or feature
```
The `tags` filter can also be specified multiple
times in the query string like so `tags:bug tags:feature` which will
filter topics that contain both the `bug` tag and `feature` tag. More
complex query like `tags:bug+feature -tags:experimental` will also work.
2023-03-30 09:00:42 +08:00
Jan Cernik
afe3e36363
DEV: Remove lazy-yt and replace with lazy-videos ( #20722 )
...
- Refactors the old plugin to remove jquery usage
- Adds support for Vimeo videos (default on) and Tiktok (experimental and default off)
2023-03-29 11:54:25 -04:00
Osama Sayegh
78befbc53e
DEV: Remove `{{user-selector}}` ( #17753 )
...
`{{user-selector}}` was deprecated in 293fd1f743
more than 2 years ago and it's time we deleted it.
2023-03-29 11:49:47 +03:00
Krzysztof Kotlarek
b854fa8cdb
FIX: disable text select on sidebar ( #20871 )
...
To make drag&drop links reliable, we have to disable user-select option on whole sidebar.
https://developer.mozilla.org/en-US/docs/Web/CSS/user-select
2023-03-29 14:32:28 +11:00
Krzysztof Kotlarek
f5fadc3149
FIX: reorder custom sidebar links on touch screen ( #20856 )
...
Previously, reorder on touch screens was disabled https://github.com/discourse/discourse/pull/20769 .
This PR enables it again. However, link has to be hold for 300 ms to enable drag&drop. Otherwise, normal scroll is performed.
2023-03-29 08:57:04 +11:00
Penar Musaraj
f8720a20f9
Revert "UX: Take sticky header into account when spacebar scrolling ( #20848 )" ( #20863 )
...
This reverts commit cb92ea3c2b
.
Was causing unexpected scrolling when interacting with the header. Will
investigate.
2023-03-28 11:13:51 -04:00
Ella E
0b05fa71ca
UX: Improve login required page ( #20847 )
...
* UX: improve static login page
* DEV: separate welcome header to its own translation line
* Define waving_hand_url helper
* Remove redundant copy
* Update translations for welcome_message
* DEV: remove unused imported getURL
---------
Co-authored-by: Bianca Nenciu <nenciu.bianca@gmail.com>
2023-03-28 07:09:44 -05:00
Penar Musaraj
cb92ea3c2b
UX: Take sticky header into account when spacebar scrolling ( #20848 )
2023-03-27 20:37:01 -04:00
Krzysztof Kotlarek
326a7a47e7
FIX: global sidebar section icon not moving on scroll ( #20851 )
...
Global section icon is using absolute position. To make it move on scroll, the parent element has to be relative.
https://meta.discourse.org/t/globe-icon-at-sidebar-behaves-badly/259382
2023-03-28 10:13:27 +11:00
Canapin
2dba3ab7c9
UX: Improve the "install theme/component" modal on mobile ( #20777 )
2023-03-27 14:11:31 -04:00
NullVoxPopuli
e988628186
DEV: Update browserslist ( #20846 )
...
Silences some verbose logging while booting the UI
2023-03-27 19:15:04 +02:00
Jarek Radosz
cbabc01e0e
DEV: Make `capabilities` into a service ( #18678 )
2023-03-27 19:06:36 +02:00
dependabot[bot]
3d0b67372f
Build(deps): Bump @uppy/aws-s3-multipart in /app/assets/javascripts ( #20032 )
...
Bumps [@uppy/aws-s3-multipart](https://github.com/transloadit/uppy ) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/aws-s3-multipart@3.1.1...@uppy/aws-s3-multipart@3.1.2 )
---
updated-dependencies:
- dependency-name: "@uppy/aws-s3-multipart"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 13:38:11 +02:00
dependabot[bot]
f425e9c66c
Build(deps): Bump @uppy/utils in /app/assets/javascripts ( #20567 )
...
Bumps [@uppy/utils](https://github.com/transloadit/uppy ) from 5.1.2 to 5.1.3.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/utils@5.1.2...@uppy/utils@5.1.3 )
---
updated-dependencies:
- dependency-name: "@uppy/utils"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 13:35:34 +02:00
dependabot[bot]
142ef6088c
Build(deps): Bump @uppy/aws-s3 in /app/assets/javascripts ( #20033 )
...
Bumps [@uppy/aws-s3](https://github.com/transloadit/uppy ) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/aws-s3@3.0.4...@uppy/aws-s3@3.0.5 )
---
updated-dependencies:
- dependency-name: "@uppy/aws-s3"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 12:50:56 +02:00
dependabot[bot]
dd0c9a96b9
Build(deps): Bump @popperjs/core in /app/assets/javascripts ( #20831 )
...
Bumps [@popperjs/core](https://github.com/popperjs/popper-core ) from 2.11.6 to 2.11.7.
- [Release notes](https://github.com/popperjs/popper-core/releases )
- [Commits](https://github.com/popperjs/popper-core/compare/v2.11.6...v2.11.7 )
---
updated-dependencies:
- dependency-name: "@popperjs/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:52:53 +02:00
dependabot[bot]
f56a6a1c28
Build(deps): Bump sinon from 15.0.2 to 15.0.3 in /app/assets/javascripts ( #20829 )
...
Bumps [sinon](https://github.com/sinonjs/sinon ) from 15.0.2 to 15.0.3.
- [Release notes](https://github.com/sinonjs/sinon/releases )
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md )
- [Commits](https://github.com/sinonjs/sinon/compare/v15.0.2...v15.0.3 )
---
updated-dependencies:
- dependency-name: sinon
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:51:33 +02:00
dependabot[bot]
e7ef5afb1b
Build(deps): Bump sass from 1.59.3 to 1.60.0 in /app/assets/javascripts ( #20830 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.59.3 to 1.60.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.59.3...1.60.0 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:50:55 +02:00
dependabot[bot]
30417b7f18
Build(deps): Bump terser in /app/assets/javascripts ( #20832 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.16.6 to 5.16.8.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.16.6...v5.16.8 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:50:06 +02:00
Ted Johansson
392cea5852
DEV: Only show plugin tab for admin ( #20841 )
...
As part of another regression, we realized that the plugins tab is visible to moderators, but they cannot interact with anything inside without triggering authorization errors.
This change hides the plugin tab for non-admin users.
2023-03-27 16:08:16 +08:00
Krzysztof Kotlarek
e0cf2849fd
FIX: admin always see configure default sidebar categories ( #20836 )
...
When an admin removes all the categories from their personal sidebar configuration, the section should remain visible to them with the “Configure default categories” prompt.
Similar solution for tags.
/t/95036
2023-03-27 15:46:39 +11:00
Alan Guo Xiang Tan
e0155b6955
DEV: Introduce dedicated controller and route for `discovery.filter` ( #20837 )
...
Instead of being tied to the old implementation and constraints, a
dedicated route and controller for the `discovery.filter` app route will
allow us to iterate on changes much faster.
2023-03-27 10:08:11 +08:00
Krzysztof Kotlarek
4047073292
FIX: display validation under custom sidebar fields ( #20772 )
...
Before, incorrectly filled fields were marked with red border. Now, additional information under the field is displayed to notify the user what is incorrect.
/t/93696
2023-03-27 13:03:16 +11:00
Keegan George
c66323f964
UX: Make table wrapper popup button icon only ( #20820 )
2023-03-24 13:23:05 -07:00
David Taylor
e47af9bb72
FIX: Check for staff without triggering anonymous user error ( #20819 )
...
Followup to 142d2ab65e
2023-03-24 19:11:57 +00:00
Keegan George
83db0bf41a
FIX: Post height issues with Expand Table button ( #18810 )
2023-03-24 11:55:49 -07:00
Kris
88004873ec
A11Y: usernames aren't a meaningful heading ( #20623 )
2023-03-24 13:22:22 -04:00
Andrei Prigorshnev
19b0dbe59d
UX: Show titles on site settings navigation menu items ( #20794 )
...
In some languages, labels on the site settings navigation menu
get truncated. This adds titles to menu items, so users can see
untruncated labels on hover.
2023-03-24 20:46:10 +04:00
David Taylor
fc3c737a7f
UX: Restore reviewable counts on hamburger for legacy navigation ( #20807 )
...
Previously we disabled the hamburger reviewable count badge when the redesigned user menu was enabled. This commit updates the logic so that the hamburger reviewable count is tied the legacy navigation mode instead. This ensures that there is always a persistent reviewable count visible. (in the non-legacy navigation modes, the total reviewable count is shown in the sidebar)
2023-03-24 14:34:32 +00:00
David Taylor
9b41700f87
DEV: Use component class instead of string in user-menu API ( #20806 )
...
In the future we'll be looking at things like tree-shaking and code-splitting. Using 'magic strings' to resolve components is not compatible with those techniques. It makes sense to switch to a more modern pattern now, before the new user-tab API is used too widely.
This commit is backwards-compatible. API consumers which pass a string will see a deprecation message asking them to pass a component class instead.
This commit also turns some unneeded getters into simple class properties (no need to use a getter when it just returns a constant).
2023-03-24 14:26:30 +00:00
Bianca Nenciu
142d2ab65e
FEATURE: Move bootstrap mode indicator to header ( #20663 )
...
The information about bootstrap mode has been moved from the notice to
the README topic for admins.
2023-03-24 15:59:03 +02:00
Jarek Radosz
a39a7028ab
DEV: Remove server-side-only entry for /upgrade ( #20804 )
...
After the docker_manager upgrade (https://github.com/discourse/docker_manager/pull/167 ) this is no longer needed.
2023-03-24 13:11:25 +01:00