b4f0a0fb94
FIX: Nil-filled CF arrays were not being deleted ( #13518 )
2021-06-25 11:34:51 +02:00
0e4b8c5318
PERF: Cache categories in Site model take 3.
...
Previous attempt resulted in custom fields going missing in the
serialized output.
This reverts commit 83a6ad32ff
2021-06-24 13:30:51 +08:00
59097b207f
DEV: Correct typos and spelling mistakes ( #12812 )
...
Over the years we accrued many spelling mistakes in the code base.
This PR attempts to fix spelling mistakes and typos in all areas of the code that are extremely safe to change
- comments
- test descriptions
- other low risk areas
2021-05-21 11:43:47 +10:00
554a617b3d
DEV: Better custom field preload error ( #11044 )
2020-10-27 10:05:07 -05:00
c363189858
Accounted for the change while reading the fields added specs to confirm working
2020-08-25 09:52:18 -04:00
352ad826c1
FIX: symbols and strings should be treated similarly while saving custom fields
2020-08-25 09:52:18 -04:00
e0d9232259
FIX: use allowlist and blocklist terminology ( #10209 )
...
This is a PR of the renaming whitelist to allowlist and blacklist to the blocklist.
2020-07-27 10:23:54 +10:00
d23f7af3cb
PERF: Allow user serializer to make use of preloaded custom fields ( #9074 )
2020-03-03 13:56:54 +00:00
74dc37c07c
FIX: upserting custom fields using keywords converts the array key to a string
2019-10-29 11:35:38 -07:00
3132a9007b
FIX: Use correct timezone for manual SQL
2019-07-06 15:14:07 -04:00
a075fd46fd
FIX: Don't use exceptions to catch conflicts
...
If a database exception is raised ActiveRecord will always rollback
even if caught.
Instead we build the query in manual SQL and DO NOTHING when there's a
conflict. If we detect nothing was done, perform an update.
2019-07-06 14:43:56 -04:00
72bac61c90
FIX: Upsert a custom field if a unique constraint fails
2019-07-04 13:26:25 -04:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
22408f93c9
FIX: Wrap custom fields database statements in a transaction.
...
Kind of strange that we don't do it because a database statement
may fail and leave us in a weird state.
2018-10-18 12:23:04 +08:00
e364547ff7
FIX: ignore and log bad json values for custom fields
2018-09-13 14:26:30 +05:30
1ac1ee4287
FEATURE: allow registration of an array custom field
2018-05-22 16:48:39 +10:00
730201d423
New interface to upsert custom fields
2018-03-02 12:45:52 -05:00
174ab2d93a
minor, ensure ordering of custom fields is consistent
2017-11-16 15:14:10 +11:00
4bb454d889
FIX: JSON custom fields incorrectly being converted to an array.
...
https://meta.discourse.org/t/custom-fields-simultaneous-save-with-json-becomes-an-array/73647
2017-11-08 11:17:37 +08:00
09ed2ed749
Add Suspend User to flags page
2017-09-25 12:28:00 -04:00
40eba8cd93
FEATURE: View flags grouped by topic
2017-09-25 12:25:14 -04:00
629810bd07
FIX: when registering custom_field types, ensure we're casting them before checking for equality
2017-08-16 23:04:40 +02:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
f2f49a5e96
Ability to add text to a poster name icon
2016-02-19 14:22:36 -05:00
4486879fd2
select less data
2015-08-05 16:09:21 +10:00
a51386a280
FEATURE: allow efficient preloading of custom fields in topic list
2015-08-05 16:09:21 +10:00
033761d2f6
FIX: reset all votes when the # of options changes
2015-05-06 18:52:09 +02:00
151dea4088
FIX: editing a poll/post with a poll wasn't working properly
2015-04-26 00:12:19 +02:00
a737090442
- FEATURE: revamped poll plugin
...
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
d1ec1e2681
Allow code to save custom fields without saving the attached object
2015-01-29 17:17:52 -05:00
505fa9f1cf
FIX: 🐛 Saving the same custom field array twice would raise an error
2015-01-15 15:31:50 -05:00
7351917ee4
Boolean -> String quoting has changed on Rails master
...
CustomField.create(name: 'zomg', value: true).reload.value # => 't' on Rails 4.1, '1' on 4.2
rails/rails@42be84ba
2014-11-10 01:05:46 -08:00
66aaa9329e
FEATURE: vBulletin importer
2014-08-18 13:04:08 +02:00
983a22004a
FEATURE: register_custom_field_type, support bool and integer
2014-06-17 12:42:12 +10:00
3211c60bbe
FEATURE: A new site setting `public_user_custom_fields` which allows you
...
to whitelist custom fields that will be exposed to the Ember client
application.
2014-05-14 14:39:01 -04:00
f757706861
Ensure Reload reloads custom_fields, too
2014-04-29 19:34:56 +02:00
0cf07d41ae
Move Concern from lib into app/models. refs #2279
2014-04-29 19:26:43 +02:00
Jarek Radosz
Alan Guo Xiang Tan
Josh Soref
Mark VanLandingham
fzngagan
Krzysztof Kotlarek
David Taylor
Jeff Wong
Robin Ward
Sam Saffron
Guo Xiang Tan
Arpit Jalan
Régis Hanol
Godfrey Chan
Benjamin Kampmann