Neil Lalonde
cbc8236288
UX: add a paragraph description on the tags tab of the category settings
2019-03-08 16:46:32 -05:00
Kris
c29ff3d2d5
UX: style adjustments for post notice feature
2019-03-08 16:02:51 -05:00
Robin Ward
57ee779b1e
FIX: Job exception: undefined method `email' for nil:NilClass
...
It seems that due to jobs being asynchronous and wrapping code in a
DistributedMutex that by the time we run the
`UserAvatar#update_gravatar!` job that the user/user email might be
destroyed.
This patch checks before a call to `user.email_hash` to make sure
the user and primary email exist to prevent the exception. If not
present, the job exits as there's nothing to do because we are
probably running after the user was destroyed for some reason.
2019-03-08 13:39:56 -05:00
Kris
e3e681ebf7
UX: better handling of width and overflow for login/signup
2019-03-08 11:14:52 -05:00
Osama Sayegh
5e58cedfbd
FIX: retranspile theme JS when settings YAML changes ( #7131 )
2019-03-08 17:49:06 +03:00
David Taylor
0a4562253e
DEV: Add 'starting' event to sidekiq log when interval logging enabled
2019-03-08 10:56:36 +00:00
David Taylor
e2510d79cc
DEV: Improve thread-safety of sidekiq logging
2019-03-08 10:31:49 +00:00
Dan Ungureanu
ac8425ad30
FIX: Date format and styling for post notices
...
Follow-up to 35942f7
.
2019-03-08 12:25:03 +02:00
Régis Hanol
ad12b2a23d
FIX: only call 'unlink' for tempfiles
2019-03-08 11:22:20 +01:00
Régis Hanol
7ff994b6ea
UX: post-notice max width on desktop
2019-03-08 10:52:47 +01:00
Régis Hanol
2434e48d4d
UX: Fix post notice on mobile
2019-03-08 10:50:33 +01:00
David Taylor
9db05a895a
DEV: Add job_id to sidkiq log
...
This makes it easier to correlate 'pending' logs from the same job
2019-03-08 09:16:13 +00:00
Dan Ungureanu
2312caccdc
FEATURE: Skip small actions when counting replies in PMs. ( #7108 )
2019-03-08 10:49:34 +02:00
Dan Ungureanu
35942f7c7c
FEATURE: Special call-out for new / returning posters. ( #7115 )
2019-03-08 10:48:35 +02:00
Simon Cossar
65464969cd
Change searchTearm to searchTerm ( #7130 )
2019-03-08 09:24:14 +01:00
Joffrey JAFFEUX
3acf8a95f3
UX: various tweaks to search-menu ( #7114 )
2019-03-08 09:23:44 +01:00
Joffrey JAFFEUX
c90267db52
FIX: do not display add/remove participants if you can’t actually do it ( #7125 )
2019-03-08 09:23:26 +01:00
Kris
cd94ac9453
FIX: remove padding from onebox site icon in composer preview
2019-03-07 22:32:27 -05:00
Kris
6e26358380
REFACTOR: streamline like button styles, clarify for themeing, enable tab focus
2019-03-07 21:09:57 -05:00
Gerhard Schlager
f6ef4f8c3f
FEATURE: Add missing S3 regions
2019-03-07 22:42:20 +01:00
Kris
ccff1d2dbb
prettier
2019-03-07 13:30:39 -05:00
Kris
837452794b
Target active nav pill with single style
2019-03-07 13:21:42 -05:00
Joffrey JAFFEUX
a2fdd4089c
FIX: nav-pills not highlighted on user preferences page ( #7126 )
2019-03-07 13:40:12 +01:00
David Taylor
fc7938f7e0
REFACTOR: Migrate GoogleOAuth2Authenticator to use ManagedAuthenticator ( #7120 )
...
https://meta.discourse.org/t/future-social-authentication-improvements/94691/3
2019-03-07 11:31:04 +00:00
Arpit Jalan
2c8e1d3578
FEATURE: remove all expired invitations by default
2019-03-07 15:28:39 +05:30
Arpit Jalan
caef0a56d1
FEATURE: create a new message via URL without specifying user or group
2019-03-07 11:30:24 +05:30
Kris
9d3c7d7b25
prettier
2019-03-06 19:52:34 -05:00
Kris
e233a69db0
Customize nav pill fix
2019-03-06 19:42:44 -05:00
Kris
7d2cc33013
prettier
2019-03-06 17:37:59 -05:00
Kris
a917a93990
fix active class, remove style
2019-03-06 17:29:19 -05:00
Kris
536952f194
adding back active nav pill
2019-03-06 17:14:02 -05:00
Bianca Nenciu
733deba585
FIX: Loading draft also replaces the recipients ( #7122 )
2019-03-07 08:14:55 +11:00
Kris
078c02cd24
UX: More consistent structure for active nav-pill
2019-03-06 16:10:22 -05:00
Gerhard Schlager
1121514799
UX: Localize date format in "new user of the month" message
2019-03-06 21:58:25 +01:00
Vinoth Kannan
5ba2ef4274
UX: Display error message if no time frame selected in topic status update
2019-03-07 02:17:29 +05:30
Vinoth Kannan
167d85c21f
FIX: post & topic destroyed hooks not triggering with tag filter
2019-03-06 22:52:54 +05:30
Kris
2db3652338
UX: Fix redeemed invite table layout
2019-03-06 11:05:45 -05:00
Gerhard Schlager
4000978452
FIX: Failed to save email template with pluralized subject
2019-03-06 16:51:04 +01:00
Kris
5cf63e43c6
FEATURE: Add about-after-description plugin outlet
2019-03-06 10:26:34 -05:00
David Taylor
df474bceee
DEV: Further sidekiq logging stability improvements
...
- Open the log file in "append" mode. This avoids issues if the file does not exist (and matches standard rails log behavior)
- Correctly parse the interval logging environment variable
2019-03-06 12:50:15 +00:00
Tarek Khalil
0a9a11094d
FEATURE: Save ignored usernames in user preferences ( #7117 )
...
* FEATURE: Save ignored usernames in user preferences
2019-03-06 11:21:58 +00:00
Joffrey JAFFEUX
974e756369
FIX: bugs in safari where select-kit is not expanding on iOS ( #7118 )
2019-03-06 11:29:45 +01:00
David Taylor
fe62de68dd
DEV: Correct sidekiq logging to avoid thread leak
2019-03-06 10:11:31 +00:00
Tarek Khalil
b58eea1fcb
FEATURE: Hide ignored user's Original Post content ( #7113 )
...
* FEATURE: Hide ignored user's Original Post content
2019-03-06 09:20:45 +00:00
Arpit Jalan
05ebb52ec4
FEATURE: defer flags when deleting child replies ( #7111 )
2019-03-06 14:32:25 +05:30
Sam
8d7c10f7f2
FIX: allow moderators to create categories setting broken
...
Mods require visibility to everyone group cause category dialogs need to
know about this.
If the site setting `allow moderators to create categories` will not function
without this
Note there is no security expansion of rights here, the group is technically
empty anyway and it always looks exactly the same on all discourse instances
2019-03-06 17:44:18 +11:00
Kris
86f9ace0ea
UX: Previous positioning was better for the image resizer
2019-03-05 22:10:12 -05:00
Kris
b5804c410e
UX: Add slash to mobile category page totals
2019-03-05 20:16:12 -05:00
Kris
2ea77073ae
prettier
2019-03-05 15:12:10 -05:00
Kris
84892429ed
UX: Improve layout of invite table
2019-03-05 14:50:27 -05:00
Jeff Wong
b0d93a38e8
FEATURE: Add plugin html hook to insert html before any other scripts
2019-03-05 10:41:16 -08:00
David Taylor
8b30ed5b7a
DEV: Serialize the job parameters in sidekiq logs
...
Otherwise this can lead to some very large data structures when processing the logs later
2019-03-05 17:44:49 +00:00
Gerhard Schlager
671cec4bd2
DEV: Use Discourse.getURL for creating URL
...
follow-up to ccb48bef75
2019-03-05 17:52:18 +01:00
Tarek Khalil
190b19f3c2
FEATURE: Add ignored user list to the User's preference page ( #7107 )
...
* FEATURE: Add ignored user list to the User's preference page
## Why?
Part of: https://meta.discourse.org/t/ability-to-ignore-a-user/110254
We want to add list of Ignored users under or along with the muted users preferences section.
This way Users can find and update their list of ignored users.
## UI
![gif](https://user-images.githubusercontent.com/45508821/53746179-8e9b3c00-3e98-11e9-9e90-94b8520896a6.gif )
## Open questions
Two of many options to represent a list of ignored users is that we can:
1. We can represent the ignored user list as a table with the ability to `un-ignore` but NOT to add new ignored users.
2. We can keep it functioning as the `muted user list` where you can `un-ignore` or `ignore` users.
2019-03-05 14:47:51 +00:00
Tarek Khalil
f19d36cbba
REFACTOR: Change `watch` wording to `unignore` ( #7112 )
...
* REFACTOR: Change `watch` wording to `unignore`
2019-03-05 14:40:31 +00:00
Gerhard Schlager
ccb48bef75
UX: Make Uncategorized category less confusing
...
* Adds warnings to the "Edit Category" dialog
* Doesn't hide the "Security" tab on the "Edit Category" dialog anymore. Instead, it shows an explanation why permissions can't be changed.
* Makes the category name translatable
* Hides the category name from the edit dialog (it can be customized by overriding the translation)
* Creates a translation override if the category has been renamed in the past
2019-03-05 14:42:41 +01:00
Gerhard Schlager
68e4aba369
UX: Don't concatenate title on "Edit Category" dialog
2019-03-05 14:42:41 +01:00
David Taylor
35275c137b
PERF: Remove final N+1 from theme admin page
...
The rails bug previously mentioned only causes an issue when using `pluck`, so this controller is not affected.
Followup to a8ffc02d06
2019-03-05 12:10:53 +00:00
David Taylor
8963f1af30
FEATURE: Optional detailed performance logging for Sidekiq jobs ( #7091 )
...
By default, this does nothing. Two environment variables are available:
- `DISCOURSE_LOG_SIDEKIQ`
Set to `"1"` to enable logging. This will log all completed jobs to `log/rails/sidekiq.log`, along with various db/redis/network statistics. This is useful to track down poorly performing jobs.
- `DISCOURSE_LOG_SIDEKIQ_INTERVAL`
(seconds) Check running jobs periodically, and log their current duration. They will appear in the logs with `status:pending`. This is useful to track down jobs which take a long time, then crash sidekiq before completing.
2019-03-05 11:19:11 +00:00
Kris
73e4204d20
UX: Image preview resizer style
2019-03-04 21:59:58 -05:00
Tarek Khalil
079b0f4bff
FIX: Remove ignore user feature from `user-card-contents` component ( #7104 )
...
Based on our discussions, we want to have the `Ignore button will ONLY be on the User’s profile page`.
2019-03-04 15:21:45 +00:00
Arpit Jalan
ad5f5b931d
DEV: deprecate blank files for static modal pages
2019-03-04 15:05:33 +05:30
Joffrey JAFFEUX
2e881adb6e
FIX: select-kit perf and positioning improvements ( #7093 )
2019-03-04 10:30:22 +01:00
Joffrey JAFFEUX
dc4001370c
FEATURE: displays groups in menu search ( #7090 )
2019-03-04 10:30:09 +01:00
Joffrey JAFFEUX
075b264338
DEV: replaces DOMNodeInserted by the better MutationObserver ( #6884 )
2019-03-04 10:28:59 +01:00
Arpit Jalan
824d9402a4
FIX: pending counts were not shown on invites tab
2019-03-04 14:14:13 +05:30
Maja Komel
fea5d4f3ec
FIX: any subcategory permissions are valid if everyone has access to parent category ( #7097 )
2019-03-04 14:49:26 +11:00
Joffrey JAFFEUX
bb39a6f7d7
REFACTOR: topic-list-header-column ( #7099 )
2019-03-04 14:45:52 +11:00
Arpit Jalan
01e2180548
FIX: /signup and /password-reset direct links were broken
2019-03-04 09:02:22 +05:30
Jeff Atwood
9585e2dff2
change separator from | to • for editor image sizing
2019-03-03 17:55:21 -08:00
Gerhard Schlager
14f9e55977
FIX: Error when filtering site settings
...
Happened only when none of the logo settings had an image assigned.
2019-03-03 20:43:22 +01:00
Dan Ungureanu
fd9671f7fe
DEV: Minor code improvements.
2019-03-02 19:07:54 +02:00
Sam
03a70ef69c
FIX: allow underscore and dash in username search
...
_ and - are technically punctuations, but we allow them in usernames so
accept them in search
2019-03-01 15:23:45 +11:00
Sam
cdf34657f6
FEATURE: focus on composer TEXTAREA when iPad has a physical keyboard
...
This disables a bunch of hacks that bypassed "focus" on iOS (cause focus
events that involve a virtual keyboard on iOS cause browser havoc unless
a physical keyboard is attached)
Also will focus on title on new topic
2019-03-01 11:31:52 +11:00
Dan Ungureanu
6bc8382555
FEATURE: Use smooth scrolling for J/K keyboard shortcuts. ( #7084 )
2019-03-01 09:31:40 +11:00
Vinoth Kannan
be436066ff
FIX: Prevent default event and stop bubbling up when card popup is closed in mobile
2019-03-01 01:42:17 +05:30
Penar Musaraj
64a3d63ddc
DEV: Rename some icons with deprecated names
2019-02-28 13:03:14 -05:00
Maja Komel
612a0be085
FIX: don't add bottom padding for avatars in composer preview
2019-02-28 18:03:38 +01:00
David Taylor
e67474daf4
UX: Don't link to theme source unless it's http(s)
2019-02-28 17:01:59 +00:00
Joffrey JAFFEUX
1cd64f68f1
FIX: staff/admin shouldn’t be able to create uncategorized topics ( #7077 )
2019-02-28 15:51:13 +01:00
David Taylor
3517103398
UX: Correct locale key for theme compatibility error
2019-02-28 14:40:33 +00:00
Arpit Jalan
c02956e29c
FIX: when posts are moved to a message then small action post should not be publicly visible ( #7085 )
...
This fix is inspired from what we do in discourse-assigned plugin.
https://github.com/discourse/discourse-assign/blob/master/lib/topic_assigner.rb#L184
https://github.com/discourse/discourse-assign/blob/master/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6#L125-L133
2019-02-28 19:49:26 +05:30
Maja Komel
bb5119b88f
FIX: only profile owner can see links to watched/tracked/muted topics ( #7083 )
2019-02-28 14:58:49 +01:00
Joffrey JAFFEUX
883a18547e
FIX: shows invite panel on mobile from topic footer buttons ( #7080 )
2019-02-28 14:56:22 +01:00
David Taylor
6296554ed1
DEV: Add additional hook for theme-creator
2019-02-28 10:48:30 +00:00
Vinoth Kannan
0cc636f648
UX: Don't add padding bottom for emojis in composer preview
2019-02-28 15:53:21 +05:30
Maja Komel
97c0fd0909
FIX: styling for resizable image wrapper in editor preview
2019-02-28 10:24:43 +01:00
Sam
06abecdb41
FEATURE: on iPad bluetooth keyboard use ALT-ENTER for post submit
...
Command and Control can not be properly detected via JavaScript so lean on
Alt that can be detected.
2019-02-28 16:41:31 +11:00
Sam
0b86a99c39
FEATURE: allow iPad users to specify they have a physical keyboard
...
Sadly there is no clean way of detecting a keyboard is connected to an iPad
If the keyboard is connected we want to disable all the touch related hacks
on iOS
This allows iPad users to specify they have a keyboard connected. Setting
is per device.
2019-02-28 15:59:44 +11:00
Kris
cafbb3aea7
UX: Use official Facebook logo
2019-02-27 09:52:06 -05:00
Tarek Khalil
986cc8a0fb
FEATURE: Introduce Ignore user ( #7072 )
2019-02-27 14:49:07 +01:00
Joffrey JAFFEUX
5c476f639c
REFACTOR: user-invited-show ( #7078 )
2019-02-27 12:59:57 +01:00
Joffrey JAFFEUX
8ff3fc20a6
REFACTOR: tags-show ( #7079 )
2019-02-27 12:59:39 +01:00
Maja Komel
7d2ea2d4dd
FEATURE: image resizing discoverability ( #6804 )
2019-02-27 11:46:16 +01:00
Dan Ungureanu
f68a7a16a4
FIX: Use field name to name files in theme export. ( #7009 )
2019-02-27 10:45:22 +01:00
Maja Komel
6f427589b2
FIX: make it possible to use backup code everywhere where 2FA required ( #7010 )
2019-02-27 10:37:33 +01:00
Erick Guan
e1d1073273
FIX: use * when apply italics in the editor instead of _ ( #7063 )
2019-02-27 10:36:14 +01:00
Régis Hanol
326d892f5e
Aadd 'secondary_emails' field in users export
...
FIX: escape_comma wasn't working in CSV exports
FIX: group_names field wasn't properly serialized
2019-02-27 10:12:20 +01:00
Kris
ef9b249cd2
UX: More consistent table header styles, removing duplicate styles
2019-02-26 21:40:17 -05:00
Kris
1d4e9b08ad
UX: Don't override unset flair color
2019-02-26 12:49:54 -05:00