a157dfd418
UX: better rejection message when reply via email is too short
2018-08-02 22:43:53 +03:00
fad9c2b971
PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.
2018-07-24 13:51:53 +08:00
3874d40910
Prepare to drop `EmailLog#topic_id`.
2018-07-18 10:22:24 +08:00
21ebb1cd54
FEATURE: Secondary emails support.
2018-07-16 11:09:49 +08:00
28dd7fb562
FEATURE: Create hidden posts for received spam emails ( #6010 )
...
* Add possibility to add hidden posts with PostCreator
* FEATURE: Create hidden posts for received spam emails
Spamchecker usually have 3 results: HAM, SPAM and PROBABLY_SPAM
SPAM gets usually directly rejected and needs no further handling.
HAM is good message and usually gets passed unmodified.
PROBABLY_SPAM gets an additional header to allow further processing.
This change addes processing capabilities for such headers and marks
new posts created as hidden when received via email.
2018-07-05 11:07:46 +02:00
4599cc8435
FIX: PM participants listed inline
2018-06-11 18:14:25 -07:00
f9ab3848ed
FEATURE: support disabling emails for non-staff users
2018-06-07 18:31:08 +05:30
7fc8a36529
DEV: Take 2 Queue jobs in tests by default.
...
On my machine this cuts the time taken to run our test suite
from ~11mins to ~9mins.
2018-05-31 16:23:23 +08:00
56e9ff6853
Revert "DEV: Queue jobs in tests by default."
...
Too risky for now
This reverts commit be28154d3b
2018-05-31 15:34:46 +08:00
be28154d3b
DEV: Queue jobs in tests by default.
2018-05-31 14:45:47 +08:00
fac4bf2f85
ignore emails that are from the reply by email addresses ( #5843 )
2018-05-23 10:04:45 +02:00
86eb3528ec
FEATURE: clearer error message when receiving a reply to an old notification
2018-05-09 18:51:01 +02:00
6b1ff0edd3
FIX: always update bounce score (instead of doing it once per day)
2018-05-09 16:40:52 +02:00
62a8904729
Feature: Include participants at the bottom of PM emails ( #5797 )
...
* Feature: Include participants at the bottom of PM emails
... as undecorated links.
https://meta.discourse.org/t/email-notification-recipients-unclear-when-pm-is-sent-to-multiple-users/26934/13?u=featheredtoast
Fix: missing translation for PM mentions
* display membership count as `group (count)`
2018-05-03 15:50:06 -07:00
ddb092f397
FIX: update mail gem to fix UTF-8 parsing issue
2018-04-25 21:53:37 +02:00
f2d00e5eff
FEATURE: Use Message-ID for detecting email replies to group
...
Ignores the site setting "find_related_post_with_key" and always tries to honor the `In-Reply-To` and `References` header for emails sent to a group.
The senders email address must be included in the `To` or `CC` header of a previous email sent to the group and the `Message-ID` of that email must be included in the current email's `In-Reply-To` or `References` header.
2018-04-05 11:00:38 +02:00
fcd352e089
FIX: Try fixing unparsable email addresses
...
The mail gem returns `UnstructuredField` when it fails to parse email addresses, but the `Receiver` always expects an `AddressList`.
2018-03-27 18:28:54 +02:00
fd33090646
FEATURE: automatically elides gmail quotes
2018-02-26 23:54:02 +01:00
7a13e50aa6
fix build
2018-02-22 11:17:49 +01:00
97e19a7d02
Fix the build
2018-02-21 11:26:41 +01:00
61930e092a
FIX: support incoming emails with just an attachment
2018-02-16 18:14:56 +01:00
9f7ae908d8
Add specs to check email domain whitelist/blacklist for To and Cc
2018-01-10 16:57:26 +01:00
f086d28b30
FIX: Do not validate messages sent to mailing list mirror
2018-01-05 11:21:53 +01:00
e0d73a957d
FEATURE: Allow posting via email to read-only mailing list mirror category
2018-01-05 11:21:53 +01:00
d7cd7e4dc7
FIX: Never mark emails sent to mailing list mirror as auto-generated
2018-01-05 11:21:53 +01:00
ceb7590bcb
FIX: bounced email can contain multiple status codes
2018-01-03 17:59:20 +01:00
16738cfb1b
FEATURE: convert plain text emails to markdown
2017-12-06 01:47:51 +01:00
1a3ab7c02e
ignore some site settings for emails sent to mailinglist mirror category
2017-11-17 15:29:14 +01:00
aea161fabd
suppress rejection email when email was sent to mailinglist mirror category
2017-11-17 15:29:14 +01:00
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
d3baae5365
removes whitespaces and uses scope
2017-11-13 15:23:24 +01:00
5210e3e744
FEATURE: accept incoming email with reply_key mismatch when original email was forwarded
2017-11-12 23:44:22 +01:00
fc6de6863b
WIP
2017-11-12 21:12:34 +01:00
4dc4bc70c8
FIX: ignore_by_title should match case-insensitive
2017-11-12 01:43:18 +01:00
1f14350220
Rename "Blocked" to "Silenced"
2017-11-10 14:10:27 -05:00
be0c7609f1
FIX: validates attachments against current authorized extensions
2017-11-07 19:17:33 +01:00
880d154381
FIX: deleting staged user of rejected email shouldn't delete incoming email
2017-10-31 15:13:23 +01:00
c0bb97b5cb
FIX: delete staged users when the incoming email is rejected
2017-10-11 16:17:01 +02:00
3bdd8f57c1
FIX: invited staged users would sometimes not get notified of replies
2017-10-06 16:37:28 +02:00
7f50380221
FIX: respect email domain whitelist/blacklist when creating staged users
2017-10-03 16:36:08 +02:00
76706f9144
FIX: don't create staged users when incoming email is rejected
...
FIX: don't send subscription mail to new users
2017-10-03 16:36:08 +02:00
31ecb4fecf
FIX: Handle incoming emails without email address in From header ( #5177 )
2017-09-12 22:35:24 +02:00
a7b7fe335f
FIX: allow an admin to click on blank errors ( #5027 )
...
* FIX: allow an admin to click on blank errors
* i18nlize strings
* what would a rails master do?
2017-08-04 20:04:26 +02:00
99527af38a
FIX: show rejected emails with unrecognized errors ( #5026 )
...
Although 407a23663d
2017-08-04 16:20:44 +02:00
88ba052446
secure default for the 'find_related_post_with_key' site setting
2017-08-01 00:03:04 +02:00
c7f76aa554
fix the receiver_spec
2017-07-31 11:29:39 +02:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
045a2abcec
FEATURE: remove the timecop gem
...
We should only have one way of mocking time, misuse of timecop
was causing build stability issues
2017-07-24 12:11:10 -04:00
8ee31d3c85
Re-enable skip tests for `Email::Styles`.
2017-07-24 23:16:54 +09:00
0ab0c82f11
Reenable skipped `Email::Receiver` spec.
2017-07-24 22:27:24 +09:00
640ced004d
FIX: wasn't unfreezing time in email processor spec
2017-07-24 11:01:53 +02:00
407a23663d
FEATURE: send rejection email for unrecognized errors
2017-07-21 18:26:52 +01:00
d2490cbbb8
Test failures for Inline Onebox
2017-07-20 16:01:16 -04:00
d0b027d88d
FEATURE: phase 1 of supporting multiple email addresses
2017-07-20 11:22:27 +09:00
13f3de4bf6
Nuke all `SiteSetting.stubs` from our codebase.
2017-07-07 15:09:14 +09:00
9294826f31
Allow inclusion of elided text from emails when sending to a category… ( #4844 )
...
* Allow inclusion of elided text from emails when sending to a category address
2017-06-29 13:03:14 +09:00
6796de8bf2
FIX: replace site_name with email_prefix in subject when use_site_subject is true
2017-06-21 21:15:49 +05:30
eb9f306e64
FIX: fail to send email notification if post has img tag with no src attribute
2017-06-15 10:36:19 -04:00
602e4d0da4
FIX: Return `nil` when the `reply_key` is missing
2017-06-08 14:28:48 -04:00
9dddb81cf6
FIX: remove memoization on class method used in a job
2017-05-22 23:35:41 +02:00
4fb335f1f0
FIX: don't process the same incoming email more than once
2017-05-18 16:43:07 +02:00
bf322281e3
Improve handling of inlined images in incoming emails
2017-05-03 23:02:02 +02:00
e9bb9a167b
Fix reply-by-mail for 8-bit transfer encodings
...
The mail class seems to handle mails sent with Content-Transfer-Encoding: 8bit
somewhat weirdly: It decodes them (to utf-8), changes the raw source to base64,
and does not modify the Content-Type:charset= header.
This leads to Discourse trying the message encoding (in my example ISO-8859-1)
first, and if that does not contain any unparseable characters, it uses that.
Sadly, in ISO-8859-1, every byte sequence is valid.
Fix this by always trying to decode as UTF-8 first. The probability of someone
using another encoding that cleanly (but wrongly) decodes as UTF-8 should be
fairly low.
2017-04-30 23:30:40 +02:00
0ec15af970
restore the 'incoming_email_prefer_html' site setting
2017-04-27 14:31:11 +02:00
b76674f640
FEATURE: convert incoming emails in HTML to markdown
...
- remove incoming_email_prefer_html site setting
- remove HtmlCleaner class
2017-04-26 16:49:06 +02:00
04016f0dec
Support Ruby 2.4.
2017-04-15 12:29:00 +08:00
1853a4852c
FIX: use email prefix only in subject
2017-03-21 20:29:57 +05:30
ee9d621d9c
FIX: surround the FROM alias with " in order to support the @ character
2017-03-07 23:37:21 +01:00
e634b37f9a
FIX: from field of emails should be including email_site_title or site title settings
2017-02-27 14:23:07 -05:00
82555ca761
FIX: mail threading wasn't working properly in Mac Mail
2017-02-01 23:02:41 +01:00
8fc7420f83
FIX: prevent huge custom emojis in emails
2017-01-30 18:06:48 +01:00
521ced38c5
fix spec for default email title
2017-01-19 14:01:51 -08:00
185dcb2ca1
handle emails with localized headers 😠
2017-01-09 22:59:30 +01:00
495a511862
simplify quote markup in emails
2017-01-02 21:37:01 +05:30
18f400e652
Remove RSpec given.
2016-12-14 10:29:22 +08:00
eb453d0f82
the note in a FWed email should be a whisper only in PM and when the author is member of the group
2016-12-01 18:43:56 +01:00
62763f025c
FIX: wasn't able to parse FROM email in the embedded email
2016-12-01 18:34:47 +01:00
a03287f2ee
FIX: 'In-Reply-To' header should default to topic_message_id
2016-11-28 14:18:02 +01:00
74b6fe8739
FIX: respect RFCs when setting 'In-Reply-To' and 'References' email headers
2016-11-25 23:25:39 +01:00
f8caae0be7
FIX: don't overwrite custom email headers when using mandrill/sparkpost
2016-10-30 11:38:55 +01:00
2a61cc8c88
FIX: email styling with blacklisted iframes
2016-10-21 12:37:03 +02:00
51322a46b3
FEATURE: retry processing incoming emails on rate limit
2016-08-08 22:28:27 +02:00
b08ab829b8
added 'X-Auto-Response-Suppress' email header (props to elijah)
2016-08-03 11:02:07 +02:00
3588780ac3
Don't reject likes by email for closed topics ( #4311 )
2016-07-05 17:33:08 +02:00
e858def372
remove invalid specs
2016-07-04 10:34:26 +10:00
7a1e99dacb
Add some clarifying specs around new-topic-creating emails work
...
Strangers get to create new topics (if the appropriate tickbox is ticked)
but low-TL existing users don't. That might seem a bit backwards, but
the tickbox says 'strangers', not 'everyone'.
2016-06-30 22:24:25 +10:00
20359788dc
Rename `SiteSetting#use_https` to `force_https`.
2016-06-29 15:02:43 +08:00
214f5bff5c
don't send more than 1 reply per day to auto-generated emails
2016-06-28 16:42:05 +02:00
800081f606
FIX: staged users weren't able to reply in restricted categories
2016-06-26 19:25:45 +02:00
852860de66
FEATURE: simpler and friendlier unsubscribe workflow
...
- All unsubscribes go to the exact same page
- You may unsubscribe from watching a category on that page
- You no longer need to be logged in to unsubscribe from a topic
- Simplified footer on emails
2016-06-17 11:28:49 +10:00
dffe50a2e6
new alternative reply by email addresses
2016-06-10 16:14:42 +02:00
99ad251731
different email footer when mailing_list_mode is enabled
2016-06-03 15:48:54 +02:00
a92fd9d701
Add Site Setting to use HTML from incoming email when available. ( #4236 )
2016-05-26 10:13:01 +02:00
c75d58ab21
FEATURE: new 'ignore_by_title' site setting
2016-05-18 23:07:01 +02:00
5f76287b18
FEATURE: cap number of staged users (defaults to 10) created per incoming email
2016-05-16 21:45:34 +02:00
1e57bbf5c8
Lots bounce emails related fixes
...
- Show bounce score on user admin page
- Added reset bounce score button on user admin page
- Only whitelisted email types are sent to emails with high bounce score
- FIX: properly detect bounces even when there is no TO: header in the email
- Don't desactivate a user when reaching the bounce threshold
2016-05-06 19:34:33 +02:00
8e611ec7a1
FEATURE: handle bounced emails
2016-05-02 23:15:32 +02:00
84d4ebd910
use 'reply_by_email_address' setting for handling bounce emails using VERP
2016-04-25 20:06:45 +02:00
4960b62110
FEATURE: new 'block_auto_generated_emails' site setting
2016-04-20 21:29:27 +02:00
7d9f2265b9
FIX: improve support for handling emails coming from screened email addresses
2016-04-18 23:01:54 +02:00
fad017d842
FEATURE: add support for bounce emails
...
We now optionally add a Variable Email Return Path to every email we send.
This allows us to cleanly handle email bounces, which in turn will improve
deliverability.
2016-04-18 17:14:01 +10:00
4d9c81fde7
Merge pull request #4148 from tgxworld/dont_reply_to_emails_that_are_autogenerated
...
FIX: Don't send rejection mailer to bounced emails.
2016-04-13 15:36:14 +02:00
56089c4856
FEATURE: new 'auto_generated_whitelist' site setting
2016-04-11 22:47:34 +02:00
e4980392da
improve receiver specs to account for posts approval
2016-04-11 18:20:26 +02:00
c5794ab0f6
allow magic login route emails even when emails are disabled
2016-04-08 11:20:09 +05:30
5734c7f3f3
FIX: Don't send rejection mailer to bounced emails.
2016-04-07 22:21:17 +08:00
39863953cd
new 'enable_staged_users' site setting
2016-03-23 18:56:03 +01:00
03a1aa0000
SECURITY: only add elided part of email in PM
2016-03-17 23:10:46 +01:00
4a3cb4a000
FIX: use MD5 of the email_string when there's no 'Message-Id'
2016-03-14 18:18:58 +01:00
841cec1bc1
FIX: support emails in with weird encoding
2016-03-11 18:51:53 +01:00
6d84a8a1b3
FIX: don't send out elided message in email notifications
...
UX: improved details tag for elided messages
2016-03-11 17:51:16 +01:00
2747e14b4c
FEATURE: hide elided part of incoming emails behind a [details] tag
2016-03-09 18:51:54 +01:00
622d804d46
FEATURE: Add rejection message on rejected IncomingEmail
...
FIX: Better RateLimit description in rejected IncomingEmail
FEATURE: Send email when hitting a rate limit
2016-03-07 16:56:17 +01:00
be5a54d67d
FEATURE: new 'allow_all_attachments_for_group_messages' site setting
2016-02-29 22:39:24 +01:00
f7432d8ec9
FEATURE: add support for multiple incoming emails for groups & categories
2016-02-24 19:47:58 +01:00
54262cc9b2
FIX: properly handle invalid from header
2016-02-24 17:40:57 +01:00
5415b2666d
FIX: staged users couldn't create new topic in a private category via email
2016-02-22 19:57:53 +01:00
52a6682690
FIX: don't create an EmailLog when we can't send a digest
2016-02-17 17:31:46 +01:00
cad7fc1062
FIX: don't allow blocked user to send emails in
2016-02-11 10:39:57 +01:00
82a75c00c0
UX: change 'Visit Topic' to 'Visit Message' for message notification email
2016-02-09 13:39:10 +05:30
49d1f88f6e
FIX: support incoming emails with no subject
2016-02-01 12:16:15 +01:00
27aaed0aa5
FIX: don't use 'Return-Path' header to determine whether the email was auto generated
2016-02-01 10:21:58 +01:00
46b6c55197
FIX: replace 'discourse_email_parser' with 'email_reply_trimmer' to better trim replies from plain text emails
...
FIX: undefined method `number_to_human_size' when email contains attachments
2016-01-30 01:29:31 +01:00
378b7f964c
Revert "FEATURE (WIP): add max-width and center email notifications"
2016-01-29 11:13:59 +01:00
77167f12ad
move styles to Styles
2016-01-27 19:07:21 -08:00
8d10130c10
test format_notifications
2016-01-27 15:44:49 -08:00
3f09ec2aca
add layout for notifications
2016-01-27 11:27:32 -08:00
4a17cdc1e4
FIX: don't invite users with emails configured as 'incoming' (reply, group our category)
2016-01-20 23:08:27 +01:00
f145310cd5
FIX: associates email replies using both 'In-Reply-To' and 'References' headers
2016-01-20 22:52:08 +01:00
c2c01cdb5d
FIX: username suggester to account for the more relaxed username rules ( closes #3907 )
2016-01-20 15:37:34 +01:00
c7283751a3
Unsubscribe via email
2016-01-20 22:25:25 +13:00
735017dd9f
FIX: don't invite users with the same email as 'reply_be_email_address'
2016-01-19 15:24:34 +01:00
3083657358
FEATURE: better email in support
...
FEATURE: new incoming_email model
FEATURE: infinite scrolling in emails admin
FEATURE: new 'emails:import' rake task
2016-01-19 00:57:55 +01:00
6ceb108946
Add specs for post action guardian
2015-12-30 20:52:36 +01:00
86da47880a
Allow +1 via email
2015-12-30 12:17:45 +01:00
3e923c7a41
FIX: ensure inactive users can't email in
2015-12-21 17:54:02 +01:00
51b2279af0
fix the build
2015-12-16 01:31:19 +01:00
4bb31daa2e
FIX: when getting a reply by email, ensure it's by the same user
2015-12-16 00:43:05 +01:00
02279c41cb
Merge pull request #3918 from techAPJ/better-email-parsing
...
FEATURE: better email reply parsing
2015-12-11 14:51:24 +01:00
1f003e3472
fix inline reply test case
2015-12-11 14:48:42 +05:30
323e3cee22
when creating a staged account, use the display name provided in the email
2015-12-10 23:52:20 +01:00
93d1cc6294
add support for incoming emails in CC/BCC fields
2015-12-10 23:49:16 +01:00
7a8e5a50ff
FEATURE: better email reply parsing
2015-12-09 23:47:01 +05:30
1cde276656
FEATURE: ability to send emails to a group
2015-12-07 17:01:08 +01:00
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
0d54c18c8b
new hidden 'allow_staged_accounts' setting
2015-11-26 18:31:23 +01:00
2196160549
FIX: Allow emails to begin with a quote (but skip it!)
2015-11-18 15:23:10 -05:00
897563a309
FIX: List-ID should not contain space
2015-10-21 00:00:06 +05:30
54d6d24cbf
FIX: timing issue with edits and cook post processing
2015-09-29 18:51:26 +02:00
e3a80936c8
prefer empty href attribute to #
2015-09-08 18:27:20 +02:00
OsamaSayegh
Guo Xiang Tan
Leo McArdle
Patrick Gansterer
Jeff Wong
Arpit Jalan
Ryan Mulligan
Régis Hanol
Gerhard Schlager
Robin Ward
Guo Xiang Tan
Sam Saffron
David Taylor
Neil Lalonde
Claus Strasburger
Jeff Atwood
James Kiesel
Matt Palmer
David McClure
scossar
Andy Waite