84ab825e41
FEATURE: Webhook for user destroyed event ( #6124 )
2018-07-23 13:19:49 +05:30
125126c893
Fix typo.
2018-07-20 07:57:00 +08:00
9b18ee4bba
Improve handling of file params in lograge.
2018-07-19 08:23:59 +08:00
665ade50c6
SECURITY: extra CORS headers should be set on correct host
2018-07-11 09:29:02 +10:00
b97b426d34
Revert "FIX: wrong site origin in message bus header"
...
This reverts commit 93b49a0dd5
2018-07-11 09:26:43 +10:00
93b49a0dd5
FIX: wrong site origin in message bus header
2018-07-10 15:01:03 -04:00
ccc2d94ae8
Update link
...
See https://meta.discourse.org/t/wrong-link-on-manual-admin-creation/90849
2018-06-27 11:38:01 +02:00
5f64fd0a21
DEV: remove exec_sql and replace with mini_sql
...
Introduce new patterns for direct sql that are safe and fast.
MiniSql is not prone to memory bloat that can happen with direct PG usage.
It also has an extremely fast materializer and very a convenient API
- DB.exec(sql, *params) => runs sql returns row count
- DB.query(sql, *params) => runs sql returns usable objects (not a hash)
- DB.query_hash(sql, *params) => runs sql returns an array of hashes
- DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array
- DB.build(sql) => returns a sql builder
See more at: https://github.com/discourse/mini_sql
2018-06-19 16:13:36 +10:00
8a2c5fbebb
Remove unused lines.
2018-06-11 08:44:41 +08:00
2aad91d4a2
PERF: Don't bloat the Sidekiq queue with `Jobs::SendPushNotification`.
2018-05-24 10:04:09 +08:00
6974b7d6a8
FIX: run deferred jobs inline in sidekiq
2018-05-23 12:05:37 +10:00
467d91347a
Missing specs for `Group`, `Tag`, `Category` and `Flag` web hooks.
2018-05-21 17:29:58 +08:00
bf84037f79
FIX: Payload for webhooks should be current as of the time the event was triggered.
...
https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752
2018-05-21 17:29:58 +08:00
2002a7c4ef
FIX: regenerate vapid keys when the public key bytes is blank
2018-05-07 17:01:56 -07:00
91b31860a1
Feature: Push notifications for Android ( #5792 )
...
* Feature: Push notifications for Android
Notification config for desktop and mobile are merged.
Desktop notifications stay as they are for desktop views.
If mobile mode, push notifications are enabled.
Added push notification subscriptions in their own table, rather than through
custom fields.
Notification banner prompts appear for both mobile and desktop when enabled.
2018-05-04 15:31:48 -07:00
26ce930ac6
FIX: remove auth cookie if we see InvalidAccess
2018-04-20 11:21:51 +10:00
1b9a38c5e2
FIX: Incorrect formatter used when logstash formatter is enabled.
2018-04-17 12:07:52 +08:00
a902d5b27f
Replace ActiveSupport::Logger with DiscourseLogstashLogger when enabled.
2018-04-13 12:08:27 +08:00
a16b616861
FEATURE: webhook for flag events
2018-04-13 07:47:58 +05:30
434cbc649f
FEATURE: Webhook for tag events
2018-04-04 17:49:20 +05:30
e04d09d148
Add Process pid to lograge output as well.
2018-04-04 18:31:29 +08:00
746889bbc1
Include hostname in lograge payload.
2018-04-04 18:24:30 +08:00
e7407d0adc
FEATURE: Webhook for group and category events
2018-03-27 11:53:35 +05:30
f7bd05e534
FEATURE: set 'Retry-After' header for 429 responses ( #5659 )
2018-03-13 23:12:41 +08:00
0134e41286
FEATURE: detect when client thinks user is logged on but is not
...
This cleans up an error condition where UI thinks a user is logged on
but the user is not. If this happens user will be prompted to refresh.
2018-03-06 16:49:31 +11:00
66d620f7b1
FEATURE: Trigger topic webhook when topic status is updated.
2018-02-27 11:07:37 +08:00
9d0807224b
Don't enqueue topic webhook unless a post has a topic
2018-02-22 14:34:59 +08:00
ca1a3f37e3
FEATURE: add instrumentation for all external net calls
2018-02-21 15:20:29 +11:00
ce060e2b86
FIX: Server didn't use default_locale as fallback locale
2018-01-25 14:57:41 +01:00
54dc191a91
Update `rails_multisite` to 2.0.1.
2018-01-19 10:19:16 +08:00
442a17bfb2
PERF: bypass omniauth unless in an auth path
2018-01-15 12:44:54 +11:00
ea63abf0f7
bypass mini profiler for locales
...
bypass cdn for now
2018-01-09 11:30:59 +11:00
b205910faa
FIX: allow upto three url redirects in onebox ( #5457 )
2017-12-27 10:30:06 +11:00
6c4ee9d5b5
FEATURE: Trigger user webhook when a user logs in/out.
...
https://meta.discourse.org/t/how-do-you-learn-how-to-build-these-plugins/57946/10?u=tgxworld
2017-12-20 17:47:30 +08:00
7d8cd84fa6
Improve lograge custom payload error handling.
2017-12-12 17:27:40 +08:00
63bdc4056d
More log suppressions for rate limit exceeded
2017-12-11 17:52:57 +11:00
2ff3444568
Rescue from errors when trying to append custom payloads to lograge output.
2017-12-08 08:31:58 +08:00
0693ed10d1
remove logging code for now
2017-12-08 08:36:35 +11:00
58aeaef0c4
FIX: Rescue if default_current_user_provider raised an error
2017-12-08 01:42:55 +05:30
19247f9087
FIX: current_user should be called only if controller have that method
2017-12-07 23:12:34 +05:30
90a55d6f7c
FIX: handle CORS in hijacked requests
2017-12-07 10:31:04 +11:00
6cb2b68b22
`current_username` -> `username`.
2017-12-05 12:29:02 +08:00
dc858ec120
Include `request.remote_ip` and `current_username` in lograge logs.
2017-12-05 11:57:41 +08:00
900dec5bc1
Make logster ignore `Rack::QueryParser::InvalidParameterError` errors.
2017-11-30 15:29:19 +08:00
46f8a6c97d
Fix broken lograge logs.
2017-11-28 14:00:13 +08:00
b907f7d307
Add more metrics to lograge's output if `MethodProfiler` is enabled.
2017-11-25 08:16:40 +08:00
2b8d4508e5
PERF: stop running background work between requests
...
Use a dedicated thread to run Scheduler::Defer
This avoids blocking of a worker during operations that require waiting.
In particular uploads risked blocking a unicorn.
This also add a queue "length" that discourse prometheus consumes.
2017-11-23 15:48:47 +11:00
89d9ffa884
EXPERIMENTAL: Allow logs to be shipped via different methods.
...
See https://github.com/dwbutler/logstash-logger#uri-configuration for
a list of available methods.
2017-11-15 09:11:33 +08:00
0d8e9a88c9
FIX: Disable `rails_multisite` formatter if lograge is enabled.
2017-11-15 09:03:50 +08:00
86e6732f78
FEATURE: update rails multisite
...
always allow /srv/status through even if host does not match
2017-11-09 15:40:56 +11:00
b840971b77
Convert params hash to a query string instead of a hash when logging.
2017-11-08 15:19:45 +08:00
09cee4c315
Don't add time to logs when using logstash formatter.
2017-11-02 14:40:18 +08:00
d888d3c54c
EXPERIMENTAL: Allow Logstash formatter to be enable for lograge logs.
2017-11-01 08:38:06 +08:00
d15068da70
Remove experimental logstash feature.
...
* We'll most likely be extracting it into a plugin.
2017-10-31 10:15:22 +08:00
b8e580b0e0
Set logstash-logger file output to sync.
2017-10-30 20:57:02 +08:00
9112d2da3b
Add timestamp to lograge output.
2017-10-28 00:46:49 +08:00
fba0c9e51e
Continue to log to Rails default log file when LogStashLogger is
...
enabled.
2017-10-28 00:30:11 +08:00
8b12a906c6
Fix incorrect URI for LogstashLogger.
2017-10-27 23:52:36 +08:00
afdd31473d
Add type when shipping logs to logstash.
2017-10-27 23:31:17 +08:00
d487be759c
EXPERIMENTAL: Allow app to Logstash directly.
2017-10-27 22:56:32 +08:00
90d6677d97
EXPERIMENTAL: Allow lograge to be selected as the logging library.
2017-10-27 17:54:45 +08:00
d2ac7a9476
Partially revert 4e89d3f778.
...
* SiteSetting uses DistributedCache which depends on MessageBus.
Therefore, we need to initialize MessageBus first.
2017-10-12 15:15:24 +08:00
23415caecd
Print out backtrace as well.
2017-10-12 14:52:18 +08:00
4e89d3f778
Only refresh site settings once on initialization.
2017-10-12 14:12:18 +08:00
630f7bfba2
Remvoe unused file.
2017-10-12 13:45:00 +08:00
69f56e8745
Remove unused file.
2017-10-11 16:05:41 +08:00
9b4fd0b26b
correct multisite issues with scheduler
2017-10-11 18:46:53 +11:00
475e86d59e
WORKAROUND: Can't reinsert a deleted middleware.
2017-09-25 13:48:59 +08:00
3840c50083
Fix logster not ignoring CSRF warnings.
2017-09-25 13:48:59 +08:00
77d4c4d8dc
Fix all the errors to get our tests green on Rails 5.1.
2017-09-25 13:48:58 +08:00
7d350d0d75
Revert plugin js changes ( #5139 )
...
* Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134 )"
This reverts commit b840170f8d#5103 )"
This reverts commit a14ab48829
2017-09-07 15:15:29 +02:00
a14ab48829
Do not load javascripts for disabled plugins ( #5103 )
...
* Do not load javascript for disabled plugins
* Appease rubocop
2017-09-06 10:06:47 +02:00
9bc3038728
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-02 21:33:56 +09:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
0ba39109a0
FIX: Make `omit_default_port` the global default
2017-06-30 12:43:26 -04:00
7ea288140d
Allow multiple host when restricting Sidekiq queues.
2017-06-19 14:45:51 +09:00
6729f032b0
Typofix in Onebox user_agent
2017-05-24 14:36:02 -04:00
8bc93c0b01
FEATURE: Add custom User-Agent to Discourse Oneboxes
2017-05-24 12:19:36 -04:00
35bb4ae995
FIX: wizard was not showing up if more than 1 system user
2017-05-23 11:09:50 -04:00
4c690f7089
Use `FinalDestination` to ensure public redirects for onebox
2017-05-22 16:42:49 -04:00
e7c2ad41ca
Move discourse dev data out of tmp
...
Fix watch for restart so it works with puma
2017-05-18 11:36:24 -04:00
f028d6cd52
Missed a spot when removing Sidekiq::Statistic.
2017-04-26 15:53:11 +08:00
f499180bb3
Add ENV variable to only allow Sidekiq scheduler to run on a particular host.
2017-04-26 14:13:26 +08:00
a3e8c3cd7b
FEATURE: Native theme support
...
This feature introduces the concept of themes. Themes are an evolution
of site customizations.
Themes introduce two very big conceptual changes:
- A theme may include other "child themes", children can include grand
children and so on.
- A theme may specify a color scheme
The change does away with the idea of "enabled" color schemes.
It also adds a bunch of big niceties like
- You can source a theme from a git repo
- History for themes is much improved
- You can only have a single enabled theme. Themes can be selected by
users, if you opt for it.
On a technical level this change comes with a whole bunch of goodies
- All CSS is now compiled using a custom pipeline that uses libsass
see /lib/stylesheet
- There is a single pipeline for css compilation (in the past we used
one for customizations and another one for the rest of the app
- The stylesheet pipeline is now divorced of sprockets, there is no
reliance on sprockets for CSS bundling
- CSS is generated with source maps everywhere (including themes) this
makes debugging much easier
- Our "live reloader" is smarter and avoid a flash of unstyled content
we run a file watcher in "puma" in dev so you no longer need to run
rake autospec to watch for CSS changes
2017-04-12 10:53:49 -04:00
66a7b0c30b
FIX: Add web hook `DiscourseEvent`s in initializer.
2017-04-12 11:55:49 +08:00
1a7e954e09
FIX: Store custom emojis as uploads.
...
* Depending on a hardcoded directory was a flawed design
which made it impossible to debug when custom emojis go
missing.
2017-03-14 13:07:18 +08:00
0f1495e64e
FIX: also add Discourse-Visible to allowed headers for message bus
2017-03-06 16:00:37 -05:00
f9aae7af6a
FIX: add Discourse-Visible to CORS allowed headers for sites that use a proxy
2017-03-06 14:41:57 -05:00
954d75f81c
FIX: CORS middleware needs to happen earlier than AnonymousCache middleware
2017-03-06 12:25:12 -05:00
1935f624b8
FEATURE: reset active record cache in sidekiq if needed
...
This can happen in multisite environments after restores
2017-02-17 12:09:53 -05:00
ff49f72ad9
FEATURE: per client user tokens
...
Revamped system for managing authentication tokens.
- Every user has 1 token per client (web browser)
- Tokens are rotated every 10 minutes
New system migrates the old tokens to "legacy" tokens,
so users still remain logged on.
Also introduces weekly job to expire old auth tokens.
2017-02-07 09:22:16 -05:00
a898d6a02a
FIX: silence and quiet logger not thread safe
...
This caused info/warning to be consistently missing
in dev mode when using puma
2017-01-31 15:44:46 -05:00
b8441fba27
Merge pull request #4546 from tgxworld/fix_postgresql_failover
...
Fix postgresql failover
2016-11-30 09:36:52 +01:00
3bec128f5f
DEV: add warning if force_https in dev
2016-11-25 11:35:29 +11:00
759feef3f0
FIX: No loggers may have been chained.
2016-11-17 13:52:08 +08:00
9848e26190
FIX: force secure cookies on session if force https is enabled
2016-10-27 15:15:58 +11:00
c03d25f170
FEATURE: Configure Admin Account
...
Adds a "Step 0" to the wizard if the site has no admin accounts where
the user is prompted to finish setting up their admin account from the
list of acceptable email addresses.
Once confirmed, the wizard begins.
2016-10-19 11:27:56 -04:00
596fcfeb58
FIX: Set formatter for original Rails logger.
2016-09-15 23:51:22 +08:00
50379183e1
FIX: allow the Dont-Chunk header for remote message bus access
2016-08-31 12:57:19 +10:00
bb5dc839a0
extend existing log suppression for empty JS errors
2016-08-29 00:47:11 -07:00
6fd3ebb253
don't log any JavaScript "errors" from IE 9
2016-08-29 00:35:01 -07:00
4fe52c8cbe
FEATURE: backend support for pushing notifications to clients
2016-08-26 12:47:10 +10:00
846a08d3c7
FIX: improve error results for message bus failures
2016-08-25 15:39:39 +10:00
dc2dae2cc4
FIX: Logs notice was not displaying the right Date.
2016-08-02 12:40:28 +08:00
0ffe8402a9
FIX: SiteSettings not avaliable in initializers on dev env.
2016-07-04 11:15:29 +08:00
42ce59d257
Partially revert https://github.com/discourse/discourse/commit/09b92dd3 .
2016-07-01 01:28:49 +08:00
8db3ab5f2a
Merge pull request #4292 from tgxworld/rename_use_https_to_force_https
...
Rename `SiteSetting#use_https` to `force_https`.
2016-06-29 15:17:57 +08:00
20359788dc
Rename `SiteSetting#use_https` to `force_https`.
2016-06-29 15:02:43 +08:00
09b92dd345
Bump minimum Ruby version to 2.3.
2016-06-10 11:40:42 +08:00
8b5dfeb18f
ignore a few more common meaningless JS errs
2016-06-09 16:38:46 -07:00
256d7a00e9
Update sprockets. ( #4167 )
...
* Update sass-rails.
* FIX: Tilt dependency has been removed from Ember::Handlebars::Template.
* Update `DiscourseIIFE` to new Sprockets API.
* `Rails.application.assets` returns `nil` in production.
* Move sprockets-rails out of the assets group.
* Pin ember-rails to 0.18.5 which works with Sprockets 3.x.
* Update sprockets to 3.6.0.
* Make `DiscourseSassCompiler` work with Sprockets 3.
* Use `Sass::Rails::SassImporterGlobbing` instead of haxxing our own.
* Moneky patch so that we don't add dependencies for our custom css.
* FIX: Missing class.
* Upgrade ember-handlebars-template.
* FIX: require path needs to share the same root as the folder's path.
* Bump discourse-qunit-rails.
* Update ember-template-compiler.js to 1.12.2.
* `prepend` is private in Ruby 2.0.0.
2016-04-18 10:47:52 +08:00
3e5f2bd1cf
FIX: replace reference to Google_oauth2 with Google during signup
2016-03-29 18:08:55 -04:00
e407ef9d0e
FIX: Also support `nil` values for the site settings
2016-03-24 11:14:17 -04:00
b270e0142b
FIX: If site settings are missing don't do anything
2016-03-24 11:12:54 -04:00
5dc5767851
FIX: Assigning wrong value to variable.
2016-03-21 15:18:31 +08:00
54bdcd9b98
Update to new rate limit Redis config.
2016-03-21 14:00:50 +08:00
1c19548e30
Merge pull request #4094 from fantasticfears/omniauth-config
...
FIX: redirect output omniauth log to Rails logger instead of stdout
2016-03-19 18:03:16 +01:00
7df33ca287
FIX: redirect output omniauth log to Rails logger instead of stdout
2016-03-19 13:17:13 +01:00
40d6f062f7
clarify why block all mobile/tablet for miniprofiler
2016-03-15 16:54:40 -07:00
d052f1746c
add support for other Nexus devices as "mobile"
2016-03-15 16:46:46 -07:00
90fde5053d
FIX: Load Redis patch much earlier.
2016-03-11 17:29:00 +08:00
c07c474575
FEATURE: Master-Slave Redis configuration with fallback and switch over.
2016-03-11 12:18:58 +08:00
b49e0e0f4a
FIX: add path to cookie on subfolder installs
2016-03-07 13:40:21 -05:00
f32f0d6337
Merge pull request #4017 from tgxworld/add_admin_banner_for_logster
...
FEATURE: Admin Banner when Logster logs is getting flooded.
2016-03-02 23:44:56 +08:00
fdd6920ae7
FEATURE: Admin Banner when Logster logs is getting flooded.
2016-03-02 22:03:16 +08:00
b500f35d14
Ignore `ActionController::UnknownHttpMethod` error in logs.
2016-02-24 12:58:23 +08:00
209b022385
PERF: cut down on memory usage allowed to redis
...
This limits the amount of backlog message bus channels can have.
2016-02-04 13:58:38 +11:00
737c606710
FIX: 'cancel_scheduled_job' wasn't working due to sidekiq upgrade
2016-01-13 09:08:26 +01:00
e451d47e84
Revert "PERF: send Content-Length from Rails on all requests"
...
This reverts commit ea0e238ae1
2016-01-08 11:36:32 +11:00
ea0e238ae1
PERF: send Content-Length from Rails on all requests
2016-01-07 21:15:55 +11:00
77f4461c51
we need to bypass this in dev
2015-12-09 16:41:09 +11:00
65edbb609c
Revert "Revert message bus upgrade"
...
This reverts commit 47e718f5b2
2015-12-09 11:48:41 +11:00
47e718f5b2
Revert message bus upgrade
2015-12-09 11:45:11 +11:00
d8795a5345
FIX: missing site id lookup causing message bus cross talk in multisite
2015-12-09 07:55:43 +11:00
2cc95af69b
Revert "REVERT: message bus changes"
...
This reverts commit 4820d5c7b0
2015-12-09 07:36:36 +11:00
4820d5c7b0
REVERT: message bus changes
2015-12-08 15:32:31 -05:00
c866d5b42d
Revert "Revert "PERF: move message bus to the front of the middleware stack""
...
This reverts commit cd1dd18f01
2015-12-08 07:11:28 +11:00
cd1dd18f01
Revert "PERF: move message bus to the front of the middleware stack"
...
I suspect this commit is preventing Sidekiq from running inprocess.
2015-12-07 14:57:23 -05:00
c04bcf8655
PERF: move message bus to the front of the middleware stack
...
Organise all initializers so they are properly ordered and use the same naming scheme
2015-12-07 14:51:24 +11:00
5e93140f85
FEATURE: Can override any translation via an admin interface
2015-11-27 11:35:19 -05:00
e168c5fde3
PERF: Much more performant, multisite aware I18n overrides
2015-11-19 16:36:59 -05:00
1be4b6a8f5
Refresh I18n customizations on change
2015-11-17 16:15:09 -05:00
3720783c1b
Refactor to our own Discourse I18n backend
...
This removes some monkey patches and makes testing easier.
It will also support database backed I18n changes.
2015-11-13 16:35:02 -05:00
08ee367210
FIX: no keepalive tests for rake tasks, shell could be stalling threads
2015-09-29 10:17:56 +10:00
233bf9bc24
Always use locale fallback on server
2015-09-13 17:24:15 +02:00
6119d9fdc0
FIX: Fallbacks for missing interpolation arguments
...
This takes effect when an interpolation is removed from a translation in
a Discourse update.
The I18n::Backend::Fallbacks loops with a catch(:exception), so calling
throw(:exception) will cause it to use the next locale, until it reaches
English which is assumed to be correct.
Also, enable fallbacks in everything except development (#3724 for more
discussion) - we should be able to test this
2015-09-11 09:39:40 -07:00
25fb684565
ensure statistic collection is on
2015-09-03 12:00:19 +10:00
2c59ad3dd3
FIX: favicon update broken when favicon lived on a CDN
2015-08-25 11:54:23 +10:00
d74d5c47ad
FIX: admin not getting updates for topics in secure groups
...
(only where admin is missing explicit permissions)
2015-08-25 09:25:39 +10:00
2203a4147d
add some extra diagnostics
2015-08-19 16:58:25 +10:00
Vinoth Kannan
Guo Xiang Tan
Sam
Neil Lalonde
Dax74
Jeff Wong
Arpit Jalan
Kyle Zhao
scossar
Gerhard Schlager
Vinoth Kannan
David Taylor
Guo Xiang Tan
Robin Ward
Felix Freiberger
Jeff Atwood
Régis Hanol
Erick Guan
Kane York