Commit Graph

8384 Commits

Author SHA1 Message Date
Robin Ward aee12fd6ef Ember Deprecations for Topics 2015-05-11 11:18:37 -04:00
Robin Ward 690b579a96 Fixes some deprecations 2015-05-11 11:18:37 -04:00
Robin Ward 8294205f7c Ember 1.11 broken WIP 2015-05-11 11:18:37 -04:00
Robin Ward b3b4fd21ed Broken WIP 2015-05-11 11:18:37 -04:00
Harm Geerts d9a3e82516 Stop sso login processing after rendering error
This prevents a DoubleRenderError triggered on the redirect_to.
2015-05-11 14:17:32 +02:00
Régis Hanol 1b3f3fa437 Merge pull request #3450 from techAPJ/patch-3
FIX: reply count is off by one
2015-05-11 10:31:25 +02:00
Arpit Jalan fc30b771cf FIX: reply count is off by one 2015-05-11 13:58:53 +05:30
Régis Hanol 4c02be0fb0 Merge pull request #3447 from techAPJ/patch-1
FIX: rss feed should be valid
2015-05-11 10:27:24 +02:00
Régis Hanol 97cc1bf279 Merge pull request #3448 from techAPJ/patch-2
FEATURE: check nofollow setting when showing website
2015-05-11 10:26:07 +02:00
Sam 3d6cfc6421 fix typo 2015-05-11 18:05:18 +10:00
Qasem Hajizadeh 6bd15dd86d Add .rtl for css tags
Im added .rtl to front of tags @SamSaffron
2015-05-11 12:22:30 +04:30
Sam f180aba492 stop random hostname for anon 2015-05-11 17:48:54 +10:00
Arpit Jalan 8366b71176 FEATURE: check nofollow setting when showing website 2015-05-11 13:16:21 +05:30
Arpit Jalan 7a20ed0617 FIX: rss feed should be valid 2015-05-11 10:50:24 +05:30
Sam 2282869f30 fix rtl changing general styles 2015-05-11 12:12:37 +10:00
Luke Granger-Brown 9f9825bb6b FIX: don't send emails to anonymous users
Also changes behaviour of real to not return anonymous users.

This means user counts will no longer include them, and the
mailing list system will ignore them even if they somehow end up
with the feature turned on.
2015-05-11 00:56:34 +01:00
Qasem Hajizadeh b99c3c85aa Update rtl.scss 2015-05-09 18:26:00 +04:30
Jeff Atwood f355579e60 remove transparent outline on topic-progress-wrapper 2015-05-08 15:47:27 -07:00
Arpit Jalan 8b876a3c21 convert open-composer mixin to es6 2015-05-09 01:01:50 +05:30
Robin Ward 4b1145dbb0 Merge pull request #3434 from techAPJ/patch-1
FEATURE: support category/subcategory name in new-topic route
2015-05-08 14:14:20 -04:00
Arpit Jalan 6cc092d54c FEATURE: support category/subcategory name in new-topic route 2015-05-08 23:33:06 +05:30
Neil Lalonde 46606cd818 FIX: missing aria-label on X of share modal 2015-05-07 17:31:36 -04:00
Neil Lalonde ffeab82947 FIX: reset message field of flag form after submitting flag 2015-05-07 17:08:07 -04:00
Allen Hancock 53c85662c6 A red meh icon is less ambiguous than a red-smile
Builds on https://meta.discourse.org/t/why-a-frowny-face-on-admin-version/27895/
2015-05-07 13:44:27 -07:00
Sam b7897d24b1 keep working even if username is blank 2015-05-07 13:52:26 +10:00
Sam 4191d97d48 FIX: missing titles and aria-labels on sharing links 2015-05-07 12:14:12 +10:00
Sam 4f53b85ee2 add aria-label to composer buttons 2015-05-07 12:03:20 +10:00
Sam 0b3ad8a3fd Merge branch 'master' of github.com:discourse/discourse 2015-05-07 11:51:09 +10:00
Sam d676bbc349 handle invalid param gracefully 2015-05-07 11:06:42 +10:00
Sam 8277a586bb usage of raise corrected 2015-05-07 11:00:51 +10:00
Sam 77cc087b13 FIX: proper error message when account created is hit with no session 2015-05-07 11:00:22 +10:00
Régis Hanol 9a96cd9f3b CRUSHED: duplicate key value violates unique constraint 'index_uploads_on_sha1' 2015-05-07 01:00:13 +02:00
Régis Hanol 52c19d74f8 FIX: error when user name was nil 2015-05-06 23:56:34 +02:00
Régis Hanol 033761d2f6 FIX: reset all votes when the # of options changes 2015-05-06 18:52:09 +02:00
Robin Ward edae9d7ad9 FIX: Sometimes `contents` is nil, don't break in that case. 2015-05-06 12:40:24 -04:00
Neil Lalonde a0afaf6d48 tweak subcategories position on mobile categories page 2015-05-06 10:58:30 -04:00
Sam 8dd4aa145c FIX: don't fail if dupe timings are sent in 2015-05-06 17:33:03 +10:00
Sam cd9e499b77 Don't try loading embeds on deleted topics 2015-05-06 16:53:28 +10:00
Sam 46aa7dab80 FEATURE: add aria-label for accessibility 2015-05-06 15:33:50 +10:00
Sam bbd5452b8d Do not alert if we have no topic (eg topic deleted) 2015-05-06 13:25:23 +10:00
Sam c6fe90006e correcly grap name, omit needless query 2015-05-06 12:55:33 +10:00
Sam 376b28b0ed FIX: raise a 404 if click tracker gets no url 2015-05-06 11:27:41 +10:00
Sam 0bbf6354eb FIX: in some cases link was not followable due to click tracker 2015-05-06 11:22:53 +10:00
Sam 6fab03b777 do not alert on deleted posts 2015-05-06 10:44:45 +10:00
Sam 0f53fc8328 correct emergency regeneration in the controller 2015-05-06 07:33:32 +10:00
Sam 2625c3bb9a avoid work if nothing there 2015-05-06 07:12:38 +10:00
Neil Lalonde 72cb784eae UX: mobile categories page is more like desktop categories page 2015-05-05 12:04:18 -04:00
Sam ea670118c1 Add better error handling, correct the location on disk of stylesheet 2015-05-05 23:28:40 +10:00
Erick Guan a48dd1cc28 store the slug as the title is, only sanitize the slug
and prettify code
2015-05-05 18:33:16 +08:00
Erick Guan b772ff6e13 FEATURE: add slug geneartion options 2015-05-05 18:08:30 +08:00
Sam f58d85edea FEATURE: move stylesheet cache out of the uploads directory 2015-05-05 15:50:13 +10:00
Sam 8e372f3616 FEATURE: add op-bookmark class for op-bookmarks 2015-05-05 10:23:17 +10:00
Sam 66423e62dc FIX: don't strip / mangle full quotes 2015-05-05 10:06:48 +10:00
Michael Downey 41a0b16cc6 Fixing map-marker FontAwesome typo
The correct icon is map-marker, not map-maker.
2015-05-04 15:53:10 -04:00
Neil Lalonde 963ebf5963 FIX: if approving a user when must_approve_users is false, don't send an email 2015-05-04 15:30:25 -04:00
Robin Ward 4745eca4ad FIX: Don't abort PurgeInactive if they have posts. Just skip. 2015-05-04 11:37:49 -04:00
Régis Hanol e9ade9c0e1 Merge pull request #3428 from techAPJ/patch-2
UX: show caps lock warning on password reset page
2015-05-04 09:38:02 +02:00
Arpit Jalan f3687b6e56 UX: show caps lock warning on password reset page 2015-05-04 13:01:35 +05:30
Jeff Atwood 9a2d999d5a Merge pull request #3427 from techAPJ/patch-3
FIX: allow site_name to be present in rejection email subject
2015-05-03 23:23:54 -07:00
Sam 539ca73668 avoid N+1 query even if no custom fields exist 2015-05-04 16:12:03 +10:00
Arpit Jalan d9ec6888e1 FIX: allow site_name to be present in rejection email subject 2015-05-04 11:22:54 +05:30
Sam 4dfc1907ac Simplify desktop notifications, only include if mention/reply/pm/link
Include post excerpt in the notification
2015-05-04 13:49:32 +10:00
Sam 803feefd54 MessageBus handles readonly redis now, no need to wrap it 2015-05-04 12:21:00 +10:00
Sam 1c7fa956dc Improve Notification probing 2015-05-04 11:14:03 +10:00
Sam 5623827433 careful checking for a global that is not there 2015-05-04 11:08:52 +10:00
Sam fe34a6acbd Merge pull request #3420 from techAPJ/patch-2
FEATURE: accept category_id as new-topic param to better support subcategory
2015-05-04 10:13:06 +10:00
Sam 9723b77b6d Merge pull request #3422 from riking/notifications-patches
FIX: Don't ask for notification permission until first one
2015-05-04 10:10:23 +10:00
Jens Maier 23cde96a1b Fix: @mention dialect matches too often 2015-05-03 18:30:53 +02:00
riking 6ea2051c4e FIX: Don't ask for notification permission until first one 2015-05-02 12:53:30 -07:00
Jeff Atwood 83b7620cb2 use pencil glyph on edit history dialog 2015-05-02 03:48:37 -07:00
Jeff Atwood 2ead293098 Merge pull request #3419 from techAPJ/patch-1
FIX: include youtube link in embedded comments
2015-05-01 14:54:13 -07:00
Arpit Jalan 480cea7284 FEATURE: accept category_id as new-topic param to better support subcategory 2015-05-01 21:40:28 +05:30
Neil Lalonde 8521ee24b1 FIX: /password-reset route now works when login_required is enabled 2015-05-01 11:14:09 -04:00
Arpit Jalan 23fd16850a FIX: include youtube link in embedded comments 2015-05-01 18:34:45 +05:30
Jens Maier 1a692bee0c Apply fix against nested SUP tags to preview 2015-04-30 23:05:04 +02:00
Arpit Jalan bb99bd8a03 FIX: flagging topic was giving error message 2015-05-01 02:15:06 +05:30
Neil Lalonde 1b250f1e01 FIX: crawler pages and RSS had broken links for sites deployed to a subfolder with relative_url_root 2015-04-30 12:46:26 -04:00
Sam 9e16e03198 FIX: text was impossible to quote on Windows Phone 2015-04-30 15:43:39 +10:00
Robin Ward 16408cee06 Allow Postgres to trigger readonly mode for the site. 2015-04-29 11:49:58 -04:00
Sam d7d93c20d7 Merge pull request #3406 from techAPJ/patch-2
FEATURE: prefill topic title, body and category via URL
2015-04-29 13:46:26 +10:00
Neil Lalonde b2fd69a675 FIX: avatar_template when using relative_url_root 2015-04-28 20:58:46 -04:00
Robin Ward 3252bf1252 FIX: Desktop Notifications break Qunit tests
We should figure out why they can't run without the conditional in a
browser.
2015-04-28 19:24:32 -04:00
Robin Ward 15ea0c4789 Merge pull request #3304 from riking/desktop-notifications
Desktop notifications!
2015-04-28 16:24:02 -04:00
Robin Ward c2f7676370 Support for custom reasons for things being queued for approval 2015-04-28 15:06:47 -04:00
Arpit Jalan cff6e49eb7 FEATURE: prefill topic title, body and category via URL 2015-04-29 00:01:10 +05:30
Régis Hanol 5783e908ea FIX: Erratic behaviour when clicking an attachment link - Take 2 2015-04-28 20:05:41 +02:00
Robin Ward 1e36400021 FIX: Enter to change username was broken 2015-04-28 11:39:10 -04:00
Sam 4eaee8f611 Merge pull request #3377 from scossar/auto-rtl
Auto rtl
2015-04-28 07:58:35 +10:00
Sam 729aaa826b Merge pull request #3404 from techAPJ/patch-1
FEATURE: magic login route for admin when SSO is enabled
2015-04-28 07:47:50 +10:00
Régis Hanol ad3d2269b2 FIX: erratic behaviour when clicking an attachment link 2015-04-27 22:18:52 +02:00
Robin Ward 8c930c97e0 If there are pending posts in a topic, display a message at the bottom 2015-04-27 15:55:10 -04:00
Robin Ward ecafbb0a63 Can delete users via the moderation queue 2015-04-27 15:06:20 -04:00
Robin Ward 3cb4554bbb Can refresh queued posts via button 2015-04-27 13:52:54 -04:00
Neil Lalonde cce8693354 FIX: canonical link tag when using relative_url_root 2015-04-27 13:34:22 -04:00
Arpit Jalan 2932284293 FEATURE: magic login route for admin when SSO is enabled 2015-04-27 22:54:48 +05:30
Robin Ward 19a89bb501 Small hooks for Queued Post version of discourse-akismet 2015-04-27 11:56:07 -04:00
Régis Hanol 151dea4088 FIX: editing a poll/post with a poll wasn't working properly 2015-04-26 00:12:19 +02:00
Robin Ward 151b559e4c FIX: If you delete a user, delete their queued posts as well. 2015-04-24 16:04:44 -04:00
Robin Ward 15dbce5886 Show pending posts count in modal when your posts are enqueued 2015-04-24 15:44:59 -04:00
Robin Ward 3660fe4f60 FIX: When approving/rejecting a post it should delete the user action 2015-04-24 15:25:47 -04:00
Robin Ward 3a6efa25f0 Allow ReadOnly to propogate up to the Ember app via Response Header 2015-04-24 14:37:16 -04:00
Robin Ward 5b3f99aa50 Don't blow up if Redis switches to READONLY 2015-04-24 14:37:16 -04:00
Robin Ward eff921d1ec FIX: Turn that frown upside down! 2015-04-24 11:14:06 -04:00
Robin Ward 2562b61448 `normalize_name` is a better name for this. 2015-04-24 10:35:18 -04:00
Régis Hanol be5a76fbc8 Merge pull request #3394 from scossar/fix-height-on-onebox-image
Fix: size on onebox-avatar
2015-04-24 11:18:26 +02:00
Régis Hanol 80b2935e11 FIX: prevent DOS when fixing avatar in quotes 2015-04-24 11:14:10 +02:00
Simon Cossar def9740d5d Fix size on onebox-avatar 2015-04-23 20:42:27 -07:00
riking 21b915f209 Suggested changes 2015-04-23 18:39:48 -07:00
Neil Lalonde ae028a5bb1 FIX: support for redirects to external url in permalinks table was broken 2015-04-23 16:45:28 -04:00
Robin Ward e17ea2e787 UX: Show a dash if a version string is missing 2015-04-23 14:50:37 -04:00
Régis Hanol a737090442 - FEATURE: revamped poll plugin
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
Robin Ward 9bce812c8f Merge pull request #3388 from Mooash/Adding_ViewActions
Adding ViewAction into email notifications
2015-04-23 10:18:57 -04:00
Will Jordan bbfa5c7df1 Fix `NoMethodError` in TopicEmbed#find_remote
Stop TopicEmbed#find_remote from generating `NoMethodError: undefined method `empty?' for nil:NilClass` exceptions
2015-04-22 16:52:02 -07:00
Mooash b65313d3b9 Adding ViewAction into email notifications
See: https://meta.discourse.org/t/integrate-viewactions-one-click-actions-schemas-into-discourse-emails/27056
2015-04-23 08:40:22 +10:00
Robin Ward 388f51eed7 FIX: Bring email username logic in line with front end 2015-04-22 16:26:57 -04:00
Robin Ward 5c7d6e0a3c FIX: Don't display names on emails if `display_name_on_posts` is false
Note that `enable_names` was always respected.
2015-04-22 16:15:23 -04:00
Robin Ward 839416212e FIX: Category badge was showing before topic loaded 2015-04-22 13:39:04 -04:00
Robin Ward 56cd381ff8 FIX: Loading more was broken on topic list after changing sort order 2015-04-22 12:52:12 -04:00
Robin Ward 53ca51654d FIX: Avoid cookie overflows by truncating the referer we store in flash 2015-04-22 12:41:49 -04:00
Neil Lalonde 85320f919b FEATURE: user list csv includes approved, suspended_at, suspended_till, blocked 2015-04-22 12:40:12 -04:00
Robin Ward afc12da2f9 Merge pull request #3387 from riking/fix-uploaded-onebox
FIX: Local files never oneboxed, onebox requests cache-busted
2015-04-22 10:37:09 -04:00
Sam Saffron 40b22bf367 PERF: improve performance for featured user calculation 2015-04-22 23:54:54 +10:00
riking 3681674ec4 FIX: Don't cache-bust onebox requests 2015-04-21 23:11:25 -07:00
riking a616d9ed1c Fix jshint 2 2015-04-21 21:23:05 -07:00
riking f5630b9791 Fix JSHint errors 2015-04-21 21:10:07 -07:00
riking fdf86143b3 fixup NotificationController 2015-04-21 20:23:30 -07:00
riking f4b0f1dbef a few fixups 2015-04-21 20:23:30 -07:00
riking 8bbead315d Add idle checking, use localStorage for seen notifications 2015-04-21 20:23:30 -07:00
riking da9913359c Convert to file in lib/, rough active tracking 2015-04-21 20:23:29 -07:00
riking 41819838ef Prevent "0 new notifications" 2015-04-21 20:21:56 -07:00
riking 59bdff348c Use Discourse.URL.routeTo 2015-04-21 20:21:56 -07:00
riking 84896bdccf Close the notification after 10 seconds 2015-04-21 20:21:56 -07:00
riking c1528e598f Use unreadCount in title 2015-04-21 20:21:55 -07:00
riking f5e27fe2c8 FEATURE: Desktop notifications 2015-04-21 20:21:52 -07:00
Jeff Atwood 706183f886 hide editor button bar overflow 2015-04-21 17:35:10 -07:00
Robin Ward 5bf8c31af4 Users can see their pending posts 2015-04-21 16:44:47 -04:00
Robin Ward 26693c16ac Don't show the link to "Needs Approval" unless approval is enabled.
Note that any plugin that extends the NewPostMananger to support
enqueuing will enable it.
2015-04-21 13:59:57 -04:00
Robin Ward b2ab95f9c2 Fix an issue with the store hydrating embedded objects 2015-04-21 13:15:40 -04:00
Robin Ward f600ead587 FIX: Don't validate approved posts.
A moderator has already validated them. Otherwise we hit things like
rate limits.
2015-04-21 11:59:35 -04:00
Robin Ward 2cdd967188 Adds support for invisible approval queues, which we'll need for Akismet 2015-04-20 17:19:05 -04:00
Robin Ward 66be9147a0 FIX: You can edit two queued posts simultaneously 2015-04-20 16:49:11 -04:00
Robin Ward 5476723906 Add post date to moderator queue 2015-04-20 16:34:36 -04:00
Robin Ward 2c53a8b7bc Link queued post avatar and username to user profile 2015-04-20 16:18:00 -04:00
Robin Ward 5990ab855b PERF: Move post alerting into async 2015-04-20 13:34:57 -04:00
Robin Ward 6ae58d41a7 PERF: Only refresh the Daily stats hourly, do the others daily. 2015-04-20 12:11:36 -04:00
Neil Lalonde 3071650eb3 FEATURE: when post is too short, suggest using the like button instead 2015-04-20 11:10:56 -04:00
Neil Lalonde a3b6e3cb97 FIX: permalinks redirects with relative_url_root 2015-04-19 23:36:09 -04:00
Sam Saffron 296add56e6 correct letter avatar template 2015-04-20 13:07:12 +10:00
Sam Saffron 6d2e651862 Revert "FIX: Missing letter avatars"
This reverts commit 03943554c6.
2015-04-20 06:41:08 +10:00
Sam 72ab1b9714 Merge pull request #3385 from tancnle/each-key-refactor
Replace Hash#keys.each with Hash#each_key for some perf boost
2015-04-20 06:17:27 +10:00