Sam Saffron
433fa74d87
FIX: ensure consistency of user options
...
Edge case during upgrade can cause accounts registered after migration
prior to restart to have missing user option records
2016-03-17 10:03:56 +11:00
Arpit Jalan
ff12b5bf57
FIX: newly created categories were not showing up
2016-03-14 23:17:02 +05:30
Robin Ward
1006b1ba94
Various Plugin Enhancements and Extension Points
2016-03-11 15:53:37 -05:00
Sam
aa001fcfc4
Merge pull request #4057 from joebuhlig/spec-for-topic-status-update-event
...
Add spec for topic_status_update event
2016-03-10 16:46:59 +11:00
Guo Xiang Tan
ee8be3d1a8
Merge pull request #4059 from gdpelican/feature/disable-mailing-list-mode
...
FEATURE: Add site setting for disabling mailing list mode site wide
2016-03-08 16:27:09 +08:00
James Kiesel
2f00e2179f
Don't use unnecessary stubs; site setting language update
2016-03-08 19:40:16 +13:00
Joe Buhlig
186a9630b7
Added spec for topic status update event
2016-03-07 10:40:06 -06:00
Sam
3e018c2588
FIX: rate limit do/undo on post actions
2016-03-06 09:51:30 +11:00
James Kiesel
54b4fb69db
FEATURE: Add site setting for disabling mailing list mode site wide
2016-03-05 11:08:31 +13:00
Sam Saffron
8b1772ac0f
FIX: if user undos like, and relikes notify
...
FEATURE: roll up likes for notify on all likes
2016-03-04 22:56:27 +11:00
Neil Lalonde
c1aea91d63
FEATURE: More digest email frequency options. Digests can be sent as often as every 30 minutes.
2016-03-02 15:43:47 -05:00
Sam Saffron
c15c483931
PERF: stop rebuilding full directory item table on refresh
2016-03-02 18:23:29 +11:00
Robert Riemann
9c39647cd2
fix: support for hyphens in group name
...
The group mention @ORG-team triggers notifications for the group @ORG. This fix changes the RegExp, so that the group name is correctly extracted.
see: https://meta.discourse.org/t/group-mentions-that-begin-with-the-same-characters-may-be-incorrect/39892/12?u=rriemann
2016-02-23 23:55:31 +01:00
Neil Lalonde
cab5dd09d3
FIX: broken links on admin dashboard in Top Referrers section
2016-02-22 14:31:13 -05:00
Régis Hanol
4d981cec53
FIX: don't try to optimize large PNGs (takes too much time)
2016-02-22 12:57:24 +01:00
Sam
f18f6dc31f
correct spec to stop checking for empty category suppression
2016-02-19 17:43:26 +11:00
Sam
f0e942f647
PERF: move 3 more option columns out of the user table
2016-02-18 16:57:22 +11:00
Sam
3829c78526
PERF: shift most user options out of the user table
...
As it stands we load up user records quite frequently on the topic pages,
this in turn pulls all the columns for the users being selected, just to
discard them after they are loaded
New structure keeps all options in a discrete table, this is better organised
and allows us to easily add more column without worrying about bloating the
user table
2016-02-17 18:08:25 +11:00
Régis Hanol
63b9d1c645
FIX: sends an email notifcation when a user's post is linked
2016-02-16 18:29:23 +01:00
Sam Saffron
8e9a8472f4
FEATURE: don't move muted messages back into inbox
2016-02-15 10:56:39 +11:00
Arpit Jalan
8a7868be07
FIX: validate user website
2016-02-06 02:19:48 +05:30
Régis Hanol
2d170712d7
new 'private_email_time_window_seconds' site setting
2016-02-04 17:22:16 +01:00
Régis Hanol
12051f79a8
FIX: don't send empty email notifications for small_actions
2016-02-01 19:12:10 +01:00
Régis Hanol
ce8c2d34d7
FIX: add a 20 seconds grace period before sending a notification about a PM
2016-02-01 10:14:30 +01:00
Robin Ward
617dc42cd9
Merge pull request #3975 from techAPJ/category-user
...
FIX: changing topic from one watched category to another watched category makes topic 'new' again
2016-01-28 10:53:29 -05:00
Sam Saffron
b25e505fb7
SECURITY: user summary could show topic links you have no permissions to
2016-01-28 11:12:12 +11:00
Sam Saffron
a764cc3a42
FEATURE: by default users track a group (as opposed to watch)
...
FEATURE: a rollup counting number of messages in the group inbox to tracking users
2016-01-27 21:38:33 +11:00
Sam
1bb485fca5
FIX: when a user got multiple replies to a topic, emails were missing
2016-01-27 12:20:08 +11:00
Arpit Jalan
d0719aed24
FIX: changing topic from one watched category to another watched category makes topic 'new' again
2016-01-26 01:28:01 +05:30
Arpit Jalan
1cee914565
FEATURE: make top criteria formula multipliers controlled by site
...
setting
2016-01-21 10:30:06 +05:30
Sam Saffron
7303f8f309
FEATURE: first pass at user summary page
2016-01-20 15:14:25 +11:00
Régis Hanol
522e0dc9ca
Merge pull request #3964 from keepcosmos/add-s3-region
...
Add new s3 region
2016-01-19 09:16:48 +01:00
Sam
665fc44741
FIX: message_archived? not set correctly for groups
2016-01-19 18:35:46 +11:00
Régis Hanol
61cc776fdd
FIX: only send email notifications for regular and whisper type of posts
2016-01-19 01:39:57 +01:00
keepcosmos
c53b4ae66d
add s3 region
2016-01-18 22:50:15 +09:00
Régis Hanol
96aa5b865f
FIX: mentions regex server-side (ie. don't count email addresses)
2016-01-12 09:53:09 +01:00
Robin Ward
2a84db73b5
Support IP addresses for embeddable hosts
2016-01-11 11:06:32 -05:00
Régis Hanol
98c0fac461
FEATURE: add small action post when adding/removing users in messages
2016-01-11 12:42:06 +01:00
Arpit Jalan
97e4f7f6d3
Enums that are used in tables need to be stable
2016-01-08 20:43:11 +05:30
Guo Xiang Tan
c1dbf5c1c4
FEATURE: Autolinking to category using hashtags.
2016-01-05 00:12:24 +08:00
Neil Lalonde
007326d3bd
FIX: hidden posts that are edited by the author and unhidden could not be flagged by the same users again
2015-12-29 16:59:36 -05:00
Neil Lalonde
98eee2b5de
FEATURE: when all posts in a topic are moved, close the topic
2015-12-29 16:01:55 -05:00
Neil Lalonde
c3e81dba68
FIX: setting tl3_min_likes_received too high can make it impossible to be promoted to tl3. Cap the min number of days over which those likes must be received.
2015-12-29 12:59:59 -05:00
Arpit Jalan
f40249faad
FEATURE: make trust level 3 time period admin setting
2015-12-22 23:26:19 +05:30
Guo Xiang Tan
cca0896b9e
FIX: Update all does not trigger callbacks.
2015-12-17 00:07:04 +08:00
Arpit Jalan
e52852dd0f
FIX: Autoclose message was not correct when immediate
...
FEATURE: Warn when setting auto-close for right now
2015-12-08 18:16:48 +05:30
Régis Hanol
578f606a1a
add 'incoming_email' to groups
2015-12-07 12:39:28 +01:00
Andy Waite
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
Sam
ad3dd161e7
FEATURE: first class group mentions built in
...
If you allow a group to be mentioned it can be mentioned with the @ symbol.
Keep in mind as a safety mechanism max_users_notified_per_group_mention is set to 100
2015-11-30 17:08:43 +11:00
Régis Hanol
914b854d92
send invite & message notification emails immediately
2015-11-27 19:09:35 +01:00
Robin Ward
5e93140f85
FEATURE: Can override any translation via an admin interface
2015-11-27 11:35:19 -05:00
Arpit Jalan
6354324f2f
FIX: validate automatic membership email domains
2015-11-27 12:35:33 +05:30
Sam
43d63367fd
PERF: stop loading handlebars and ember compilers in prod
...
(this removes a nice 50K from our initial payload and saves memory)
Also fixes invalid HTML automatically if added to HEAD or /BODY
2015-11-27 11:59:01 +11:00
Régis Hanol
0d54c18c8b
new hidden 'allow_staged_accounts' setting
2015-11-26 18:31:23 +01:00
Robin Ward
d65ec1af2e
Rename `ninja_edit_window` to `editing_grace_period` :'(
2015-11-24 14:28:42 -05:00
Sam
88f1a8f0b1
Merge pull request #3821 from mpalmer/letter-avatar-proxy
...
Proxy letter avatars by default
2015-11-19 20:02:16 +11:00
Régis Hanol
85580cd243
fix user_search spec
2015-11-18 21:08:50 +01:00
Régis Hanol
ff10eb32a6
don't return staged users in mentions
2015-11-18 20:57:49 +01:00
Régis Hanol
92ba6125c4
FEATURE: new 'automatically_unpin_topics' user preference
2015-11-17 18:21:40 +01:00
Sam Saffron
448a1413d3
left over specs
2015-11-10 00:56:57 +11:00
Sam Saffron
6dd4bc7d57
FEATURE: support group owner, capable of controlling group membership
...
Group owners are regular users that can add or remove users to a group
The Admin UX allows admins to appoint group owners
The public group UX will display group owners first and unlock UI to
add and remove members
Group owners can only be appointed on non automatic groups
Group owners may not appoint another group owner
2015-11-10 00:56:57 +11:00
Sam Saffron
ffa523a543
FIX: when moving posts, retain creator and date from OP
2015-11-07 15:17:47 +11:00
Matt Palmer
c09f345cff
Proxy letter avatars by default
...
On sites that don't otherwise configure an avatar fallback, Discourse will
now tell the client to get its letter avatars from a location which nginx
proxies to the centralised `avatars.discourse.org` service. This alleviates
privacy concerns, whilst still providing some degree of performance benefit
(no need for every site to delay avatar response by 300ms for image
rendering).
It is still possible to gain the benefits of global image caching and the
lower latency of requesting directly from a CDN, by explicitly changing the
`external_system_avatars_url` site setting to
`https://avatars.discourse.org/letter/{first_letter}/{color}/{size}.png `.
2015-11-06 14:13:44 +11:00
kerryliu
b7803fc68e
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers
2015-11-05 18:51:26 -08:00
James Kiesel
2fc52e26a6
Optimize all_allowed_users query
2015-10-29 19:39:30 +02:00
Arpit Jalan
a439500bac
FIX: do not mark post as spam if the previous flag was disagreed
2015-10-17 01:30:53 +05:30
Régis Hanol
de344bcd7e
Merge pull request #3854 from tgxworld/fix_transactional_race_condition
...
FIX: Race condition when wrapping `PostCreator#create` in a transaction.
2015-10-15 11:07:20 +02:00
Guo Xiang Tan
600e42c2ba
FIX: Race condition when wrapping `PostCreator#create` in a transaction.
2015-10-15 14:42:40 +08:00
Arpit Jalan
b60bceba36
fix the build
2015-10-14 19:20:30 +05:30
Sam
6f43b575a8
FEATURE: no need to cap new and unread together anymore
...
- leave unread alone
- cap new at 500 per site, with a site setting
2015-10-01 17:17:15 +10:00
Sam
6c37b26b24
Correct site spec
2015-09-28 16:50:24 +10:00
Robin Ward
43c7320f55
FIX: Allow really long links to work
2015-09-25 14:07:20 -04:00
Sam
ffb8cb8cac
FEATURE: remove dependency of Redcarpet
...
PERF: cache fancy_title in topics table
New pure ruby implementation is far more flexible and easier to amend.
2015-09-24 13:37:53 +10:00
Neil Lalonde
5ca26a7707
FEATURE: add site setting use_admin_ip_whitelist to enable/disable the whitelisting of admins by IP address
2015-09-23 12:15:08 -04:00
Régis Hanol
36309e50cc
Merge pull request #3767 from tgxworld/track_user_profile_views
...
Track user profile views
2015-09-23 11:38:18 +02:00
Régis Hanol
1aad58b642
Merge pull request #3781 from tgxworld/feature_log_category_settings
...
Feature log category settings
2015-09-23 11:34:08 +02:00
Sam
3853e3cfdc
PERF: omit 2 queries on every full page load
2015-09-23 16:47:17 +10:00
Sam
613761d1cd
FEATURE: upgrade to Rails 4.2.4
2015-09-23 15:24:30 +10:00
Régis Hanol
4f7140fb32
FIX: properly filter whispers in user stream
2015-09-22 00:50:52 +02:00
Neil Lalonde
2ae032c9b0
FIX: categories page would sometimes show no topics, even if there are some visible topics to show
2015-09-21 18:13:14 -04:00
Régis Hanol
fe656fb04d
FIX: select appropriate period when redirecting to top
2015-09-21 20:28:20 +02:00
Guo Xiang Tan
f39b9124b6
FEATURE: Log staff actions for Category changes.
2015-09-18 10:53:08 +08:00
Guo Xiang Tan
7acc93b2a0
FEATURE: Track user profile views.
2015-09-16 14:48:31 +08:00
Sam
83efde79f0
specs to account for new default letter avatar location
2015-09-15 13:25:15 +10:00
Régis Hanol
b9a9a91335
FIX: couldn't set 'never' for the default email digest frequency setting
2015-09-14 10:36:25 +02:00
Robin Ward
5af0f5f80e
FEATURE: Whisper posts
2015-09-11 14:05:21 -04:00
Robin Ward
b6343b1e10
Merge pull request #3697 from riking/patch-6
...
FEATURE: Allow plugins to add admin dashboard warnings
2015-09-08 16:49:58 -04:00
Sam
335be272ff
FEATURE: implement capping of new/unread
...
We cap new and unread at 2/5th of SiteSetting.max_tracked_new_unread
This dynamic capping is applied under 2 conditions:
1. New capping is applied once every 15 minutes in the periodical job, this effectively ensures that usually even super active sites are capped at 200 new items
2. Unread capping is applied if a user hits max_tracked_new_unread,
meaning if new + unread == 500, we defer a job that runs within 15 minutes that will cap user at 200 unread
This logic ensures that at worst case a user gets "bad" numbers for 15 minutes and then the system goes ahead and fixes itself up
2015-09-07 12:03:17 +10:00
Régis Hanol
5984b62347
FIX: ensure we remove 'category_users' records when a user is deleted
2015-09-02 20:43:15 +02:00
Sam
262f561a87
FEATURE: relax username rules to allow - and . and leading _
...
This relaxes our very strict username rules to allow for some long asked for requests
- leading _ is now allowed
- . is allowed except for trailing char and confusing extensions like .gif .json
- dash (-) is now permitted
2015-09-02 12:13:44 +10:00
Neil Lalonde
1bd0f5b015
FEATURE: group can grant a trust level when a user is added
2015-09-01 16:52:12 -04:00
Kane York
65790452d8
Clean up the test checks when done
2015-09-01 13:32:35 -07:00
Arpit Jalan
4e5228dc9e
FIX: don't send notification emails to deactivated user
2015-08-31 12:35:12 +05:30
Kane York
3cbfc45bf6
FEATURE: Allow plugins to add admin dashboard warnings
2015-08-25 17:20:14 -07:00
Régis Hanol
bef80633b1
FEATURE: global admin override of most of the user preferences
2015-08-21 20:39:21 +02:00
Robin Ward
d1c69189f3
FEATURE: Can edit category/host relationships for embedding
2015-08-20 15:56:04 -04:00
Régis Hanol
9ae9aed010
FIX: change **default** notification state when a topic is recategorized within 5 days of creation
2015-08-19 22:40:20 +02:00
Sam
e82f892c2d
FIX: allow global settings to include keys that have numbers in them
2015-08-14 17:01:21 +10:00
Sam
a3c6cd7b38
FIX: handle link tracking correctly for cdn based urls
...
(usually attachments)
2015-08-05 12:15:08 +10:00
Sam
54b780439d
FIX: CDN should always be whitelisted correctly
2015-08-05 11:49:11 +10:00
Sam
7b8b96446e
FEATURE: track statistics around post creation
...
- how long were people typing?
- how long was composer open?
- how many drafts were created?
- correct, draft saved to go away after you continue typing
store in Post.find(xyz).post_stat
2015-08-03 14:29:15 +10:00
Robin Ward
bb93a345eb
UX: Use smaller messages for moderator actions.
2015-07-27 10:09:21 -04:00
Sam
3b61b098ab
PERF: optimise original query instead of huge rewrite
...
better perf for all cases
2015-07-21 21:53:54 +10:00
Sam
4491813d22
Revert "Revert "PERF: optimise query that gathers topic tracking state""
...
This reverts commit 909be09f1a
.
2015-07-21 21:48:07 +10:00
Sam
909be09f1a
Revert "PERF: optimise query that gathers topic tracking state"
...
This reverts commit 343e417a55
.
2015-07-21 17:35:50 +10:00
Sam
343e417a55
PERF: optimise query that gathers topic tracking state
...
(this query runs on the front page to figure out new and unread topics)
2015-07-21 17:14:30 +10:00
Sam
e3d6c476f5
Merge pull request #3593 from tgxworld/cache_results_on_about_page
...
Cache results on about page
2015-07-21 10:04:51 +10:00
Guo Xiang Tan
b0ea6764e0
PERF: Cache About#stats.
2015-07-20 22:45:05 +08:00
Régis Hanol
b0802abae2
FIX: crop & optimize user background profile/card images
2015-07-15 17:15:43 +02:00
Sam
b772d96f7a
FEATURE: permalink normalization
...
Optionally allow admins to apply regex based normalization
to permalinks prior to matching.
This allows us to drop query string, or cleanly ignore slugs, etc.
2015-07-15 15:34:25 +10:00
Arpit Jalan
e0c9054748
FEATURE: invite page tabs
2015-07-13 09:42:51 +05:30
Neil Lalonde
782dd13e78
FEATURE: track user visits on mobile and display on admin dashboard in a new Mobile section
2015-07-07 14:06:42 -04:00
Neil Lalonde
00e1659a57
remove some intermittently failing report specs. they aren't worth the cost of maintaining them.
2015-07-06 15:01:43 -04:00
Neil Lalonde
8c84e60df6
FIX: application request numbers for prev 30 day period was for current 30 day period minus today, not previous 30 days
2015-07-06 15:01:43 -04:00
Arpit Jalan
03665e8466
FIX: mark user as approved if an invite is already present
2015-06-26 01:57:29 +05:30
Régis Hanol
80f258e51c
FIX: don't count mentions in oneboxes
2015-06-24 11:44:58 +02:00
Sam
9f88d6e252
fix regression in visible notification detection
2015-06-23 06:14:22 +10:00
Sam
5eabf01c29
FIX: don't allow storage of post timings batch larger than 60 secs
2015-06-19 10:35:55 +10:00
Neil Lalonde
611b5f996e
FIX: unpinned topics shouldn't remain pinned on categories page
2015-06-10 14:36:55 -04:00
Robin Ward
7b6d6b76eb
FEATURE: Multiple embeddable hosts
...
- Also refactors two site settings components into one, with tests
2015-06-09 13:25:43 -04:00
Arpit Jalan
545f19500d
FIX: when sending private message emails do not check email_direct setting
2015-06-09 13:05:26 +05:30
Sam Saffron
feeb509a97
SECURITY: expire all existing email tokens on password reset
2015-06-06 03:50:06 +10:00
Sam Saffron
4171eb758c
SECURITY: expire all existing sessions if user changes passwords
2015-06-06 03:09:19 +10:00
Arpit Jalan
b33654ac31
Remove site setting stubbing (Round 1)
2015-06-03 15:44:00 +05:30
Arpit Jalan
725861f344
FIX: move draft cleanup to the dedicated method and add test
2015-06-03 14:35:54 +05:30
Sam Saffron
40882a9576
add another test
2015-06-02 20:28:33 +10:00
Sam Saffron
0fd1974838
FIX: leaving around useless drafts after posting
2015-06-02 20:28:33 +10:00
Sam Saffron
d459cb95dc
FIX: when advancing draft sequence remove old drafts
2015-06-02 20:28:33 +10:00
Régis Hanol
64e73e98fb
FIX: allow the cooked_post_processor to download external uploads
2015-06-01 20:08:41 +02:00
Sam Saffron
97f03e699d
FIX: mixed local s3 store missing avatars
2015-06-01 11:17:42 +10:00
Régis Hanol
acafa491b2
user avatar urls/templates refactor
2015-05-29 18:51:17 +02:00
Régis Hanol
5a143c0c6e
storage engines refactor
2015-05-29 18:39:47 +02:00
Régis Hanol
0aa552cf61
remove fragile assertion
2015-05-29 16:53:27 +02:00
Neil Lalonde
ea8cf1a208
FIX: topic auto-close uses the client's time zone
2015-05-27 18:01:46 -04:00
Sam
147ea002f7
FIX: allow handling for avatars that are not in the set of "resized sizes"
2015-05-26 15:41:50 +10:00
Sam
eeda367e70
FIX: should be able to serve optimized image from local if its ... local...
2015-05-26 12:32:52 +10:00
Régis Hanol
bb0c2813ac
FEATURE: generate (avatar) thumbnails in a background task
...
FIX: keep the "uploading..." indicator until the server replies via the MessageBus
FIX: text was disapearing when uploading an avatar
PERF: always use a region for S3 (defaults to 'us-east-1')
FEATURE: ApplyCDN middleware when using S3
FIX: use the same pattern to store files on S3 and locally
PERF: keep a local cache of uploads when generating thumbnails
FEATURE: migrate_to_s3 rake task
2015-05-25 17:59:00 +02:00
Paul Kaplan
1c926d22c6
Correctly parse `require_activation` field of SSO
2015-05-21 16:50:54 -05:00
Paul Kaplan
1c34341f31
Replace site setting with a payload attribute
2015-05-19 11:16:02 -05:00
Paul Kaplan
4c26c4d9bc
Add a SiteSetting to not trust sso emails by default
2015-05-15 12:15:06 -05:00
Sam
e074651fdc
PERF: refactor user search so works more efficiently
...
Stop scanning entire user table
2015-05-14 14:38:47 +10:00
Sam
e6f73a1c80
PERF: optimise front page category security lookup query
2015-05-14 12:19:22 +10:00
Régis Hanol
bb29bff5d8
Merge pull request #3463 from techAPJ/patch-2
...
FIX: match subdomain with email domain blacklist
2015-05-13 17:56:54 +02:00
Arpit Jalan
220b9c5abe
FIX: match subdomain with email domain blacklist
2015-05-13 21:02:02 +05:30
Régis Hanol
d90e0fe66b
Merge pull request #3460 from techAPJ/patch-3
...
FIX: rate limit topic invitations
2015-05-13 12:55:20 +02:00
Arpit Jalan
4324a157e0
FIX: rate limit topic invitations
2015-05-13 14:44:37 +05:30
Sam
51d82fc25d
PERF: Active Record #pluck is twice faster
...
PERF: SqlBuilder bypasses AR converters and uses PG directly
2015-05-13 16:46:17 +10:00
Sam
5ef641126f
remove s3 deprecation warning, we will continue to support it
2015-05-12 08:27:25 +10:00
Sam
0f53fc8328
correct emergency regeneration in the controller
2015-05-06 07:33:32 +10:00
Erick Guan
a48dd1cc28
store the slug as the title is, only sanitize the slug
...
and prettify code
2015-05-05 18:33:16 +08:00
Erick Guan
b772ff6e13
FEATURE: add slug geneartion options
2015-05-05 18:08:30 +08:00
Sam
f58d85edea
FEATURE: move stylesheet cache out of the uploads directory
2015-05-05 15:50:13 +10:00
Neil Lalonde
963ebf5963
FIX: if approving a user when must_approve_users is false, don't send an email
2015-05-04 15:30:25 -04:00
Sam
803feefd54
MessageBus handles readonly redis now, no need to wrap it
2015-05-04 12:21:00 +10:00
Arthur Neves
b8cbe51026
Convert specs to RSpec 2.99.2 syntax with Transpec
...
This conversion is done by Transpec 3.1.0 with the following command:
transpec
* 424 conversions
from: obj.should
to: expect(obj).to
* 325 conversions
from: == expected
to: eq(expected)
* 38 conversions
from: obj.should_not
to: expect(obj).not_to
* 15 conversions
from: =~ /pattern/
to: match(/pattern/)
* 9 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 5 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 4 conversions
from: lambda { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should_not
to: expect { }.not_to
* 1 conversion
from: === expected
to: be === expected
* 1 conversion
from: =~ [1, 2]
to: match_array([1, 2])
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2015-04-25 11:18:35 -04:00
Robin Ward
151b559e4c
FIX: If you delete a user, delete their queued posts as well.
2015-04-24 16:04:44 -04:00
Robin Ward
3660fe4f60
FIX: When approving/rejecting a post it should delete the user action
2015-04-24 15:25:47 -04:00
Robin Ward
5b3f99aa50
Don't blow up if Redis switches to READONLY
2015-04-24 14:37:16 -04:00
Régis Hanol
a737090442
- FEATURE: revamped poll plugin
...
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
Robin Ward
f600ead587
FIX: Don't validate approved posts.
...
A moderator has already validated them. Otherwise we hit things like
rate limits.
2015-04-21 11:59:35 -04:00
Robin Ward
2cdd967188
Adds support for invisible approval queues, which we'll need for Akismet
2015-04-20 17:19:05 -04:00
Sam Saffron
296add56e6
correct letter avatar template
2015-04-20 13:07:12 +10:00
Sam
51b747346e
PREF: speed up grabbing unread counts
2015-04-17 16:01:20 +10:00
Sam
832cb9fdc3
FIX: admin check missing from topic tracking state
...
FIX: handle muted categories correctly
2015-04-17 14:03:08 +10:00
Sam
4387e05162
PERF: speed up query
2015-04-16 17:29:37 +10:00
Sam
a5b25ad2af
FEATURE: scale up likes per day as users increase trust level
...
tl2 = 1.5 times the likes
tl3 = 2 times the likes
tl4 = 3 times the likes
configurable via tl[234]_additional_likes_per_day_multiplier site setting
2015-04-16 09:44:30 +10:00
Robin Ward
d2ed64751e
UX: Show category badge on enqueued posts
2015-04-15 15:29:37 -04:00
Robin Ward
9ffec28076
Allow posts in any queue to support topic/post attributes
2015-04-15 14:54:37 -04:00
Robin Ward
0c233e4e25
Interface is wired up for Approving/Rejecting posts
2015-04-15 14:54:37 -04:00
Robin Ward
a5ee45ccbe
`PostEnqueuer` object to handle validation of enqueued posts
2015-04-15 14:54:36 -04:00
Robin Ward
8ba6a45cd7
Post Queue model to enqueue creation of posts
2015-04-15 14:54:35 -04:00
Robin Ward
eaf5d21c41
Don't store post timings that are greater than the account lifetime
2015-04-14 11:49:44 -04:00
Ed Gibbs
5650428052
FIX: Sort page views report records
...
Adding a sort ascending by date to the page views report.
2015-04-12 10:46:13 -07:00
Sam
75890aed26
FEATURE: allow admins to choose a group as a primary group
...
FEATURE: allow admins to set a default title for a group
2015-04-10 12:17:28 +10:00
Régis Hanol
0e1c4a0a44
Merge pull request #3313 from techAPJ/patch-1
...
FEATURE: invite existing user to a topic
2015-04-03 11:41:10 +02:00
Arpit Jalan
8c2d7dcaac
FEATURE: invite existing user to a topic
2015-04-03 15:00:04 +05:30
Régis Hanol
682656fa6c
FIX: only redirect to whitelisted hostnames
2015-04-01 22:59:25 +02:00
Régis Hanol
0f4a4651a9
FIX: youtube preview video title link doesn't work
2015-04-01 18:23:27 +02:00
Régis Hanol
eec1921ba9
FIX: notifications inconsistencies + never notify system user
2015-04-01 11:55:59 +02:00
Sam
05737effef
FIX: stop stripping dots from SSO names
...
This could upset Louis C.K.
2015-03-27 10:25:51 +11:00
Sam
0c287d7d6b
ensure usernames do not keep cycling
2015-03-27 10:04:16 +11:00
Sam
4566a1e30a
FIX: sso override code not triggered when attaching to existing user
2015-03-27 09:39:35 +11:00
Sam
5aa1272f05
clean up first day user definition and object model
2015-03-26 16:48:36 +11:00
Sam
9834d11503
Staff and TL2 up are immune to newuser checks and not considered new users
2015-03-26 16:04:46 +11:00
Sam
cfa511e35d
FIX: correctly mute likers
...
FEATURE: disallow all muting of staff
2015-03-26 12:08:04 +11:00
Arpit Jalan
fb0e7dc0b2
FIX: do not delete already redeemed invite
2015-03-25 23:30:09 +05:30
Régis Hanol
90de61ee3d
S3 deprecation warning
2015-03-25 18:34:07 +01:00
Arpit Jalan
4862a93804
FIX: delete duplicate invites
2015-03-25 22:43:41 +05:30
Sam
853c91d7d0
Merge pull request #3289 from fullfatthings/suppress_sso_welcome_emails
...
Add an sso option to suppress welcome emails
2015-03-23 10:36:58 +11:00
Robin Ward
3c0fee1786
Fixes broken spec
2015-03-20 13:24:03 -04:00
Dan Singerman
e8648350eb
Add an sso option to suppress welcome emails
...
As discussed here: https://meta.discourse.org/t/create-new-sso-users-without-sending-welcome-emails/24894
2015-03-20 17:04:52 +00:00
Régis Hanol
5084e2bdf1
Merge pull request #3284 from techAPJ/patch-1
...
FEATURE: new site setting min_first_post_length
2015-03-19 19:55:27 +01:00
Arpit Jalan
b706307ac7
FEATURE: new site setting min_first_post_length
2015-03-20 00:20:38 +05:30
Robin Ward
3d2d224312
FEATURE: User Directory, with sorting and time period filter
2015-03-18 15:20:34 -04:00
Régis Hanol
df7c38dd51
FIX: don't add an automated message when *a* moderator already replied (as opposed to *the* moderator)
2015-03-16 12:02:34 +01:00
Régis Hanol
3a40875e0b
Merge pull request #3247 from jmay/group-manager-invites
...
group manager can issue invitations from restricted topics
2015-03-16 09:53:04 +01:00
Régis Hanol
afd2417945
FEATURE: new 'auto_respond_to_flag_actions' site setting
2015-03-11 19:29:09 +01:00
Régis Hanol
c8631a7a8b
FIX: auto-message shouldn't generate notifications
2015-03-11 19:07:17 +01:00
Régis Hanol
6cd4330335
FIX: show all deleted posts
2015-03-11 18:07:47 +01:00
Neil Lalonde
608647d02f
FEATURE: Anonymize User. A way to remove a user but keep their topics and posts.
2015-03-10 11:59:08 -04:00
Sam
79a17d5c22
FIX: discourse.conf not parsing out comments correctly
2015-03-09 13:14:29 +11:00
Robin Ward
c4fa75918b
FIX: If a category of a topic changed, watching/tracking didn't kick in
2015-03-04 13:39:50 -05:00
Jason W. May
0f36774246
group manager can invite members into the group from any restricted topic
2015-03-03 12:18:42 -08:00
Neil Lalonde
7c14db44cc
UX: improve message when admin login is blocked because of admin ip address whitelisting
2015-03-02 12:13:22 -05:00
Sam
37fefc16de
workaround, something about report spec is messed up
2015-03-02 12:29:56 +11:00
Sam
0742f340f9
FEATURE: allow for a localized error when a regex fails in site settings
...
FEATURE: apply string validation to list site settings (so we get regex)
2015-02-27 11:45:56 +11:00
Sam
3658c21fc5
REGRESSION: incorrect ordering when featuring topics
2015-02-25 14:24:25 +11:00
Robin Ward
ca5730018a
FIX: SSO code should respect IP address filters
2015-02-23 16:01:46 -05:00
Sam
6960639c58
Merge pull request #3190 from riking/thrown_logging
...
Delete old ErrorLog, use Logster for 500 errors
2015-02-23 14:19:16 +11:00
Régis Hanol
e74b9ee5da
FIX: should not count disagreed flags
2015-02-19 18:11:07 +01:00
Sam
709ab731c7
don't put missing notifications in the stream for tests.
2015-02-19 13:20:25 +11:00
Robin Ward
3ce2077aa8
Migrate unsubscribe keys to the database.
...
This should reduce a lot of the keys in redis.
2015-02-13 14:24:15 -05:00
Sam
276fd702e8
missed a send which caused code to break
2015-02-12 15:01:14 +11:00
riking
68ccd2d664
FEATURE: All 500 errors now show up in Logster
...
Added Discourse.handle_request_exception()
2015-02-09 12:48:33 -08:00
Régis Hanol
e36272cb68
fix the build
2015-02-09 17:13:22 +01:00
Sam
e8323fa534
FIX: removing a group from a user was not removing primary group
2015-02-09 16:03:09 +11:00
Sam
820ce8765e
refactor traffic report
...
split traffic report in 2, page view vs raw traffic
hide raw traffic report by default
improve flushing logic for application reqs
2015-02-06 14:39:16 +11:00
Régis Hanol
2fcd199f48
FIX: send a PM to moderators when a post has been flagged as sockpuppet
2015-02-05 19:58:49 +01:00
Sam
08b790b3c2
improve metrics gathered using in our traffic section
...
this also pulls out the middleware into its own home and inserts in front
2015-02-05 16:08:52 +11:00
Sam
eb7a5c251d
freeze time in report spec so it has consistent results
2015-02-05 11:33:13 +11:00
Sam
e105f0965c
infrustructure for tracking application web requests
2015-02-04 16:15:16 +11:00
Dan Singerman
64c4bd5dbf
Fix force_avatar_update.to_i error as force_avatar_update is a boolean
...
If force_avatar_update is passed in sso attributes it errors on
force_avatar_update.to_i. The SingleSignOn class forces avatar_force_update
to a boolean, so it should be treated as such.
2015-01-30 09:51:38 +00:00
Sam
8264dbd971
Merge pull request #3140 from fullfatthings/fix_missing_sso_avatar_bug
...
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
2015-01-30 10:45:25 +11:00
Arpit Jalan
6c410ed093
FIX: strip whitespaces from user email
2015-01-30 01:44:24 +05:30
Robin Ward
e42e9bd010
Merge pull request #3149 from techAPJ/patch-2
...
FIX: allow developer emails to bypass email blacklist/whitelist restrict...
2015-01-29 13:42:59 -05:00
Arpit Jalan
58f46137d6
FIX: allow developer emails to bypass email blacklist/whitelist restriction
2015-01-30 00:10:03 +05:30
Régis Hanol
bdb0b45834
Merge pull request #3148 from techAPJ/patch-1
...
Do not allow TL0 users topics in email digest
2015-01-29 17:50:21 +01:00
Robin Ward
6e862e0e59
FIX: Should flush rate limit keys before testing it
2015-01-29 11:45:12 -05:00
Arpit Jalan
21e94859a9
Do not allow TL0 users topics in email digest
2015-01-29 21:10:26 +05:30
Régis Hanol
cd2c9edb46
FIX: 🐛 upload on IE9 wasn't working :'(
...
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
2015-01-28 19:43:20 +01:00
Dan Singerman
dbf2f4efec
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
...
If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is
passed in the sso attributes, the current code errors, as it tries to parse a nil
as a URL. It seems to me valid that a third party system may not pass an avatar_url in
some cases (e.g. avatars may not be mandatory, so not all users may have them)
This might warrant a discussion about what should happen in this case; maybe the current
avatar in discourse should be removed? This branch merely stops the login process erroring.
2015-01-28 16:01:39 +00:00
Jason W. May
a2b284a0a4
table & model changes for group managers with permission to edit membership
2015-01-15 11:44:42 -08:00
Régis Hanol
256519dddf
FEATURE: automatic group membership based on email address
2015-01-23 18:25:43 +01:00
Arpit Jalan
5e751ce90a
FEATURE: 🎁 rate limit invites for non-staff users
2015-01-20 01:12:24 +05:30
Sam
0b14cfa2c3
skip failing spec, something is off with timezones
2015-01-09 12:03:08 +11:00
Sam
03388e11ab
oops, migration was flipping
2015-01-08 15:26:15 +11:00
Sam
3347a48275
FEATURE: add liked and bookmarked classes to topic list item rows
2015-01-08 14:35:56 +11:00
Robin Ward
114cc1c851
FIX: We missed some references to `/category/xyz` in the ruby code base.
2015-01-07 11:47:01 -05:00
Sam
efc717c14a
FEATURE: remove star concept from Discourse
2015-01-07 13:43:27 +11:00
Luciano Sousa
b52f12948a
models with rspec3 syntax
2015-01-05 13:04:23 -03:00
Luciano Sousa
b3d769ff4f
Update rspec syntax to v3
...
update rspec syntax to v3
change syntax to rspec v3
oops. fix typo
mailers classes with rspec3 syntax
helpers with rspec3 syntax
jobs with rspec3 syntax
serializers with rspec3 syntax
views with rspec3 syntax
support to rspec3 syntax
category spec with rspec3 syntax
2015-01-05 11:59:30 -03:00
Régis Hanol
9fcaf090ec
Merge pull request #3068 from fantasticfears/category_slug
...
support setting category slug
2015-01-02 11:55:27 +01:00
Erick Guan
97b3914b70
FIX: use utc time when generate reports; set boundary
2014-12-30 22:43:03 +08:00
Régis Hanol
a04f44d65a
Merge pull request #3065 from fantasticfears/fix-visits-report
...
FIX: today visits not shown
2014-12-29 21:23:47 +01:00
Erick Guan
1e166d89ff
support setting category slug
2014-12-30 03:14:54 +08:00
Erick Guan
fe7f2c6979
FIX: today visits not shown
2014-12-30 03:09:22 +08:00
Régis Hanol
7ca092da17
Merge pull request #3057 from jaanus/s3-frankfurt-bucket
...
Add eu-central-1 to list of S3 buckets.
2014-12-29 18:02:14 +01:00
jaanus
f6026ad1d0
Added eu-central-1 S3 bucket.
2014-12-29 18:31:21 +02:00
Robin Ward
1055fc0919
Merge pull request #3021 from jmay/custom-category-slug
...
optional custom value for category slug (create and update)
2014-12-29 10:34:23 -05:00
Sam
ef62933034
Ruby 2.2 fixes
2014-12-29 13:31:15 +11:00