Commit Graph

15057 Commits

Author SHA1 Message Date
Neil Lalonde 28bc5ac10a FIX: link to about page on subfolder 2017-10-30 14:34:12 -04:00
Neil Lalonde fec5691064 FIX: unsubscribe links in summary emails were missing subfolder 2017-10-30 14:28:43 -04:00
Robin Ward a0dd75ba88 FEATURE: New API to create a custom formatter for displaying usernames
This is not exhaustive right now, but a good start and we can add to
it over time.
2017-10-30 13:27:08 -04:00
Robin Ward e02ad4249e FIX: In case that `category` is `nil` it should not throw an error 2017-10-30 11:59:13 -04:00
Robin Ward 00bc79439a FIX: Couldn't disagree with "notify moderator" flags 2017-10-30 10:52:00 -04:00
Régis Hanol 6b344e8a20 Revert "UX: semantic form on login modal"
This reverts commit f2219138e1.
2017-10-30 15:05:29 +01:00
Joffrey JAFFEUX 43920827ed
FIX: makes sure the combo-box selects the first value 2017-10-30 01:28:11 -07:00
Joffrey JAFFEUX 71cea12ee2 Revert "[FIX] Makes sur we always have a selectedGroup"
This reverts commit 9406eee179.
2017-10-30 01:14:38 -07:00
Joffrey JAFFEUX 9406eee179
[FIX] Makes sur we always have a selectedGroup 2017-10-30 00:20:44 -07:00
OsamaSayegh 55095bc44e FEATURE: Use ACE for badge queries (#5269)
* FEATURE: Use ACE for badge queries

* Forgot disabled

* When disabled, cursor should be `not-allowed`

* Tests + prefix custom attribute with `data-`
2017-10-30 18:07:49 +11:00
Sam fab3e25101 FIX: badge selector showing up for anon 2017-10-30 16:21:31 +11:00
Guo Xiang Tan 0abc5f90cd FIX: Broken link in new user of the month post. 2017-10-30 13:11:29 +08:00
Guo Xiang Tan ddd07773da FIX: Don't hardcode the path into translations. 2017-10-30 12:47:34 +08:00
Neil Lalonde bf00ab5d4a FIX: grant admin on subfolder 2017-10-27 16:46:02 -04:00
Robin Ward fbd5f1e411 REFACTOR: Rename `store:main` to `service:store` so we can inject it 2017-10-27 13:59:45 -04:00
Régis Hanol f2219138e1 UX: semantic form on login modal
cf. https://meta.discourse.org/t/improve-semantics-of-orphaned-form-elements-such-as-buttons/72936
2017-10-27 19:14:25 +02:00
Vinoth Kannan 0a7035e5d3 REFACTOR: searchData constant included in search-menu widget 2017-10-27 10:29:55 -04:00
Jeff Atwood b1ec4e17d9 Merge pull request #5271 from awesomerobot/master
updating banner style, fixes banner on dark themes
2017-10-26 21:50:58 -07:00
Arpit Jalan 33f0d80ed5 UX: better title on search page 2017-10-27 09:13:04 +05:30
Kris 4e2b85bb7f updating banner style, fixes darker themes 2017-10-26 22:39:27 -04:00
Robin Ward 530624d438 FIX: Couldn't agree with a custom flag type 2017-10-26 14:41:11 -04:00
Robin Ward 764cf7e3a5 FEATURE: Add longer suspension defaults
Also refactors and DRYs up the future input date data a lot
2017-10-26 14:16:35 -04:00
Guo Xiang Tan c650ef9138 UX: Move disable PM option under notifications in user preferences. 2017-10-26 16:20:58 +08:00
Guo Xiang Tan f1615c2148 Merge pull request #5263 from tgxworld/improve_pattern
REFACTOR: Always validate email by default.
2017-10-26 14:34:09 +08:00
Rafael dos Santos Silva a173511681 Merge pull request #5259 from discourse/groups_in_sso_provider
Add groups to the SSO provider payload
2017-10-25 23:02:53 -02:00
Rafael dos Santos Silva 5d5268a82b Feature: Group handling 2017-10-25 22:49:17 -02:00
Joffrey JAFFEUX 443573a62f [FIX] prevents click on select-box from reaching parent elements 2017-10-25 13:47:23 -07:00
Joffrey JAFFEUX 1612818e2b [FIX] assign a value when an array of numbers is given 2017-10-25 08:55:16 -07:00
Guo Xiang Tan defea6245c REFACTOR: Always validate email by default. 2017-10-25 13:48:34 +08:00
Sam 0d816302e2 Explicitly avoid all readonly protection and scoping 2017-10-25 13:31:44 +11:00
Sam 877b7be579 FIX: in readonly mode don't double count pages 2017-10-25 13:19:43 +11:00
Neil Lalonde d9a9ad3edb FIX: rendering of block style tags in search results 2017-10-24 17:55:30 -04:00
Neil Lalonde 2c15e9c6fe FIX: search couldn't find tags from before 2017-08-25 2017-10-24 17:55:05 -04:00
Robin Ward 5f47a4807b FIX: Read time was not displaying the unit 2017-10-24 13:46:59 -04:00
Robin Ward edaf5b60dc UX: Remove triple css class 2017-10-24 12:31:20 -04:00
Guo Xiang Tan ad9553ff86 Merge pull request #5238 from discourse/jomaxro-patch-1
Add div to login-required text
2017-10-24 17:04:18 +08:00
Robin Ward dfdf12c92f UX: Don't hardcore height for margins below a title 2017-10-23 16:08:43 -04:00
Robin Ward f6f3b8ecc9 UX: Make admin user list easier to style 2017-10-23 16:06:05 -04:00
Robin Ward 23dce88f5f FIX: Removed a line by accident, broke tests 2017-10-23 14:49:14 -04:00
Robin Ward 6f04bff28c UX: Give a class name to the container of the `#bulk-select` 2017-10-23 14:07:52 -04:00
Robin Ward 89a1b34480 FIX: Show the deleted icon if the quote expands a deleted topic 2017-10-23 13:41:41 -04:00
Robin Ward 48314d04f7 FIX: Groups were not being displayed in the map of private messages 2017-10-23 13:14:16 -04:00
Guo Xiang Tan d5e369d6cf Fix weird Rubocop error. 2017-10-23 12:30:28 +08:00
Guo Xiang Tan 19f3b81161 Revert "FIX: always trigger the ':user_updated' event"
This reverts commit 519b70ea46.

https://meta.discourse.org/t/creating-a-topic-or-a-post-sends-the-user-updated-webhook/71643
2017-10-23 11:44:22 +08:00
Guo Xiang Tan e91a631978 REFACTOR: DRY up code and add better test coverage. 2017-10-23 11:16:14 +08:00
Sam 87e4c2a90f allow for missing header in tests 2017-10-23 11:04:24 +11:00
Arpit Jalan dbfd43c854 UX: show title in search results 2017-10-22 18:12:06 +05:30
Joffrey JAFFEUX 2fe2c1bfb9 [FIX] Better header height computation
Prevents the select-box to think there's enough space above (very common when using customised header).
2017-10-20 14:03:26 -07:00
Joffrey JAFFEUX 07929be817 [FIX] restore legacy combobox to ensure compatibility
TODO: Remove once all select2 instances are replaced.
2017-10-20 13:49:09 -07:00
Joffrey JAFFEUX ae1e4de286 [FIX] better control on value mutation 2017-10-20 13:40:56 -07:00
Robin Ward 383191cafc FIX: You needed to click twice to expand a hidden post 2017-10-20 15:58:14 -04:00
Robin Ward 20e7c0307a UX: Buttons needn't have a `block` style in this modal 2017-10-20 13:55:42 -04:00
Robin Ward e9159e49f3 FEATURE: Site Setting to determine whether flags defaults to topics 2017-10-20 12:37:20 -04:00
Arpit Jalan cafbf506cc better error message when confirming email change 2017-10-20 20:58:00 +05:30
Arpit Jalan 804b4f32f8 better error message when API authentication fails 2017-10-20 20:05:34 +05:30
Joffrey JAFFEUX df4102466c [FIX] Prevents multiple rows from being selected 2017-10-20 07:34:29 -07:00
Robin Ward 0927d75743 UX: Better flex for the bulk actions modal 2017-10-20 10:33:24 -04:00
Robin Ward e00d330579 FIX: Defer wasn't working on all flag types 2017-10-20 10:04:55 -04:00
Joffrey JAFFEUX 671af2690e [FIX] Improves select positioning with direction=rtl in a modal 2017-10-20 07:01:04 -07:00
Joffrey JAFFEUX 21af7d7755 [FIX] Caret not showing in topic-footer-mobile-dropdown 2017-10-20 06:41:00 -07:00
Joffrey JAFFEUX fd7af2e146 [FIX] dropdown tracking not showing in groups 2017-10-20 05:34:10 -07:00
Guo Xiang Tan 989280a222 FIX: Don't rotate session in reaodnly mode. 2017-10-20 17:15:28 +08:00
Régis Hanol 62156885ec UX: remove 🔥heading and ruler button from composer toolbar 2017-10-20 10:59:31 +02:00
Gerhard Schlager 4205c1ad2b FIX: postprocessing ignored cook method 2017-10-20 10:26:45 +02:00
Joffrey JAFFEUX aa134294cc [FIX] Improves positioning of select-box 2017-10-19 18:39:46 -07:00
Joffrey JAFFEUX 4d041d5b87 [FIX] Fix wizard spec
This commit introduces a mutation on input value given to select-box-kit when value is empty. The refactoring required to avoid this would be too heavy atm, but ultimately we would want to avoid this.
2017-10-19 17:34:56 -07:00
Joffrey JAFFEUX 42162c38b3 fix linting 2017-10-19 15:24:21 -07:00
Joffrey JAFFEUX 63c63c1bfd Skip wizard tests
awaiting fixes on select-box-kit
2017-10-19 15:18:01 -07:00
Joffrey JAFFEUX d77ef05ee1 Fix broken tests 2017-10-19 14:32:37 -07:00
Robin Ward aad5118aa9 FIX: Post Action Type 6 is not a notify type 2017-10-19 17:13:55 -04:00
Robin Ward 552b66a2ff Add a helper for the `user-select` vendor prefix CSS 2017-10-19 15:54:19 -04:00
Joffrey JAFFEUX ae1743c61f [WIP] select-box-kit refactoring 2017-10-19 12:51:08 -07:00
Robin Ward a9f718fe57 FIX: Custom flags didn't work when flagging a topic 2017-10-19 14:27:38 -04:00
Robin Ward 7cfb8ed5c1 FIX: You can't notify a user on a flag topic 2017-10-19 14:11:31 -04:00
Robin Ward 838568cbc3 Refactor flag types for more customization 2017-10-19 13:55:23 -04:00
Gerhard Schlager 1cae875146 FIX: topic link extraction shouldn't fail when the parsed URL has no path 2017-10-19 15:26:37 +02:00
Gerhard Schlager 3cd73cdf18 FIX: fancy topic title must fit into column 2017-10-19 14:34:30 +02:00
Guo Xiang Tan 22ba70fb01 Merge pull request #5226 from tgxworld/allow_user_to_disable_private_messages
FEATURE: Allow users to disable new PMs.
2017-10-19 16:46:18 +08:00
Guo Xiang Tan 5b9ddaf972 FIX: `Topic#fancy_title` should not write in readonly mode. 2017-10-19 16:07:03 +08:00
Guo Xiang Tan 25c25ae423 FEATURE: Allow user to leave a PM. 2017-10-19 12:32:55 +08:00
Guo Xiang Tan 79de10b212 FEATURE: Allow users to disable new PMs.
https://meta.discourse.org/t/is-it-possible-to-disable-private-messaging-for-a-specific-user/46391
2017-10-19 12:32:55 +08:00
Régis Hanol c838f43a75 let's not generate an error when logging errors... 2017-10-18 23:14:13 +02:00
Arpit Jalan f50d447881 FIX: render secure category topics in RSS if the user can view the topics 2017-10-18 14:23:30 +05:30
Sam 7f9b0f5e60 try moving shortcut to ctrl+alt+f 2017-10-18 12:20:45 +11:00
Robin Ward 69920b7e60 UX: More flag modal improvements. Remove `!important` class 2017-10-17 11:37:30 -04:00
Robin Ward 77652f4387 FIX: Use computed properties instead of manual HTML for buttons
This way they receive the proper classes
2017-10-17 11:23:44 -04:00
Robin Ward 62b260b3f9 UX: Improve markup for flag modal 2017-10-17 10:44:52 -04:00
Guo Xiang Tan b54eb8f53c FIX: Set PG `connect_timeout` to 5 seconds.
* 30 seconds is alittle too long.
2017-10-17 12:32:41 +08:00
Neil Lalonde 2db66072d7 SECURITY: signup without verified email using Google auth 2017-10-16 13:51:41 -04:00
Robin Ward 80d0c6df7c Use a `user-stat` for the read time too 2017-10-16 13:18:52 -04:00
Robin Ward fb2e581b26 FIX: Headings must begin with `heading--` to avoid some griefing 2017-10-16 11:53:47 -04:00
Sam 229a10e142 Missed a whitelist, compensate for strict classes 2017-10-16 10:46:01 +11:00
Sam 7af1bf32d5 UX: switch global search trigger to ctrl+alt+s
Otherwise it conflicts with firefox
2017-10-16 10:01:17 +11:00
Sam 9cb088e3f6 FIX: restrict classes allowed for img tag in Markdown 2017-10-16 09:34:30 +11:00
Joshua Rosenfeld 64e5532b90 Add div to login-required text 2017-10-15 14:45:24 -04:00
Robin Ward 30bb3b4a86 Include category for summary topics 2017-10-13 16:29:56 -04:00
Robin Ward 5572d1d5f7 Refactor user summary page to use more components 2017-10-13 16:05:40 -04:00
Robin Ward f73a3cc0d4 Don't include suspended_at or suspended_till unless suspended 2017-10-13 12:17:54 -04:00
Kris dc2d9f05dc removing scale-color, first pass 2017-10-13 11:57:10 -04:00
Robin Ward c2a8b95e83 FIX: Don't show the up arrow to jump to posts in different topics 2017-10-13 11:56:44 -04:00
Neil Lalonde c53f41f4f2 FIX: don't flag watched words when rebaking posts 2017-10-12 15:34:22 -04:00
Robin Ward c383cf82a7 Pass `hideCategory` through to the plugin outlet 2017-10-12 12:22:41 -04:00
Robin Ward 4d8619f62c Move topic list extensibility to `topic-list` component 2017-10-12 12:03:22 -04:00
Arpit Jalan 97395ebb66 FIX: SSO avatar downloads were broken
cc @tgxworld
2017-10-12 12:12:04 +05:30
Guo Xiang Tan 4e89d3f778 Only refresh site settings once on initialization. 2017-10-12 14:12:18 +08:00
Régis Hanol f7282e4ecd use force_https site setting when adding scheme for downloading schemaless images locally 2017-10-12 00:06:24 +02:00
Régis Hanol 4e78abb537 let's try 3 times to download images locally 2017-10-11 23:11:44 +02:00
Robin Ward c9b5ef9f58 Typo'd name of jump-bottom 2017-10-11 15:47:18 -04:00
Robin Ward d43fa4d584 Extension points for topic list on discovery page 2017-10-11 14:50:17 -04:00
Robin Ward 8a8d3a3a7e Allow `currentUser` to be passed into raw templates automatically 2017-10-11 12:21:24 -04:00
Robin Ward ba5635f3fc UX: `break-all` looks a bit weird. Removing for now. 2017-10-11 11:32:53 -04:00
Gerhard Schlager c0bb97b5cb FIX: delete staged users when the incoming email is rejected 2017-10-11 16:17:01 +02:00
Guo Xiang Tan 9dcb11f553 Fix the build. 2017-10-11 17:45:19 +08:00
Guo Xiang Tan 09721090a3 FIX: Ensure that we revert back to default connection after running jobs. 2017-10-11 17:17:03 +08:00
Robin Ward faa4c4e5f7 FIX: Sort icons were not showing up 2017-10-10 10:54:43 -04:00
Robin Ward 14b1736c74 Include `currentPath` in the `below-site-header` plugin outlet 2017-10-09 13:58:43 -04:00
Arpit Jalan a2183c3f1d SECURITY: verify that inviter can invite new user to a topic 2017-10-09 15:59:41 +05:30
Guo Xiang Tan 59aeb0bc56 FIX: Sidekiq hot reloading wasn't working in dev.
https://meta.discourse.org/t/webhooks-sidekiq-issue-on-dev-instance/71129

* Remove code that is no longer required as well.
2017-10-09 18:23:25 +08:00
Guo Xiang Tan 1d0fadd48c Merge pull request #5227 from majakomel/delete-tag-confirm
UX: Improve Delete Tag Confirm Message
2017-10-09 11:26:12 +08:00
Guo Xiang Tan a6f2533d38 SECURITY: Fix XSS on unsubscribed page. 2017-10-09 09:04:46 +08:00
Guo Xiang Tan 6fe604b93e Revert "SECURITY: Fix XSS on unsubscribed page."
This reverts commit 190558db9d.
2017-10-09 09:03:07 +08:00
Guo Xiang Tan 190558db9d SECURITY: Fix XSS on unsubscribed page. 2017-10-09 08:59:03 +08:00
Sam 4ea87b5ab8 Merge branch 's3_refactor' 2017-10-09 10:27:52 +11:00
Robin Ward 4da4f986ee FIX: Clicking on quote button was tricky 2017-10-06 21:29:16 -04:00
Robin Ward 193244f8c1 Convert quote button to use d-icon 2017-10-06 15:45:43 -04:00
Robin Ward 494ad1e9de Convert quote controls to use `d-icon` 2017-10-06 15:42:24 -04:00
Robin Ward f4decf9193 The `quote-other-topic` class has been removed 2017-10-06 15:16:06 -04:00
Régis Hanol 8d14d55fc5 make rubocop happy 2017-10-06 16:48:11 +02:00
Régis Hanol 3bdd8f57c1 FIX: invited staged users would sometimes not get notified of replies 2017-10-06 16:37:28 +02:00
Maja Komel 5780596c50 use delete_confirm_no_topics instead of nested no_topics 2017-10-06 16:29:29 +02:00
Maja Komel 3c1e005fea missing semicolon 2017-10-06 15:42:53 +02:00
Maja Komel 13cc0fd665 replace zero key with no_topics 2017-10-06 15:35:15 +02:00
Maja Komel 789a354570 UX: Delete Tag Warning Improvement 2017-10-06 12:13:37 +02:00
Sam 70bb2aa426 FEATURE: allow specifying s3 config via globals
This refactors handling of s3 so it can be specified via GlobalSetting

This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3

It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
Guo Xiang Tan 4ba5e678d8 Require dependencies to enable live reload in dev for Sidekiq. 2017-10-06 11:39:00 +08:00
Guo Xiang Tan d67f0b39ae Update annotations. 2017-10-06 11:13:01 +08:00
Guo Xiang Tan 3efde2618d UX: Do not display non-human users on group page.
https://meta.discourse.org/t/members-of-groups-staff/71437
2017-10-06 10:35:40 +08:00
Guo Xiang Tan 8b71a0e49f UX: Restore missing border at the end of topic list. 2017-10-06 08:27:03 +08:00
Robin Ward 5822c64bdc FIX: If you can manage a post you can wiki it 2017-10-05 17:47:52 -04:00
Robin Ward 2ae06e6fd0 More customization for menu items 2017-10-05 17:00:23 -04:00
Robin Ward 0c84352386 Add support for transformations 2017-10-05 16:24:58 -04:00
Robin Ward 7df73c94a0 Add a hook to decorate extra buttons 2017-10-05 14:35:06 -04:00
Guo Xiang Tan 5dc4b469be Remove unused code for Redis Sentinel. 2017-10-05 14:53:03 +08:00
Guo Xiang Tan b0557c6692 UX: Allow users to remove a remind me topic timer. 2017-10-05 11:50:08 +08:00
Neil Lalonde f5a2ed99b0 FIX: deleting category background images sometimes has no effect 2017-10-04 17:04:37 -04:00
Régis Hanol 4771b0a99f FIX: user fields in invite signups were broken 2017-10-04 23:04:24 +02:00
Robin Ward cf4e6e2f5b FIX: `deletePost` action was incorrect called `delete` 2017-10-04 16:12:18 -04:00
Régis Hanol e212435545 FIX: redirect to top wasn't working 2017-10-04 22:08:41 +02:00
Robin Ward 4aa30cba2e Extensibility for Post manage menu 2017-10-04 15:53:06 -04:00
Robin Ward 6d0bf287b5 Allow more extensibility for the post menu buttons 2017-10-04 15:53:06 -04:00