Arpit Jalan
4fcb307f84
UX: consistent password label on signup and invites page
2020-09-28 20:45:12 +05:30
Joffrey JAFFEUX
cad223c012
DEV: fix broken backend test due to #10749 ( #10758 )
2020-09-28 14:05:01 +02:00
Arpit Jalan
2282fbcedd
fix the build
2020-09-28 16:57:42 +05:30
Joffrey JAFFEUX
c230d2e443
FIX: prevents scrollbar jumping in the emoji picker ( #10749 )
...
This was mostly due to `content-visibility: auto;` but setting the width/height is also a good practice.
2020-09-28 13:23:46 +02:00
Jarek Radosz
e00abbe1b7
DEV: Clean up S3 specs, stubs, and helpers
...
Extracted commonly used spec helpers into spec/support/uploads_helpers.rb, removed unused stubs and let definitions. Makes it easier to write new S3-related specs without copy and pasting setup steps from other specs.
2020-09-28 12:02:25 +01:00
Arpit Jalan
50d53508b1
UX: show range for advanced search views filter.
2020-09-28 16:07:44 +05:30
Arpit Jalan
4498c59085
FEATURE: add alias for min_post_count search filter
2020-09-28 16:07:44 +05:30
Joffrey JAFFEUX
2b254f4305
FIX: removes time from date in calendar range at midnight ( #10751 )
2020-09-28 10:39:21 +02:00
dependabot-preview[bot]
4edb769ef2
Build(deps): Bump rubocop-ast from 0.5.1 to 0.7.0 ( #10754 )
...
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast ) from 0.5.1 to 0.7.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.5.1...v0.7.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-09-28 09:58:33 +02:00
Krzysztof Kotlarek
902fbd0b7e
FIX: when the user is promoted to TL2 invite to advance training ( #10752 )
...
Invitation to advanced training should be sent as a separate private message instead of hooking into TL2 promotion message.
2020-09-28 13:52:33 +10:00
Krzysztof Kotlarek
e7c72cd1e4
FIX: deprecate whitelist constants ( #10716 )
...
Deprecation of:
WHITELISTED_REDIRECT_HOSTNAMES
CUSTOM_INTERPOLATION_KEYS_WHITELIST
WHITELISTED_SVG_ELEMENTS
2020-09-28 13:52:05 +10:00
jjaffeux
bab56fdb9d
Revert "UX: Prevent categories from overflowing select-kit"
...
This reverts commit f1ac3cf888
.
2020-09-26 22:14:52 +02:00
awesomerobot
6acd2ab7d4
UX: Allow horizontal scroll on mobile post buttons
2020-09-25 21:06:17 -04:00
awesomerobot
7c206b321f
theme settings need some bottom margin
2020-09-25 20:34:29 -04:00
awesomerobot
f1ac3cf888
UX: Prevent categories from overflowing select-kit
2020-09-25 19:31:41 -04:00
Mark VanLandingham
b8015ab654
FIX: Dismiss unread respects tracked query param ( #10714 )
...
* WIP: 'dismiss...' respectes tracked query param
* Address review comments
* Dismiss new respects query params
* Remove comment
* Better variable name
* remove self
2020-09-25 12:39:37 -07:00
dependabot-preview[bot]
0bc4fd4bd1
Build(deps): Bump rubocop-ast from 0.5.0 to 0.5.1
...
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast ) from 0.5.0 to 0.5.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.5.0...v0.5.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-25 15:30:12 -04:00
jbrw
4421820354
FIX: don’t include category in quote topic title, if present
2020-09-25 15:01:57 -04:00
dependabot-preview[bot]
b257253e7e
Build(deps): Bump rubocop from 0.91.1 to 0.92.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.91.1 to 0.92.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.91.1...v0.92.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-25 15:01:10 -04:00
Penar Musaraj
f031869e08
UX: Center wizard vertically
2020-09-25 11:05:10 -04:00
Penar Musaraj
ea59f43f6c
UX: Use pointer cursor for wizard buttons
2020-09-25 09:44:32 -04:00
Penar Musaraj
b1692422b1
FEATURE: Support using system font in wizard font step ( #10742 )
...
Co-authored-by: Bianca Nenciu <nbianca@users.noreply.github.com>
2020-09-25 09:39:14 -04:00
Penar Musaraj
8fcfb9586c
FEATURE: Dark-mode-friendly wizard ( #10739 )
...
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
2020-09-25 08:56:23 -04:00
Arpit Jalan
30ffd3a44d
Update locale for minimum posts filter on advanced search.
2020-09-25 08:18:03 +05:30
Neil Lalonde
2a268bd89b
Version bump to v2.6.0.beta3
2020-09-24 16:05:52 -04:00
dependabot-preview[bot]
1e615bf10e
Build(deps): Bump rubocop-ast from 0.4.2 to 0.5.0
...
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast ) from 0.4.2 to 0.5.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.4.2...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-24 15:21:15 -04:00
dependabot-preview[bot]
6841ad4a7e
Build(deps): Bump parser from 2.7.1.4 to 2.7.1.5
...
Bumps [parser](https://github.com/whitequark/parser ) from 2.7.1.4 to 2.7.1.5.
- [Release notes](https://github.com/whitequark/parser/releases )
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v2.7.1.4...v2.7.1.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-24 15:16:13 -04:00
Mark VanLandingham
1a29801e2d
UX: More upbeat message when topic list is empty ( #10740 )
2020-09-24 12:05:58 -07:00
Justin DiRose
82a18f125f
FIX: Don't skip the new user badge ( #10743 )
...
The NewUserOfTheMonth badge is part of the Badges::GettingStarted group. This group is skipped in BadgeGranter if the user skips the new user tips. However, the NewUserOfTheMonth badge granter job does not account for this. Instead, it notifies the user they've received the badge even if they did not.
This commit introduces a simple fix to allow granting of this badge even to users who skipped the new user tips.
2020-09-24 12:58:31 -05:00
David Taylor
f1d64bbbe5
FEATURE: Add a site setting to control automatic auth redirect ( #10732 )
...
This allows administrators to stop automatic redirect to an external authenticator. It only takes effect when there is a single authentication method, and the site is login_required
2020-09-24 17:06:07 +01:00
dependabot-preview[bot]
6a5aeceee8
Build(deps): Bump exifr from 1.3.7 to 1.3.8
...
Bumps [exifr](https://github.com/remvee/exifr ) from 1.3.7 to 1.3.8.
- [Release notes](https://github.com/remvee/exifr/releases )
- [Changelog](https://github.com/remvee/exifr/blob/master/CHANGELOG )
- [Commits](https://github.com/remvee/exifr/compare/release-1.3.7...release-1.3.8 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-24 11:13:35 -04:00
dependabot-preview[bot]
fdf238c2b5
Build(deps): Bump rubocop from 0.91.0 to 0.91.1
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.91.0 to 0.91.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.91.0...v0.91.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-24 11:07:27 -04:00
Penar Musaraj
f55807922e
UX: Use simple list for settings without choice options ( #10737 )
...
It's a more user-friendly alternative to the default select-kit list,
for settings that are simple lists of items (the regular list widget is
better for settings with choice options).
2020-09-24 08:58:45 -04:00
Arpit Jalan
cdf45f4fe6
Update regex for views search filter.
2020-09-24 17:05:55 +05:30
Arpit Jalan
5b0ce25dd7
Update locale for views search filter.
2020-09-24 16:33:53 +05:30
Arpit Jalan
0c5cd0d1ef
FEATURE: advanced search filters for view count
2020-09-24 15:22:18 +05:30
Sam Saffron
580383dff3
FEATURE: change default size for search recent posts
...
The site setting `search_recent_posts_size` controls the window of posts
that we will search through before trying to search through the full index
If this number is too low then the search quality can suffer a lot as recent
posts may dominate search. If the number is too high then performance will
suffer.
This attempts to find a happy medium, 1 million posts will cover the majority
of forums out there and should perform adequately.
2020-09-24 17:04:55 +10:00
Guo Xiang Tan
911d47934a
DEV: Prefer `update!` over `update` when return value is not checked.
2020-09-24 09:56:09 +08:00
Osama Sayegh
d745568633
DEV: Stop polluting `Class` with deprecated settings methods ( #10736 )
...
`self.class` here evaluates to `Class` and then we're calling `define_method` on it which means all classes will have those methods defined in them. For example:
```
~/discourse(master*) » rails c
Loading development environment (Rails 6.0.3.3)
[1] pry(main)> Integer.methods
=> [:sqrt,
:yaml_tag,
:email_domains_blacklist=,
:email_domains_whitelist=,
:unicode_username_character_whitelist=,
:user_website_domains_whitelist=,
:whitelisted_link_domains=,
:email_domains_blacklist,
:email_domains_whitelist,
:unicode_username_character_whitelist,
...
...
```
Fix here is to use `self.define_singleton_method`.
2020-09-24 01:58:53 +03:00
Joffrey JAFFEUX
1ae9858c3f
DEV: updates eslint-config-discourse for prettier 2.1.2 ( #10735 )
2020-09-24 00:22:33 +02:00
dependabot-preview[bot]
99d63b9611
Build(deps): Bump simplecov-html from 0.12.2 to 0.12.3
...
Bumps [simplecov-html](https://github.com/simplecov-ruby/simplecov-html ) from 0.12.2 to 0.12.3.
- [Release notes](https://github.com/simplecov-ruby/simplecov-html/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov-html/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov-html/compare/v0.12.2...v0.12.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-23 15:33:52 -04:00
Robin Ward
c5a2de99d1
FIX: `mouseEnter` is deprecated in newer Ember releases
...
This is the recommended fix via:
https://deprecations.emberjs.com/v3.x/#toc_component-mouseenter-leave-move
2020-09-23 15:29:41 -04:00
Robin Ward
1976306539
Add extra locales to bootstrap.json
...
This allows an app (such as Ember CLI) to get the full list of locales
for a user, including admin and overrides.
2020-09-23 14:48:52 -04:00
Arpit Jalan
3684337e4a
FIX: email always settings were not being respected
...
https://meta.discourse.org/t/email-notification-for-messages/163937/10?u=techapj
2020-09-23 22:00:15 +05:30
Bianca Nenciu
214b4c3910
FIX: Remove category id from category class name ( #10712 )
...
The generated class name included ID (parent_slug-child_slug-child_id),
but the client side did not expect it (parent_slug-child_slug).
2020-09-23 19:22:07 +03:00
Mark VanLandingham
9f73e8779d
FIX: Only staff can edit topic details when first post is locked ( #10729 )
2020-09-23 11:13:18 -05:00
Joe
061ab75343
UX: ensures new-topic badge renders consistently
...
We previously used the "●" Unicode character for this circle. Using Unicode for this means that it's up to the browser / OS to determine how it renders.
This commit changes it to a CSS shape so that we always get the same rendering regardless of the user's browser / OS.
2020-09-23 23:32:19 +08:00
jbrw
09a97363da
FIX: allow editing in composer before a category is selected ( #10724 )
...
* FIX: allow editing in composer before a category is selected
If the site setting `allow_uncategorized_topics` is disabled, but no site categories have a topic template, the textarea of the composer should be enabled. This allows for a post body to be entered, however the post/topic should not be successfully created until a category is selected.
If `allow_uncategorized_topics` is disabled *and* one or more categories have a topic template, the textarea of the composer should remain disabled until a category is chosen (so that the body of their post isn’t overwritten by the template).
* Avoid recalculating hasTopicTemplates repeatedly
2020-09-23 10:28:56 -04:00
Penar Musaraj
59a83634c4
FIX: Use scrollY for current scroll position
...
This replaces an invalid `window.scrollTop` occurrence, left over from a
jQuery refactoring. It should fix an undesirable "shake effect" I have
run into in Safari when navigating to a reply in the post stream.
2020-09-23 10:21:02 -04:00
Robin Ward
291f8a17bb
Ignore the giant rename commit
2020-09-23 10:03:56 -04:00