f140c4d499
FIX: ensures routing to / with query string works ( #7859 )
2019-07-05 09:40:19 +02:00
1bb258ab49
DEV: use upload short-url in html to markdown conversion if 'base62-sha1' data attr available.
2019-07-05 10:06:41 +05:30
c78634284c
UI: when in a different topic context, allow dismissing draft without destroying it
...
This changes the label and behaviour of the "No, keep" button in the confirmation modal when user cancels a draft while on a different topic. The new button label is "No, save draft", and when clicked, the composer will be dismissed without destroying the draft.
2019-07-04 11:45:57 -04:00
c5625b70f1
FIX: Prevent emoji-picker from not showing ( #7856 )
...
If an external plugin inserts an element with class "emoji-picker", something probable if they extend EmojiPicker, it could cause troubles as css is added depending on the emoji-picker height. Just by adding a class of a parent <div> as could be d-editor, we prevent this from happening.
2019-07-04 11:46:21 +02:00
a5e80079d6
FEATURE: Add Belarusian language
2019-07-04 11:37:37 +02:00
71bf9ec1b2
FEATURE: opt-in guidance on topics for users without access ( #7852 )
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
Co-Authored-By: Robin Ward <robin.ward@gmail.com>
2019-07-04 10:12:39 +02:00
5fdf228db6
FIX: Respect the full_screen_login parameter from plugin auth providers ( #7855 )
...
This behavior was regressed in 427979e7e5
2019-07-04 09:06:29 +01:00
459932f4e2
FIX: Use title attribute for notification items. ( #7840 )
2019-07-03 10:48:13 -04:00
9ca1bbe900
Revert "FIX: remove misplaced save button"
...
This reverts commit 4f468ef210
2019-07-03 10:56:08 -03:00
f9f1df7611
DEV: prevents reports key to be time dependant when testing ( #7850 )
2019-07-03 15:43:01 +02:00
4f468ef210
FIX: remove misplaced save button
2019-07-03 10:39:01 -03:00
bfdf740a05
FIX: Show 'Export' button for all tabular reports. ( #7838 )
2019-07-03 14:47:36 +02:00
3d64532273
FEATURE: allow disabling theme components ( #7812 )
...
This allows you to temporarily disable components without having to remove them from a theme.
This feature is very handy when doing quick fix engineering.
2019-07-03 18:18:11 +10:00
ecf0215ee7
DEV: resets page tracking state between tests ( #7847 )
2019-07-03 10:08:05 +02:00
0733ed3a2b
FIX: ensures /t/TOPIC_ID/POST_NUMBER is correctly routing ( #7841 )
2019-07-03 09:23:23 +02:00
6e3e0685fb
DEV: add useBlockMode option for toolbar button text selection
...
Allows buttons to switch selection to block mode if needed.
2019-07-02 18:02:40 -04:00
c422520b4a
FEATURE: Add CSS classes to associated accounts rows
2019-07-02 16:56:15 -03:00
72441e2c7c
FIX: page starts at 1 ( #7844 )
2019-07-02 17:26:23 +02:00
8404921b91
FIX: Remove misplaced outlet
2019-07-02 11:26:40 -03:00
ccb3ba509d
FIX: creating new badge is failing on empty SQL query ( #7837 )
2019-07-02 15:12:53 +05:30
fca2f0f212
FIX: Only show remove timer button to users with permission to do so
2019-07-01 22:17:02 -04:00
f1c67729de
Different fix ( #7815 )
2019-07-02 11:53:16 +10:00
4dcc5f16f1
FEATURE: when under extreme load disable search
...
The global setting disable_search_queue_threshold
(DISCOURSE_DISABLE_SEARCH_QUEUE_THRESHOLD) which default to 1 second was
added.
This protection ensures that when the application is unable to keep up with
requests it will simply turn off search till it is not backed up.
To disable this protection set this to 0.
2019-07-02 11:22:01 +10:00
f56d86a852
FIX: use normal title instead of fancy title for prefilled composer
2019-07-01 17:55:24 +05:30
7b52a110b8
DEV: removes DOMTokenList polyfill ( #7831 )
...
Creates more issues than it solves especially on IOS, I dont trust it anymore. Will reconsider if this is an issue in the future.
2019-07-01 14:08:38 +02:00
997250586c
FEATURE: prefill title for direct messages from topic
...
https://meta.discourse.org/t/default-re-title-title-for-direct-messages-from-topic/121413
2019-07-01 17:14:08 +05:30
af58049eeb
UX: puts tags and categories on same line in search-menu-results ( #7830 )
2019-07-01 13:11:43 +02:00
384f5cea05
FIX: ensures static pages are using absolute path ( #7828 )
2019-07-01 11:25:45 +02:00
11ae5c78db
FEATURE: adds infite scroll on admin users list page ( #7821 )
2019-07-01 11:00:06 +02:00
4f97f85178
DEV: Fix lint. ( #7824 )
2019-06-28 20:24:09 +02:00
5bab4f8007
UX: gives each info its own line in search-menu-results ( #7825 )
2019-06-28 11:14:38 +02:00
61438c825a
fix prettier ( #7823 )
2019-06-28 09:36:38 +02:00
b2eb0f4ad6
FEATURE: Export any type of report supporting table mode. ( #7662 )
2019-06-28 08:50:31 +02:00
82f2af8a0d
UX: Move link to show tracked topics, simplify translation
2019-06-27 21:36:24 -04:00
4ba35472e6
Don't check for second factor when switching to anonymous account ( #7803 )
2019-06-27 15:01:26 -07:00
a61147d838
FEATURE: displays tags in search menu results when enabled ( #7819 )
2019-06-27 19:26:14 +02:00
ed936bcb01
FIX: Fix a navigation bug
...
To reproduce:
1. Visit a url in a new tab such as `/latest?order=views`
2. Click a topic link
3. Click the back button
Before this patch, you would not be sent back to the latest list.
Now, I am somewhat hesitant to delete code like this, but the [original
commit](b2b7f4d905
2019-06-27 09:06:10 -04:00
5bc5c02af6
FIX: mark topics in sub categories as unread when dismissing parent
...
Previously we would only dismiss the parent category and leave the
child categories unread
2019-06-27 13:26:48 +10:00
88ef5e55fe
FEATURE: add ability to have multiple totp factors ( #7626 )
...
Adds a second factor landing page that centralizes a user's second factor configuration.
This contains both TOTP and Backup, and also allows multiple TOTP tokens to be registered and organized by a name. Access to this page is authenticated via password, and cached for 30 minutes via a secure session.
2019-06-26 16:58:06 -07:00
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
56b76f31dc
fix prettier linting ( #7809 )
2019-06-26 15:26:02 +02:00
65a6e2c860
Change Widget#attach signature
...
Take a fallback option instead of a list of names
2019-06-26 09:01:25 -04:00
37b8f5d989
Use dasherize instead of replace
2019-06-26 09:01:25 -04:00
d025e188e8
Make the linter happy
2019-06-26 09:01:25 -04:00
70e27641eb
Pass data to description to prevent duplication
2019-06-26 09:01:25 -04:00
8c349101c5
Pass data to text method to prevent duplication
2019-06-26 09:01:25 -04:00
86d5208b31
Pass data to url method to avoid duplication
2019-06-26 09:01:25 -04:00
ac6f7b3625
Remove notificationType argument from text
2019-06-26 09:01:25 -04:00
a3254b8446
Pull invitee accepted notification behaviour into its own class
2019-06-26 09:01:25 -04:00
7c52ba1431
Pull liked consolidated notification behaviour into its own class
2019-06-26 09:01:25 -04:00
42143a874e
Pull custom notification behaviour into its own class
2019-06-26 09:01:25 -04:00
305562bf66
Pull title logic into its own method
2019-06-26 09:01:25 -04:00
d83147d137
Rename "title" variable to more apt "description"
2019-06-26 09:01:25 -04:00
02deaa4bc6
Pull icon choosing into its own method
2019-06-26 09:01:25 -04:00
36d7abed0b
Pull group message summary behaviour into its own class
2019-06-26 09:01:25 -04:00
396e13aaa7
Pull liked notification behaviour in its own class
2019-06-26 09:01:25 -04:00
bd062fcbef
Export DefaultNotificationItem
2019-06-26 09:01:25 -04:00
04a75b1cb3
Change the way notification items are created
...
Look for the specialised version first, before falling back to the
default. This allows the behaviour to be customised based on the type of
notification.
2019-06-26 09:01:25 -04:00
cdf0cd3ecd
`createWidgetFrom` creates a new widget with an arbitrary base class
2019-06-26 09:01:25 -04:00
01a7fd4225
Make `attach` optionally take a list of widget names to try
2019-06-26 09:01:25 -04:00
41129f933d
Rename notification-item to default-notification-item
2019-06-26 09:01:25 -04:00
7e70db3fb7
s/notName/notificationName/g
2019-06-26 09:01:25 -04:00
7c9d62c280
FIX: prevents failure when TL was mutated on internal object ( #7808 )
2019-06-26 14:51:45 +02:00
01de7e1444
FIX: calling action with a string is deprecated ( #7807 )
2019-06-26 12:42:46 +02:00
e64544ae44
icon s/trash/trash-alt ( #7806 )
2019-06-26 12:31:49 +02:00
ea2a9bc4fc
FIX: closes search-menu on escape ( #7804 )
2019-06-26 11:53:39 +02:00
2eece2c41b
UX: add shortcut for deferring topics ( #7798 )
2019-06-25 07:20:55 +03:00
c1ca942a77
REFACTOR: removes self pattern from safari-hacks lib ( #7795 )
2019-06-24 11:12:06 +02:00
e064db35d9
REFACTOR: removes self pattern from eyeline lib ( #7796 )
2019-06-24 10:58:59 +02:00
cea3a027f3
FIX: category-chooser search should be scoped to category ( #7794 )
2019-06-24 10:45:30 +02:00
7cabc47945
UX: improves change-timestamp modal datepicker ( #7771 )
2019-06-24 10:24:54 +02:00
02f6db4e59
FIX: Back button shenanigans when redirecting from `index` routes
...
This is a problem that has long plagued Discourse. The root issue here
is that we have to implement our own link click handler, because
Discourse allows users to create HTML blobs of content with links, and
when those links are clicked they must be handled by the Ember router.
This always involved a certain amount of use of private Ember APIs which
of course evolved over time.
The API has more or less stabilized in the last two years, however we
have hacks in our URLs to handle a dynamic root path, depending on how
forums have set up their filters and in what order.
This patch adds a special case for the root path so we needn't update
the URL ourselves otherwise, which preserves the back button on index
routes. The update call would otherwise insert an extra history event if
a route redirected on transition, breaking the back button.
2019-06-21 14:42:01 -04:00
e51de4cc25
FEATURE: Add endpoint to individually update a theme setting ( #7789 )
...
- also adds a new staff action type called "change theme setting" for easier logging of staff changes to theme settings
2019-06-21 13:49:14 -04:00
2738d11f60
UX: show like icon on archived posts ( #7775 )
2019-06-21 20:47:32 +05:30
1cbe2dd2ce
DEV: adds polyfill to fully support DOMTokenList in IE ( #7765 )
2019-06-21 09:59:28 +02:00
fc026e12a5
FIX: Some toolbar operations weren't triggering the `change` event
...
This would mean that some simple edits to queued posts did not get
saved.
2019-06-20 13:35:12 -04:00
0e26c57afa
FIX: Do not refresh all settings on save for all settings, limit to only a few
...
- Followup to 0e303c7f5d
2019-06-20 10:57:31 -04:00
56b7777705
FIX: 'status' param change not filtering the topics in tag route.
...
Use existing 'filterQueryParams' helper method to set 'queryParams' value for tag route.
2019-06-20 17:27:32 +05:30
f096c994de
FIX: use correct name for selectable_avatars_enabled site setting
2019-06-19 13:18:16 -04:00
6fec4982d9
FIX: Couldn't modify a widget that wasn't in the registry
2019-06-18 12:28:18 -04:00
03ba1d49fb
DEV: lint file
...
We no longer need that isAppleDevice require
2019-06-18 17:12:55 +10:00
506de13896
FIX: remove temporary hack for fixed iOS bug ( #7773 )
...
A bug where input focus is displaced on modals was fixed in iOS 11.3 update. This hack was causing problems on topic page since hiding main-outlet results in lost read position after opening and closing a modal.
2019-06-18 16:25:29 +10:00
52387be4a4
SECURITY: Add confirmation screen when logging in via email link
2019-06-17 16:18:37 +01:00
5f6f707080
Revert "Merge pull request from GHSA-hv9p-jfm4-gpr9"
...
This reverts commit b8340c6c8e
2019-06-17 16:17:10 +01:00
b8340c6c8e
Merge pull request from GHSA-hv9p-jfm4-gpr9
...
* SECURITY: Add confirmation screen when logging in via email link
* SECURITY: Add confirmation screen when logging in via user-api OTP
* FIX: Correct translation key in session controller specs
* FIX: Use .email-login class for page
2019-06-17 15:59:41 +01:00
102be5a9e3
DEV: optimize fix for sub-categories not getting pre-filled.
2019-06-17 13:28:08 +05:30
c909033f2b
Add plugin outlets to login/create-account modals ( #7770 )
2019-06-17 16:22:00 +10:00
48b9e0d749
FIX: sub-categories was not getting selected for pre-filled topics
2019-06-15 13:46:15 +05:30
efc05e7224
FIX: remove topic timer info on completion
2019-06-13 17:01:43 +05:30
19ca2d4772
DEV: reset widget clean callback between tests ( #7761 )
2019-06-12 17:49:02 +02:00
13b979cb71
FIX: Performing actions on a particular reviewable was displaying an error
...
It was expecting a method to remove the reviewable from the current
list, only we were not displaying a list.
Instead, we refresh the reviewable model with the latest result.
2019-06-12 10:56:30 -04:00
0ebe5ec1f8
FIX: Check `postStream.gaps` exists before trying `postSteam.gaps.after`
2019-06-11 23:48:21 +01:00
f6e0c79742
FIX: Trigger change event when inserting text
...
This would normally not fire and result in odd behavior in the review
queue when inserting links.
2019-06-11 17:27:34 -04:00
3d7c26c15e
FIX: Memory Leaks w/ Container ( #7750 )
...
Gives instance initializers the ability to add a `teardown` method that
will be called between tests to clean up after themselves.
2019-06-11 18:41:27 +02:00
47095a7fa1
FIX: Memory leak when adding ajax prefilter repeatedly.
2019-06-11 11:50:35 -04:00
c322cccd53
FIX: Memory Leaks when decorating posts ( #7749 )
...
* Remove long-deprecated method
* FIX: Memory Leaks when decorating posts
Previously we'd keep creating mixins dynamically when decorating the
same class.
This code changes the API to recommend an `id` parameter for each
decorator which will avoid leaks. All plugins should be updated to
include this parameter, although if they don't in the meantime it'll
just mean a warning in the console (and a continued leak.)
2019-06-11 17:21:23 +02:00
f4fd75aea4
DEV: Rename variable to avoid conflict
2019-06-11 13:02:40 +01:00
f1d5b992bf
DEV: Correct linting error
2019-06-11 12:51:18 +01:00
dc15486f0a
Revert "DEV: resets csrf ajax prefilter only if present ( #7747 )"
...
This reverts commit 6612218a4e
2019-06-11 13:34:25 +02:00
61b587f66e
FIX: Mark ignored posts as 'read', if last visible post is read ( #7739 )
2019-06-11 12:16:28 +01:00
000a35b219
FIX: Do not live-load posts from ignored users
2019-06-11 12:07:14 +01:00
6612218a4e
DEV: resets csrf ajax prefilter only if present ( #7747 )
2019-06-11 12:50:20 +02:00
ebf77f74b7
Revert "DEV: prevents csrf token to leak state between tests ( #7746 )"
...
This reverts commit b29d63a52d
2019-06-11 12:19:49 +02:00
b29d63a52d
DEV: prevents csrf token to leak state between tests ( #7746 )
2019-06-11 11:54:23 +02:00
e6714d3531
Revert "DEV: attempts to prevent session object to be retain in csrf init ( #7743 )"
...
This reverts commit 62c56b6e59
2019-06-11 10:58:32 +02:00
4deb0f6d59
DEV: prevents post-cooked decorators to leak between tests ( #7744 )
2019-06-11 10:02:10 +02:00
62c56b6e59
DEV: attempts to prevent session object to be retain in csrf init ( #7743 )
2019-06-11 09:59:14 +02:00
c407e32368
DEV: should check on object and not length ( #7742 )
2019-06-11 09:45:45 +02:00
e5cace9185
FIX: File size text should not be part of link.
2019-06-11 15:21:06 +08:00
06d974d55c
FEATURE: Add base62 sha1 to cooked data attribute
...
* FEATURE: Add base62 sha1 to data attribute in `Post#cooked`.
* FIX: Use `Upload#short_url` when quoting an image.
2019-06-11 11:15:45 +10:00
bd538f7437
FIX: Composer preview not caching inline onebox.
2019-06-11 09:14:53 +08:00
9168ffc201
PERF: Use already loaded post when quoting or opening draft.
2019-06-11 08:21:38 +08:00
ace6ce0462
FIX: Add 'deleted' to the list of status filters ( #7738 )
2019-06-10 15:43:49 -03:00
bdfa55ee5d
UX: Copyedits on reviewable filters
2019-06-10 13:45:38 -04:00
86f3e74799
DEV: Allow `{{d-button}}` to include a href
2019-06-10 13:24:40 -04:00
8b31b812f8
UX: Use a glyph to indicate a new topic instead of "New Topic:"
...
In the review queue it was easy to miss "New Topic:" so let's try a font
awesome glyph instead.
2019-06-10 12:43:20 -04:00
8c4e16eafd
FIX: In reply to would sometimes have a broken link
2019-06-10 11:33:10 -04:00
af08ab5b7b
Revert "DEV: prevents csrf-token initializer to leak session object ( #7730 )"
...
This reverts commit da5255e560
2019-06-07 18:31:16 +02:00
ebecd0b7d1
Revert "fix tests, crsf token meta is not present on tests ( #7733 )"
...
This reverts commit 240b61e844
2019-06-07 18:31:13 +02:00
2dce650b72
FIX: prevents screen-track from leaking object ( #7734 )
2019-06-07 17:18:27 +02:00
240b61e844
fix tests, crsf token meta is not present on tests ( #7733 )
2019-06-07 17:11:16 +02:00
dfb66334c1
DEV: prevents global-notice events to leak ( #7732 )
2019-06-07 16:49:59 +02:00
55325679ac
DEV: prevents share-popup to leak events ( #7731 )
2019-06-07 16:48:45 +02:00
da5255e560
DEV: prevents csrf-token initializer to leak session object ( #7730 )
2019-06-07 16:46:55 +02:00
df01249db4
FIX: removes leaking handler in select-kit ( #7729 )
2019-06-07 16:12:22 +02:00
fca90106b9
FIX: select-kit events were sometimes not cleaned up ( #7728 )
2019-06-07 15:20:01 +02:00
d1228f47bb
FIX: Handle missing plural keys on client
2019-06-07 10:24:17 +02:00
a652d620f6
FIX: safari desktop doesnt support input[time] ( #7719 )
...
This commit attempts to improve the experience by:
- showing time input as disabled on any platform if date hasn't been set
- showing a placeholder --:-- to emphasize the expected format
2019-06-07 15:50:43 +10:00
9db1fef4e3
FIX: add support for custom/plugin notification title attribute
2019-06-07 09:09:16 +08:00
35da531f1d
FIX: Do not resize images in Onebox while lazy loading.
...
Follow-up to 35d0fd0
2019-06-06 18:36:18 +03:00
48b6391777
FIX: s/thumb-tack/thumbtack ( #7718 )
2019-06-06 14:43:16 +02:00
c462c2f271
FIX: prevents appEvents to leak ( #7714 )
2019-06-06 12:33:52 +02:00
782da448a2
FIX: Missing `title` attribute when quoting an image.
2019-06-06 16:45:12 +08:00
2265c5102f
DEV: Remove unnecessary condition.
...
Follow up to 21876d46d6
2019-06-06 15:55:49 +08:00
21876d46d6
DEV: Missing loading spinner for staff action logs.
...
Follow up to e0c821ebb0
2019-06-06 15:41:55 +08:00
e0c821ebb0
FEATURE: Make staff action logs page support infinite loading
2019-06-06 13:02:53 +10:00
c3a38d2304
DEV: Make groups/new extensible by plugins ( #7642 )
...
* Expose a new plugin outlet. Pass group model to the group-member-dropdown so it can be accessed by plugins
* Added controller tests for group custom fields. update custom fields when updating a group
2019-06-06 12:05:33 +10:00
7bd8f715bc
DEV: Prefer `this.site.notification_types`.
2019-06-06 09:39:59 +08:00
d9d36f241d
DEV: Use `this.site.get("notification_types")` instead.
...
Follow up to fcb7422213
2019-06-06 08:18:25 +08:00
58ff7216ca
UX: Display "Queued Topic" if a Queued Post will create a topic
2019-06-05 14:11:28 -04:00
d902c4eb9f
FEATURE: Can sort reviewable queue
...
Choices are Priority / Created At (and desc versions.)
2019-06-05 13:21:05 -04:00
35d0fd038e
FIX: Add unit to width and height CSS properties.
2019-06-05 19:51:31 +03:00
f1d547c301
FEATURE: Show "in reply to" on the review queue
...
We now show if a queued or flagged post is a reply to another when in
the review queue. It's especially helpful for queued posts where
normally they are linked to the topic where they are created, and you
have no context about the reply.
Note that this will only apply to new queued posts going forward.
Previously queued posts will not show the "in reply to"
2019-06-05 12:34:41 -04:00
ad876880e1
FIX: Ember was raising an error without a `.set` here
2019-06-05 10:23:39 -04:00
0082a57718
REFACTOR: computed lib ( #7702 )
2019-06-05 15:50:22 +02:00
f506843074
REFACTOR: user route ( #7704 )
2019-06-05 13:05:27 +02:00
1178f4865b
REFACTOR: login-method model ( #7703 )
2019-06-05 12:35:41 +02:00
80459d83a4
REFACTOR: discourse-location lib ( #7700 )
2019-06-05 11:46:36 +02:00
Joffrey JAFFEUX
Vinoth Kannan
Penar Musaraj
Mario Santos
Gerhard Schlager
David Taylor
Bianca Nenciu
romanrizzi
Osama Sayegh
Rafael dos Santos Silva
Arpit Jalan
Sam Saffron
Kris
Ralph Rooding
Robin Ward
Jeff Wong
Daniel Waterworth
Maja Komel
tshenry
Guo Xiang Tan
Bianca Nenciu