Penar Musaraj
27387b0859
Do not collapse quote notifications
...
This prevents an issue where edits to a post with a quote would trigger push notifications indefinitely.
2019-06-27 18:20:43 -04:00
Ralph Rooding
4ba35472e6
Don't check for second factor when switching to anonymous account ( #7803 )
2019-06-27 15:01:26 -07:00
Arpit Jalan
7f14e185cc
Bump onebox version.
...
- prevent double escaping of URL
2019-06-27 23:35:35 +05:30
Joffrey JAFFEUX
a61147d838
FEATURE: displays tags in search menu results when enabled ( #7819 )
2019-06-27 19:26:14 +02:00
Penar Musaraj
5cf5e73536
FIX: copy local theme changes to correct temp folder when diffing updates to remote theme
...
Previously, local changes were being copied to a subfolder, resulting in lots of false positive diff changes.
2019-06-27 13:01:34 -04:00
Daniel Waterworth
23c5da4617
DEV: Check for pending migrations before starting the turbo tests
2019-06-27 16:41:19 +01:00
Daniel Waterworth
d6aa92e98e
DEV: Add a verbose option to ./bin/turbo_rspec
2019-06-27 15:49:21 +01:00
Robin Ward
ed936bcb01
FIX: Fix a navigation bug
...
To reproduce:
1. Visit a url in a new tab such as `/latest?order=views`
2. Click a topic link
3. Click the back button
Before this patch, you would not be sent back to the latest list.
Now, I am somewhat hesitant to delete code like this, but the [original
commit](b2b7f4d905
)
explains a situation that I cannot reproduce with the code missing.
I cannot seem to keep the filters as sticky even if I try. At the very
least this is better to commit right now than the currently known broken
situation.
2019-06-27 09:06:10 -04:00
Daniel Waterworth
8a0be71b3c
FIX: FakeExceptions should have the original class name
2019-06-27 11:43:53 +01:00
Daniel Waterworth
e58f67a0c0
FIX: an exception cause is itself an exception
2019-06-27 11:43:53 +01:00
Gerhard Schlager
fe870a1e54
DEV: Respond with error 400 to uploads requested via XHR
...
follow-up to 13f38055
2019-06-27 11:15:35 +02:00
Joffrey JAFFEUX
df9b295510
DEV: skip load-script to prevent timeouts ( #7817 )
2019-06-27 10:57:40 +02:00
Joffrey JAFFEUX
5b9a3f8acd
DEV: attempts to make load-script more reliable ( #7816 )
...
We don't check on script anymore, but we still check on window.ace making very unlikely to regress.
2019-06-27 10:19:55 +02:00
Sam Saffron
8f7a387aa7
FEATURE: add support for tag group search
...
The behaviour of #TERM in search has been amended
1. We try category or subcategory slugs
2. We try tags
3. We try tag-groups
The term `hello #my-group` will search for all posts tagged with any of
the tags in the tag group `My Group`
Future work may be introducing a slug cache here or caching it in the table
but the assumption is that the number of tag groups will not be huge
2019-06-27 17:53:26 +10:00
Arpit Jalan
9a2eb5c8cb
UX: change icon for video placeholder
2019-06-27 12:27:14 +05:30
Sam Saffron
5bc5c02af6
FIX: mark topics in sub categories as unread when dismissing parent
...
Previously we would only dismiss the parent category and leave the
child categories unread
2019-06-27 13:26:48 +10:00
Jeff Wong
79d657203d
fix tests
2019-06-26 17:44:23 -07:00
Jeff Wong
88ef5e55fe
FEATURE: add ability to have multiple totp factors ( #7626 )
...
Adds a second factor landing page that centralizes a user's second factor configuration.
This contains both TOTP and Backup, and also allows multiple TOTP tokens to be registered and organized by a name. Access to this page is authenticated via password, and cached for 30 minutes via a secure session.
2019-06-26 16:58:06 -07:00
Régis Hanol
b2a033e92b
REFACTOR: use Ruby's sum
2019-06-27 01:54:40 +02:00
Régis Hanol
134a4c66b7
PERF: limit time spent diffing large blobs of text
...
REFACTOR: s/.length/.size/g
2019-06-27 01:45:52 +02:00
Osama Sayegh
50e4ecc77e
UX: hide post is unread tooltip after the post is read ( #7813 )
...
Note we can't use `display: none` here because it doesn't work with
animations.
2019-06-26 22:39:57 +03:00
Arpit Jalan
a3bcb8e887
UX: make onebox video placeholder icon grey
2019-06-26 23:40:36 +05:30
Arpit Jalan
168a38dc29
Bump onebox version.
...
- better Twitch placeholder
- CSS for said placeholder
2019-06-26 23:22:29 +05:30
Robin Ward
817661aed9
UX: Require a confirmation if approving a post in a closed topic
2019-06-26 12:21:49 -04:00
Daniel Waterworth
b3ec3fac93
FIX: turbo_rspec doesn't accept these options
2019-06-26 17:05:27 +01:00
Daniel Waterworth
68d54d818a
DEV: Add USE_TURBO option to docker rake task ( #7811 )
2019-06-26 11:54:39 -04:00
Robin Ward
14a64e7c4c
Move "Hide Post" option up to the top on the review interface
...
If you agree with the post you are likely to want to hide it.
2019-06-26 11:35:59 -04:00
Robin Ward
eedec7d79b
FIX: Only include pending/agreed scores in the total score
...
This should prevent posts from being hidden if a previous flag was
rejected and a new one was added.
2019-06-26 11:21:35 -04:00
Joffrey JAFFEUX
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
Penar Musaraj
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
Gerhard Schlager
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
Bianca Nenciu
463db22928
DEV: Add test.
...
Follow-up to bccd090ced
.
2019-06-26 16:37:01 +03:00
Bianca Nenciu
bccd090ced
SECURITY: Escape email text for posts containing [details].
2019-06-26 16:28:31 +03:00
Joffrey JAFFEUX
56b76f31dc
fix prettier linting ( #7809 )
2019-06-26 15:26:02 +02:00
Joffrey JAFFEUX
dfde59f631
FIX: provides an emoji helper to replace codes by images ( #7802 )
2019-06-26 15:11:04 +02:00
Daniel Waterworth
65a6e2c860
Change Widget#attach signature
...
Take a fallback option instead of a list of names
2019-06-26 09:01:25 -04:00
Daniel Waterworth
37b8f5d989
Use dasherize instead of replace
2019-06-26 09:01:25 -04:00
Daniel Waterworth
d025e188e8
Make the linter happy
2019-06-26 09:01:25 -04:00
Daniel Waterworth
70e27641eb
Pass data to description to prevent duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
8c349101c5
Pass data to text method to prevent duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
86d5208b31
Pass data to url method to avoid duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
ac6f7b3625
Remove notificationType argument from text
2019-06-26 09:01:25 -04:00
Daniel Waterworth
a3254b8446
Pull invitee accepted notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
7c52ba1431
Pull liked consolidated notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
42143a874e
Pull custom notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
305562bf66
Pull title logic into its own method
2019-06-26 09:01:25 -04:00
Daniel Waterworth
d83147d137
Rename "title" variable to more apt "description"
2019-06-26 09:01:25 -04:00
Daniel Waterworth
02deaa4bc6
Pull icon choosing into its own method
2019-06-26 09:01:25 -04:00
Daniel Waterworth
36d7abed0b
Pull group message summary behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
396e13aaa7
Pull liked notification behaviour in its own class
2019-06-26 09:01:25 -04:00