Commit Graph

14994 Commits

Author SHA1 Message Date
Robin Ward c6ff387ce9 Use more semantic names for various tracking icons
This way they can be replaced by plugins without conflicting with other
icons. For example `circle` is used in some places that doesn't
represent `tracking`.
2017-09-01 12:14:58 -04:00
Sam Saffron 46ebd0ee40 correct spec and allow for zero allowed iframes 2017-09-01 12:08:55 -04:00
Robin Ward cb56dcdf2e FIX: Use proper `iconNode` when compiling virtual dom templates 2017-09-01 11:20:33 -04:00
Vinoth Kannan 0fb7831749 FEATURE: Add placeholders to broken and large image files (#5113) 2017-09-01 10:26:13 -04:00
Sam Saffron e283e6aea0 FEATURE: allowed_iframes site setting for allowing iframes
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
minusfive b3b6eeff97 Ensure css applies to .user-main > .about icons regardless of tag 2017-09-01 06:32:27 -07:00
minusfive 611d62e4a5 Cleanup, deduplicate, debug user css, separated user-info component css 2017-09-01 06:32:27 -07:00
Robin Ward dffb1fc4ee FEATURE: Use Glimmer compiler for widget templates
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.

Example:

```javascript
createWidget('post-link-arrow', {
  template: hbs`
    {{#if attrs.above}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
        {{fa-icon "arrow-up"}}
      </a>
    {{else}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
        {{fa-icon "arrow-down"}}
      </a>
    {{/if}}
  `,

  click() {
    DiscourseURL.routeTo(this.attrs.shareUrl);
  }
});
```
2017-09-01 09:28:16 -04:00
Arpit Jalan 66f2925348 SECURITY: do not include links from whispers in topic summary map
https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj
2017-08-31 23:44:54 +05:30
Robin Ward ef0f346eec Add custom style for header buttons 2017-08-31 12:10:54 -04:00
Joffrey JAFFEUX 56468582ee FIX: visual regressions on title-wrapper 2017-08-31 15:08:09 +02:00
Joffrey JAFFEUX 0957ac9ee2 FIX: minor css tweaks to title-wrapper 2017-08-31 11:16:08 +02:00
Joffrey JAFFEUX 84e992363c FIX: use maximum z-index for select-box when expanded 2017-08-31 00:55:05 +02:00
Robin Ward 75b2aa2edd Better support for inline modals 2017-08-30 17:52:49 -04:00
Robin Ward a48abc6556 Tweaks for better modal distinction between fixed/inline 2017-08-30 17:38:49 -04:00
Robin Ward 6361618188 `fixed-modal` is a better name 2017-08-30 15:52:29 -04:00
Robin Ward 3d95bac3fb Migrate away from `#discourse-modal` to `.d-modal` 2017-08-30 15:29:51 -04:00
Robin Ward 8fcd5af5b1 UX: Use a template for the `d-modal` component 2017-08-30 15:20:49 -04:00
Robin Ward 64bb0f9f05 Add a class to target the sugested topics message 2017-08-30 13:50:39 -04:00
Robin Ward 3aed047b7e UX: Add another div to aid in styling via flexbox 2017-08-30 13:43:56 -04:00
minusfive 5fd4970602 Cleanup nav-stacked .active state styles, remove unnecessary nesting 2017-08-30 09:14:56 -07:00
minusfive 8781c6bfcb Removed unnecessary outer link-tos from admin/settings|watched-words navs 2017-08-30 09:14:56 -07:00
Joffrey JAFFEUX 746c5927e1 Replaces remaining {{category-chooser}} by {{category-select-box}}
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues

Note: {{category-chooser}} will be removed in the next weeks.
2017-08-30 17:04:17 +02:00
Guo Xiang Tan 0a53c589c4 Fix linting. 2017-08-30 15:36:45 +08:00
Sam 9a861c1b43 Correct previous commit
Selector was way too wide
2017-08-29 16:51:57 -04:00
Sam 5cdb486332 UX: large topic creation area on mobile
This refines the iOS hack and allows for height 100%
on the composer

Also removes annoying box shadows
2017-08-29 15:45:02 -04:00
Sam c705159d22 Remove email column from user table 2017-08-29 11:50:56 -04:00
Sam b3fd091379 annotate stuff 2017-08-29 10:48:22 -04:00
Joffrey JAFFEUX 98c6c7e35a FIX: css regression on select-box 2017-08-29 15:52:38 +02:00
Joffrey JAFFEUX cb4f690937 uses new select-box for quick topic edit 2017-08-29 15:15:17 +02:00
Joffrey JAFFEUX dcc5f93344 FIX: disable highlighting when no value set on select-box 2017-08-29 14:32:23 +02:00
Joffrey JAFFEUX 21c4e38eec clean select-box css 2017-08-29 14:31:03 +02:00
Joffrey JAFFEUX f101fec19c FIX: improves uncategorized support for category-select-box 2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX 861dbe3b51 select-box refactoring
- more flexibility (allows custom title)
- less re-render
- more robustness
2017-08-29 12:25:54 +02:00
Joshua Rosenfeld e3e6fd6ea0 FIX: Only show topic timer to staff 2017-08-28 23:49:30 -04:00
Sam 50203794e6 FIX: staged users should get emails on must_approve_users sites 2017-08-28 17:32:07 -04:00
Sam 41e7bdff38 FIX: don't refresh notifications in a tight loop 2017-08-28 16:52:00 -04:00
Sam 9f0f086b3e FEATURE: allow API to mark accounts as approved on creation 2017-08-28 15:36:46 -04:00
Bianca Nenciu fa69e0dd77 Improved metadata for tags. (#5067) 2017-08-28 13:11:34 -04:00
Leo McArdle fd2cd63b08 FIX: make /new-topic redirect survive full screen login (#5105) 2017-08-28 12:40:31 -04:00
Bianca Nenciu 6bc74ceb50 Split alias levels in mentionable and messageable levels. (#5065)
* Split alias levels in mentionable and messageable levels.

* Fixed some tests.

* Set messageable level to everyone by default.

* By defaults, groups are not mentionable or messageable.

* Made staff groups messageable by the system.
2017-08-28 12:32:08 -04:00
David Taylor ce2250d7aa Add avatar-flair plugin outlet for user card (#5104) 2017-08-28 12:26:42 -04:00
minusfive d70ecf1c53 Simplify user-nav styles to facilitate theming 2017-08-28 09:24:41 -07:00
Bianca Nenciu bb3a5910d7 Support for sending PMs to email addresses (#4988)
* Added support for sending PMs to email addresses.

* Made changes after review.

* Added settings validator.

* Fixed tests.
2017-08-28 12:07:30 -04:00
Joffrey JAFFEUX b83c0747d9 FIX: select-box improvments
- more tests for category-select-box
- allows to clear selection
- fix positioning on safari
- focus on click
- do not display uncategorized if not allowed in settings
- fix component state impacting other specs
- better texts
- higher category-select-box on mobile
2017-08-28 14:34:04 +02:00
Arpit Jalan be972912cb FIX: do not show full name field when accepting invite if full names are disabled
https://meta.discourse.org/t/require-password-for-trusted-user-invites/13750/58?u=techapj
2017-08-27 12:15:32 +05:30
Robin Ward a77ede05e2 FIX: Don't re-render if you find composer messages after destroying 2017-08-26 00:41:24 -04:00
Robin Ward b93f491035 Add option for button type under posts 2017-08-26 00:00:52 -04:00
Robin Ward 27b10a709b Revert "FIX: Un-revert the btn class added to the topic post menu"
This reverts commit aa07d23caa.
2017-08-25 23:50:00 -04:00
Joffrey JAFFEUX 5d12db1fb5 FIX: html not showing in select-box header 2017-08-26 02:44:36 +02:00
Joffrey JAFFEUX 918f5045b4 FEATURE: display subcategories when filtering on parent name 2017-08-26 02:01:34 +02:00
Joffrey JAFFEUX 2efb39289c FIX: select-box fragile specs 2017-08-26 01:24:17 +02:00
Robin Ward aa07d23caa FIX: Un-revert the btn class added to the topic post menu 2017-08-25 17:08:34 -04:00
Joffrey JAFFEUX 296ea6c7b1 FIX: castInteger on initial value 2017-08-25 22:41:35 +02:00
Robin Ward 7f16323ba4 REVERT: btn class looked ugly, let's revert for now 2017-08-25 16:06:56 -04:00
Neil Lalonde 398604ac71 FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users 2017-08-25 15:20:06 -04:00
minusfive d911d3ff6e Namespaced Sass color brightness function to avoid conflict w/CSS filter 2017-08-25 11:10:11 -07:00
Joffrey JAFFEUX 14f06c2740 select-box minor fixes 2017-08-25 19:56:57 +02:00
Robin Ward 075cc1a8bb FIX: some button classes 2017-08-25 13:44:28 -04:00
Robin Ward 493fd707f8 UX: Add missing `btn` class to `flat-button` 2017-08-25 13:16:18 -04:00
Robin Ward 4e9c4f0768 Add option to collapse buttons in post menu 2017-08-25 13:11:53 -04:00
Robin Ward 324b02a830 Add option to move the poster name in with the avatar 2017-08-25 13:11:53 -04:00
Neil Lalonde ea969d1ed0 FEATURE: add Thai language 2017-08-25 12:33:09 -04:00
Neil Lalonde 2c56f8df7c FEATURE: show tags in search results 2017-08-25 11:52:59 -04:00
minusfive cdcc5d6174 Extracted/DRYed user-stream-item component CSS from user.css into own files
- Renamed 'stream-item' component to 'user-stream-item'
- Replaced generic 'item' class with clearer 'user-stream-item' class
- Retained 'item' class for backward compatibility, marked as 'DEPRECATED'
- Extracted CSS pertaining 'user-stream-item' component to component CSS files
- Removed unnecessary duplication from 'user-stream-item' CSS
- Removed unnecessary nesting from 'user-stream-item' CSS
2017-08-25 08:38:27 -07:00
Joffrey JAFFEUX bbd428fb94 FIX: more consistent filter from keyboard on select-box 2017-08-25 01:48:32 +02:00
minusfive 8a06d3d312 Fix + remove unnecessary indentation, dead code, cleanup user.css 2017-08-24 14:46:01 -07:00
Jeff Atwood c8ce3c6dee make composer edu panel close button more visible 2017-08-24 13:49:33 -07:00
minusfive 512858c2e7 Removed no-longer-used styles from group.scss 2017-08-24 10:07:36 -07:00
minusfive c01dc26ea6 Add no-content message for user/activity/replies, fix no-content display 2017-08-24 09:51:39 -07:00
Joffrey JAFFEUX f3388043db FIX: avoids select-box being over composer popup 2017-08-24 18:49:35 +02:00
minusfive cdf0fefe8c Removed icons + no-glyph classes from /user sub-navs, normalized indentation 2017-08-24 09:41:27 -07:00
Joffrey JAFFEUX 39a89419b6 uses select-box for theme selection on user profile 2017-08-24 18:33:01 +02:00
Joffrey JAFFEUX d05df4a337 FIX: better headerText handling on select-box 2017-08-24 18:31:33 +02:00
Robin Ward a6251f717b Convert user card buttons to `{{d-button}}` components 2017-08-24 12:23:08 -04:00
Joffrey JAFFEUX 9c446fcb4d FIX: modify select-box orientation when composer resizes 2017-08-24 17:14:55 +02:00
Joffrey JAFFEUX 21d6c7f6b3 FIX: duplicated categories in select-box 2017-08-24 16:54:10 +02:00
Joffrey JAFFEUX d52048ad34 Revert "Revert "FEATURE: improves select-box to support category selection on new topic""
This reverts commit 1d90f6016a.
2017-08-24 16:04:47 +02:00
Guo Xiang Tan 0531ef2e20 Fix calling `exists?` on Arrays. 2017-08-24 09:56:07 +09:00
Guo Xiang Tan 4b4169c8fd Merge pull request #5053 from fantasticfears/session-controller
Spec for local auth check
2017-08-24 09:42:54 +09:00
Guo Xiang Tan 91d3929f52 Merge pull request #5078 from lelelelemon/master
change count>0 to exists
2017-08-24 09:24:42 +09:00
Guo Xiang Tan 027b999828 Merge pull request #5071 from LeoMcA/remove_duplicated_without_posts
FIX: removed the duplicated staged users without posts
2017-08-24 09:23:36 +09:00
junwen yang 8124f26a6e change count>0 to exists 2017-08-23 22:54:51 +00:00
minusfive 38eef177d4 Cleanup & debug .nav-stacked styles 2017-08-23 13:58:41 -07:00
Robin Ward 950c9e50ac Add wrapper div to aid in styling 2017-08-23 14:47:09 -04:00
Sam f766ea4257 Correct short url decoding for sha1s leading with zero
This was picked up cause we had a flaky test!
2017-08-23 11:08:18 -04:00
Joffrey JAFFEUX 1d90f6016a Revert "FEATURE: improves select-box to support category selection on new topic"
This reverts commit 7b4e302677.
2017-08-23 16:33:03 +02:00
Leo McArdle 3986367f3f update pr based on review 2017-08-23 14:55:34 +01:00
Joffrey JAFFEUX 7b4e302677 FEATURE: improves select-box to support category selection on new topic 2017-08-23 15:08:19 +02:00
Sam 8dfb1be4d1 FEATURE: unlisted *only* means not listed in topic lists
Remove security by obscurity feature that tries for exact slug match

If you need to hide a topic from users either move to a secure category
or convert to a PM
2017-08-22 17:53:54 -04:00
Neil Lalonde 224796a7d4 FIX: wrongs counts on tags with deleted topics 2017-08-22 16:55:05 -04:00
Sam d7a2584c6e FEATURE: image uploads now have short urls
Shorten all image uploads to use short urls, this is the client
side implementation.
2017-08-22 16:40:08 -04:00
Robin Ward 605653a369 Add classes to small action buttons 2017-08-22 14:49:14 -04:00
Robin Ward cbe17be40e Remove unused small action component 2017-08-22 14:39:57 -04:00
Robin Ward 7e8766cee8 UX: Move buttons into the nav section of the topic map 2017-08-22 14:20:18 -04:00
Joffrey JAFFEUX a3e9819158 FEATURE: allows to disable automaticPositioning of emoji-picker (#5074)
Usage:
{{emoji-picker automaticPositioning=false}}
2017-08-22 19:41:02 +02:00
Sam ce8030716f FIX: broken badge show page 2017-08-22 13:28:02 -04:00
Sam bcf7dc38c2 FEATURE: server side support for upload:// markdown
This allows uploads to be specified using short sha1 hash instead of full
URL

Client side change is pending
2017-08-22 11:46:23 -04:00
Leo McArdle be1df3ba75 FIX: transfer posts by duplicated staged users to original 2017-08-22 09:58:51 +01:00
Arpit Jalan b00747fd49 FIX: do not create topic link reflection for unlisted topics 2017-08-22 14:28:01 +05:30
Guo Xiang Tan 29a9e0c4d2 Fix the build. 2017-08-22 15:52:24 +09:00
Guo Xiang Tan bc3e43b496 FIX: Topic timers being incorrectly `trashed!`.
https://meta.discourse.org/t/temporary-timed-closure-of-topic-not-re-opening-topic/67877
2017-08-22 15:23:09 +09:00
Guo Xiang Tan 87994a86ce FIX: Don't set topic timer for close topics when changing category.
https://meta.discourse.org/t/moving-a-topic-after-closure-reopens-topic/67659/4
2017-08-22 12:54:34 +09:00
Robin Ward 3a3dca32a3 FIX: Move before post count outlet inside the link 2017-08-21 20:40:35 -04:00
Robin Ward 8bd7cfedfd Convert suggested topics to a component 2017-08-21 17:03:38 -04:00
Sam 2f0c6c99e0 FIX: ip lookup not working
Also add a powered by line so it is clear this makes an external service call
2017-08-21 14:18:49 -04:00
Joffrey JAFFEUX c264348fcb FIX: avoids user-selector having no width 2017-08-21 18:55:44 +02:00
Guo Xiang Tan 93fe76fc02 Make eslint happy. 2017-08-21 21:56:22 +09:00
Kyle Zhao 1a32de722b last attempt at fixing user page layout
drop the width setting on the right column *completely* so it can
 adjust on it own

https://meta.discourse.org/t/long-words-not-wrapping-in-user-activity-page/68181
2017-08-18 17:28:50 -04:00
Sam 5c80d4bcdd UX: move close button to bottom and add esc hint. 2017-08-18 15:40:34 -04:00
Bianca Nenciu e976b98efc Show the select badge button only once. (#5064) 2017-08-18 14:00:20 -04:00
minusfive 77469cfb88 Unnest top level selectors from body 2017-08-18 13:00:26 -04:00
Robin Ward 286bc7db33 Revert "fixes overflowing div width on user activity page"
This reverts commit 375153ce57.
2017-08-18 10:43:42 -04:00
Jeff Atwood d84f105288 Merge pull request #5060 from xrav3nz/fix-user-activity-word-wrap-take-2
fixes overflowing div width on user activity page
2017-08-17 22:48:52 -07:00
Kyle Zhao 375153ce57 fixes overflowing div width on user activity page
detailed explanation: https://meta.discourse.org/t/long-words-not-wrapping-in-user-activity-page/68181/8?u=xrav3nz
2017-08-18 01:01:09 -04:00
Bianca Nenciu ac8bc04ad7 Set user title from the badge view (#5049)
* title info under notification

* create badge-title as component

* display available titles, close button

* remove visual feedback when grant new badge

* Made changes after review.

* Some minor fixes.
2017-08-17 16:32:37 -04:00
Sam c2a6616035 Correct erratic spec failure 2017-08-17 15:26:31 -04:00
Sam 0c4527323e FIX: queues posts broken for multiple posts 2017-08-17 14:47:09 -04:00
Robin Ward 4b0dcd64eb FIX: Footer message was missing the class 2017-08-17 14:40:14 -04:00
Sam 9246bc3400 support up button from first result 2017-08-17 13:32:30 -04:00
Sam 889b99552a FEATURE: allow ctrl+shift+s to open search 2017-08-17 12:57:08 -04:00
Sam dc4d5677eb FEATURE: use `a` when search result is focused to add to composer 2017-08-17 12:39:43 -04:00
Jen d29fc781fb trigger for other backup choices 2017-08-17 10:34:24 -04:00
Jen b5823a3b03 add event for other backup choices 2017-08-17 10:34:24 -04:00
Mudasir Raza 84c83afd35 Allow optional import_mode param for posts in api (#4952) 2017-08-17 07:53:04 -04:00
Kyle Zhao 43e2c91845 fixes word wrap issue on user activity page (#5056)
By default, the width of a table and its cells are adjusted to fit
the content. Thus, longer words are not wrapped and lead to a
wider width.
2017-08-17 08:52:50 +02:00
Régis Hanol 629810bd07 FIX: when registering custom_field types, ensure we're casting them before checking for equality 2017-08-16 23:04:40 +02:00
Sam 304379d436 FEATURE: up/down arrow will highlight search result
Then you can use enter to visit result.
2017-08-16 14:14:55 -04:00
Robin Ward b78958fbfc Silence CSS logging in development - it's way too noisy 2017-08-16 10:59:56 -04:00
Sam c68999e128 annotate models
WARNING annotators out there, be to run bin/annotate on RAILS_ENV=test on a clean db
2017-08-16 10:38:11 -04:00
Sam Saffron 56f7b4e01e PERF: reindex search data without loading large post counts 2017-08-16 08:18:59 -04:00
Erick Guan 6e59149a77 FIX: rebuild index when engine replaced (#5021) 2017-08-16 07:38:34 -04:00
Erick Guan c7a101476e Spec for local auth check 2017-08-16 11:01:00 +02:00
Guo Xiang Tan b77aa29e71 Merge pull request #5013 from LeoMcA/alternate-emails-phase-1.5
FIX: add additional email to tests and clean up resulting mess
2017-08-16 16:19:28 +09:00
Guo Xiang Tan ed851dbfff FIX: Avoid publishing a gigantic payload.
* Certain sites have way too many categories.
2017-08-16 11:38:30 +09:00
jomaxro 1219ae685b Add specific class to site description on /about 2017-08-15 19:48:57 -04:00
Joffrey JAFFEUX cad6107624 refactors select-box
Note: this commit also now uses select-box for mobile topics controls
2017-08-16 00:41:56 +02:00
Neil Lalonde d506e577a5 FEATURE: if full search returns no results, show google search form 2017-08-15 16:46:41 -04:00
Robin Ward 4085c40e50 Minor CSS changes 2017-08-15 13:17:25 -04:00
Kyle Zhao c3249f6e93 FEATURE: add full editing access to queued posts (#5047)
For pending new topics: the body of the post, title, categories
and the tags are editable.

For pending new replies: only the body is applicable and thus
editable

DISCUSSION: https://meta.discourse.org/t/66754
2017-08-15 12:44:05 -04:00
Erick Guan 1146772deb Fix: unlinked topic search model (#5044) 2017-08-15 11:46:57 -04:00
Neil Lalonde 130ae2cd4b FEATURE: add Latvian language 2017-08-15 11:40:00 -04:00
Arpit Jalan b354099252 FEATURE: add custom open graph tag for ignoring canonical url 2017-08-15 19:24:20 +05:30
Sam 6002f2ca4a FIX: not splitting words correctly for search tokenizer 2017-08-14 16:19:39 -04:00
Neil Lalonde 94d8f6d734 FIX: digest emails should not include posts that are still in the edit grace period 2017-08-14 12:47:33 -04:00
Robin Ward e568be04e8 Refactor footer message to use a component 2017-08-13 16:06:26 -04:00
Robin Ward f4839da047 More consistent container class names for styling 2017-08-13 15:49:57 -04:00
Arpit Jalan de642e0b0e Merge pull request #5042 from davidtaylorhq/login-required-404
SECURITY: Do not show latest/top topics on 404 for login_required sites
2017-08-13 23:36:24 +05:30
Robin Ward 0c2d20a523 Split out `latest-topic-list-contents` component 2017-08-13 13:19:27 -04:00
Robin Ward 8ccde140e5 Convert latest-topic-list to components and remove nested tables 2017-08-13 12:45:26 -04:00
David Taylor 37300d6777 SECURITY: Do not show latest/top topics on 404 for login_required sites 2017-08-13 19:02:44 +03:00
Joffrey JAFFEUX 9e475860e0 theme color select-box should be filterable 2017-08-13 14:53:07 +02:00
Joffrey JAFFEUX 482924b161 FEATURE: initial implementation of an ember native select 2017-08-13 14:34:50 +02:00
Bianca Nenciu 7213e02dee FIX: Scroll position is tracked on search page 2017-08-13 14:24:29 +02:00
Régis Hanol 75e4f7f896 Shorten some very long lines
Prevent warnings from already defined constants when reloading
2017-08-12 04:18:04 +02:00
Régis Hanol c2061aae3d Add new 'post_moved' event 2017-08-12 04:12:09 +02:00
Régis Hanol 4f09a5a7a5 Add 'Post.permitted_create_params' to allow plugins to add new params when creating a post 2017-08-12 04:10:45 +02:00
Régis Hanol 962db8c759 Add 'beforeCreate' hook in rest model 2017-08-12 04:08:40 +02:00
Régis Hanol 13e9d2867a Add current user's primary group name class to the composer body 2017-08-12 04:06:23 +02:00
Régis Hanol 19b7658dc3 Add 'primary_group_name' to CurrentUserSerializer 2017-08-12 04:05:16 +02:00
Neil Lalonde 9813f9f0f8 FIX: more cases of case sensitive group membership in sso 2017-08-11 18:09:29 -04:00
Robin Ward c2016e2bc6 Revert "Fix up some markup to making styling latest categories easier"
This reverts commit 2589b59f39.
2017-08-11 17:08:58 -04:00
Robin Ward 2589b59f39 Fix up some markup to making styling latest categories easier 2017-08-11 16:49:15 -04:00
Arpit Jalan 51f9c23e48 UX: add a divider line between regular user fields and custom user fields
https://meta.discourse.org/t/differentiate-user-fields-on-signup-form-better/66427/2?u=techapj
2017-08-11 17:46:40 +05:30
Bianca Nenciu 117417848e Remove like on change of ownership. (#5038) 2017-08-11 09:55:00 +02:00
Guo Xiang Tan f2539a86d0 Merge pull request #5036 from tgxworld/another_pass_at_removing_duplicated_users
FIX: Staged users were incorrectly created multiple times with same e…
2017-08-11 12:30:28 +09:00
Neil Lalonde 15a74d6d3e FIX: don't enforce newuser_spam_host_threshold on private messages 2017-08-10 17:19:08 -04:00
Robin Ward e6398bac21 Accept no arguments for `NavItem` options 2017-08-10 15:16:52 -04:00
Neil Lalonde 3c538270e4 UX: placeholder text in watched word input field 2017-08-10 11:25:17 -04:00
Régis Hanol 05a74d2534 FIX: navigation item counters weren't updating properly 2017-08-10 12:22:15 +02:00
Guo Xiang Tan 793eccf6c5 FIX: Staged users were incorrectly created multiple times with same email. 2017-08-10 18:56:15 +09:00
Guo Xiang Tan b84e87dedd FIX: Don't raise an error if URL timesout. 2017-08-10 12:58:56 +09:00
Guo Xiang Tan a849959915 Fix missing parameter. 2017-08-10 11:15:51 +09:00
Guo Xiang Tan b404a4b97c Merge pull request #5034 from tgxworld/fix_staged_primary_email
FIX: Staged users are still missing primary email.
2017-08-10 10:30:51 +09:00
Robin Ward c3051b89c0 Allow explicit hover and active buttons 2017-08-09 16:39:43 -04:00
Neil Lalonde ca1609c821 FIX: user directory didn't update stats of users with no recent activity 2017-08-09 15:57:42 -04:00
Robin Ward 53e6ccf17b Allow reloading of translation keys for plugins in development mode 2017-08-09 13:58:20 -04:00
Neil Lalonde 197944edaa UX: when staff change their email address, show a message saying an email has been sent to their current address, not their new one 2017-08-09 13:43:01 -04:00
Robin Ward 5ba3a2bd9d Allow route maps to access `site` easily 2017-08-09 11:49:18 -04:00
Guo Xiang Tan 705f75dd8c Merge pull request #5032 from xrav3nz/ux-hide-options-in-adv-search
UX: exclude irrelevant search filters for anonymous users
2017-08-09 18:21:44 +09:00
Guo Xiang Tan 90d7dd1f05 FIX: Ensure that post action moderation post uses the site's default locale.
https://meta.discourse.org/t/a-post-in-looking-for-someone-to-customize-discourse-to-create-a-forum-site-requires-staff-attention/67468/5?u=tgxworld
2017-08-09 18:20:20 +09:00
Arpit Jalan e993d53260 FIX: handle missing parent category when exporting user archive
https://meta.discourse.org/t/download-my-posts-failed/67613?u=techapj
2017-08-09 14:37:21 +05:30
Arpit Jalan bf2c35aa99 FEATURE: add RSS feed for badge pages 2017-08-09 13:43:49 +05:30
Guo Xiang Tan 49c6959dfc Adjust width for membership request input field. 2017-08-09 16:05:20 +09:00
Guo Xiang Tan 898c6ba037 Merge pull request #5033 from tgxworld/reason_when_requesting_to_join_a_group
FEATURE: Force user to enter reason when requesting for group members…
2017-08-09 15:54:21 +09:00
Guo Xiang Tan a9613163b5 FEATURE: Force user to enter reason when requesting for group membership. 2017-08-09 15:45:28 +09:00
Guo Xiang Tan 0bc690ed11 FIX: Staged users are still missing primary email. 2017-08-09 12:03:49 +09:00
Neil Lalonde c4b49fbabe send args to user-preferences-nav plugin outlet 2017-08-08 17:30:10 -04:00
Kyle Zhao cea2a9fe53 UX: exclude irrelevant search filters for anonymous users
On the advanced search page, filters like "I've read", "I'm watch
-ing", etc, are irrelevant to anonymous users and should be hidden
2017-08-08 15:25:40 -04:00
Régis Hanol 15fa27a1ff Add warning when using the 'modifyClass' plugin API after it's been cached in the container 2017-08-08 20:07:35 +02:00
Arpit Jalan e36a20660d FIX: handle topics without excerpt for meta description tag 2017-08-08 22:17:05 +05:30
Régis Hanol d182f0f2d1 Add support for preloaded custom_fields on Group 2017-08-08 15:45:27 +02:00
Régis Hanol 76a217c4bc add support for classNames binding in Navigation Item 2017-08-08 15:44:31 +02:00
Robin Ward 6ecb7cdff4 UX: Support for `none` style of category badge 2017-08-07 12:49:19 -04:00
Régis Hanol 4bfb049054 Add new 'group-edit' plugin outlet 2017-08-07 18:16:54 +02:00
Régis Hanol 770efee25f Add support for disabled attribute to the d-checkbox component 2017-08-07 18:16:43 +02:00
Robin Ward 2e4b3e9b06 Don't include all html builders on client and server side 2017-08-07 11:29:35 -04:00
Régis Hanol 4c306f9f49 New 'topic:current-post-changed' application event 2017-08-07 15:56:08 +02:00
Régis Hanol 125cc356f3 FIX: don't break the site when adding a navigation item without a 'name' field 2017-08-07 10:45:35 +02:00
Régis Hanol ce7d97a9a8 move title computed property back to nav-item so it can be overriden in a plugin 2017-08-07 09:53:03 +02:00
Guo Xiang Tan f496302c2c `order` scope is ignored when using `find_each`. 2017-08-07 11:46:18 +09:00
Guo Xiang Tan 3f24ed2b3e Can't revert due to incompatibility of new site setting types.
Revert "Revert "FEATURE: Site settings defaults per locale""

This reverts commit 439fe8ba24.
2017-08-07 10:43:09 +09:00
Guo Xiang Tan 439fe8ba24 Revert "FEATURE: Site settings defaults per locale"
This reverts commit 468a8fcd20.
2017-08-07 10:31:50 +09:00
Régis Hanol 4b53fe3cc7 new 'addNavigationBarItem' plugin api 2017-08-05 02:23:35 +02:00
Régis Hanol e958500735 extract 'timeline-controls' and 'timeline-footer-controls' widgets 2017-08-05 01:22:01 +02:00
Leo McArdle a7b7fe335f FIX: allow an admin to click on blank errors (#5027)
* FIX: allow an admin to click on blank errors

* i18nlize strings

* what would a rails master do?
2017-08-04 20:04:26 +02:00
Robin Ward a3ef814245 UX: Show proper HTML for category preview in site settings 2017-08-04 13:56:27 -04:00
Robin Ward 58d452fc41 FIX: Site setting previews were not rendering 2017-08-04 13:48:02 -04:00
Régis Hanol 3c0de22bf0 FIX: wasn't able to remove a user's primary group 2017-08-04 18:13:20 +02:00
Régis Hanol 519b70ea46 FIX: always trigger the ':user_updated' event
We don't always use the UserUpdated class to update a user's record
2017-08-04 18:12:10 +02:00
Régis Hanol c26ba890bd prevent N+1 when loading custom emojis 2017-08-04 17:04:59 +02:00
Leo McArdle 99527af38a FIX: show rejected emails with unrecognized errors (#5026)
Although 407a23663d will send rejection
messages for unrecognized errors, sometimes processing the email will
raise an error which has a blank message.

This commit:

1. Shows rejected emails which have already been processed and contain
   a blank error in /admin/email/rejected

2. Replaces new blank error messages with the error type
2017-08-04 16:20:44 +02:00
Guo Xiang Tan 40fc6c429a Merge pull request #5018 from discourse/wekbit-embedded-referer
FIX: First load of embed comments would always fail on WebKit
2017-08-04 14:12:26 +09:00
Robin Ward 2589b17cb7 Add wrapper divs with classes to the topic footer button area 2017-08-03 15:59:26 -04:00
Robin Ward 82230a1830 Support forcing badge styles 2017-08-03 14:55:36 -04:00
Arpit Jalan 2d95b9dfbf FIX: prevent Cloudflare from obfuscating emails
https://support.cloudflare.com/hc/en-us/articles/200170016-What-is-Email-Address-Obfuscation-
2017-08-03 15:06:13 +05:30
Guo Xiang Tan a47e297508 Merge pull request #5019 from tgxworld/more_resiliency_to_readonly_redis
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-03 06:34:36 +09:00
Robin Ward edc7fae0b0 FIX: The ellipsis should be a `flat-button` 2017-08-02 17:30:40 -04:00
Sam 5942ad83c0 Skip inline onebox for domain only 2017-08-02 17:27:58 -04:00
Rafael dos Santos Silva 57a214e920 FIX: First load of embed comments would always fail on WebKit 2017-08-02 17:43:31 -03:00
Sam 902be91a5a FEATURE: CTRL+/ to trigger search even from composer 2017-08-02 16:26:03 -04:00
Sam a4e1920604 FIX: inline oneboxer not applying to lists 2017-08-02 16:10:08 -04:00
Erick Guan 468a8fcd20 FEATURE: Site settings defaults per locale
This change-set allows setting different defaults for different locales. 

It also:

- Adds extensive testing around site setting validation

- raises deprecation error if site setting has the default property based on env

- relocated site settings for dev and tests in the initializer

- deprecated client_setting in the site setting's loading process

- ensure it raises when a enum site setting being set

- default_locale is promoted to `required` category.

- fixes incorrect default setting and validation

- fixes ensure type check for site settings

- creates a benchmark for site setting

- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
Neil Lalonde 3de45ce0cd FIX: use case insensitive group name search when applying group rules from SSO 2017-08-02 11:30:37 -04:00
Guo Xiang Tan 33e22cf598 Add back `Admin::GroupsController#index` route for now.
* The endpoint is being used by discourse_api.
2017-08-03 00:24:23 +09:00
Neil Lalonde be30d4510a FIX: change email success message container was too narrow 2017-08-02 10:50:18 -04:00
Neil Lalonde 47fa536f46 FIX: plugin outlet in user preferences nav needs to be li tag 2017-08-02 10:05:11 -04:00
Guo Xiang Tan 9bc3038728 Fix Redis command errors when trying to start app with a readonly Redis. 2017-08-02 21:33:56 +09:00
Guo Xiang Tan 1c80c233cf FIX: Adding group owners returns 400 error. 2017-08-02 19:18:41 +09:00
Régis Hanol e43799134c fix the regexp used to valide user's website 2017-08-02 10:19:24 +02:00
Benjamin Elijah Griffin d471ad08c6 Website RE validator without a 10 char limit on TLD. 2017-08-01 23:37:28 -07:00
Jeff Atwood 3538b63305 FIX: on desktop, anon topic reply btn too far over 2017-08-01 16:47:52 -07:00
Robin Ward 53e78edbef Silence ESLint 2017-08-01 17:26:49 -04:00
Robin Ward 8dd7c0c984 UX: Convert buttons to `d-button` 2017-08-01 17:24:06 -04:00
Robin Ward 75d10a4098 UX: Add consistent classes to buttons 2017-08-01 17:24:06 -04:00
Robin Ward 513b7bf706 REFACTOR: DRY up New Topic button code 2017-08-01 15:04:07 -04:00
Guo Xiang Tan bd0efb8525 Fix the build. 2017-08-01 17:57:26 +09:00
Guo Xiang Tan 1197750e7d PERF: Allow plugins to preload custom fields for topics in `CategoryList`. 2017-08-01 17:27:28 +09:00
Matt Palmer 67882ec37d Hunt-and-kill a few more mis-encoded params
https://meta.discourse.org/t/tags-does-not-work-with-cyrillic/67217/6?u=mpalmer
2017-08-01 18:03:44 +10:00
Matt Palmer 7ee861f457 FIX: Return a UTF-8 string in tag notifications
https://meta.discourse.org/t/tags-does-not-work-with-cyrillic/67217
2017-08-01 16:27:52 +10:00
Neil Lalonde fa3c240e8b Merge pull request #4981 from dmacjam/fix_limited_search_results
FIX: limited search results
2017-07-31 20:23:57 -04:00
Leo McArdle 836dee1120 FIX: add additional email to tests and clean up resulting mess 2017-07-31 22:27:29 +00:00
Neil Lalonde ec85b41078 UX: Move watched words to the Logs section of admin 2017-07-31 17:06:50 -04:00
Robin Ward ce27783da4 UX: Add new plugin outlet before reply count 2017-07-31 16:50:25 -04:00
Neil Lalonde 7c1d7fb423 Merge branch 'master' into fix_limited_search_results 2017-07-31 15:55:31 -04:00
Erick Guan f1eccd113c Replace rmmseg gem for cppjieba_rb since better dictionary (#5006)
* Rename locale to ts config in search module to make it clear

* Replace rmmese-cpp for cppjieba_rb
2017-07-31 15:28:48 -04:00
Arpit Jalan 6c997b65d9 optimize enqueuing activation email code 2017-07-31 22:57:39 +05:30
Arpit Jalan 0b01d0e95d FIX: staff cannot manually activate accounts after 48 hours has elapsed
https://meta.discourse.org/t/staff-cannot-manually-activate-invited-accounts-after-48-hours-has-elapsed/66292/14?u=techapj
2017-07-31 22:24:09 +05:30
Neil Lalonde 5d528f0d15 Merge pull request #4958 from dmacjam/search_posts_by_filetype
FEATURE: Search posts by filetype
2017-07-31 11:55:34 -04:00
Neil Lalonde 4a5907b116 Merge branch 'master' into search_posts_with_images 2017-07-31 10:44:41 -04:00
Robin Ward 31deebc8e6 FIX: Extra `<` character after icon refactor 2017-07-31 10:18:56 -04:00
Arpit Jalan 2e2b5e28aa FIX: add slight delay when enqueuing activation email 2017-07-31 16:52:07 +05:30
Jakub Macina f8edf2636c Fix rspec tests for search pagination. 2017-07-31 12:16:23 +02:00
Guo Xiang Tan 83bb042311 FIX: `Group#visibility_level` isn't shown in admin group edit page. 2017-07-31 16:34:22 +09:00
jomaxro 65c4e81bb2 Add placeholder text to group member add field 2017-07-30 23:52:46 -04:00
Guo Xiang Tan 24e0e000b9 FIX: Always validate presence of user's primary_email. 2017-07-31 11:47:29 +09:00
Robin Ward 307311fdb1 Add class to admin wrench button 2017-07-28 16:38:10 -04:00
Robin Ward 15fa514791 Add classes to notification dropdown buttons 2017-07-28 16:35:14 -04:00
Robin Ward 67556e6381 REFACTOR: Category / Tag Dropdown headers had extra classes 2017-07-28 16:19:33 -04:00
Robin Ward e4c2b5e430 REFACTOR: CSS improvements to improve targetting and remove !important 2017-07-28 15:52:57 -04:00
Sam a13d146251 Correct post deletion spec so it is async 2017-07-28 10:50:18 -04:00
Sam 64d54bc549 FIX: when quoting add a newline
so **highlight** > quote

Does not end like:

[quote]
test
[quote]~
2017-07-28 10:49:49 -04:00
Sam ae68795d82 FIX: deleting own post results in error 2017-07-28 10:14:11 -04:00
Guo Xiang Tan 4620dfe92d FEATURE: Add group settngs to allow users to leave a group freely.
https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565
2017-07-28 15:00:25 +09:00
Guo Xiang Tan 5012d46cbd Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
Robin Ward ff4e295c4f FIX: Notifications dropdown had incorrect spacing 2017-07-27 19:22:19 -04:00
Sam 4f574e7c93 FEATURE: support inline bbcode blocks eg: [quote]test[/quote] 2017-07-27 17:55:17 -04:00
Robin Ward c3b7419a08 UX: Remove `hidden` from the `#discourse-modal` when the modal is shown 2017-07-27 17:14:41 -04:00
Robin Ward 1b1fd64639 FIX: Badge icons disappeared 2017-07-27 16:57:26 -04:00
Robin Ward 41afd9c818 Bump Plugin API version for icon api 2017-07-27 15:13:03 -04:00
Robin Ward 6dfa3625df REFACTOR: Replace `fa-*` in SCSS with `d-icon-*` 2017-07-27 15:09:30 -04:00
Robin Ward 5b590b9637 REFACTOR: Replace some `fa-*` uses with helpers 2017-07-27 14:55:41 -04:00
Robin Ward d0c41a578e Rename `{{fa-icon}}` to `{{d-icon}}` so it can be more generic 2017-07-27 14:55:41 -04:00
Neil Lalonde 68b3dd43ce fix intermittent failing tests, some watched word refactoring 2017-07-27 12:27:01 -04:00
Robin Ward 5cfc2d8972 Run wizard specs in docker:test 2017-07-27 11:29:18 -04:00
Robin Ward 32c9ad6f7f FIX: Wizard was broken 2017-07-27 10:48:31 -04:00
Guo Xiang Tan 75374c76b3 UX: Display button to message group on group page.
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 17:51:25 +09:00
Guo Xiang Tan 4d25d61e9c UX: Change group membership requests icons on groups pages.
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 16:24:15 +09:00
Guo Xiang Tan 2442bba131 UX: Better group creation workflow.
* Owners and users can now be added to a group during creation.

https://meta.discourse.org/t/you-cannot-allow-membership-requests-without-any-owners/64760/3
2017-07-27 16:12:42 +09:00
Guo Xiang Tan fd95c971ec REFACTOR: Better variable name. 2017-07-27 16:10:53 +09:00
Robin Ward e87125b63c FEATURE: Plugins can overwrite and add support for new icons 2017-07-26 13:21:17 -04:00
Neil Lalonde 24cb950432 FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block 2017-07-26 11:01:09 -04:00
David Taylor 27539e15e1 Allow whitespace around % scaler in markdown image syntax (#5000) 2017-07-26 10:54:20 -04:00
Neil Lalonde ea0e90b2b0 Merge branch 'master' into search_posts_with_images 2017-07-26 10:15:55 -04:00
David Taylor febd7621ea Qunit plugin rake tasks (#4985)
* Allow running specific plugin tests using ENV variables

* Add a `rake plugin:qunit` task to match the existing `rake plugin:spec` task

* Improve docker.rake to allow running specific plugin qunit tests

* Purge cache before and after qunit tests

* Stop module auto-loader trying to auto-load tests

* Use URL query parameters to pass config into Qunit, avoiding caching issues

* Oops, searchParams doesn’t work in phantomJS. Parse the URL manually.

* Escape ampersands before passing URL to phantomJS, otherwise multiple parameters go wrong
2017-07-26 09:07:46 -04:00
Guo Xiang Tan 917d186303 REFACTOR: Reduce number of queries sent to the DB. 2017-07-26 17:20:00 +09:00
Guo Xiang Tan 3a46ea8bad Sanitize SQL arguments to prevent injections. 2017-07-26 17:20:00 +09:00
Guo Xiang Tan f9627f4533 UX: Don't show empty user list for groups without members. 2017-07-26 16:11:06 +09:00
Guo Xiang Tan b59dfb86f4 UX: Include group name in email when group is invited to a PM.
https://meta.discourse.org/t/xyz-invited-you-to-a-message-but-really-invited-a-group-im-in/65996
2017-07-26 15:51:44 +09:00
Guo Xiang Tan 93130b15e3 Fix invalid CSS syntax. 2017-07-26 10:38:34 +09:00
Guo Xiang Tan e3ac6585bd FIX: Search by topic_id should not be restricted by `SiteSetting.min_search_term_length`. 2017-07-26 09:52:39 +09:00
cpradio feb423d07a Update ul padding/margin to match ol.
https://meta.discourse.org/t/numbers-cut-off-in-long-list/59856/16?u=cpradio
2017-07-25 18:54:28 -04:00
Sam ec2506c32b Merge pull request #4996 from ryantm/patch-2
safely call html_safe on category description
2017-07-25 15:34:07 -04:00
Sam 17d56a4cb7 FEATURE: use Markdown for image pasted in as opposed to IMG tags 2017-07-25 15:11:38 -04:00
Neil Lalonde d8c27e3871 Merge branch 'master' into search_posts_by_filetype 2017-07-25 14:41:20 -04:00
Ryan Mulligan f3f7dd02d1 safely call html_safe on category description
The `categories.description` column is not modified as "not null", so it is possible for the description to be nil. This changes the code not call html_safe on nil.
2017-07-25 11:40:02 -07:00
Sam 0d66a41753 Merge pull request #4989 from begrif/html-safe-category-desc
Stop Rails from escaping the HTML in this description.
2017-07-25 13:41:30 -04:00
Robin Ward f2e592c1ab UX: Apply `btn-flat` class to flat buttons on posts 2017-07-25 12:00:19 -04:00
Robin Ward 3152eabbb0 UX: Use flat button style for bulk selection 2017-07-25 12:00:19 -04:00
Robin Ward 5da848088a UX: Refactor composer buttons into flat buttons 2017-07-25 12:00:19 -04:00
Régis Hanol d67fe4c674 FIX: block all emails associated to a user when destroying their record 2017-07-25 17:44:46 +02:00
Guo Xiang Tan 601064a95a Remove stray debugger. 2017-07-25 22:51:47 +09:00
Guo Xiang Tan bdf1be65a3 FIX: Broken topic invite button. 2017-07-25 22:48:10 +09:00
Jakub Macina 2d45b3fc6d Add infinite loading to full page search. 2017-07-25 15:33:25 +02:00
Joffrey JAFFEUX 8556d3c27f FIX: emoji-picker do not reload all everything when changing diversity 2017-07-25 12:23:38 +02:00
Joffrey JAFFEUX 22c5fb20b4 FIX: emoji-picker broken and skipped specs 2017-07-25 12:23:38 +02:00
Régis Hanol c7c93e7159 FEATURE: new 'strip image metadata' site setting 2017-07-25 11:48:39 +02:00
Guo Xiang Tan 6c0a29698b Fix JS tests failing when running in `RAILS_ENV=test`.
Fixes the following error:

```
phantomjs /home/tgxworld/work/discourse/vendor/assets/javascripts/run-qunit.js http://localhost:60099/qunit
2017-07-25 16:27:41 +0900: Rack app error handling request { GET /stylesheets/desktop.css }
<Errno::ENOENT: No such file or directory @ rb_sysopen - /home/tgxworld/work/discourse/tmp/stylesheet-cache/desktop.css>
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:65:in `write'
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:65:in `show_resource'
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:9:in `show'
```
2017-07-25 16:31:31 +09:00
awesomerobot 3905d6bc0d mildly lighter @mention 2017-07-24 22:26:14 -04:00
Jeff Atwood df653a2350 Merge pull request #4991 from awesomerobot/master
fixing @mention color
2017-07-24 18:33:00 -07:00
awesomerobot 3dd79b3b3a fixing @mention color 2017-07-24 21:11:14 -04:00
Benjamin Elijah Griffin 4f77ca72a3 Stop Rails from escaping the HTML in this description. 2017-07-24 17:15:15 -07:00
Sam 4da98cdcfe FIX: allow bbcode to be unquoted for default 2017-07-24 18:36:17 -04:00
Neil Lalonde 25097deb39 FIX: saving profile preferences removes name in account preferences 2017-07-24 13:13:50 -04:00
Sam 40abcfc2f5 FIX: smart quote edge case with quotes 2017-07-24 12:21:49 -04:00
Sam Saffron 045a2abcec FEATURE: remove the timecop gem
We should only have one way of mocking time, misuse of timecop
was causing build stability issues
2017-07-24 12:11:10 -04:00
Robin Ward 5dd56a41d9 Merge branch 'master' into master 2017-07-24 12:01:48 -04:00
Neil Lalonde b5a375c70a FIX: oops, real fix for change email instructions 2017-07-24 11:15:55 -04:00
Neil Lalonde 1f1d84c378 FIX: wrong position for change email instructions 2017-07-24 11:14:36 -04:00
Guo Xiang Tan 6b17178533 Validate uniquness of `api_key`. 2017-07-24 21:46:08 +09:00
Joffrey JAFFEUX d9696c98c3 FIX: broken spec 2017-07-24 13:59:36 +02:00
Joffrey JAFFEUX 995d253030 FIX: improves efficiency 2017-07-24 12:42:54 +02:00
Guo Xiang Tan 1b0750d7ef Merge pull request #4983 from tgxworld/group_owners_can_invite_users_to_groups
Group owners can invite users to groups
2017-07-24 16:21:19 +09:00
Guo Xiang Tan 6593f0355f FIX: Exclude `www` in topic map links.
https://meta.discourse.org/t/topic-popular-links-panel-domain-extraction-doesnt-handle-country-tlds/60156/38?u=tgxworld
2017-07-24 10:14:33 +09:00
Guo Xiang Tan 887c3b66f5 Revert "UX: Don't try to figure out root domain."
This reverts commit 7690cc6ca5.
2017-07-24 09:40:57 +09:00
Régis Hanol 65ab5f58fe FIX: keep newlines between paragraphs when quoting a post 2017-07-23 15:25:28 +02:00
David Taylor 2ddf365e3a Fix user stats colour for dark themes 2017-07-22 23:48:31 +01:00
Joffrey JAFFEUX f68e711fb2 FIX: makes emoji filter case insensitive 2017-07-22 22:48:22 +02:00
Jeff Atwood bc9270defb filetype comparison needs to be case insensitive 2017-07-22 13:18:15 -07:00
Joffrey JAFFEUX e2e0221dd7 FIX: make sure there are meaningful titles on the picker 2017-07-22 17:32:12 +02:00
Robin Ward bc3a32385c FIX: Empty lines should be selected for block quotes 2017-07-21 16:32:29 -04:00
Sam 9b4f5710e6 api cleanup for before / after rules 2017-07-21 16:12:11 -04:00
Joffrey JAFFEUX bb35d9fc07 FIX: do not restore scroll on successive click on the same first emoji 2017-07-21 21:42:23 +02:00
Robin Ward 2f8f2aa1dd FEATURE: Whitelists for inline oneboxing 2017-07-21 15:41:47 -04:00
Arpit Jalan 9727977fef Fix the build. 2017-07-22 00:34:39 +05:30
Joffrey JAFFEUX 8c17596aa5 FIX: keep scroll position when adding first recent emoji 2017-07-21 20:57:17 +02:00
Joffrey JAFFEUX cdefb58018 FIX: emoji-picker filtering false positive 2017-07-21 20:42:34 +02:00
Arpit Jalan 6d09fbde44 UX: use down chevron icon to expand "show more links.." 2017-07-22 00:10:37 +05:30
Régis Hanol fff5e2c3a5 Merge pull request #4984 from LeoMcA/unrecognized-error-email
FEATURE: send rejection email for unrecognized errors
2017-07-21 20:40:18 +02:00
Robin Ward 574681dc47 FIX: Show emoji in inline oneboxes 2017-07-21 14:24:48 -04:00
Joffrey JAFFEUX c2db2c5c78 FIX: do not store scroll position in local storage 2017-07-21 20:18:32 +02:00
Joffrey JAFFEUX d5f53da43f FIX: filtered emojis now correctly include custom emojis 2017-07-21 19:46:40 +02:00
Joffrey JAFFEUX e36d9f55c3 replaces links/imgs by buttons in the emoji-picker 2017-07-21 19:42:50 +02:00
Joffrey JAFFEUX 54e0075a3e use the EMOJI_VERSION constant 2017-07-21 19:42:49 +02:00
Leo McArdle 407a23663d FEATURE: send rejection email for unrecognized errors 2017-07-21 18:26:52 +01:00
Sam e1ce47a901 Pass the full CommonMark spec 2017-07-21 13:20:52 -04:00
Robin Ward aa5b8a5749 REFACTOR: Merge onebox and inline onebox code paths 2017-07-21 13:12:30 -04:00
Leo McArdle ddc0134b48 add DiscourseEvent triggers necessary to update a user's permissions before they're notified 2017-07-21 11:03:54 -04:00
Guo Xiang Tan 2a17f1ccd7 FIX: Group owners should be able to invite users to their groups.
https://meta.discourse.org/t/group-owner-cannot-send-an-invite-to-a-group/60617/12
2017-07-21 23:48:25 +09:00
Joffrey JAFFEUX c7f2b0fe58 tweaks to copy and styles 2017-07-21 14:19:04 +02:00
Joffrey JAFFEUX 79c8b505e8 FIX: faster successive loading of emojis 2017-07-21 14:18:02 +02:00
Joffrey JAFFEUX 1ce1953ee1 FIX: makes sure we don’t track when clicking on recent emojis 2017-07-21 13:35:55 +02:00
Joffrey JAFFEUX c906bd3f22 emoji-picker refactoring 2017-07-21 13:35:29 +02:00
Joffrey JAFFEUX 1ca0c33802 FIX: dot not close emoji-picker when click is inside picker 2017-07-21 12:01:39 +02:00
Joffrey JAFFEUX 0c9ea1aaf2 reduce emoji loading threshold 2017-07-21 11:46:34 +02:00
Jakub Macina 44bd8f3837 Add info about more results to full-page search frontend. 2017-07-21 09:35:04 +02:00
Robin Ward 657e592a39 FIX: Oneboxes were not being previewed 2017-07-20 17:12:54 -04:00
Jeff Atwood 18d1ff0c0a Merge pull request #4980 from cpradio/fix-ol-margin-padding
Fix ol margin/padding so it displays ordered lists without cutting them off.
2017-07-20 13:58:17 -07:00
Robin Ward 3882722195 FEATURE: Inline (Mini) Oneboxing
see:
https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 15:38:04 -04:00
Sam 44fb2a2833 DEV: support multiple capture groups for text post process 2017-07-20 15:33:44 -04:00
Joffrey JAFFEUX d7a20c8e93 FIX: Object.assign is not supported in all browsers 2017-07-20 20:27:59 +02:00
Joffrey JAFFEUX ac6413f456 FIX: broken specs 2017-07-20 20:08:11 +02:00
Sam 1096dcd602 correct bbcode parsing edge case 2017-07-20 13:02:40 -04:00
Sam 0791d740a6 FIX: only highlight exact word matches in results
- also fixes phrase highlighting
2017-07-20 12:26:46 -04:00
Jakub Macina e5ee4ccc48 Add pagination and checking for more results to search. 2017-07-20 18:12:34 +02:00
Jakub Macina 7b40de5ac4 Add attribute to grouped search results for more available posts. 2017-07-20 18:07:13 +02:00
Sam 911ffbb98c Correct mention edge cases
@sam. was not correctly detected as a mention
2017-07-20 11:52:38 -04:00
Joffrey JAFFEUX a9ab3f9ef0 FIX: emoji-picker positioning glitches on few edge cases 2017-07-20 17:03:45 +02:00
cpradio 8101b630f2 Fix ol margin/padding so it displays ordered lists without cutting them off.
https://meta.discourse.org/t/numbers-cut-off-in-long-list/59856
2017-07-20 11:03:04 -04:00
Joffrey JAFFEUX a5a3651cf3 FIX: improves emoji-picker handling of its different states
- closing modal with escape
- using modal less frequently
- closing the picker by clicking anywhere
2017-07-20 16:08:25 +02:00
Régis Hanol bf6c3b7017 FIX: don't error out when an unsubscribe key isn't associated to a user anymore 2017-07-20 12:24:24 +02:00
Leo McArdle d0b027d88d FEATURE: phase 1 of supporting multiple email addresses 2017-07-20 11:22:27 +09:00
Joffrey JAFFEUX 739794f0cb resets img src before changing it 2017-07-19 23:24:50 +02:00
Joffrey JAFFEUX 26a7ae3750 increase time needed to load section in emoji-picker 2017-07-19 23:20:27 +02:00
Joffrey JAFFEUX d27f744d16 refactor async code of the emoji-picker 2017-07-19 22:54:58 +02:00
Joffrey JAFFEUX ce982d9935 enforce that emoji-picker is not active by default 2017-07-19 22:54:57 +02:00
Joffrey JAFFEUX bb7241ccc2 simplify emoji-picker recent usage logic 2017-07-19 22:54:56 +02:00
Joffrey JAFFEUX 0112b9aa43 FIX: emoji-picker works with dark theme 2017-07-19 22:54:56 +02:00
Joffrey JAFFEUX f32950a475 unbind div-resizing event 2017-07-19 22:54:55 +02:00
Joffrey JAFFEUX bd0607b15b makes emoji-picker position more dynamic 2017-07-19 22:54:55 +02:00
Joffrey JAFFEUX d2581bbf21 FIX: make sure the emoji picker is hidden 2017-07-19 22:54:54 +02:00
Joffrey JAFFEUX d238de87a4 FIX: infinite rebinding when filtering emojis 2017-07-19 22:54:53 +02:00
Joffrey JAFFEUX d1f2b981b5 scope .section-group to .emoji-picker 2017-07-19 22:54:52 +02:00
Joffrey JAFFEUX 69a52cca83 improve emoji picker filter style 2017-07-19 22:54:52 +02:00
Joffrey JAFFEUX 8620662ac7 do not display clear on windows 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX a1de26d614 more consistent positioning 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 81c1cc4f22 should be a const 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 33c1ce8d55 better scroll/touch handling on mobiles 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX b3454b535f refactoring 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 4ef52d5e88 correctly hide the picker 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 8d91e7d493 pixel perfect position 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 2322118d4f es-lint 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX c99a5bce8f faster tests 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX b83f430ef0 better positioning on mobile devices 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 8cf7e614d9 move picker at top of the screen on mobile 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 9956a58df0 uses es6 shorthands 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 0b98bfe1dc function is not needed 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 7739b2f53e reduces element search scope 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX d992ef24ce emphasizes it's a jquery object 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX b5c5c9c883 formating 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 6ebdf86ec1 storing scroll position every 100 ms should be enough 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 9a4dcd1a1c es-lint 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX bd0e5b91c0 function is not needed 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX f4c20472d2 refactoring 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 80ff685148 disable modale escape for now 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 60c0b5f0d2 bind hover only on desktop 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 38be969727 do not apply touch start hack on emojis 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 89573e3427 simplifying code 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 03508b72b9 clarification 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 6a4d74d9f8 performance/memory optimizations 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 2a0dcedb3d fixes regression 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 9664fd7302 fixes es-lint errors 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 6de258d4cf FEATURE: Introduces new emoji-picker 2017-07-19 16:48:23 +02:00
Guo Xiang Tan 87a1ff15fd Treat URL as loaded when loading script with tag. 2017-07-19 10:25:13 +09:00
Sam c7b0764089 correct more edge cases with new engine 2017-07-17 17:44:48 -04:00
Sam 8921058c67 FIX: medium URL with @ incorrectly handled as mention
Also:

- remove unused code
- rename bbcode_ruler to bbcode.ruler
- add md.core.textPostProcess.ruler to apply at end of chain (excluding links)
2017-07-17 17:44:48 -04:00
Robin Ward 29d529020b UX: Allow site settings to display as textareas if they like 2017-07-17 16:38:26 -04:00
Robin Ward cdb3706025 Track clicks on topics in search results 2017-07-17 15:42:32 -04:00
Robin Ward 21e02d6969 Include the `search_log_id` in search results 2017-07-17 12:10:32 -04:00
Sam Saffron d0c5205a52 Feature: Change markdown engine to markdown it
This commit removes the old evilstreak markdownjs engine.

- Adds specs to WhiteLister and changes it to stop using globals
    (Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
    CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs
2017-07-17 11:41:34 -04:00
Guo Xiang Tan 2ddf2e0e95 FIX: Concurently loading deferred loading of a script incorrectly resolves the promise. 2017-07-17 14:41:46 +09:00
Guo Xiang Tan d613f3f559 Fix guard against concurrently loading of assets. 2017-07-17 13:04:30 +09:00
Guo Xiang Tan c5401a0927 Log errors when trying to load a `markdown-it-bunlde.js`. 2017-07-17 11:21:57 +09:00
awesomerobot c29b7aa65d initial pass at color simplification 2017-07-14 21:43:35 -04:00
Robin Ward 610728a70f FIX: Don't include images in the topic map top links 2017-07-14 16:37:41 -04:00
Robin Ward 6b6ad9391b Clean up job for search logs 2017-07-14 14:30:58 -04:00
Robin Ward 97e211f837 FEATURE: Log Search Queries 2017-07-14 14:30:58 -04:00
Neil Lalonde 951fd1219d FIX: set a max height for the tag input field 2017-07-14 12:00:35 -04:00
Guo Xiang Tan 9792e03c63 FIX: Group name was being reverted to non-localized version.
https://meta.discourse.org/t/localized-staff-group-names-changed/65360/16
2017-07-14 14:15:33 +09:00
Neil Lalonde 3ebd8838af FEATURE: cross-domain tracking for Google universal analytics 2017-07-13 15:21:44 -04:00
Sam 79a084dd58 Revert "remove old markdown engine work-in-progress"
This reverts commit ee470b5317.
2017-07-12 18:10:51 -04:00
Sam bcbb9f208d Revert "Integrate new engine, correct old specs"
This reverts commit f1b38ba4fb.
2017-07-12 18:10:07 -04:00
Sam d609f8a53c Revert "correct more specs"
This reverts commit 40bcc6bbdc.
2017-07-12 18:10:05 -04:00
Sam 40bcc6bbdc correct more specs 2017-07-12 17:44:40 -04:00
Sam f1b38ba4fb Integrate new engine, correct old specs
corrects edge cases with

- full quotes
- [url] with nested tags
- engine overrides
- onebox applying to non http srcs
2017-07-12 17:44:40 -04:00
Sam Saffron ee470b5317 remove old markdown engine work-in-progress 2017-07-12 17:44:40 -04:00
Neil Lalonde 24db001bfa FIX: user card contents can go up out of the bounds of the card when user has a title and full name 2017-07-12 16:16:59 -04:00
Arpit Jalan 76981605fa FIX: don't raise error when inviting existing user to private topic via email
https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994
2017-07-12 21:51:21 +05:30
Jakub Macina 677267ae78 Add onceoff job for uploads migration of column extension. Simplify filetype search and related rspec tests. 2017-07-12 17:19:27 +02:00
Régis Hanol a6dff79c2c change log level to info when failing to download a hotlinked image 2017-07-12 11:06:28 +02:00
Sam 98e03b04b5 Don't depend on imports for md extensions 2017-07-11 16:48:25 -04:00
Sam 5d139e461c FIX: multi option poll not working (new engine) 2017-07-11 14:43:34 -04:00
Sam 3f950a756a FEATURE: support image dimensions via Markdown image 2017-07-11 12:13:03 -04:00
Robin Ward 1163c086a3 FIX: Missing `model` binding 2017-07-11 11:19:49 -04:00
Arpit Jalan 3fb1c21dd5 Fix the build. 2017-07-11 19:26:33 +05:30
Sam 9840e4285d Merge pull request #4962 from nbianca/add_composer_events
Added events to show and hide the preview pane.
2017-07-11 08:26:25 -04:00
Arpit Jalan 35fb45749d FIX: remove unneeded code 2017-07-11 13:21:41 +05:30
Guo Xiang Tan 31932813b7 FIX: Wait for CSS transition to end before attempting to focus.
https://meta.discourse.org/t/tab-should-work-after-edit-title-or-using-hotkeys/65792
2017-07-11 15:26:57 +09:00
Guo Xiang Tan 3ff9133f85 FIX: Only trigger callback for parent transition events.
* This fixes a bug where multiple requests were being
  made to the server whenever the composer is opened.
2017-07-11 15:09:22 +09:00
Guo Xiang Tan f529cb1674 Remove validation for invalid interpolation keys.
* Our codebase currently supports custom interpolations keys that are
  not present in the original translation. The proper fix should
  be to make `TranslateOverride` aware of such keys.
2017-07-11 11:12:11 +09:00
Guo Xiang Tan c5b1317a15 Remove code that is no longer being used. 2017-07-11 11:11:51 +09:00
Bianca Nenciu 375eb290b9 Made changes as per review. 2017-07-10 23:28:35 +01:00
Bianca Nenciu 1e7f0fd8f1 Added events to show and hide the preview pane. 2017-07-10 20:23:56 +01:00
Robin Ward 31f7640335 FIX: Allow discourse app to link directly to wizard 2017-07-10 14:31:58 -04:00
Robin Ward dcdd5baf54 FIX: Only show search if there are more total posts than the chunk size 2017-07-10 13:46:50 -04:00
Sam ba9898c5a9 FIX: smarter newline handling for <img> tags on line alone
Run all of pretty text spec on new engine
2017-07-10 12:22:15 -04:00
Régis Hanol c66b9dcdbd add 'us-east-2' S3 region 2017-07-10 15:36:38 +02:00
Arpit Jalan 3b1b00a869 FIX: invited user should not be able to redeem invite as admin 2017-07-10 07:47:37 +05:30
Robin Ward f1a6449e4b SECURITY: Remove disposable invite feature 2017-07-07 20:24:39 -04:00
Sam 9fb180f839 we don't want that console.log 2017-07-07 16:38:52 -04:00
Sam 6f09df0deb FIX: don't create tags autolinks inside links (new engine) 2017-07-07 13:04:25 -04:00
Sam 436b894f7a FIX: mention not working after a newline (new engine) 2017-07-07 11:06:50 -04:00
Robin Ward fa2eb8dab1 UX: Reply button was offset improperly when anonymous 2017-07-06 15:05:45 -04:00
Jakub Macina 8c445e9f17 Fix backend code for searching by a filetype as a combination of uploads and topic links. Add rspec test for extracting file extension in upload. 2017-07-06 19:19:31 +02:00
Jakub Macina f0a674d620 Add extraction of upload extension. Add rspec test for search of post
with upload by extension.
2017-07-06 19:16:07 +02:00
Guo Xiang Tan e92acb4c40 FIX: `Jobs::PullHotlinkedImages#is_valid_image_src` returns true for a generic string. 2017-07-06 18:31:15 +09:00
Régis Hanol 405672f8e6 Merge pull request #4957 from jjaffeux/google-classic
FIX: s/google_blob/google_classic
2017-07-06 10:29:40 +02:00
Guo Xiang Tan b49579d9a7 FIX: Disable topic status info when no category has been selected. 2017-07-06 17:08:29 +09:00
Joffrey JAFFEUX 6fd44b1efd FIX: s/google_blob/google_classic 2017-07-06 09:05:15 +02:00
Guo Xiang Tan f6491ee125 FIX: Select topic timer's category by default in edit modal. 2017-07-06 16:01:57 +09:00
Robin Ward c53eeaaa68 REFACTOR: Remove `requirejs` calls 2017-07-05 17:24:27 -04:00
Robin Ward 754c1e5438 Upgrade to Babel 6 2017-07-05 15:25:23 -04:00
Joffrey JAFFEUX fcc50edeef FIX: do not override 🦗 with :cricket_bat_and_ball: 2017-07-05 18:51:25 +02:00
Joffrey JAFFEUX 76a55fd138 FIX: adds new emojis into correct groups 2017-07-05 16:24:53 +02:00
Guo Xiang Tan 061aa261da Log site name when logging to Logster in `Jobs::PullHotlinkedImages`. 2017-07-05 10:34:24 +09:00
Guo Xiang Tan 4e8b80c157 Remove unnecessary `ensure` block. 2017-07-05 10:21:42 +09:00
Neil Lalonde fcb2f68565 FIX: duplicate topics and posts in summary email because user has muted tags and topics contain multiple tags 2017-07-04 16:12:10 -04:00
Robin Ward df213639f1 UX: Allow CTRL+ENTER to save topic title edits 2017-07-04 14:23:57 -04:00
Neil Lalonde 3964929c75 FIX: summary email excludes all untagged topics if user has muted some tags 2017-07-04 12:52:25 -04:00
Robin Ward 35ff5d6796 FIX: Naving to root URL was broken 2017-07-04 12:44:53 -04:00
Sam 43ecfb016a Merge pull request #4950 from jjaffeux/use-emoji-db
FEATURE: emoji generation now uses emoji-db
2017-07-04 09:01:13 -04:00
Joffrey JAFFEUX a71c75367e FEATURE: emoji generation now use emoji-db
- unicode 10
- emoji 5.0
- support for google_blob and facebook_messenger sets
2017-07-04 14:08:47 +02:00
Arpit Jalan c243861b17 FIX: do not show "Send Activation Email" button if `must_approve_users` setting is enabled
https://meta.discourse.org/t/error-when-pressing-send-activitation-email-when-must-approve-users-setting-is-enabled/65408
2017-07-04 14:00:50 +05:30
Sam d2ba543ed3 correct case where %20 decoded as space in auto link
correct case where onebox is not applied when url is decoded
2017-07-03 16:32:53 -04:00
Sam 340a3ee5cb correct spec to handle not null visibility_level 2017-07-03 16:03:26 -04:00
Sam 45c3ad5f91 FIX: stop highlighting single l which is used for sorting 2017-07-03 15:45:15 -04:00
Sam 845170bd6b FEATURE: add support for group visibility level
There are 4 visibility levels

- public (default)
- members only
- staff
- owners

Note, admins and group owners ALWAYS have visibility to groups

Migration treated old "non public" as "members only"
2017-07-03 15:26:57 -04:00
Sam c79418d334 DEV: Move RTL into lib where it belongs 2017-07-03 15:26:57 -04:00
Arpit Jalan 984778d3ac FIX: handle moving first post to a closed/archived topic 2017-07-03 21:21:20 +05:30
Arpit Jalan 72c92b0f4e FIX: include canonical meta tag on category pages 2017-07-03 13:25:22 +05:30
Arpit Jalan d3ee5752b8 remove unneeded condition from invite model 2017-07-01 21:50:34 +05:30
Arpit Jalan 4fb9269642 FEATURE: optimize invite js code 2017-07-01 19:11:39 +05:30
Robin Ward 566cf31c66 UX: Always show topic progress on mobile 2017-06-30 16:19:19 -04:00
Sam 0650c8dbab optimize rule lookup
we have tons of bbcode rules, might as well speed them up
2017-06-30 15:19:16 -04:00
Robin Ward 0ba39109a0 FIX: Make `omit_default_port` the global default 2017-06-30 12:43:26 -04:00
Robin Ward 46a3b30021 FIX: omit the default port in the `Host` header 2017-06-30 12:36:02 -04:00
Sam a55e679563 support wrap function in bbcode rules 2017-06-30 12:21:01 -04:00
Sam 5c89a37ceb FIX: log when push notifications fail 2017-06-30 10:45:53 -04:00
Arpit Jalan 16d356ab4e FEATURE: resending invite should include original custom message
https://meta.discourse.org/t/will-resent-invite-include-original-custom-message/64699
2017-06-30 18:13:33 +05:30
Sam c1580b9d36 attempt to fix push notifications 2017-06-30 08:40:43 -04:00