Sam Saffron
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
Guo Xiang Tan
152238b4cf
DEV: Prefer public_send over send.
2019-05-07 09:33:21 +08:00
Kyle Zhao
f1cb431968
FIX: rescue ActiveRecord::RecordInvalid in find_or_create_by_safe! ( #6385 )
...
AR uniqueness validation could raise ActiveRecord::RecordInvalid
2018-09-12 11:03:12 +10:00
Sam
6ee352510a
Correctly handle exception
2018-08-23 16:27:00 +10:00
Sam
57d04200a1
Add Rails 6 note here
2018-08-21 11:09:10 +10:00
Sam
ca5a6f0a9d
FIX: handle concurrently creating post reply keys
...
In some very rare conditions this would be called concurrently and fail
2018-08-21 10:59:18 +10:00
Sam
44091f20c6
DEV: allow for method deprecation using Discourse.deprecate
...
New method deprecator will ensure one log message an hour happens
for all deprecated method calls per call site
Also removes unused monkey patches to ActiveRecord::Base
2018-06-20 17:53:49 +10:00
Sam
b7037808bb
PERF: stop using exec which is blocking for direct sql
2018-05-03 15:50:30 +10:00
Guo Xiang Tan
9d6449ae92
Revert "Guard ActionRecord::Base.exec_sql against a readonly PostgreSQL cluster."
...
This reverts commit c2a5e603c22ed104cfe48f1d93338fea98f8fd23.
2017-10-19 15:39:03 +08:00
Guo Xiang Tan
c2a5e603c2
Guard ActionRecord::Base.exec_sql against a readonly PostgreSQL cluster.
2017-10-19 14:47:29 +08:00
Guo Xiang Tan
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
Sam
1f044350f6
stop running exec_sql through active record
...
this avoids double logging
2015-08-14 10:01:38 +10:00
Stephan Kaag
f12925887c
Drop Rails3 support
2014-02-17 19:42:08 +01:00
Robin Ward
3d6d7c8abe
SiteSetting to hide regular names from users
2013-10-30 15:45:34 -04:00
Sam
3565f4c8cf
correct monkey patch, disable it from rails4 mode (that has a proper implementation)
2013-10-24 13:35:21 +11:00
Sam
ff957a7b37
rails 4 deprecation fixes
2013-10-24 13:02:25 +11:00
Sam
a3128665cf
make it more idiomatic
2013-10-02 12:23:16 +10:00
Sam
5f8851cb44
Avoid superfluous transaction when saving drafts
2013-10-02 12:17:27 +10:00
Régis Hanol
239cbd2d58
enforce coding convention
...
replaced every `and` by `&&` and every `or` by `||`
2013-03-05 01:42:44 +01:00
Gosha Arinich
cafc75b238
remove trailing whitespaces ❤️
2013-02-26 07:31:35 +03:00
Robin Ward
674c861eaf
Adjust deadlock trap to match postgres format.
2013-02-15 11:48:38 -05:00
Robin Ward
57049b55a2
Little things:
...
- Retries on deadlock when calculating average time
- Removes Warning: When specifying html format for errors
- Doesn't use manual SQL to update user's ip address
2013-02-11 15:47:28 -05:00
Robin Ward
21b5628528
Initial release of Discourse
2013-02-05 14:16:51 -05:00
