ad5f502332
FIX: add a basic validator for topic params
...
This cuts down on log noise when people try out sql injection
2018-08-14 17:01:04 +10:00
983dba37ce
FIX: use BasicUserSerializer for user_badge.granted_by ( #6266 )
...
BasicUserSerializer contains enough information for the badges page,
while UserSerializer issues ~100 SQL queries on the fly when serializing
the field without preloading.
2018-08-14 08:11:14 +10:00
71b65be6f6
SECURITY: prevent use of X-Forwarded-Host to perform XSS
2018-08-13 16:45:22 -04:00
075d80862f
UX: topic-timer modal style fixes
2018-08-13 14:04:20 +08:00
03010571f5
Remove unnecessary code ( #6262 )
...
"border-bottom: none;" gets overridden a few lines below by "border-bottom: 1px solid $primary-low;" making it unnecessary.
2018-08-13 15:43:03 +10:00
e26437f334
FEATURE: Do encodeURI on share links
...
Some Discourse-supported sharing platforms such as Twitter are unable to determine the end of a unicode URL. If you post a URL "https://example.org/t/测试/1 " on Twitter, it will be a link of href="https://example.org/t/ "
If the URL contains any unicode character (usually in the slug part) , it must be urlencoded with encodeURI(url) before being passed to source.generateUrl(link, title), or it will be a malformed URL in the sharing tweet.
2018-08-13 15:35:56 +10:00
7e68062a46
Topic meta-data flexbox fixes ( #6263 )
...
Topic meta-data flexbox fixes
2018-08-13 13:29:46 +08:00
83fd308963
FEATURE: group error message regarding image optimization failures
2018-08-13 14:48:25 +10:00
ba022234c6
Add onceoff job to fix incorrect upload extensions.
2018-08-13 10:44:08 +08:00
a6820d8767
Add Hungarian locale ( #6260 )
2018-08-13 01:02:35 +02:00
6d813c2b52
FIX: Importers failed to import avatars
2018-08-12 22:02:17 +02:00
448e95b97d
UX: Show anchor icon instead of text when topic bump is disabled
2018-08-11 21:51:13 +02:00
a960a57c72
Improving category reorder modal layout
2018-08-10 22:09:46 -04:00
e53983b53b
Alignment fix
2018-08-10 14:00:06 -04:00
b73950692b
FIX: Parsing non-existent feed should not fail
2018-08-10 18:37:14 +02:00
865cb3feb9
FIX: allow selecting site's default theme from preference
2018-08-10 14:12:02 +03:00
6f6b4ff988
regression: don't return from a block
...
also clean up some warnings (shadowed var, unused var)
2018-08-10 14:53:55 +10:00
0451dba27a
Table margin adjustment
2018-08-09 21:24:26 -04:00
093c3510e6
Rework moderators activity query ( #6230 )
...
* Order rows in query
* Don't increment revisions when moderator revises their own post
2018-08-10 10:51:31 +10:00
b9072e8292
FEATURE: Add "Reset Bump Date" action to topic admin wrench ( #6246 )
2018-08-10 10:51:03 +10:00
6db623ef6b
UX: Improve category filtering and include subcategories
...
* category_filtering
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
* category_filtering with subcategory topics
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
4. report_posts
5. report_topics
6. report_topics_with_no_response
* category_filtering tests (without subcategory topics)
1. report_posts
2. report_topics_with_no_response
* subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb`
1. `in_category_and_subcategories` in `topic_spec.rb`
2. topics, posts, flags and topics_with_no_response in `report_spec.rb`
2018-08-10 10:50:05 +10:00
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
6ec92d5845
prettier
2018-08-09 20:45:47 -04:00
2e1049a75a
Minor dashboard style adjustments
2018-08-09 20:43:18 -04:00
3cd4dc0f5f
Allow users with group_locked_trust_level to be promoted to tl3 ( #6249 )
2018-08-10 10:42:23 +10:00
6a2ca60b48
FIX: ember click event not reliably working on fx ( #6256 )
2018-08-09 22:41:35 +02:00
04658bb2f1
UX: prevent text from wrapping below notification icons
2018-08-09 12:04:34 -04:00
2c4d7225d8
FIX: permalink redirects with subfolder
2018-08-09 11:05:27 -04:00
701c5ae781
UX: admin permalink form can fit on one line
2018-08-09 11:05:27 -04:00
da1d520d4c
FIX: simplifies mini tag chooser events handling ( #6252 )
2018-08-09 14:23:28 +02:00
bfcf8ed61b
FIX: prevents focus of input on mobile ( #6251 )
2018-08-09 14:23:09 +02:00
523acfcea4
FIX: checks on parent visibility instead of filter itself ( #6250 )
2018-08-09 10:45:53 +02:00
7aef604f7d
regression, if there is not excerpt skip
2018-08-09 15:07:18 +10:00
ed4c0f256e
FIX: check permalinks for deleted topics
...
- allow to specify 410 vs 404 in Discourse::NotFound exception
- remove unused `permalink_redirect_or_not_found` which
- handle JS side links to topics via Discourse-Xhr-Redirect mechanism
2018-08-09 15:05:12 +10:00
f7b4a2b3ba
FIX: ensure URLs include subfolder in admin emails UI
2018-08-08 16:48:03 -04:00
b53d3457c8
updating color scheme attribution
2018-08-08 16:01:21 -04:00
cc96af07d1
Full-width markdown table on mobile
2018-08-08 15:51:11 -04:00
35bef72d4e
FIX: subfolder redirects to wrong URL if the subfolder appears in the slug
2018-08-08 13:41:29 -04:00
94622b451a
FIX: Search does not retrigger when context has changed.
...
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-08 17:55:37 +08:00
d3a9596d08
Remove unused import
2018-08-08 10:46:43 +01:00
d4d5088324
FIX: Don't require device capabilities when calculating login methods
2018-08-08 10:37:25 +01:00
575d9e0b1a
FIX: Include parameters in function call
2018-08-08 10:09:22 +01:00
ba6f11c521
PERF: Only log the first skipped email when user exceeds daily limit.
...
https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132
2018-08-08 16:25:00 +08:00
0d45826d22
fix theme previewing ( #6245 )
2018-08-08 10:58:45 +03:00
0b7ed8ffaf
FEATURE: backend support for user-selectable components
...
* FEATURE: backend support for user-selectable components
* fix problems with previewing default theme
* rename preview_key => preview_theme_id
* omit default theme from child themes dropdown and try a different fix
* cache & freeze stylesheets arrays
2018-08-08 14:46:34 +10:00
3f6ad65aec
FEATURE: include excerpt in HTML view for pinned topics
2018-08-08 11:15:49 +10:00
4e6e4a83df
FIX: subfolder digest emails have incorrect URLs
2018-08-07 16:38:17 -04:00
17d8fea796
Markdown tables should have vertical margin
2018-08-07 16:15:28 -04:00
48ecad53f2
additional hamburger alignment fix
2018-08-07 09:47:01 -04:00
67ec81babf
FIX: fixes last backup/last_update dates ( #6242 )
2018-08-07 08:19:52 -04:00
aa9a9a5a72
FIX: Include auth_providers for anonymous users when login_required
2018-08-07 09:24:16 +01:00
d5a7b818ba
FIX: Move Jobs::CreateAvatarThumbnails to low priority queue.
2018-08-07 16:05:54 +08:00
2b57239389
FIX: Upload's content is the only source of truth for the file type.
2018-08-07 13:15:00 +08:00
6797395bd0
FIX: staff should be allowed to agree and keep post
2018-08-07 10:05:43 +10:00
8477501e83
FIX: imrpoves alert-error styles in counters reports ( #6240 )
2018-08-06 16:59:45 -04:00
7f2f3b8b22
FIX: improves reports resilience ( #6239 )
...
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
c301111461
FIX: display select kit body if no choices ( #6237 )
2018-08-06 11:22:48 -04:00
74269ad585
FIX: hamburger menu category alignment
2018-08-06 11:11:29 -04:00
9b04921616
FIX: don't require auth providers to set full_screen_login_setting
2018-08-06 10:24:39 +01:00
812add18bd
REFACTOR: Serve auth provider information in the site serializer.
...
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
4e11811321
FIX: `UserAvatar#update_gravatar!` does not update `User#uploaded_avatar`.
...
https://meta.discourse.org/t/missing-user-profile-pictures/93844/4
2018-08-06 13:29:44 +08:00
18b396ad56
FEATURE: add link to see new commits when updates are available for themes ( #6233 )
...
* FEATURE: add link to see new commits when updates are available for themes
* shorten regexp
2018-08-06 15:29:15 +10:00
cc77a285ee
UX: improves edit reason contrast in dark themes
2018-08-06 10:53:46 +08:00
0cd9e2acb9
fix build
2018-08-04 01:56:26 +02:00
bf4d98e89d
FIX: always store topic links using the upload url
2018-08-04 01:29:32 +02:00
84d822959a
Reducing some specificity, color fix
2018-08-03 17:44:22 -04:00
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
072f5ce825
Increase ruby character size
2018-08-03 13:37:08 -04:00
535732bdc1
FIX: ensure the 'email_revoked' PM template is customizable
2018-08-03 17:10:20 +02:00
280c318c49
FEATURE: allow ruby tags in Markdown
2018-08-03 11:47:36 +10:00
880462a41c
FEATURE: display out of date themes on admin dashboard
...
* FEATURE: disaply out of date themes on admin dashboard
* Update copy
2018-08-03 09:53:48 +10:00
864e279aaf
FIX: wrong links to subcategories in top categories section of user summary
2018-08-02 17:38:42 -04:00
1ca999fdb5
FIX: formats topic report only if we have one ( #6231 )
2018-08-02 08:01:17 -04:00
0b3d51a8bc
FEATURE: whitelist lang attribute
2018-08-02 16:53:08 +10:00
9499693baa
Layout works better with auto columns
2018-08-01 22:37:21 -04:00
60f62f6f36
FIX: improves report-show mobile UI ( #6229 )
2018-08-01 19:54:27 -04:00
859c98743f
FIX: removes ellipsis from activity-metrics report cells
2018-08-01 19:08:53 -04:00
8cbe3cbe26
this file shouldn’t have been comitted
2018-08-01 19:01:47 -04:00
9073e11943
FIX: improves number/percent support in reports
2018-08-01 18:40:59 -04:00
4a872823e7
Improvements to user drafts ( #6226 )
...
* drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels
* use JSON when testing Draft.stream
2018-08-02 07:41:27 +10:00
8147130412
Group icon misalignment
2018-08-01 17:30:17 -04:00
d678ef2653
group icon needs margin
2018-08-01 17:05:35 -04:00
04255d1dce
removing unneeded styles
2018-08-01 16:38:47 -04:00
f0bea4ae55
Improve PM participant list
2018-08-01 16:20:14 -04:00
4eef41ea1b
FIX: Error with debouncing mentions
2018-08-01 15:57:24 -04:00
2ec1aec2be
FIX: Clicking admin wrench in topic footer didn't hide post select box
2018-08-01 21:29:35 +02:00
1a0ffc5ace
FEATURE: Added method to get multiple values at once from PluginStore. ( #6225 )
2018-08-01 18:42:40 +02:00
f4ca105498
FIX: Moving posts to existing topic didn't update topic metadata
2018-08-01 18:05:43 +02:00
d7b463a03d
FIX: Remove unused import
2018-08-01 11:54:47 -04:00
7c950321d1
FIX: Allow non-english usernames in autocomplete
...
Also add support for username formatters
2018-08-01 11:53:20 -04:00
b829452c75
Merge pull request #6209 from discourse/mini_scheduler
...
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
0b9437cee7
FIX: more resilient/consistent dashboard caching ( #6223 )
2018-08-01 09:45:50 -04:00
7c7dfa4e5e
FIX: wraps any query with the slow query guard ( #6222 )
2018-08-01 07:39:57 -04:00
8178444382
Make prettier happy
2018-08-01 15:13:54 +05:30
8556288397
DEV: Export Tag class to modify methods in plugin
2018-08-01 15:10:15 +05:30
a115aae45f
Use rchardet instead of charlock_holmes gem
2018-08-01 10:41:20 +02:00
5d421fb946
FIX: Try respecting charset in HTTP header of RSS feed
2018-08-01 10:41:20 +02:00
ff942ed2f3
FIX: Try detecting encoding of RSS feed
2018-08-01 10:41:20 +02:00
1f45215537
FEATURE: Drafts view in user profile
...
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
70ea153dce
Fix lint.
2018-08-01 12:23:36 +08:00
53adbf70f3
FIX: Nav item missing for plugins that don't include a custom filter.
2018-08-01 11:50:14 +08:00
5febe71baa
FIX: prevents crash if flagger doesn’t exist ( #6219 )
2018-07-31 23:48:54 -04:00
849f0d00f6
FEATURE: adds revision_count to moderators_activity ( #6218 )
...
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-31 23:40:45 -04:00
919e8db686
FIX: Check for group name availability should skip reserved usernames.
2018-08-01 11:09:33 +08:00
129268ddc6
Highlighted titles too wide on mobile
2018-07-31 21:24:43 -04:00
2b2a506a7b
FIX: makes dashboard more resilient to errors ( #6217 )
...
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
0715aa18da
UI: uses tiny avatars for reports ( #6215 )
2018-07-31 18:57:00 -04:00
37252c1a5e
UI: improves dashboard table reports
...
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
4ad7ce70ce
REFACTOR: extract scheduler to the mini_scheduler gem
2018-07-31 17:12:55 -04:00
4b166cccc1
FIX: Linting error
2018-07-31 14:19:45 -04:00
b6bb8df622
FIX: We loosened username restrictions some time ago
...
Additionally, remove `Discourse.User` constant
2018-07-31 13:53:31 -04:00
ece3cb73df
Rename humburger_menu_categories_count site setting to header_dropdown_category_count
2018-07-31 09:12:30 +05:30
fd29ecb91a
UX: include a flag reason in the post-deleted-by-staff-because-of-flags message
2018-07-30 16:45:46 -04:00
c12a9279f6
post deleted notification regression because controller was agreeing with all flags too early
2018-07-30 16:45:46 -04:00
c1e62808ed
FIX: Top site categories are displayed in random order
2018-07-31 01:01:03 +05:30
7368dd8e7d
Prevent activity-metrics stats from wrapping
2018-07-30 14:40:26 -04:00
c6fd506a15
fix eslint
2018-07-30 13:10:20 -04:00
2c90a2e5c2
FIX: prevents mini-tag-chooser to catch unwanted focus
2018-07-30 13:03:40 -04:00
a327393651
fix 1.14.0 prettier offenses
2018-07-30 11:56:48 -04:00
536f88b95b
Revert "DEV: prettier 1.14.0"
...
This reverts commit 1f899bec21
2018-07-30 11:52:05 -04:00
1f899bec21
DEV: prettier 1.14.0
2018-07-30 11:09:08 -04:00
c54b5824d4
REFACTOR: Prioritize unread categories in hamburger menu
2018-07-30 20:20:10 +05:30
6566b2f11a
FEATURE: Allow revoke and connect for Instagram logins
2018-07-30 14:38:53 +01:00
d494feaa32
FIX: should not be needed as we have itemprop='url'
2018-07-30 09:31:27 -04:00
dfcb2a0d42
FEATURE: include published_time in metadata
2018-07-30 17:09:56 +05:30
50df2d7241
FIX: Should not include regular categories in top_category_ids array
2018-07-30 16:06:36 +05:30
04baddf731
DEV: migrate tests to async/await
2018-07-30 12:21:05 +02:00
176d8ca78d
FIX: Hide muted categories from hamburger menu top categories block
2018-07-30 15:39:37 +05:30
249b16e8e3
FIX: Hide muted categories from hamburger menu top categories block
2018-07-30 15:37:41 +05:30
581cf62bcf
UX: Allow emojis to be displayed in nav-item.
2018-07-30 18:02:34 +08:00
ef78268c01
Give `ExtraNavItem` more control over when it can be displayed.
2018-07-30 17:30:13 +08:00
ba64ebbf10
FIX: preserve whitespace between uploads when the process is complete
2018-07-30 14:49:33 +05:30
78d91b1daf
UX: Changes in top categories of hamburger menu ( #6200 )
2018-07-30 14:13:00 +05:30
acde8d4323
Fix the build.
2018-07-30 15:07:03 +08:00
96a0448c52
FIX: Add onceoff job to fix incorrect extension for gravatar uploads.
2018-07-30 14:44:02 +08:00
87537b679c
Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`.
2018-07-30 11:39:28 +08:00
b94633e844
FIX: `FileHelper` should prioritize response content-type.
...
Request to a URL with `.png` extension may return a jpg
instead causing us to attach the wrong extension to an
upload.
2018-07-30 10:54:36 +08:00
fc3b904e1f
remove "track external right clicks" feature
2018-07-29 15:01:33 +05:30
3dbaaf0d74
UX: gives wizard language selector more room to expand
2018-07-28 11:51:53 +08:00
7a1a1eb4c0
improve header scaling with font size
2018-07-27 16:49:28 -04:00
a8f1b07686
FIX: prevents exception when loading old dashboard ( #6196 )
2018-07-27 16:29:30 -04:00
3159c46613
Making dataless sections stand out less
2018-07-27 14:55:51 -04:00
60b2c3207e
larger mobile topic list badges
2018-07-27 13:10:13 -04:00
5f1fd0019b
FEATURE: Allow revoke and connect for GitHub logins
2018-07-27 17:18:53 +01:00
6296f63804
FEATURE: Revoke and connect for Yahoo logins
2018-07-27 16:20:47 +01:00
a9c959e3e2
Make prettier happy
2018-07-27 20:39:44 +05:30
bc501038cb
FIX: Remove null value from categories list
2018-07-27 20:00:39 +05:30
85291e53f1
UX: more categories link alignment
2018-07-27 22:17:29 +08:00
9c72c00206
FEATURE: Revoke and reconnect for Twitter logins
2018-07-27 12:28:51 +01:00
5b4e13bfcc
Make prettier happy
2018-07-27 13:20:21 +05:30
Sam
Kyle Zhao
Neil Lalonde
Joe
tshenry
Misaka 0x4e21
Guo Xiang Tan
Peter Borsa
Gerhard Schlager
Kris
Osama Sayegh
Simon Cossar
Joffrey JAFFEUX
David Taylor
Leo McArdle
Régis Hanol
Penar Musaraj
Robin Ward
Dan Ungureanu
Vinoth Kannan
Arpit Jalan
Maja Komel