17a615165c
FIX: Don't lock wiki posts when they're edited
2018-03-05 14:50:06 -05:00
003b03d939
allow staff to delete user if posts are 5 or less irrespective of delete_user_max_post_age
2018-03-05 23:31:29 +05:30
ce1994beea
FIX: do not treat :: as a valid emoji
2018-03-05 15:35:24 +01:00
2f65393706
REFACTOR: Use `Topic#private_message?` to reduce duplication.
2018-03-05 15:39:22 +08:00
282f53f0cd
FEATURE: Theme settings (2) ( #5611 )
...
Allows theme authors to specify custom theme settings for the theme.
Centralizes the theme/site settings into a single construct
2018-03-04 19:04:23 -05:00
cd6c5fc5fb
FIX: Disable "Make Personal Message" if they are disabled
2018-03-02 20:28:39 -05:00
6a78669ca3
FIX: 'reply by email addresses' site settings should allow email addresses without a 'reply_key' when 'find related post with key' is disabled
2018-03-02 17:53:18 +01:00
b3883f5c32
FIX: Don't lock a post on edit unless the raw changes
2018-03-01 20:40:19 -05:00
75172024ca
SECURITY: ensure users have permission when moving categories
2018-03-02 12:13:27 +11:00
482c615ef8
FEATURE: extract signatures from most popular email services/software
2018-03-02 01:51:15 +01:00
a41446a502
single quote password in restore command
...
> Followup to #3283 . Quotes passwords passed to shell for backup restore.
2018-03-01 12:08:35 -08:00
7a2183e8ab
FEATURE: rake task for merging users
2018-03-01 12:28:12 +01:00
fb75f188ba
FEATURE: Disallow login via omniauth when user has 2FA enabled.
2018-03-01 15:47:07 +08:00
81ca3677f7
Add guard for `nil` in our `RateLimiter`.
2018-03-01 13:20:42 +08:00
5d9f9c2614
FIX: `RateLimiter` max of zero or less should raise rate limit exceeded.
2018-03-01 13:14:46 +08:00
baf1c385eb
UX: when a post is blocked due to a watched word, message includes the word being blocked
2018-02-28 11:22:18 -05:00
e7a7356986
Remove ancient votes code that is no longer used.
2018-02-28 14:37:22 +08:00
902c5d11cf
FIX: Don't allow other flag actions after `notify_moderator` has happened.
...
https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5
2018-02-28 11:27:56 +08:00
f295a18e94
FIX: stop double counting net calls in logs
2018-02-28 10:45:11 +11:00
2a7b7add59
oops
2018-02-28 09:35:46 +11:00
182aaffbd5
Keep second semantics for method
2018-02-28 09:21:38 +11:00
33340071e7
FIX: Use 60 minutes, not 60 seconds for column dropper
2018-02-27 16:45:20 -05:00
3c430a3949
FEATURE: begone gmail signatures!
2018-02-27 15:19:34 +01:00
73ee62f55f
FEATURE: automatically elide forwarded emails and signature from outlook
2018-02-27 15:00:50 +01:00
4a54c09e46
FIX: Retry with GET request when HEAD fails with error 400
2018-02-27 12:07:16 +01:00
cb0c443343
Merge pull request #5615 from jjaffeux/puke
...
Adds :puke: as alias to :face_vomiting:
2018-02-27 10:20:54 +08:00
fd33090646
FEATURE: automatically elides gmail quotes
2018-02-26 23:54:02 +01:00
26d5ae61dd
FIX: handle <pre> inside <blockquote> in html_to_markdown
2018-02-26 23:28:02 +01:00
3313072957
Remove censored_pattern site setting, which is replaced by watched words
2018-02-26 16:29:27 -05:00
3be0294465
FIX: local post onebox was always pointing to 1st post
2018-02-26 16:05:35 +01:00
7d7f6faf40
FIX: properly render emojis in local oneboxes
2018-02-26 11:16:53 +01:00
b301c9f6c1
more prep work for jRuby
2018-02-26 10:25:58 +11:00
b9a669ba32
FIX: do not log personal message view if user can't see the message
2018-02-25 22:39:25 +05:30
aa990604c5
Adds :puke: as alias to :face_vomiting:
2018-02-24 17:11:04 +01:00
0559a4736a
FIX: don't double request when downloading a file
2018-02-24 12:35:57 +01:00
a1ea477604
rescue error when cleaning avatars
2018-02-23 18:15:55 +05:30
69af881f7f
New site setting `trusted_users_can_edit_others`
...
The default is true to keep with previous discourse behavior. If
disabled, high trust level users cannot edit the topics or posts of
other users.
2018-02-22 20:39:24 -05:00
24d0a7a4c7
Take 2 on f74d6bb605.
...
New options are left out by default when not configured so that an
incorrect default configuration doesn't blow up google oauth for
everyone.
2018-02-23 07:53:01 +08:00
dd26bbe868
Merge pull request #5610 from discourse/pm-tags
...
FEATURE: Allow staffs to tag PMs
2018-02-23 07:07:41 +08:00
1c790ae6bc
Revert "Add prompt and HD settings to the Google OAuth2 plugin."
...
This reverts commit f74d6bb605
2018-02-22 19:17:02 +01:00
ca1fd774a1
Revert "WIP"
...
This reverts commit 2cf5479678
2018-02-22 18:15:42 +01:00
2cf5479678
WIP
2018-02-22 17:56:56 +01:00
7cbda949f1
REFACTOR: New spec tests and code improvement
2018-02-22 20:27:02 +05:30
c302c28a7d
Switch ids in References-Header field of mails. ( #5567 )
...
This change allows email-clients to show threaded views of mails as
expected. Apparently most algorithms expect the message ids of mails
in the Reference-header-field to be sorted such that they build a
traversal through the thread, so the oldest (original) message being
first, then its child, grandchild and so on until it arrives at the
message id that the "new" mail (that is to be sent) is the reply to.
MSGA [1]
+- Re: MSGA [1-1]
| +- Re: Re: MSGA [1-2-1]
| +- Re: Re: MSGA [1-2-2]
+- Re: MSGA [1-1]
If the stuff in brackets would be the message ID, the References-Header
field of a message that is a reply to [1-2-1] should look like:
References: 1, 1-1, 1-2-1
Discussion took place in:
https://meta.discourse.org/t/e-mail-threading-in-ml-mode-does-not-work-in-thunderbird
Main information taken from:
https://www.jwz.org/doc/threading.html
2018-02-22 10:48:23 +01:00
f74d6bb605
Add prompt and HD settings to the Google OAuth2 plugin.
2018-02-22 12:29:19 +08:00
84867c1c07
Rename site setting to allow_staff_to_tag_pms from allow_staff_to_tag_in_pm
2018-02-22 06:48:34 +05:30
1b04d881c5
UX: Display lock icon in admin user lists when user has 2FA enabled.
2018-02-22 09:00:09 +08:00
720e1965e3
FEATURE: add category suppress from latest
...
In the past we used suppress_from_homepage, it had mixed semantics
it would remove from category list if category list was on home and
unconditionally remove from latest.
New setting explicitly only removes from latest list but leaves the
category list alond
2018-02-22 09:56:35 +11:00
2b509eaa91
Merge branch 'master' into pm-tags
2018-02-21 23:55:59 +05:30
776ab73a8d
FIX: can_tag method called without guardian variable
2018-02-21 21:22:56 +05:30
84ce1acfef
FEATURE: Allow staffs to tag PMs
2018-02-21 20:11:46 +05:30
8964e75ad6
Merge pull request #5612 from discourse/featheredtoast-two-factor-login
...
Featheredtoast two factor login
2018-02-21 15:00:10 +08:00
26450f7587
allow for no lograge
...
(fixes tests)
2018-02-21 15:40:37 +11:00
ca1a3f37e3
FEATURE: add instrumentation for all external net calls
2018-02-21 15:20:29 +11:00
f4f8a293e7
FEATURE: Implement 2factor login TOTP
...
implemented review items.
Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator
add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests
add qunit tests - password reset, preferences
fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.
Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP
add two factor to email signin link
rate limit if second factor token present
add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
3ea272f4f1
New setting: minimum trust level to embed images in a post
2018-02-20 20:00:06 -05:00
0799831dbe
FIX: use the avatar of the post rather than the topic in local oneboxes
2018-02-20 19:49:39 +01:00
a4bc54a686
FIX: strip zero width spaces from topic title
2018-02-21 00:12:39 +05:30
de5418a905
correct search in topic list
2018-02-20 20:47:44 +11:00
86d12bd44b
FEATURE: search within title using in:title
...
Also
- Significantly improved search ranking, title is treated most strongly
- Adds tag names to the index
- Run search re-indexer more aggressively
- Re-index topic and all posts on category change
2018-02-20 14:41:21 +11:00
e5cec28eae
FIX: `Stylesheet::Manager.stylesheet_link_tag` cache should account for `Discourse.current_hostname`.
2018-02-20 09:53:15 +08:00
60ec483caa
FIX: include title in local onebox when linking to a different topic
2018-02-19 22:40:14 +01:00
c419c26f56
FEATURE: new site setting 'max_emojis_in_title'
2018-02-19 18:15:26 +05:30
b6277e208b
FIX: Cookies header didn't have the right format
2018-02-19 12:46:57 +01:00
f3815cd785
FEATURE: New site setting for additional allowed filetypes for staff ( #5364 )
...
* FEATURE: New site setting for additional allowed filetypes for staff
* Problematic variable name
* feedback
* small issues
* fix indentation
* failing tests
* Remove message bus and fix minor issues
* Missed this message bus
2018-02-19 10:44:24 +01:00
5d9d0fcb4f
FEATURE: add setting which adds group name to PM email subject ( #5475 )
2018-02-19 10:20:17 +01:00
a3c7ee09b6
FIX: ruby bench not working properly
...
- Remove thin which is no longer supported
- Bypass admin api rate limiting in profile environment
- Admin password was too short
- Run by default in concurrency 1 mode
- A skip bundle assets flag to speed up local testing
2018-02-19 11:37:16 +11:00
61930e092a
FIX: support incoming emails with just an attachment
2018-02-16 18:14:56 +01:00
93b1829f04
tiny refactor
2018-02-16 11:21:11 +01:00
49ad983050
fix extra blank line
2018-02-15 16:54:22 -07:00
925d1a7869
FEATURE: add rake task for import/export of site settings
2018-02-15 16:23:42 -07:00
322aa9ed85
Version bump to v2.0.0.beta3
2018-02-15 17:48:34 -05:00
cda3f72ab8
SECURITY: don't onebox whispers
2018-02-16 08:57:20 +11:00
57e140dc07
FIX: oneboxing to private messages
2018-02-16 08:00:22 +11:00
8e0da35857
FIX: allow local oneboxes to public topics/posts in PM
2018-02-15 18:14:41 +01:00
94b2c70c0d
PERF: remove oga gem
...
oga gem is automatically required by the aws gem
the oga gem retains about 1mb of memory, aws now uses nokogiri
This also removes the html normalize from the pretty text specs that was
a fair bit buggy as the polls test shows.
2018-02-15 14:36:40 +11:00
b4aa0b096e
FIX: Couldn't like staff when `allow_flagging_staff` was set
2018-02-14 15:46:04 -05:00
f028ffaf29
SECURITY: correct local onebox category checks
...
Also removes ugly "source_topic_id" from cooked posts
Patch was authored by @zogstrip
Signed-off-by: Sam <sam.saffron@gmail.com>
2018-02-14 10:40:46 +11:00
03b3e57a44
FEATURE: login by a link from email
...
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
3e835047da
Remove "already initialized" constant warning.
2018-02-13 08:55:15 +08:00
4dfe659189
Rename `allow staff flags` to `allow flagging staff`
2018-02-12 15:27:26 -05:00
6287631745
FEATURE: New site setting, `allow staff flags`, false by default
...
For some large communities, it makes sense to disable flagging of
staff posts.
2018-02-12 14:56:21 -05:00
932a1a1187
Remove use of deprecated site setting.
2018-02-12 14:26:22 +08:00
569e57f0a9
FIX: Delete the invalid auth cookie even if you hit the rate limit
2018-02-09 19:09:54 -05:00
5466389f4e
FIX: Consider oneboxes links wrt to `min_trust_level_to_post_links`
2018-02-08 18:27:40 -05:00
dedeb2deb8
FIX: Don't show the link button in the composer if linking is disabled
2018-02-08 12:56:10 -05:00
6a5dad0b86
FIX: Too much Javascript :)
2018-02-07 11:46:05 -05:00
8c04893a04
FIX: Don't throttle local lookups
2018-02-07 00:31:05 -05:00
016b9cd0e9
FIX: Count the links in the post
2018-02-06 20:16:48 -05:00
1bab15c757
FEATURE: A site setting for a minimum TL to post links
2018-02-06 18:07:58 -05:00
b2b6dc68a6
FEATURE: a setting to customize the minimum TL to flag a post
2018-02-06 17:12:27 -05:00
df8e43abdd
use lazy & instead of try
...
unregister ip skipper in test
raise if called when a skipper is in play
2018-02-06 10:38:15 +11:00
eefd226611
Add extensibility point to `request_tracker` to skip IP addresses
...
This is useful if you want to run a per IP rate limiter but want to be
able to skip some IPs with custom logic.
2018-02-05 17:49:40 -05:00
2f19588311
FIX: If personal messages are disabled, don't show messages for groups
2018-02-02 16:35:54 -05:00
0edd386b48
FEATURE: Vanilla bulk importer
2018-02-02 16:28:51 -05:00
8ff4104555
Many enhancements to the flagging / suspending interface.
2018-02-01 17:13:02 -05:00
350cbb1700
deprecate existing site settings
2018-02-01 13:25:29 +05:30
9bbfad1081
rename private to personal
2018-02-01 13:25:29 +05:30
7e48c47d37
rename 'enable_private_email_messages' to 'enable_personal_email_messages'
2018-02-01 13:25:29 +05:30
ff0376a80b
rename 'enable_private_messages' to 'enable_personal_messages'
2018-02-01 13:25:29 +05:30
25ec077eca
rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'
2018-02-01 13:25:29 +05:30
ee0d3f15c1
FEATURE: allow better fidelity for auto linkify, disable most tlds based linkify
...
New site settings:
enable_markdown_linkify: which is default on, auto links https:// and http:// and mail://
markdown_linkify_tlds: which allows control of what tlds get autolinked for cases such as www.site.com, default is com|net|gov
2018-02-01 13:22:38 +11:00
7d2283167a
UX: only crops images taller than 18:9 instead of 16:9
2018-01-31 22:31:16 +01:00
c598db28e7
Version bump to v2.0.0.beta2
2018-01-31 12:18:35 -05:00
361030d8ad
Also try popular Windows-1252 encoding when decoding incoming email
2018-01-30 23:45:04 +01:00
b2f18fc98f
FIX: system user edits should not generate notifications
2018-01-30 22:21:07 +01:00
018cb7f36b
add a custom user onebox ( #5542 )
...
* add custom user onebox
* add specs
2018-01-30 11:03:08 +01:00
f946db4afe
FIX: inline oneboxer min title length of 2
...
also: cache mini onebox misses as well to cut down traffic
2018-01-30 08:40:04 +11:00
2eef9b3295
UX: Adding a sticky footer to the post history modal, removing bootstrap columns
2018-01-29 15:15:50 -05:00
fa5880e04f
PERF: ability to crawl for titles without extra HEAD req
...
Also, introduces a much more aggressive timeout for title crawling
and introduces gzip to body that is crawled
2018-01-29 15:40:12 +11:00
1f6adbea5c
FEATURE: log private message views
2018-01-29 08:08:08 +05:30
9721fb7573
Linting
2018-01-26 14:35:04 -05:00
44e2038b53
Setting to automatically lock posts when edited by staff
2018-01-26 14:01:30 -05:00
6b04967e2f
FEATURE: Staff members can lock posts
...
Locking a post prevents it from being edited. This is useful if the user
has posted something which has been edited out, and the staff members don't
want them to be able to edit it back in again.
2018-01-26 14:01:30 -05:00
e2d82b882e
FIX: redirect to original URL after social login
2018-01-26 18:52:27 +01:00
feec968801
Add extensibility to admin constraints
2018-01-25 13:56:08 -05:00
7b4e6d508b
improve reviving_old_topic education message
2018-01-26 00:06:53 +05:30
eb52c5469e
FEATURE: Allow plugins to register a new locale
2018-01-25 14:57:41 +01:00
ce060e2b86
FIX: Server didn't use default_locale as fallback locale
2018-01-25 14:57:41 +01:00
1fac2ecb56
FIX: uploads not working on themes admin page
2018-01-25 21:13:06 +11:00
adae963751
ensure we do not override charset for content type
2018-01-25 18:43:42 +11:00
594efa37b6
add some output to category and topic importer
2018-01-24 12:33:47 -05:00
cbf4204ecc
FIX: uploads:migrate_from_s3 wasn't destroying records before creating new ones
2018-01-24 13:22:07 +01:00
782d75069e
FIX: UX improvements for system messages when PMs are disabled
2018-01-23 13:12:11 -05:00
28d432263e
rework the uploads:migrate_from_s3 rake task
2018-01-23 18:48:06 +01:00
17ebfd1715
FIX: Don't show suggested messages if private messages are disabled
2018-01-23 12:05:44 -05:00
2437b0d531
FIX: regression, missing 404 page
2018-01-23 09:00:28 +11:00
cbb321658f
FIX: support for generating excerpt when nesting <details> blocks
2018-01-22 19:17:35 +01:00
f26ff290c3
FEATURE: Shorten setting name to max_reqs
...
So it is consistent with other settings
2018-01-22 13:18:30 +11:00
83a346cd68
FIX: migrate_from_s3 rake task not working
2018-01-22 11:42:09 +11:00
fc36f095a7
FIX: ensure proper header transfer (except for cache control)
...
allows discourse special headers to be visible on hijacked reqs
2018-01-21 14:26:42 +11:00
b68799e081
FIX: Allow plugins to register importers
2018-01-19 16:24:41 -05:00
24dcfc2db5
remove constant warning in base62 file
2018-01-19 19:52:42 +01:00
b6c9d7a9d2
move requires to top of file
2018-01-19 17:51:42 +01:00
9009cb5963
OOPS: Deleted file
2018-01-19 11:43:09 -05:00
a8b46df4bd
More extensibility for custom silence/suspend messages
2018-01-19 11:35:19 -05:00
2d49250107
FIX: support recovering images using 'upload://' scheme
2018-01-19 15:40:17 +01:00
8bf91b8dca
correct tracking of x runtime
2018-01-19 17:51:19 +11:00
8ad43f01c2
FIX: correctly log topic timings as background
2018-01-19 10:37:43 +11:00
4f946319b4
improve warning text
2018-01-19 08:32:15 +11:00
12872d03be
PERF: run post timings in background
...
This means that if a very large amount of registered users hit
a single topic we will handle it gracefully, even if db gets slow.
2018-01-19 08:27:29 +11:00
5f4f617689
FIX: cache_file storage cleanup logic was wrong
...
https://meta.discourse.org/t/68296
2018-01-18 17:00:04 +01:00
2a22b90538
SECURITY: email domain whitelist could be bypassed
2018-01-17 21:45:32 +01:00
34ed6088b9
FEATURE: New modal to show flags received for a user
2018-01-17 15:08:08 -05:00
bb54eb1192
Improvements to mbox importer
...
* store time it took to index message in DB (to find performance issues)
* ignore listserv specific files
* better examples for split_regex
* first email in mbox shouldn't contain the split string
* always lock the DB in exclusive mode
* save email within transaction
* messages can be grouped by subject and use original order (for Listserv)
* adds option to index emails without running the import
2018-01-17 12:04:57 +01:00
79eb9d7086
FEATURE: show header search results on search log term details page
2018-01-17 12:47:16 +05:30
650ec9c73f
minor test the developer cache first before digging into email
2018-01-17 15:50:41 +11:00
1208254961
FIX: validate presence of 'top menu' setting
2018-01-17 01:43:53 +05:30
f274a5234f
FIX: topic and category exporters were only exporting users who created the first post
2018-01-16 12:51:53 -05:00
d7657d8e47
correct specs, ensure crawler layout only applies to html
2018-01-16 16:28:11 +11:00
7b562d2f46
FEATURE: much improved and simplified crawler detection
...
- phase one does it match 'trident|webkit|gecko|chrome|safari|msie|opera'
yes- well it is possibly a browser
- phase two does it match 'rss|bot|spider|crawler|facebook|archive|wayback|ping|monitor'
probably a crawler then
Based off: https://gist.github.com/SamSaffron/6cfad7ea3e6df321ffb7a84f93720a53
2018-01-16 15:41:45 +11:00
fcfce3e426
PERF: avoid expensive OR clause query info more efficiently
2018-01-15 16:38:58 +11:00
38c018a84b
FIX: invalid cache for parent category with limit_suggested_to_category
2018-01-15 16:13:29 +11:00
41a604a764
PERF: improve perf of topic suggested query with limit_suggested_to_category
2018-01-15 15:32:25 +11:00
442a17bfb2
PERF: bypass omniauth unless in an auth path
2018-01-15 12:44:54 +11:00
234aa68bf8
Correct Arabic month names
...
Correct Arabic month names. It's not right to concatenate month names from two different calendars [Assyrian calendar](https://en.wikipedia.org/wiki/Assyrian_calendar ) and [Gregorian calendar](https://en.wikipedia.org/wiki/Gregorian_calendar )
2018-01-14 20:01:45 +01:00
215c0d5569
FEATURE: allow system api to target users via external id or user id
...
usage ?api_key=XYZ&api_user_external_id=ABC
usage ?api_key=XYZ&api_user_id=123
2018-01-12 17:40:18 +11:00
988b13ac77
FIX: GitHub auth always asking to verify email for new users ( #5487 )
2018-01-12 15:17:29 +11:00
49ed382c2a
FIX: return 429 when admin api key is limited on admin route
...
This also handles a general case where exceptions leak out prior to being handled by the application controller
2018-01-12 14:15:26 +11:00
7fea15ca4d
FIX: rescue login required / broken images
2018-01-11 22:18:56 +05:30
fc05164667
demo script for demonizing using fork exec
...
minor refinements to demon
2018-01-11 13:51:52 +11:00
cc819539b0
FIX: makes rake qunit:test task work on macOS
2018-01-10 14:51:08 +01:00
8ff5f5f2ef
FIX: cache admin locale file for 24 hours
2018-01-09 10:23:49 +11:00
cecd7d0d07
FEATURE: global rate limiter can bypass local IPs
2018-01-08 08:39:17 +11:00
e0d73a957d
FEATURE: Allow posting via email to read-only mailing list mirror category
2018-01-05 11:21:53 +01:00
d7cd7e4dc7
FIX: Never mark emails sent to mailing list mirror as auto-generated
2018-01-05 11:21:53 +01:00
754fa3d2f5
FIX: facebook deprecated facebook messenger emojis
2018-01-05 11:01:23 +01:00
e7d1d4eddf
FIX: correct shushing_face name
2018-01-05 11:01:23 +01:00
715cb98e95
add better diagnostics for rate limits
2018-01-05 12:14:28 +11:00
25f4d98307
improve error logging for warn_exception
2018-01-05 09:54:42 +11:00
c2c0a81a4f
Version bump to v2.0.0.beta1
2018-01-03 16:54:55 -05:00
ceb7590bcb
FIX: bounced email can contain multiple status codes
2018-01-03 17:59:20 +01:00
ad02437358
FIX: Missing post/topic created web hooks due to race condition.
2018-01-03 17:24:01 +08:00
81427e26ea
Ignore errors when remapping posts
2017-12-28 15:13:01 +01:00
f5e170c6b5
FIX: catch all server-side error when uploading a file
...
UX: always show a message to the user whenever an error happens on the server when uploading a file
2017-12-27 16:33:25 +01:00
805d1c25d3
Merge pull request #5451 from tgxworld/treat_non_ascii_urls_as_valid
...
Treat non-ascii URLs in `UrlValidator`.
2017-12-27 14:14:20 +08:00
0514ac4ee2
FIX: verify presence of 'sso url' before enabling 'enable sso'
2017-12-23 13:30:49 +05:30
d6b22e6cc1
FIX: whitelist oneboxed iframes
2017-12-23 01:56:33 +01:00
364e6fdd53
FIX: pluralization rules for Serbian language ( #5453 )
...
Updated SR pluralization to use 3 keys: one, few, other (as by Transifex)
2017-12-22 12:20:19 +01:00
cedfd6b68c
Merge pull request #5449 from Supermathie/google_fix
...
FIX: google oauth flow should automatically update the google account used for login when appropriate
2017-12-21 17:46:43 -08:00
6f89db4c24
Re-enable check for yarn when running qunit:test rake task.
2017-12-22 09:11:49 +08:00
aed37770e3
FIX: Load the route format before discourse
2017-12-21 16:29:11 -05:00
063e449ce5
FIX: `RouteFormat` is a better class name than `RouteFormats`
2017-12-21 15:30:32 -05:00
2908aab0da
Allow extensibility on username route format (non-english usernames)
2017-12-21 14:32:51 -05:00
4b51871f6a
Treat non-ascii URLs in `UrlValidator`.
2017-12-21 14:22:55 +08:00
6ecf37c482
Improve URL validation to check for a valid host.
...
Parsing a URL with `URI` is not sufficient as the following cases
are considered valid:
URI.parse("http://https://google.com ")
=> #<URI::HTTP http://https//google.com >
2017-12-21 13:50:15 +08:00
081959227d
FIX: unicode titles missing when visiting topic from topic list
2017-12-21 15:20:47 +11:00
aabac55edd
Better ENV name for QUnit's seed.
2017-12-21 09:47:32 +08:00
e17ce65aab
Version bump to v1.9.0.beta17
2017-12-20 18:50:35 -05:00
105cf61ed9
Implements https://meta.discourse.org/t/issue-user-changed-google-account-and-cant-connect-thru-his-profile/35028/18?u=supermathie
2017-12-20 17:59:36 -05:00
88a4ec5f1b
FIX: stop forking regular backup jobs
2017-12-21 09:00:48 +11:00
21e1b05c7e
FIX: Don't disable details when below truncate limit
2017-12-20 15:45:00 -05:00
4986132e1b
Fix missing variable in smoke test rake task.
2017-12-20 14:49:41 +08:00
bbc606988f
improve message
2017-12-20 10:12:33 +11:00
b3fda0ea86
FIX: details tags broke excerpts
2017-12-19 17:28:55 -05:00
ca8e4dfb43
Allow seed to be passed via ENV.
2017-12-19 21:35:51 +08:00
141a4a059d
QUnit tests should be run in random order.
2017-12-19 21:33:31 +08:00
349dc8da29
Disable check for yarn in qunit tests first.
2017-12-19 20:09:36 +08:00
fc6cb7bbe3
Merge pull request #5444 from tgxworld/remove_phantomjs
...
Switch to chrome headless mode instead of phantomjs.
2017-12-19 19:42:40 +08:00
b47b378cb6
Retry PNG to JPG conversion with debug enabled on failure
2017-12-19 11:49:04 +01:00
6a4f391e38
Switch to chrome headless mode instead of phantomjs.
2017-12-19 16:00:43 +08:00
f315c142b1
BUG: Load the appropriate file for AlternativeReplyByEmailAddressesValidator
...
Autoloading only works when the class names are namespaced appropriately.
2017-12-19 09:43:41 +11:00
8e55400392
FIX: add 'SiteSetting.port' to 'Onebox.allowed_ports' in development mode
2017-12-18 18:31:41 +01:00
8d44642b97
Add smoke test script that runs in chrome headless.
2017-12-18 16:39:01 +08:00
f2565f6c7e
SECURITY: Any group can be invited into a PM.
2017-12-14 14:57:48 +08:00
67aecff59c
FEATURE: store twitter supplied email for auditing
2017-12-14 15:54:32 +11:00
b15059418b
FIX: rake task for updating posts received by email should not crash
2017-12-13 22:03:31 +01:00
f525d83b53
FIX: empty uploads and blank filenames caused errors during validation
2017-12-13 22:03:31 +01:00
dee498a281
correct regression
2017-12-13 17:36:36 +11:00
9d925f6b26
FIX: correctly count participants when more than 24
...
Also cuts out one query for the normal case
2017-12-13 17:19:42 +11:00
e30851e45a
Move escape_uri method to a more suitable place
2017-12-12 20:17:46 +01:00
3016901a34
Version bump to v1.9.0.beta16
2017-12-12 11:38:15 -05:00
6ade508f39
FIX: Prevent 'rack.input' missing error.
2017-12-12 16:40:35 +08:00
ff6dda85b7
FIX: replace curly quotes to regular quotes in search terms
2017-12-12 11:17:28 +05:30
4986ebcf24
FEATURE: optional default off global per ip rate limiter
2017-12-11 17:52:57 +11:00
68d3c2c74f
FEATURE: add global rate limiter for admin api 60 per minute
...
Also move configuration of admin and user api rate limiting into global
settings. This is not intended to be configurable per site
2017-12-11 11:07:22 +11:00
6b3aa81c11
FIX: Remove other whitespaces except the line intents
2017-12-09 02:36:27 +05:30
dcc63a8ead
FIX: Keep all the indenting in the text
2017-12-09 01:11:00 +05:30
47c44356f8
FIX: load balanced servers do not share monotonic clock
...
This means then when a service is load balanced and you reach rate limits
there was a case where they counting was way off
also remove the stub from clock_gettime cause we need to be super careful with
it, so we should probably just stub by hand when needed
2017-12-07 11:48:11 +11:00
90a55d6f7c
FIX: handle CORS in hijacked requests
2017-12-07 10:31:04 +11:00
16738cfb1b
FEATURE: convert plain text emails to markdown
2017-12-06 01:47:51 +01:00
5f318a5241
FEATURE: Replace SimpleRSS with Ruby RSS module ( #5311 )
...
* SPEC: PollFeedJob parsing atom feed
* add FeedItemAccessor
It is to provide a consistent interface to access a feed item's tag
content.
* add FeedElementInstaller
to install non-standard and non-namespaced feed elements
* FEATURE: replace SimpleRSS with Ruby RSS module
* get FinalDestination and download with Excon
* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
85a59c632d
allow header_instructions to be passed in to message builder
2017-12-05 15:12:24 -05:00
a5e58e7afa
UX: add onebox favicon styling in email
2017-12-05 14:08:30 +05:30
5a9622163d
FIX: regression around rate limiter
2017-12-04 21:44:16 +11:00
dd70ef3abf
Revert "Revert "PERF: improve speed of rate limiter""
...
This reverts commit 2373d85239
2017-12-04 21:23:11 +11:00
2373d85239
Revert "PERF: improve speed of rate limiter"
...
This reverts commit a9bcdd7f27
2017-12-04 21:19:28 +11:00
a9bcdd7f27
PERF: improve speed of rate limiter
...
Also
- adds a global rate limiter option
- cleans up usage in tests
- fixes freeze_time so it handles clock_gettime
2017-12-04 18:17:30 +11:00
6c82a50903
Improve error handling in hijacked code
2017-12-01 16:23:32 +11:00
7f2eeaf767
FIX: Password required flag should be cleared whenever clearing the raw password ( #5384 )
2017-12-01 15:19:24 +11:00
49371d668f
Version bump to v1.9.0.beta15
2017-11-30 16:32:43 -05:00
3334a4b539
Simplify hijack code
2017-11-29 11:54:35 +11:00
44ee388070
FEATURE: omit images from og and twitter description tags
2017-11-28 21:34:02 +01:00
f80522671b
improve instrumentation and defer hijacking till last moment
2017-11-28 18:21:56 +11:00
b094894c94
Feature: Add service worker registration method to plugin API
2017-11-28 14:01:41 +08:00
df84e1c358
Correctly track hijacked requests
2017-11-28 16:47:20 +11:00
b3b55e18d1
UX: stop warping tiny onebox images
2017-11-28 12:32:35 +11:00
0caa335ef0
FIX: Handle more cases where HTTP status is not correct
...
HTTP status was not correct with send_file which uses streaming
2017-11-28 11:00:13 +11:00
ca7af7b88f
FIX: displaying wrong avatar and letter avatar
...
correct regression where params and env is reused in production
2017-11-28 09:28:40 +11:00
5a959ca4e4
FIX: We also need a base key for `admin_js`
2017-11-27 11:57:06 -05:00
77f90876d3
REFACTOR: Track manual locked user levels separately from groups
2017-11-27 11:23:44 -05:00
1f3e9a4350
FIX: Should skip the loop if the image src is blank
2017-11-27 13:41:28 +05:30
608207b2e5
FEATURE: avatar proxy happens in background
...
This ensures that even if it is slow to download avatars site will
continue to work
Also simplifies hijack pattern
2017-11-27 17:43:24 +11:00
e48c280c7e
correct regression
2017-11-27 15:07:13 +11:00
d5e7691ae9
favicon proxy now uses hijack
2017-11-27 14:51:14 +11:00
eb428ef54d
FEATURE: uploads are processed a faster
...
Also cleans up API to always return 422 on upload error. (previously returned 200)
Uploads are processed using new hijack pattern
2017-11-27 12:43:35 +11:00
71942e4f62
Merge pull request #5352 from tgxworld/method_for_replica_postgres_connection
...
Expose `replica_postgresql_connection` to `ActiveRecord::Base`.
2017-11-27 08:38:10 +08:00
6f8f2c494d
FIX: admin strings in plugins should fallback to english when untranslated
2017-11-24 14:11:01 -05:00
45c19e44f0
assets rake task: only try and detect brotli if COMPRESS_BROTLI is set
2017-11-24 12:00:38 -05:00
5584085943
assets rake task: detect the brotli version on the image as the usage changes
2017-11-24 10:40:57 -05:00
3c60702663
assets rake task: gzip and brotli exit codes exist for a reason - to be checked
2017-11-24 09:52:08 -05:00
e0e99d4bbd
PERF: hijack onebox requests so they do not use up a unicorn worker
2017-11-24 15:31:40 +11:00
a509f466a0
Expose `replica_postgresql_connection` to `ActiveRecord::Base`.
2017-11-24 09:35:45 +08:00
613f4d737a
FIX: updating topic stats failed silently for invalid topics
2017-11-23 18:47:45 +01:00
2b8d4508e5
PERF: stop running background work between requests
...
Use a dedicated thread to run Scheduler::Defer
This avoids blocking of a worker during operations that require waiting.
In particular uploads risked blocking a unicorn.
This also add a queue "length" that discourse prometheus consumes.
2017-11-23 15:48:47 +11:00
6c86e0c94a
FEATURE: remove the featured link by editing the topic
2017-11-22 14:53:35 -05:00
26d14dbcbb
Remove onceoff job in migrate rake task.
2017-11-22 12:50:01 +08:00
edfa2c3af9
FIX: Don't enqueue onceoff job in migration.
...
* Deployment of app servers may happen minutes after migrations.
2017-11-22 12:07:48 +08:00
f7642e076d
REFACTOR: Avoid duplicated logic on server and client.
2017-11-21 17:10:04 +08:00
c390169b71
Move monkey patch into freedom_patchers.
2017-11-21 14:15:11 +08:00
337ccfa3a6
MONKEYPATCH: Allow us to disable the use of advisory locks during migration.
2017-11-21 14:06:22 +08:00
f8164956dd
Add quote and mention support for username formatters
2017-11-20 16:28:03 -05:00
385372e384
Revert "PERF: Reduce number of topics to filter while querying for unread."
...
This reverts commit c06b782cab
2017-11-20 11:49:09 +08:00
546b206da0
replace indentation with non-breaking spaces when cooking emails
2017-11-18 17:16:44 +01:00
de037da731
FIX: FinalDestination's small_get method wasn't using proper request headers
2017-11-17 17:24:35 +01:00
aebcd56300
FIX: try a GET for error code 406
2017-11-17 16:59:51 +01:00
221ff24418
SQL != Ruby
2017-11-17 16:12:20 +01:00
a0fc8bd924
don't log 404s to gravatar.com
2017-11-17 15:38:26 +01:00
1a3ab7c02e
ignore some site settings for emails sent to mailinglist mirror category
2017-11-17 15:29:14 +01:00
aea161fabd
suppress rejection email when email was sent to mailinglist mirror category
2017-11-17 15:29:14 +01:00
3a472b507e
FIX: `severity_name` was being logged incorrectly.
2017-11-17 08:55:21 +08:00
2974faee68
FIX: Support client locales defined in plugins
2017-11-16 16:21:53 -05:00
fc346d207b
Only return unique paths
2017-11-16 15:22:05 -05:00
966c7e7f07
FEATURE: Allow plugins to dynamically add seed fixture paths
...
This is useful if your plugin wants different seed data for different
locales for example.
2017-11-16 14:43:17 -05:00
8cd0026cde
FIX: If there is an invalid locale in the site setting, default to en
2017-11-16 10:58:29 -05:00
678e28794a
FIX: properly handle too large & broken images in posts
2017-11-16 15:45:07 +01:00
f52111f787
FEATURE: allow plugins to easily detect if running in Rack
...
Usage: Discourse.running_in_rack? to tell if rack was booted
2017-11-16 08:39:29 +11:00
0cdded8079
Merge pull request #5303 from vinothkannans/export-multiple-categories
...
FEATURE: Option to export multiple categories using export_category method
2017-11-15 16:07:21 -05:00
9207dee69a
FEATURE: escape HTML when cooking plaintext emails
2017-11-15 20:22:11 +01:00
5c11104f9f
FIX: Duplicate a tag if image url is same to href
2017-11-15 17:36:48 +05:30
7b494a65c9
NEW: large image placeholder added in cooked html ( #5291 )
2017-11-15 11:30:47 +01:00
89d9ffa884
EXPERIMENTAL: Allow logs to be shipped via different methods.
...
See https://github.com/dwbutler/logstash-logger#uri-configuration for
a list of available methods.
2017-11-15 09:11:33 +08:00
d07ebf9d4c
UX: Support for custom error pages and headers in plugins
2017-11-14 16:31:44 -05:00
23baaa5dcc
FIX: don't crop iPhone X screenshots
2017-11-14 20:37:27 +01:00
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
075a458489
FIX: child theme component vars not resolved in parent
2017-11-14 15:22:59 +11:00
d3baae5365
removes whitespaces and uses scope
2017-11-13 15:23:24 +01:00
ed0751f288
always double check there is a class first
2017-11-13 16:06:18 +11:00
4f28c71b50
FIX: error setting tombstone bucket when set to old version
2017-11-13 15:36:45 +11:00
3ac7d041ae
UX: generic onebox treats all square images as avatars and renders them smaller
2017-11-13 11:21:19 +11:00
5210e3e744
FEATURE: accept incoming email with reply_key mismatch when original email was forwarded
2017-11-12 23:44:22 +01:00
4dc4bc70c8
FIX: ignore_by_title should match case-insensitive
2017-11-12 01:43:18 +01:00
d9823f69c6
FEATURE: Option to export multiple categories using export_category method
2017-11-11 19:11:16 +05:30
1f14350220
Rename "Blocked" to "Silenced"
2017-11-10 14:10:27 -05:00
9dc9ca4ac0
FIX: be consistent with how first posts in topics are counted. do like DirectoryItem.refresh_period :all
2017-11-10 12:18:25 -05:00
38b8d68c68
FEATURE: Allow the user to select a custom home page ( #5268 )
...
* Add user_home configuration option
* Use the new user_home preference to actually show the right home page
* Fix trailing whitespace
* Update user_option_serializer.rb
* Fix JavaScript default homepage tests
* Use an object instead of a giant switch
* Remove trailing whitespace
* Make the default `user_home` set to `null` instead of `0`
* Rename user_home to homepage_id
2017-11-10 06:45:19 +11:00
16407dfc11
Add a `failed_code` we can check for when using Auth::Result
2017-11-09 10:49:42 -05:00
06365023c4
FEATURE: new API to search for a user by email
2017-11-09 17:04:21 +11:00
2d5bf0705a
PERF: exact email match bypass
...
instead of scanning full table when there is an exact email match ONLY
return the actual user.
2017-11-09 16:53:14 +11:00
7777a44673
FIX: Don't skip validations when updating user's email.
2017-11-08 11:38:51 +08:00
fc7dca58fe
UX: oneboxes with avatars now display consistently
...
Onebox avatar size is reduced to 60px
Also fixes regression with some oneboxes not cooking after post
2017-11-08 11:50:01 +11:00
be0c7609f1
FIX: validates attachments against current authorized extensions
2017-11-07 19:17:33 +01:00
8f560f0bf4
Merge pull request #5282 from vinothkannans/local_onebox_slash
...
FIX: Topic links onebox differently if end in /
2017-11-07 17:39:38 +05:30
8970bdd4fa
FIX: Undefined method before unicorn boots.
2017-11-07 11:52:22 +08:00
d9602fe729
Fix incorrect severity field.
2017-11-07 11:24:54 +08:00
6a47491afe
Fix the build.
2017-11-06 16:56:22 +08:00
ffe823ed32
Ensure we log the datetime in the format that we want.
2017-11-06 16:40:11 +08:00
96a414d0a5
Log `progname` as empty string if `nil`.
2017-11-06 16:01:32 +08:00
c9df21e131
FEATURE: Allow Unicorn logs to be JSON formatted.
2017-11-06 12:46:14 +08:00
230fec68ca
FIX: Topic links onebox differently if end in /
2017-11-06 01:41:36 +05:30
2f0c9793f1
FEATURE: Allow multiple html builders to be registered via plugins
2017-11-03 11:32:32 -04:00
93633865d9
Adds primary user group as a class to quote ( #5285 )
...
* Adds primary user group as a class to quote
This feature addition will add the class `group-PRIMARY_USER_GROUP` to
the quote `aside`. `PRIMARY_USER_GROUP` will be the primary user group
of the user being quoted. This is similar to the class that is added to
a `topic-post`.
* Remove trailing whitespace
* Fix avatar in test
* Address PR comments
* Fix trailing whitespace
2017-11-03 09:51:40 -04:00
470b1a5bc1
Don't print Sidekiq starting message to STDERR.
2017-11-03 21:02:31 +08:00
88492b2b94
Merge pull request #5283 from viktorbenei/patch-1
...
Fix "duplicate method" issue
2017-11-03 09:32:45 +08:00
18d65fe7e5
FIX: post counts in user stats when changing post owner
2017-11-02 18:05:23 -04:00
21dd2ccd43
FIX: only count regular posts in user stats when deleting
2017-11-02 18:05:23 -04:00
30689783db
don't decrement post_count for a post in a deleted topic that has already been uncounted
2017-11-02 18:05:23 -04:00
f29290ad11
FIX: don't count whispers in user stats post_count
2017-11-02 18:05:23 -04:00
24af9b7d97
FIX: when a topic is deleted, update the post count stats of all user who replied
2017-11-02 18:05:23 -04:00
64cb8a3ce3
FIX: Normalizer wasn't working with attributes without values
2017-11-02 14:11:20 -04:00
54e4ff34f8
Fix "duplicate method" issue
...
Fixing http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/DuplicateMethods
Readers are defined (https://github.com/discourse/discourse/blob/master/lib/single_sign_on.rb#L61 ), so only writers have to be generated.
2017-11-02 12:33:35 +01:00
5849bae9df
FIX: rescue error when importing category structure
2017-11-01 22:21:37 +05:30
7f33f7850a
Merge pull request #5270 from vinothkannans/rake_categories
...
FEATURE: Rake task to export and import category structure
2017-11-01 21:36:03 +05:30
a00af4d85a
FEATURE: Rake task to export and import category structure
2017-11-01 17:17:05 +05:30
2792c3c80e
fix typo
2017-11-01 15:51:17 +05:30
deb79a8fff
DEV: private means nothing for class methods
2017-11-01 16:43:19 +11:00
f5cc28d740
UX: correct regression with twitter onebox
2017-11-01 16:42:56 +11:00
d1f257d275
FinalDestination should only log when verbose is enabled
2017-10-31 17:16:59 +01:00
880d154381
FIX: deleting staged user of rejected email shouldn't delete incoming email
2017-10-31 15:13:23 +01:00
8c27f28dcb
add more logging to FinalDestination
2017-10-31 12:26:35 +01:00
9197feefb8
UX: onebox images no longer cause jiggle
...
This stops pages from "jiggling" while oneboxes download.
see: http://cssmojo.com/aspect-ratio-using-custom-properties-and-calc/
2017-10-31 13:50:58 +11:00
9705f8b9c2
Version bump to v1.9.0.beta14
2017-10-30 11:20:55 -04:00
7ca08216bd
FIX: ensure we have no dangling db connections on threads
...
This correct 10 second timeouts in dev mode, when reloader kicks in
2017-10-30 14:24:15 +11:00
401fbdbfe7
FIX: `Topic#title` were being parameterized when encoded slug is
...
enabled.
2017-10-27 11:02:47 +08:00
70aed105a6
FIX: bypass all site setting work for shadowed method
2017-10-27 11:12:44 +11:00
f30366744a
Fix the build.
2017-10-26 17:09:00 +08:00
7c3123a2dd
Downcase encoded slug by default and more specs
2017-10-26 16:50:29 +08:00
a173511681
Merge pull request #5259 from discourse/groups_in_sso_provider
...
Add groups to the SSO provider payload
2017-10-25 23:02:53 -02:00
5d5268a82b
Feature: Group handling
2017-10-25 22:49:17 -02:00
efbd923f60
Merge pull request #5261 from xrav3nz/fix-rebake-match-rake
...
FIX: `post:rebake_match` rake task
2017-10-25 10:22:56 +05:30
877b7be579
FIX: in readonly mode don't double count pages
2017-10-25 13:19:43 +11:00
82c18f6ca3
fix: undefined variable in `post:rebake_match`
2017-10-24 20:05:58 -04:00
2c15e9c6fe
FIX: search couldn't find tags from before 2017-08-25
2017-10-24 17:55:05 -04:00
fb5b9b6d06
FIX: don't offer the "Something Else" flag reason to TL0 users since they don't have permission to send private messages
2017-10-24 11:47:42 -04:00
5c8dac3ae5
Replace `discourse-slack-official` with `discourse-chat-integration`.
2017-10-24 09:44:11 +08:00
d4d5e6965e
FEATURE: discourse-prometheus is an official plugin
2017-10-24 10:27:28 +11:00
4452d67a23
Revert "FIX: TL0 users' messages to moderators were not being posted when flagging private messages"
2017-10-23 18:17:53 -04:00
214fdad155
FEATURE: category and topic importer can support data from different sources using IMPORT_SOURCE
2017-10-23 14:01:57 -04:00
17e5fb0dc0
fix the build
2017-10-23 19:09:38 +02:00
80ad32094d
Small re-organization of CookedPostProcessor workflow
...
- only 'limit_size!' of oneboxed images once
- update post image at the end
- move 'enforce_nofollow' in its own method
2017-10-23 18:15:51 +02:00
Robin Ward
Arpit Jalan
Joffrey JAFFEUX
Guo Xiang Tan
OsamaSayegh
Régis Hanol
Sam
Will Jordan
Gerhard Schlager
Neil Lalonde
Guo Xiang Tan
Vinoth Kannan
Felix Wolfsteller
Geoffrey Challen
Jeff Wong
Leo McArdle
Blake Erickson
Erick Guan
Maja Komel
Kris
Mohammad AlTawil
blokovi
Jeff Atwood
Michael Brown
Matt Palmer
Vinoth Kannan
Kyle Zhao
Michael Howell
ckeboss
Viktor Benei
Rafael dos Santos Silva