2e7753c27f
User 'FileHelper.is_image?' to check wether a link is poiting to an image
2017-06-22 12:54:42 +02:00
80e348d226
PERF: Speed up slow tests in our test suite.
...
Before
```
Finished in 7 minutes 23 seconds (files took 4.15 seconds to load)
7145 examples, 0 failures, 10 pending
```
After
```
Finished in 6 minutes 12 seconds (files took 4.41 seconds to load)
7145 examples, 0 failures, 10 pending
```
2017-06-22 11:23:31 +09:00
d82dbd565b
FIX: Remove dependency on `rest-client`.
2017-06-16 09:42:41 +09:00
d6c63cc5b2
FIX: user's default group should only be set once
...
Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address.
Previously we were doing this everytime we'd save a user record 🤷
2017-06-14 19:20:18 +02:00
5d63a7f4a6
FIX: pull hotlinked images even when they have no extension
2017-06-13 13:27:05 +02:00
e888369f51
UX: Don't send emails for discobot notifications.
2017-06-12 17:00:27 +09:00
d92c938491
FIX: Don't raise an error cleaning up uploads if a path is nil
2017-06-08 14:31:58 -04:00
e8f0771dc9
FIX: the 'clean_up_uploads' jobs would delete images used in site settings
...
when they were entered using absolute URLs, with the CDN or simple a different format than the one used in the database
2017-06-07 22:53:15 +02:00
209383faab
FEATURE: pull onebox images
2017-06-06 18:51:58 +05:30
0aed2533ac
Revert unread optimisation, has too many edge cases
2017-05-26 09:04:13 -04:00
29fac1ac18
PERF: improve performance of unread queries
...
Figuring out what unread topics a user has is a very expensive
operation over time.
Users can easily accumulate 10s of thousands of tracking state rows
(1 for every topic they ever visit)
When figuring out what a user has that is unread we need to join
the tracking state records to the topic table. This can very quickly
lead to cases where you need to scan through the entire topic table.
This commit optimises it so we always keep track of the "first" date
a user has unread topics. Then we can easily filter out all earlier
topics from the join.
We use pg functions, instead of nested queries here to assist the
planner.
2017-05-25 15:07:30 -04:00
cdbe027c1c
Refactor `FileHelper` to use keyword arguments.
2017-05-24 13:54:26 -04:00
b78b010757
FIX: Fixes to grant new user of the month badge
2017-05-24 11:36:24 -04:00
9edc490d3f
FIX: remove memoized values in jobs
2017-05-22 16:26:30 -04:00
b23fc2bf84
Helper to find the final destination for a URL
2017-05-22 15:52:41 -04:00
f350dd4fd1
FIX: possible data leaking from one site to another in multisite in PendingFlagsReminder
2017-05-22 15:18:13 -04:00
773445b8df
FIX: Topic Crawling should only crawl HTTP/S urls
2017-05-22 11:57:20 -04:00
4382a0bb07
Rename `PostTimestampChanger` -> `TopicTimestampChanger`.
2017-05-22 15:01:33 +08:00
ea9f93dcc5
FIX: Don't crawl non-http/s links
2017-05-19 16:57:41 -04:00
7821400141
FEATURE: staff can set a timer to remind them about a topic
2017-05-16 14:49:50 -04:00
bd0bb879e5
FIX: Don't count likes from system users in the new user of the month
2017-05-15 13:14:32 -04:00
8eecd42856
FIX: Delete topic timer after completion.
2017-05-12 10:28:51 +08:00
55b61e9bea
rename topic_status_update to topic_timer
2017-05-11 18:27:53 -04:00
1019bbda46
FEATURE: set a timer to delete a topic
2017-05-11 12:52:29 -04:00
3ade46de0b
FIX: Don't send system message for new user of the month if disabled
2017-05-11 11:33:16 -04:00
4b7be137cb
don't generate errors if 'upload_id' is invalid
2017-05-11 09:07:04 +02:00
9641d2413d
REFACTOR: upload workflow creation into UploadCreator
...
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
f709899a1d
Allow theme field object model to support uploads
2017-05-10 15:46:42 -04:00
4db76796b9
FEATURE: Setting to poll feeds more frequently
2017-05-10 14:30:12 -04:00
6e4ba8a33e
Catch RSS Parsing errors
2017-05-09 15:07:06 -04:00
c2bf525a06
Make CloseTopic a no-op just in case
2017-05-09 15:02:05 -04:00
ba1868b051
FIX: There are still jobs enqueued for CloseTopic
2017-05-09 14:58:37 -04:00
e6e0025326
FIX: handle BOM in bulk import CSV file
2017-05-09 22:38:07 +05:30
94683b33b8
FIX: sanitize bulk invite error log
2017-05-09 17:41:59 +05:30
4f6e5fed2a
We don't need to raise an error when no post is present. Just noop.
2017-05-08 15:08:29 -04:00
71a266b673
Remove daily mailing mode option as it doesn't scale.
...
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
2017-05-05 12:21:50 +08:00
50c8ae2c10
Load user records in batches.
2017-05-05 10:57:31 +08:00
86f1cc8c92
FIX: don't apply max_emails_per_day_per_user on critical emails
2017-05-03 17:07:39 +05:30
cdce060a38
FIX: don't apply max emails per day per user to forgot password
2017-05-03 14:02:37 +05:30
ca224ed8e9
FIX: pending flags message should go to moderators group, not staff
2017-05-01 14:53:16 -04:00
dfe1174137
FIX: The dates for retroactive anniversary badges were wrong
2017-05-01 12:06:18 -04:00
f05f1a24d3
Change Anniversary badge to be multiple grant, once per year
2017-04-28 14:22:54 -04:00
85d9342ff0
Merge pull request #4836 from tgxworld/fix_clean_up_staged_users_job
...
FIX: Clean up unused staged users job not completing.
2017-04-27 15:41:46 +08:00
bf9c4a7828
FEATURE: secure_email site setting to prevent data going out in email
2017-04-26 13:05:56 -04:00
fe0a7d97ca
Fix incorrect class name.
2017-04-26 18:12:51 +08:00
b00886f5c1
Remove sidekiq-statistic gem.
...
* We don't really use it and there is an on-going issue
with the gem not expiring keys in a Redis list which
hasn't been fully resolved.
https://github.com/davydovanton/sidekiq-statistic/issues/73
2017-04-26 14:54:47 +08:00
daa97c40ce
FIX: Clean up unused staged users job not completing.
2017-04-26 10:51:36 +08:00
423f2ab228
FIX: Processing incoming email should be done in a background job.
2017-04-24 13:57:28 +08:00
05efa7ce68
simplify last_notified_id
2017-04-20 15:26:28 -04:00
3835e16cf7
FIX: New implementation of the "notify about flag after" setting. Only notify about new flags since the last notification. Send a private message to staff. Mention the 3 most active moderators in the message so they get notification emails.
2017-04-19 16:17:45 -04:00
73180c8a19
FIX: Private message can be set to publish in the future.
2017-04-11 20:44:25 +08:00
aadf4805a5
FIX: Topic status update not being deleted once it has been executed.
2017-04-11 10:32:13 +08:00
db77640634
FIX: grant first reply by email job was *brokenated*
2017-04-10 22:11:29 +02:00
690d2f4bd3
UX: Publish topic changes when topic is published.
2017-04-07 15:32:00 +08:00
48a9860f07
FIX: Publish topic to a category should unlist it as well.
2017-04-07 13:58:52 +08:00
8e794070d2
Fix incorrect method name.
2017-04-06 13:45:59 +08:00
e0e06c2992
Merge pull request #4794 from tgxworld/nuke_old_auto_close_jobs
...
FIX: Add onceoff job to remove old auto close topic sidekiq jobs.
2017-04-06 12:29:42 +08:00
5943543ec3
FIX: Improve checks for non-human users.
2017-04-06 11:29:34 +08:00
e8eaffbd72
FIX: Add onceoff job to remove old auto close topic sidekiq jobs.
2017-04-06 10:52:13 +08:00
17f2974d0a
SECURITY: Confirm new administrator accounts via email
2017-04-04 15:59:01 -04:00
69661be500
FIX: Don't raise an error if `TopicStatusUpdate` has been deleted.
2017-04-04 14:29:47 +08:00
ad44d2a400
Merge pull request #4790 from tgxworld/add_publish_to_topic_status_update
...
FEATURE: Allow admins to schedule a topic to be published in the future.
2017-04-04 11:18:53 +08:00
f4758a4c4d
FEATURE: Allow admins to schedule a topic to be published in the future.
2017-04-04 11:16:05 +08:00
ebe232da47
Weigh staff votes more for New User of the Month badges
2017-04-03 16:52:31 -04:00
a13a8dc96c
FIX: Safeguard to not award NewUserOfTheMonth if it hasn't been a month
2017-04-03 13:26:51 -04:00
3d64f33d40
Require at least two likes to get the "New User of the Month" badge
2017-04-03 13:03:28 -04:00
3b64aeaf21
loosen new user of the month criteria slightly
2017-03-31 16:33:50 -07:00
e4b1376146
Change New User of the Month Badge to use trust level rather than age
2017-03-31 16:56:58 -04:00
a8d3779f0b
Update New User of the Month badge to require 4 posts in 2 topics
2017-03-31 16:52:00 -04:00
fc7fa4c0ad
Rename "Rookie of the Month" to "New User of the Month"
2017-03-31 16:30:30 -04:00
e6f6bd34d8
Send the user a notice when they've received rookie of the month
2017-03-31 15:06:31 -04:00
893e93dfbe
New badge, Rookie of the Month, for two new high quality users.
2017-03-31 15:06:31 -04:00
34b7bee568
FEATURE: Allow admin to auto reopen at topic.
...
* This commit also introduces a `TopicStatusUpdate`
model to support other forms of deferred topic
status update in the future.
2017-03-31 11:14:18 +08:00
df246c79b6
FEATURE: add user profile fields in user list export
2017-03-21 15:51:52 +05:30
566f367fc3
FIX: Don't migrate custom emojis that are no longer valid.
...
* Warn about failed migration in logs.
2017-03-17 08:28:24 +08:00
1957d12670
SECURITY: Don't use backticks for exporting your archive
2017-03-16 16:24:59 -04:00
0a87547cbc
Fix broken tests.
2017-03-16 10:22:15 +08:00
cfbfea0596
FEATURE: Allow easier customization to the web hook event serialization.
2017-03-16 10:09:05 +08:00
1a7e954e09
FIX: Store custom emojis as uploads.
...
* Depending on a hardcoded directory was a flawed design
which made it impossible to debug when custom emojis go
missing.
2017-03-14 13:07:18 +08:00
23b06d2895
FIX: should not try to send digest to users who reached the bounce threshold
2017-03-08 19:19:11 +01:00
cf8bc4483f
FIX: always send critical emails even when bounce score threshold has been reached
2017-03-08 10:06:16 +01:00
d5bcc70e9c
FIX: grant trust level when bulk adding users to group
2017-03-06 14:39:53 +05:30
80858bae2c
FEATURE: further restrict downloading of backups
...
- send email to logged in admin when they press the "download" button
- show pop-up that email was sent
- create email template
- require a valid token to download backup
2017-03-01 08:28:34 -07:00
0a41da6bad
FEATURE: Add order logic to admin users controller
...
Added order and direction parameters for sorting admin user pages. This
commit only includes backend api changes.
https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649
Now you can pass in `order` and `asc` parameters to the
`/admin/users/list/<query>.json` endpoint.
Example:
`/admin/users/list/active.json?&order=post_count` which defaults to desc
and
`/admin/users/list/active.json?order=post_count&asc=true`
2017-02-24 17:11:17 -07:00
f07b4b310a
should not have renamed this setting in 460665895c
2017-02-08 18:11:34 +01:00
ff49f72ad9
FEATURE: per client user tokens
...
Revamped system for managing authentication tokens.
- Every user has 1 token per client (web browser)
- Tokens are rotated every 10 minutes
New system migrates the old tokens to "legacy" tokens,
so users still remain logged on.
Also introduces weekly job to expire old auth tokens.
2017-02-07 09:22:16 -05:00
19f7beaa2c
FIX: topic links were getting dropped when post is rebaked
2017-01-30 14:55:53 +05:30
496682c442
Merge pull request #4662 from tgxworld/fix_localized_group_name_change
...
Fix localized group name change
2017-01-26 10:50:00 -05:00
706b4f6b9f
FEATURE: Remap group mentions when group name has been changed.
2017-01-18 13:39:34 +08:00
b60e9b7330
FIX: Handle img src starting with "//" in pull_hotlinked_images job
2017-01-16 10:50:07 +00:00
7a1ff59822
FIX: PM email to suspended member was broken
2017-01-05 13:58:14 +05:30
076a08d8e1
FIX: Unactivated users should not be automatically added into groups as well.
2016-12-21 18:15:01 +08:00
7228081820
FIX: Automatic group membership should not add staged or unactivated users.
2016-12-21 18:04:26 +08:00
923cf73c6e
Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox.
2016-12-19 14:54:07 -05:00
f867af6bf9
bye bye byebug
2016-12-15 15:52:25 +11:00
3666575b46
UX: Improve styling for groups page.
2016-12-15 12:19:13 +08:00
664feca199
FIX: don't send emails from muted users in mailing list mode
2016-12-12 15:28:26 +01:00
9a800107cb
FIX: Associate category logo and background to uploads record.
2016-12-12 17:37:28 +08:00
05f55dbc10
FEATURE: Group logs.
2016-12-12 17:29:54 +08:00
424fc8e2e2
FIX: Don't raise an error if the RSS endpoint is 404
2016-12-05 12:29:14 -05:00
ce974da9e5
FIX: simplify CSV file upload
2016-12-05 14:09:08 +05:30
55b35a05ed
FIX: This should not have been checked in.
2016-12-05 11:49:04 +08:00
22059d4df9
Add Rake task to clean up unused multisite Redis keys.
2016-12-05 11:46:34 +08:00
0dfac2dd24
Merge pull request #4545 from hiveeyes/pop3_polling_openssl_verify
...
Add “pop3_polling_openssl_verify” setting to turn off TLS server certificate verification
2016-11-15 19:33:44 +01:00
43fd3ebd4a
Add “pop3_polling_openssl_verify” setting to turn off TLS server certificate verification like “smtp_openssl_verify_mode”. Defaults to “true”, so it does not change current behavior.
2016-11-11 21:59:15 +01:00
ac2c035856
FIX: stop raising exceptions when a post goes missing
2016-11-08 14:51:56 +11:00
dd58c00699
FEATURE: Add instance id in the webhook payload
2016-11-04 15:21:41 +01:00
f03d9cad06
PERF: `NOT IN` query is really inefficient for large tables.
2016-11-02 13:09:18 +08:00
478418e780
FIX: notify_old_email template did not had new_email
2016-10-25 23:50:55 +05:30
52b338db62
FIX: category logo & background URLs should not use the CDN
2016-10-25 10:43:57 +02:00
923db2e559
FIX: download avatar from facebook/twitter in a job in order to prevent hangs when avatars are huge
2016-10-24 17:15:13 +02:00
aee943486a
FEATURE:'No Echo' option for mailing list mode.
...
Mailing list mode now includes the 'no echo' option: to only receive emails of posts not created
by you. If you reply to an email thread in mailing list mode, your reply will not then be echoed
back to you in a duplicate email by the system.
2016-10-19 13:14:36 -04:00
e5a13b0ac1
FIX: specify CSV file encoding and better error reporting
2016-10-18 00:31:35 +05:30
af83c8dc14
Upload Logos Step
2016-09-22 09:52:19 -04:00
707fcb9434
FIX: Content-Lenght should be the size in octets
2016-09-21 10:31:20 +08:00
00d5facf36
FEATURE: prompts new webhook events
2016-09-19 12:07:17 +08:00
451050c6c4
Merge pull request #4437 from fantasticfears/webhooks-event-name
...
FIX: show event name in webhook headers
2016-09-16 14:27:12 +08:00
baacb30ba1
FIX: Incorrect folder.
2016-09-15 15:20:07 +08:00
7423140825
FIX: show event name in webhook headers
2016-09-12 17:48:54 +08:00
0fbb949af5
Merge pull request #4432 from tgxworld/migrate_upload_scheme_to_scheduled_job
...
FIX: Make `Jobs::MigrateUploadScheme` a scheduled job.
2016-09-06 08:39:27 +08:00
9ce61b4586
FEATURE: Webhooks.
2016-09-05 18:44:00 +08:00
340874d345
FIX: post notifications in JSON so we properly support arrays and so on
2016-09-04 15:51:16 +10:00
a869d861f4
FIX: Make `Jobs::MigrateUploadScheme` a scheduled job.
...
This reverts https://github.com/discourse/discourse/commit/9d8db11c
If the job fails during execution or if `SiteSetting.migrate_to_new_scheme`
has been set to `false`, the job will be considered as executed even
though the migration has not been completed. As a result, the job
will have to be executed manually which is not desirable.
2016-09-02 11:48:45 +08:00
929730c008
FIX: properly insert images in markdown inline format (take 2)
2016-09-01 17:56:39 +05:30
54a1180140
FIX: properly insert images in markdown inline format
2016-09-01 11:55:40 +05:30
896732975e
correct url linked in push notification
2016-08-26 13:45:56 +10:00
4fe52c8cbe
FEATURE: backend support for pushing notifications to clients
2016-08-26 12:47:10 +10:00
394cd43d77
Scrub only after converting strings to UTF-8
...
Scrubbing an ASCII-8BIT string isn't ever going to remove anything, because
there's no code point that isn't valid 8-bit ASCII. Since we'd really
prefer it if everything were UTF-8 anyway, we'll just assume, for now, that
whatever comes out of SimpleRSS is probably UTF-8, and just nuke anything
that isn't a valid UTF-8 codepoint.
Of course, the *real* bug here is that SimpleRSS [unilaterally converts
everything to
ASCII-8BIT](https://github.com/cardmagic/simple-rss/issues/15 ). It's
presumably *far* too much to ask that it detects the encoding of the source
RSS feed and marks the parsed strings with the correct encoding...
2016-08-25 16:09:07 +10:00
a2220feaea
FEATURE: new site setting rebake_old_posts_count
2016-08-15 16:34:13 +05:30
7db2083d45
FIX: 'cancel_scheduled_job' was deleting all jobs in multisite
2016-08-12 13:10:52 +02:00
e55e2aff94
FIX: FirstReplyByEmail badge wasn't granted
...
DEPRECATED: PostProcess badge trigger
2016-08-10 19:24:01 +02:00
51322a46b3
FEATURE: retry processing incoming emails on rate limit
2016-08-08 22:28:27 +02:00
8b252f19d7
Merge pull request #4365 from gdpelican/fix/daily-mlm-notifications
...
Don't halt notification emails for those on daily mailing list mode
2016-08-08 14:30:56 -04:00
c064e946b2
FIX: custom reason for flags were not showing for non-english locales
2016-08-05 18:41:11 +05:30
c2819e99f4
Don't halt notification emails for those on daily mailing list mode
2016-08-03 12:29:38 -04:00
c591429868
FIX: don't destroy uploads in queued posts and drafts
2016-08-01 18:35:57 +02:00
12dc511fea
PERF: make score calculator cheaper when site has long topics
2016-07-22 09:48:44 +10:00
f1566ef80b
FIX: escape comma in exported CSV file
2016-07-19 13:19:46 +05:30
1ea1cefb35
Extract Nginx log analyzer into a plugin that ships with Discourse.
2016-07-19 15:44:00 +08:00
a80e8cb9bd
FIX: do not execute onceoff badge queries if the badges are disabled
2016-07-06 13:04:08 +05:30
17890f95a1
FIX: don't send emails to mailing_list users when bounce threshold is reached
2016-07-05 12:20:07 +02:00
bd07658a37
PERF: Split queries when cleaning uploads.
...
This reduces the number of scans that the db has to do in the query
to fetch orphan uploads. Futheremore, we were not batching our
records which bloats memory.
2016-07-04 16:34:32 +08:00
813fcebdd1
FIX: email_always was not respected correctly
...
In the past email always meant, email me even if active UNLESS I read post
Now emails always means, always, even if I read the post
2016-07-01 11:22:07 +10:00
5dcdfb9777
ensure default locale is 'en' instead of nil
2016-06-30 17:37:00 +02:00
76766a25bf
FIX: wrong translation key
2016-06-28 17:22:34 +02:00
2ecd0da59f
REFACTOR: use same code path for handling emails via API and POP
2016-06-22 15:50:49 +02:00
e9a293beeb
FIX: clean up uploads job
2016-06-20 22:05:41 +02:00
852860de66
FEATURE: simpler and friendlier unsubscribe workflow
...
- All unsubscribes go to the exact same page
- You may unsubscribe from watching a category on that page
- You no longer need to be logged in to unsubscribe from a topic
- Simplified footer on emails
2016-06-17 11:28:49 +10:00
e97e0bb311
FEATURE: new FirstReplyByEmail bronze badge
2016-06-13 15:37:14 +02:00
7b205ebba4
FEATURE: customize invite email message
2016-06-06 20:15:30 +05:30
Régis Hanol
Guo Xiang Tan
Robin Ward
Vinoth Kannan
Sam
Neil Lalonde
Arpit Jalan
Guo Xiang Tan
Jeff Atwood
Erick Guan
Blake Erickson
Leo McArdle
Andreas Motl
Kiril Staikov
Matt Palmer
James Kiesel