30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
45285f1477
DEV: remove update_attributes which is deprecated in Rails 6
...
See: https://github.com/rails/rails/pull/31998
update_attributes is a relic of the past, it should no longer be used.
2019-04-29 17:32:25 +10:00
6f7b6a3333
FIX: Disagree and Restore should not revert edits
2019-04-11 16:21:18 -04:00
abf4ca9774
FIX: Should be able to recover a user deleted post if raw didn't change
2019-04-10 13:10:40 -04:00
31053f30de
FEATURE: Let users delete their own topics. ( #7267 )
2019-03-29 17:10:05 +01:00
7740b1570b
FIX: Avoid the deleted_at scope when recovering a topic from a recently recovered post
2019-03-29 09:40:15 -04:00
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
9ebabc1de8
FEATURE: unconditionally update Topic updated_at when posts change in topic
...
Previously we would bypass touching `Topic.updated_at` for whispers and post
recovery / deletions.
This meant that certain types of caching can not be done where we rely on
this information for cache accuracy.
For example if we know we have zero unread topics as of yesterday and whisper
is made I need to bump this date so the cache remains accurate
This is only half of a larger change but provides the groundwork.
Confirmed none of our serializers leak out Topic.updated_at so this is safe
spot for this info
At the moment edits still do not change this but it is not relevant for the
unread cache.
This commit also cleans up some specs to use the new `eq_time` matcher for
millisecond fidelity comparison of times
Previously `freeze_time` would fudge this which is not that clean.
2019-03-28 17:28:01 +11:00
167d85c21f
FIX: post & topic destroyed hooks not triggering with tag filter
2019-03-06 22:52:54 +05:30
05ebb52ec4
FEATURE: defer flags when deleting child replies ( #7111 )
2019-03-06 14:32:25 +05:30
76696b22fe
DEV: call 'enqueue_hooks' method only if active webhooks exist
2019-02-19 12:47:57 +05:30
f2c3415548
FIX: Should not generate payload until active webhooks are exist
2019-02-19 12:23:42 +05:30
c719658f9f
`human?` helper method on a user
...
This is cleaner than hard coding `id > 0` in ruby code.
2019-02-08 13:34:54 -05:00
9cf4013073
Add raw post content in "flagged post removed by staff" PM
2019-01-21 12:27:23 +05:30
40f10855c6
FIX: defer flags (only) when handling a flag and deleting replies ( #6702 )
2018-11-29 22:44:18 +05:30
851ef14096
Revert "FIX: do not agree flags by default when deleting posts"
...
This reverts commit cb6fc8057b
2018-11-28 10:21:11 +05:30
cb6fc8057b
FIX: do not agree flags by default when deleting posts
2018-11-27 10:57:20 +05:30
993d8f346e
FIX notifications for flag PMs ( #6641 )
2018-11-22 10:25:19 +08:00
24e5be3f0c
FIX: Relative links in translations should work with subfolder
2018-11-08 23:31:05 +00:00
8430ea927e
FIX: Generate webhook payloads before destroy events ( #6325 )
2018-10-05 16:53:59 +08:00
34516c72bd
FIX: Recover public actions (likes) when recovering a post ( #6412 )
2018-10-02 11:25:08 -04:00
2e02a28ab4
FIX: do not revise post if post revision is not present
2018-09-21 14:08:58 +05:30
d77dccc636
FIX: user-deleted posts with deferred flags can be destroyed
2018-08-09 14:54:31 -04:00
fd29ecb91a
UX: include a flag reason in the post-deleted-by-staff-because-of-flags message
2018-07-30 16:45:46 -04:00
135c803f49
FIX: don't send PM if flagged post is deleted but flags were deferred or cleared
2018-07-26 15:12:31 -04:00
417bcf7d2e
add checks for staff and system user before sending flags_agreed_and_post_deleted message
2018-07-24 19:25:11 -04:00
fe39cdc90a
FEATURE: when a post is deleted because a moderator agreed with flags, send a message to the post author
2018-07-24 17:17:56 -04:00
b1082924b9
FIX: do not validate topic deletions
2018-07-13 22:53:36 +05:30
f134701c7b
FIX: user topic and post counts can become negative when staff deletes posts in personal messages
2018-07-04 09:31:16 -04:00
50f14c6e61
Prefer `update!` -> `update!`.
2018-06-22 15:13:04 +08:00
d96c1058a2
FEATURE: add staff action log for 'restore topic'
2018-03-21 18:04:13 +05:30
9dc9ca4ac0
FIX: be consistent with how first posts in topics are counted. do like DirectoryItem.refresh_period :all
2017-11-10 12:18:25 -05:00
21dd2ccd43
FIX: only count regular posts in user stats when deleting
2017-11-02 18:05:23 -04:00
30689783db
don't decrement post_count for a post in a deleted topic that has already been uncounted
2017-11-02 18:05:23 -04:00
24af9b7d97
FIX: when a topic is deleted, update the post count stats of all user who replied
2017-11-02 18:05:23 -04:00
77d4c4d8dc
Fix all the errors to get our tests green on Rails 5.1.
2017-09-25 13:48:58 +08:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
a6450f7377
REFACTOR: Allow `delete_removed_posts_after` SiteSetting to be bypassed.
2017-06-16 12:27:51 +09:00
aef89c4850
REFACTOR: Load `Post` records in batches when destroying stubs.
2017-04-25 10:19:21 +08:00
e84fcc7d74
Staff action logs explain when system is deleting a post because author marked it to be deleted
2017-01-10 17:25:36 -05:00
2f6a4cc6de
remove UserActionObserver, replace with after_save and service
...
interestingly there was some left over dead code from when stars
existed in the topic_users table
2016-12-22 16:46:53 +11:00
1b2b142f30
FIX: Post without a topic can be destroyed.
2016-09-05 19:00:49 +08:00
aabb7a8592
FIX: DiscourseEvent should not be triggered from within the controller.
2016-09-05 15:58:04 +08:00
6e4ff45e44
FIX: deleting a topic result not updated on screen
2016-06-22 17:28:46 +10:00
0c8dd28395
FIX: Post count wasn't recovered when a post is recovered.
2016-06-13 11:25:06 +08:00
fbdd9c0034
FIX: unread and new count not removing deleted topics on the fly
...
FIX: unread PMs interfering with unread count
2016-03-30 11:18:07 +11:00
007326d3bd
FIX: hidden posts that are edited by the author and unhidden could not be flagged by the same users again
2015-12-29 16:59:36 -05:00
c1a9e32b48
FIX: When recovering a post, it should recreate user actions
2015-09-18 12:48:43 -04:00
1343d40558
PERF: deleting a post in huge topics was timing out
...
- add missing index to user actions for fast retrieval by post
- add missing indexes to users for fast retrieval of staff
- only refresh topic_users liked/bookmarked cache for affected users
2015-06-18 09:58:49 +10:00
Sam Saffron
Bianca Nenciu
Robin Ward
Roman Rizzi
Vinoth Kannan
Arpit Jalan
Maja Komel
Gerhard Schlager
Penar Musaraj
Neil Lalonde
Guo Xiang Tan
Guo Xiang Tan