75f3f7fcbd
FEATURE: clean API method for reading a single notification
2016-09-16 16:14:15 +10:00
512922d776
SECURITY: Add filename validation for backup uploads.
2016-09-16 11:58:14 +08:00
2c9a47dda5
FIX: Validate the raw content of posts before enqueuing them
2016-09-12 12:26:49 -04:00
2d859ba0ed
FIX: user api should always be available to staff
2016-09-12 15:42:06 +10:00
e78b7a243e
FIX: Don't enqueue posts if the user can't create them (ex: closed)
2016-09-09 12:15:56 -04:00
1d281e02c7
id is optional if already specified in header
2016-09-02 17:08:46 +10:00
be0fd5b4cc
FEATURE: allow user api key revocation for read only keys
2016-09-02 17:04:00 +10:00
0217973374
FIX: Importing user avatar when new user login by SSO
2016-08-29 20:47:19 +08:00
2251104e32
FEATURE: avatar flair can be font awesome icons
2016-08-26 17:15:37 -04:00
ca79c4b276
stop eating up push_urls
2016-08-26 13:23:06 +10:00
fcdf13f52d
add some more testing
2016-08-26 13:18:20 +10:00
a37db9448f
correctly return access rights in auth redirect
2016-08-26 13:12:38 +10:00
d079f69b7b
FEATURE: add flair to avatars using new settings in the groups admin UI
2016-08-17 15:13:15 -04:00
a25a8115e8
FEATURE: support HEAD request to /user-api-key/new
...
This allows us to cleanly sniff to find if it exists
2016-08-17 09:58:19 +10:00
416e7e0d1e
FEATURE: basic UI to view user api keys
2016-08-16 17:06:52 +10:00
3b792054f2
Merge pull request #4387 from gdpelican/feature/tags-intersection
...
FEATURE: Tags intersection page
2016-08-15 16:24:29 -04:00
037e9bb7b8
Support any number of tag intersections
2016-08-15 15:30:17 -04:00
fc095acaaa
Feature: User API key support (server side implementation)
...
- Supports throttled read and write
- No support for push yet, but data is captured about intent
2016-08-15 17:59:36 +10:00
7e73b933c7
First pass
2016-08-12 15:28:46 -04:00
7e4503dd99
FEATURE: basic info route for all sites, even ones that require login
...
This information is public in meta tags already on home page, providing a
route allows consumers to check it way more cheaply
2016-08-12 17:10:35 +10:00
afaba56de3
FEATURE: missing API endpoint for topic tracking states
2016-08-12 17:10:35 +10:00
429f27ec96
SECURITY: Avoid mass assignment on user create
2016-08-05 11:57:13 -04:00
5f67cd7b45
FIX: tag input detects when a tag is not allowed and won't offer to create it anyway
2016-08-03 13:18:56 -04:00
681f566a66
FIX: staff members should be able to see raw email of deleted posts
2016-08-01 23:55:22 +02:00
82e170d6a6
FIX: 404 when filtering by category, no sub-category, and a tag
2016-07-28 16:19:03 -04:00
2f8ab8cd30
SECURITY: XSS in "Account Suspended" Messages and Badge Descriptions
2016-07-28 11:38:12 -04:00
c6dbaca0dc
SECURITY: disable user entered badge SQL by default
...
- Hidden site settings now must be change via rails console
2016-07-28 09:03:00 +10:00
cb3afd11b4
SECURITY: limit route access when using external avatars
2016-07-28 09:00:43 +10:00
c626558d36
UX: group pages should not show Messages tab to unauthorised users ( #4318 )
2016-07-09 00:50:04 +05:30
1eb64151f6
User interface for watching first post
2016-07-07 11:21:50 -04:00
ccf9b70671
When restoring a backup, disable emails.
...
This prevents accidental sending of emails after a restore before
the admin has had a chance to review everything.
2016-06-24 17:15:15 -04:00
8866169879
FEATURE: can invite/revoke groups on private messages
2016-06-20 16:29:27 +10:00
dd1a184955
Correct mailing list mode unsubscribe
2016-06-17 11:57:23 +10:00
852860de66
FEATURE: simpler and friendlier unsubscribe workflow
...
- All unsubscribes go to the exact same page
- You may unsubscribe from watching a category on that page
- You no longer need to be logged in to unsubscribe from a topic
- Simplified footer on emails
2016-06-17 11:28:49 +10:00
49f8a2baa7
FEATURE: support for mandrill webhooks
2016-06-13 12:32:14 +02:00
3015030fe2
FIX: unlisted topics do not get "slug auto correct" logic
2016-06-10 10:53:26 +10:00
214e25f1b5
use proper 'Message-Id' field
2016-06-09 00:33:13 +02:00
3e3538d603
loosen security a bit on mailgun's webhook
2016-06-08 22:38:38 +02:00
431179dd25
FEATURE: Prompt users when they are entering duplicate links
2016-06-07 14:47:22 -04:00
6aaa484baa
REFACTOR: Move composer messages to store
2016-06-07 14:47:22 -04:00
cc66bff730
we forgot to update the mailgun tests
2016-06-06 16:55:24 -07:00
fe595f1653
FEATURE: mailjet webhook
2016-06-06 19:47:45 +02:00
9704603fab
FEATURE: sendgrid webhooks
2016-06-01 21:48:06 +02:00
116efffdaa
FEATURE: webhooks support for mailgun
2016-05-30 17:11:17 +02:00
cb5be1fe8f
Upgrade rspec to 3.4.0.
2016-05-30 11:38:38 +08:00
f387dfe226
FIX: mixed case group mentions were not getting highligted in composer
2016-05-22 18:32:49 +05:30
49a6d0b789
FIX: Don't bother with negative offsets
2016-05-09 16:33:55 -04:00
82daf93eb3
Merge pull request #4206 from techAPJ/convert-topic
...
FEATURE: move a topic from PM to regular topic or vice versa
2016-05-04 01:33:15 +05:30
b061ba5c52
FIX: Broken spec. Stupid mocking.
2016-05-03 15:30:48 -04:00
acfb540952
FEATURE: move a topic from PM to regular topic or vice versa
2016-05-02 21:34:05 +05:30
74b3807f60
FEATURE: new bootstrap mode settings for brand new Discourse community ( #4193 )
...
* FEATURE: new bootstrap mode settings for brand new Discourse community
* new SiteSetting.set_and_log method
2016-04-26 13:08:19 -04:00
9e50f36c50
Merge pull request #4137 from cpradio/add-warning-to-flag
...
FEATURE: Add warning input to flag dialog when notifying a user
2016-04-15 16:23:22 +10:00
379bfac36d
Merge pull request #4010 from riking/patch-sitelinks
...
FEATURE: Add /search discovery
2016-04-14 10:35:13 +02:00
22b2f5285c
FIX: extract links in post processor
...
when oneboxes are not cached or are refreshed they can introduce new
links, these links must be extracted otherwise you can not follow them
2016-04-12 12:28:18 +10:00
a5cd557906
Simplify setting the top_page_default_timeframe SiteSetting ( #4149 )
2016-04-07 18:06:54 +02:00
a130cb8305
FEATURE: move more urgent emails notifications to critical queue
...
Move signup, admin login and password change email notifications
to critical queue
2016-04-07 14:39:01 +10:00
8ec7fd84fd
FEATURE: prioritize sidekiq jobs
...
This commit introduces 3 queues for sidekiq
"critical" for urgent jobs (weighted at 4x weight)
"default" for standard jobs(weighted at 2x weight)
"low" for less important jobs
"critical jobs"
Reset Password emails has been seperated to its own job
Heartbeat which is required to keep sidekiq running
Test email which needs to return real quick
"low priority jobs"
Notify mailing list
Pull hotlinked images
Update gravatar
"default"
All the rest
Note: for people running sidekiq from command line use
bin/sidekiq -q critical,4 -q default,2 -q low
2016-04-07 12:56:43 +10:00
2b9e8e5a7d
Merge pull request #4147 from cpradio/default_top_timeframe
...
FIX: Use default top setting when user is return or enough data exists for Top Page Results
2016-04-06 18:33:56 +02:00
c5bb1d1cfe
Return default top setting as part of best_periods_for to see if it can be used
2016-04-05 14:27:18 -04:00
d402a45781
FIX: hitting '/t/:id/posts.json' should return the first page of posts
2016-04-05 19:12:14 +02:00
95fa340601
Added spec tests
2016-04-03 19:44:14 -04:00
41208b99a1
FEATURE: RSS feed for user posts and topics
2016-03-31 20:24:05 +05:30
f2ddd44712
FEATURE: Add /search discovery
...
The opensearch.xml results in a "site search engine" being added to
Chrome, while the sitelinks search tag results in "Search this website"
being added to Google Search.
2016-03-28 15:07:59 -07:00
9a5ded48cf
FIX: Return a proper error message when sync sso fails.
2016-03-26 13:30:15 +08:00
4180e207c3
FIX: Crazy large ids should not raise exceptions
2016-03-23 12:13:47 -04:00
34469e725b
FEATURE: separate API endpoints for public and private posts
2016-03-21 18:21:15 +05:30
bd83cf7f4c
FEATURE: add group posts and mentions RSS
2016-03-18 22:29:10 +05:30
1fba835d4f
FIX: Use a logging table for daily likes given. Use it for badges.
2016-03-18 11:18:54 -04:00
213950e4cf
FEATURE: add option to include topics from trust level 0 users in digest emails
2016-03-17 17:35:23 -04:00
0ea20f2d77
mock was causing spec to fail
2016-03-17 15:46:16 +11:00
84d234a98a
Merge pull request #4076 from scossar/locale-from-header-setting
...
FEATURE: add site setting for setting locale from header
2016-03-17 07:53:20 +11:00
06591022fe
FEATURE: Generous badge
2016-03-15 16:08:29 -04:00
0cbeda8414
add site setting for setting locale from header
2016-03-14 16:18:19 -07:00
89248580dc
FEATURE: revert post to a specific revision
2016-03-11 02:46:55 +05:30
5771d2aee2
SECURITY: Support for confirm old as well as new email accounts
2016-03-08 14:52:22 -05:00
d62689fa76
Move updating a user's email to its own controller
2016-03-08 14:52:22 -05:00
1135d2094a
Merge pull request #4006 from scossar/set-locale-from-header
...
Feature: (WIP) Set locale from Accept-Language header
2016-03-04 09:12:30 +01:00
8d4bac7da2
fix build & add migration to clear common passwords cache
2016-03-03 19:39:22 +01:00
bfaa4cdb37
FEATURE: compose a new pre-filled private message to a group via URL
2016-03-03 00:19:06 +05:30
50e65634d7
FEATURE: new setting min_admin_password_length and better default
2016-03-02 14:43:26 +05:30
0a396583ed
set locale for anonymous from header
...
set locale on signup
update spec
add locale option
2016-02-26 13:45:00 -08:00
b2f4659792
Pass discourse username to TopicRetriever from embed controller
...
When you specify `discourse_username` param on the embed URL, it should
translate to creating the post with that username.
This commit ensures that this is now the case.
2016-02-25 13:02:25 +00:00
e8de80de98
FIX: Default to first page when page params is an array.
2016-02-25 11:32:58 +08:00
6df5b38b54
better user update spec
2016-02-24 16:10:08 +05:30
d77511319e
show monthly top topics on 404 page
2016-02-24 13:46:55 +05:30
1253afdf95
FIX: invite link should not auto-accept invitation if user is already logged in
2016-02-23 19:49:58 +05:30
3829c78526
PERF: shift most user options out of the user table
...
As it stands we load up user records quite frequently on the topic pages,
this in turn pulls all the columns for the users being selected, just to
discard them after they are loaded
New structure keeps all options in a discrete table, this is better organised
and allows us to easily add more column without worrying about bloating the
user table
2016-02-17 18:08:25 +11:00
dd6ebde824
FIX: Always ensure notifications are treated as read once clicked
...
UX: improve messaging so notifications list is far more stable
PERF: improve performance of notifcation lookup queries
- Add feature "SetTransientHeader" that allows shipping info to server
in the next Ajax request
- remove local storage hack used for notifications
- amend lookupStale to return hydrated objects, move logic into store
- stop magically clearing various notifications (likes, invitee accepted, group_summary, granted badge)
2016-02-15 19:29:47 +11:00
35142847ba
FIX: Prepend the user id before username in admin user routes
2016-02-09 15:14:13 +01:00
b75353c26f
correct specs
2016-01-27 23:40:45 +11:00
0064927077
FIX: do not allow new email to be duplicate
...
FIX: return proper error message when email already exists
2016-01-23 13:42:53 +05:30
74b5d063f9
FIX: enabling suppress_from_homepage should only remove the category from the homepage
2016-01-20 17:55:58 +01:00
f61537bc16
Merge pull request #3952 from gdpelican/unsubscribe-via-email
...
Unsubscribe via email
2016-01-20 14:38:14 +01:00
c7283751a3
Unsubscribe via email
2016-01-20 22:25:25 +13:00
7303f8f309
FEATURE: first pass at user summary page
2016-01-20 15:14:25 +11:00
ca3e2b4da3
FEATURE: you can not drill down and see why you have badges
...
Clicking on badges filters down the list to a particular user.
2016-01-18 17:59:20 +11:00
a055c37939
Merge pull request #3956 from tgxworld/fix_clashing_slug
...
FIX: Clashing category slug.
2016-01-18 10:15:13 +08:00
380764dc92
FIX: validate email when changing via user preferences page
2016-01-16 10:50:49 +05:30
c60e360c90
FIX: Clashing category slug.
2016-01-13 15:32:29 +08:00
e676974f16
Merge pull request #3953 from techAPJ/wiki
...
FEATURE: allow users to wikify their own posts based on trust level
2016-01-13 09:53:33 +05:30
8049dfdfda
CLEANUP: remove 'contains_messages' leftover 💩
2016-01-12 11:29:26 +01:00
06bac23e5f
FEATURE: allow users to wikify their own posts based on trust level
2016-01-12 08:44:25 +05:30
c7df6783a9
FIX: only invalidate password reset links using javascript
2016-01-04 11:48:54 -05:00
c1dbf5c1c4
FEATURE: Autolinking to category using hashtags.
2016-01-05 00:12:24 +08:00
03ea0bfe22
FEATURE: allow users to archive messages
...
Messages are now in 3 buckets
- Inbox for all new messages
- Sent for all sent messages
- Archive for all messages you are done with
You can select messages from your Inbox or Sent and move them to your Archive,
you can move messages out of your Archive similarly
Similar concept applied to group messages, except that archiving and unarchiving
will apply to all group members
2015-12-23 11:09:30 +11:00
a9099f9e23
SECURITY: ensure we never accept fake images
2015-12-21 16:08:14 +01:00
d20f6e0cb0
fix test and comment out js test for now
2015-12-20 17:34:15 +11:00
4c967d11b4
FEATURE: log site text changes
2015-12-18 19:42:06 +05:30
878ae7628f
correct spec
2015-12-16 13:48:49 +11:00
15c229195f
FEATURE: notification_level on a per-group basis
2015-12-14 23:17:09 +01:00
e52852dd0f
FIX: Autoclose message was not correct when immediate
...
FEATURE: Warn when setting auto-close for right now
2015-12-08 18:16:48 +05:30
578f606a1a
add 'incoming_email' to groups
2015-12-07 12:39:28 +01:00
68bfecef8f
FIX: Broken categories controller specs.
2015-12-07 00:09:02 +08:00
9899e8d4a5
FEATURE: First class messages to groups, you can select a group as a target of a message
2015-12-02 15:49:43 +11:00
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
46d2e17194
Remove mock that was breaking tests
2015-12-01 17:04:16 +11:00
76692235ae
FIX: don't ever fetch staged accounts in unseen mentions
2015-11-27 18:16:50 +01:00
5e93140f85
FEATURE: Can override any translation via an admin interface
2015-11-27 11:35:19 -05:00
ba0df7e4cd
rename 'is_support' to 'contains_messages'
2015-11-26 18:40:54 +01:00
e8a6ff4808
prevent users from ever changing the category of a topic in a support category
2015-11-26 18:31:24 +01:00
43614439e6
FEATURE: can take over a staged account
2015-11-13 19:07:28 +01:00
3939331dec
FIX: Staff was getting 500 when editing post in deleted topic
2015-11-13 11:35:23 -05:00
16f509afb9
FIX: enforce 'allow_uploaded_avatars' & 'sso_overrides_avatar' server-side
2015-11-12 10:26:45 +01:00
7d3be0f8f1
forgot password on a staged account does nothing
2015-11-09 17:37:33 +01:00
6dd4bc7d57
FEATURE: support group owner, capable of controlling group membership
...
Group owners are regular users that can add or remove users to a group
The Admin UX allows admins to appoint group owners
The public group UX will display group owners first and unlock UI to
add and remove members
Group owners can only be appointed on non automatic groups
Group owners may not appoint another group owner
2015-11-10 00:56:57 +11:00
fe5264f9e9
filter by username in email digest preview
...
adds a user prompt on the email digest preview page to generate a preview for a particular user
also fixes some broken styling on the page
2015-10-30 18:11:38 +00:00
bb79e6aff7
FEATURE: new hide_user_profiles_from_public site setting
2015-10-28 19:56:08 +01:00
23371b026d
FIX: Don't raise an error if you try to assign a group that exists
2015-10-28 12:21:54 -04:00
47e25648df
FEATURE: Change user groups in bulk via admin
2015-10-26 15:57:30 -04:00
c28843e87b
FIX: redirect to return_url when working as SSO provider
2015-10-25 11:30:38 +05:30
06b799bfbf
Merge pull request #3857 from gdpelican/fix-for-untopiced-posts
...
Don't error on posts#latest if a post does not have a topic
2015-10-16 14:59:36 +02:00
695b366a03
Don't error on posts#latest if a post does not have a topic
2015-10-16 14:44:48 +03:00
a527c58c7d
UX: Show a nicer "Log In" screen if the user follows `/my/preferences`
2015-10-14 13:39:31 -04:00
3ef16a7711
FIX: permalinks redirect on subfolder installs could add the subfolder to the url twice
2015-10-12 16:54:53 -04:00
33e58c0587
FIX: You can click to see your own PMs from flags
...
Also refactors post action users to be a new object type since they can
have `post_url` which is not a field of a `User`
2015-09-30 12:28:55 -04:00
2422289c8b
FIX: whispers should not be revealed in reply to, or reply expansion
...
FEATURE: mark whisper as experimental
FIX: badges should never apply to whispers
2015-09-25 10:16:19 +10:00
5ca26a7707
FEATURE: add site setting use_admin_ip_whitelist to enable/disable the whitelisting of admins by IP address
2015-09-23 12:15:08 -04:00
36309e50cc
Merge pull request #3767 from tgxworld/track_user_profile_views
...
Track user profile views
2015-09-23 11:38:18 +02:00
ed717ccb6e
Merge pull request #3794 from tgxworld/add_web_manifes
...
FEATURE: Add web manifest for Chrome users.
2015-09-23 11:35:14 +02:00
1aad58b642
Merge pull request #3781 from tgxworld/feature_log_category_settings
...
Feature log category settings
2015-09-23 11:34:08 +02:00
79beb9f409
FIX: You could set `reply_to_post_number` when replying as a new topic
2015-09-22 13:32:19 -04:00
a0524ea4d1
FIX: render canonical URLs
2015-09-22 09:37:52 +10:00
71eab8f4df
FEATURE: Add web manifest for Chrome users.
2015-09-21 10:34:03 +08:00
cc516d3be0
Merge pull request #3743 from sitepoint/topic-embed-info
...
Add embed/info endpoint for TopicEmbed queries
2015-09-18 11:00:01 -04:00
c9e4745fe8
FIX: Return 410 Gone for deleted topics you could otherwise see
2015-09-18 00:14:43 -07:00
f39b9124b6
FEATURE: Log staff actions for Category changes.
2015-09-18 10:53:08 +08:00
07e7b07b63
FIX: refreshing gravatar wasn't working
2015-09-17 19:42:44 +02:00
7acc93b2a0
FEATURE: Track user profile views.
2015-09-16 14:48:31 +08:00
9cca510944
Add embed/info endpoint for TopicEmbed queries
2015-09-16 03:22:24 +00:00
83efde79f0
specs to account for new default letter avatar location
2015-09-15 13:25:15 +10:00
460243d7a3
FIX: Give 403 for deleted topics, +lots of tests
2015-09-11 08:29:44 -07:00
18d7c1c75d
fix the build - take 2
2015-09-11 15:47:48 +02:00
342eba4374
FEATURE: Category reordering dialog
2015-09-06 16:53:52 -07:00
a501947d67
FEATURE: suppress categories from the homepage
2015-09-02 20:25:18 +02:00
1bd0f5b015
FEATURE: group can grant a trust level when a user is added
2015-09-01 16:52:12 -04:00
43c62d413c
FIX: similar topics api shouldn't return error if params are below minimum lengths
2015-08-31 10:54:45 -04:00
4ad07b8c09
FEATURE: generate invite token
2015-08-28 18:29:31 +05:30
1a82a59f47
fix the build
2015-08-27 22:46:30 +02:00
73624e63c5
FIX: revoke any api keys when suspending an user
2015-08-23 22:33:37 +02:00
58190c92e9
fix timestamp comparison in spec that can fail
2015-08-21 17:21:20 -04:00
2b9ca0de8b
Merge pull request #3678 from tgxworld/allow_admin_to_change_timestamp
...
FEATURE: Allow admin to change timestamp of topic.
2015-08-21 10:34:37 +10:00
d1c69189f3
FEATURE: Can edit category/host relationships for embedding
2015-08-20 15:56:04 -04:00
4c2df814de
FIX: ensure a file is present when creating an upload
2015-08-18 11:39:51 +02:00
c0e88724c2
Preserve user-field options when updating user-fields
...
Avoid deleting options of the user-field when no options are
transmitted.
2015-08-17 19:01:20 +02:00
c7a21b7c23
FEATURE: Allow admin to change timestamp of topic.
2015-08-17 00:00:05 +08:00
b02d624503
FIX: Okay, add support for hosts that have trailing paths
2015-08-10 15:26:58 -04:00
118763df50
FIX: Broken spec
2015-08-10 10:34:40 -04:00
bafdf9290d
FIX: don't let blocked users reach post creator or new post queue
...
correct broken spec
2015-08-06 10:32:53 +10:00
ca393bcc53
FEATURE: optional regex to be applied against first posts
...
for spam prevention you can add a regex to auto_block_first_post_regex
this will be applied against all first posts, if it matches post will go
into the approval queue and user will be blocked
2015-08-05 13:08:21 +10:00
3c8ae643b2
UX: improve handling of users in queued-posts
...
- Display an icon on already blocked users
- Automatically unblock users that you approve
2015-08-04 12:56:37 +10:00
6fdd53e3d6
FEATURE: auto block fast typers
...
if tl0 enter text too fast they get automatically blocked, configurable
2015-08-04 12:56:37 +10:00
01ad88f1ed
FEATURE: min_first_post_typing_time
...
If a user spends less than 3 seconds typing
first post they will automatically enter the approval queue
2015-08-04 10:57:34 +10:00
faf4f44776
FEATURE: make pin expiration mandatory
2015-07-29 16:34:21 +02:00
5f45e5361f
FIX: Moderation actions can have their messages removed
2015-07-28 16:58:56 -04:00
dc8a68fd29
FEATURE: New "Dropdown" user field type
2015-07-28 12:30:21 -04:00
53b1d89f96
Merge branch 'master' of github.com:discourse/discourse
2015-07-23 07:48:55 +10:00
3a54923116
FIX: permalink normalization not applied at constraint
...
implement permalink import for lithium
2015-07-22 13:40:45 +10:00
acbf82d8db
FIX: Change post owner of deleted post, take 3
2015-07-21 16:43:52 -07:00
dc90c396f2
FEATURE: manage Permalinks
2015-07-17 01:26:02 +05:30
61ea8c6f72
FIX: Allow to change ownership on deleted users' posts
2015-07-15 15:29:35 -07:00
b772d96f7a
FEATURE: permalink normalization
...
Optionally allow admins to apply regex based normalization
to permalinks prior to matching.
This allows us to drop query string, or cleanly ignore slugs, etc.
2015-07-15 15:34:25 +10:00
e0c9054748
FEATURE: invite page tabs
2015-07-13 09:42:51 +05:30
6ba6a59552
FIX: Broken spec
2015-07-07 11:39:44 -04:00
2c14acac72
Merge pull request #3236 from sigginet/patch-1
...
FIX: Added two user badge triggers
2015-07-07 11:25:11 -04:00
df988a20eb
FEATURE: Reserved usernames
...
A list of usernames that will be blocked from being used to sign up.
2015-07-01 13:50:55 -07:00
6422d5efbd
Use the same component for similar topics as search results.
2015-06-24 15:08:22 -04:00
470d9418fd
Add tests for X-Robots-Tag
2015-06-22 16:23:26 -07:00
efb02ae561
FIX: take into account unlisted banners
2015-06-22 14:08:30 +02:00
131cf643ce
FIX: Allow api to send uploads with :url
2015-06-21 14:54:59 +03:00
ae277e28a6
FEATURE: Allow embedding topics without creating them, by id
2015-06-09 16:24:20 -04:00
e3fa27a01c
FEATURE: serialize and update category custom_fields
...
- send to client
- update from client
2015-06-10 06:13:36 +10:00
7b6d6b76eb
FEATURE: Multiple embeddable hosts
...
- Also refactors two site settings components into one, with tests
2015-06-09 13:25:43 -04:00
74141cc475
FIX: send 404 error when unauthorized user tries to download user archive
2015-06-08 11:32:31 +05:30
73646184aa
correct specs
2015-06-05 18:58:20 +10:00
b33654ac31
Remove site setting stubbing (Round 1)
2015-06-03 15:44:00 +05:30
acafa491b2
user avatar urls/templates refactor
2015-05-29 18:51:17 +02:00
cb025a65e0
FIX: make sure we also save the user_avatar.custom_upload_id
2015-05-29 10:21:41 +02:00
ea8cf1a208
FIX: topic auto-close uses the client's time zone
2015-05-27 18:01:46 -04:00
83d2b59fc3
FIX: s3 endpoint when using 'us-east-1' region
2015-05-27 17:50:49 +02:00
a988cd5abe
FIX: redirect to CDN avatar for s3 avatars
2015-05-27 12:02:57 +10:00
147ea002f7
FIX: allow handling for avatars that are not in the set of "resized sizes"
2015-05-26 15:41:50 +10:00
bb0c2813ac
FEATURE: generate (avatar) thumbnails in a background task
...
FIX: keep the "uploading..." indicator until the server replies via the MessageBus
FIX: text was disapearing when uploading an avatar
PERF: always use a region for S3 (defaults to 'us-east-1')
FEATURE: ApplyCDN middleware when using S3
FIX: use the same pattern to store files on S3 and locally
PERF: keep a local cache of uploads when generating thumbnails
FEATURE: migrate_to_s3 rake task
2015-05-25 17:59:00 +02:00
379eb01aab
missing prep in test
2015-05-23 15:39:44 +10:00
bcaed90744
fix missing rtl stylesheets
2015-05-23 15:25:05 +10:00
96dbeb8608
fix stylesheet cache to recover if file is on disk
2015-05-22 11:22:12 +10:00
c91634c09a
FIX: support for async uploads of emojis
2015-05-20 16:45:48 +02:00
8d967d9065
FEATURE: move all uploads to a single endpoint + defer upload creation in a background thread
2015-05-20 16:45:48 +02:00
7d23826cee
FIX: Keep around the page when redirecting
2015-05-20 10:16:17 -04:00
7d3b7a5657
fix the build
2015-05-20 15:32:31 +02:00
8be746b285
fix spec
2015-05-20 12:35:22 +10:00
d1d703718a
Merge pull request #3476 from paulkaplan/sso-distrust-email
...
Add SSO setting to not trust emails automatically
2015-05-20 12:07:14 +10:00
1c34341f31
Replace site setting with a payload attribute
2015-05-19 11:16:02 -05:00
9ded21e4c6
FIX: consistent and future-proof upload storage pattern
2015-05-19 12:31:12 +02:00
b8a43e153c
Use session controller to prevent inactive SSO users
2015-05-15 12:15:06 -05:00
4c00eef8b5
FIX: category custom slug can't be set when generation method is none
2015-05-13 16:54:19 +08:00
0b65c88003
Upgrade Notifications to fix deprecations and use store
2015-05-11 11:20:45 -04:00
124ae8ada6
correct spec
2015-05-06 12:01:47 +10:00
16408cee06
Allow Postgres to trigger readonly mode for the site.
2015-04-29 11:49:58 -04:00
6a338afbdd
Merge pull request #3403 from zzakcanncode/rspec_up
...
Rspec 3
2015-04-28 07:50:30 +10:00
2932284293
FEATURE: magic login route for admin when SSO is enabled
2015-04-27 22:54:48 +05:30
b8cbe51026
Convert specs to RSpec 2.99.2 syntax with Transpec
...
This conversion is done by Transpec 3.1.0 with the following command:
transpec
* 424 conversions
from: obj.should
to: expect(obj).to
* 325 conversions
from: == expected
to: eq(expected)
* 38 conversions
from: obj.should_not
to: expect(obj).not_to
* 15 conversions
from: =~ /pattern/
to: match(/pattern/)
* 9 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 5 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 4 conversions
from: lambda { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should_not
to: expect { }.not_to
* 1 conversion
from: === expected
to: be === expected
* 1 conversion
from: =~ [1, 2]
to: match_array([1, 2])
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2015-04-25 11:18:35 -04:00
3a6efa25f0
Allow ReadOnly to propogate up to the Ember app via Response Header
2015-04-24 14:37:16 -04:00
5bf8c31af4
Users can see their pending posts
2015-04-21 16:44:47 -04:00
2459f52c71
Merge pull request #3375 from techAPJ/patch-2
...
FEATURE: invite existing users to private topic
2015-04-16 11:13:42 -04:00
866d1cd8e3
FIX: handle error for duplicate email_in address
2015-04-16 16:23:22 +05:30
d491d4f997
FEATURE: invite existing users to private topic
2015-04-16 00:52:54 +05:30
0c233e4e25
Interface is wired up for Approving/Rejecting posts
2015-04-15 14:54:37 -04:00
96d2c5069b
Interface for reviewing queued posts
2015-04-15 14:54:37 -04:00
19a9a8b408
`NewPostManager` determines whether to queue a post or not
2015-04-15 14:54:36 -04:00
499bed69e2
FIX: show error message if user already exist in group
2015-04-15 14:15:58 +05:30
2a3f71a9a1
SECURITY: log off all existing sessions when resetting password
2015-04-15 08:57:43 +10:00
869d8e25ad
Promotion fails if the user account isn't old enough yet.
2015-04-14 12:14:59 -04:00
db4c04d606
FIX: Moderators shouldn't be able to see secure deleted posts
2015-04-13 11:48:31 -04:00
75890aed26
FEATURE: allow admins to choose a group as a primary group
...
FEATURE: allow admins to set a default title for a group
2015-04-10 12:17:28 +10:00
f5d89169e2
FEATURE: initial implemenation of anonymous posting mode
2015-04-07 18:05:31 +10:00
28864e74bc
FIX: Don't show the filter title on the default route
2015-03-30 11:40:44 -04:00
48c58601a6
fix spec
2015-03-27 13:14:50 +11:00
94fceaf517
Remove non-legit test, we should always change attributes even if external is unchanged
...
Overriding should be all or nothing
2015-03-27 09:57:43 +11:00
2cc5858163
Add site setting to disable User Directory, include restricted info
2015-03-26 11:26:19 -04:00
33e35930b0
FIX: Server error when no results on user directory while logged in
2015-03-25 11:18:46 -04:00
92e371f0b3
FEATURE: civilized mute
...
Allow user to mute all notifications generated by specific users
2015-03-24 11:55:22 +11:00
6d38005a22
Allow staff to change uneditable user fields
2015-03-20 15:18:43 -04:00
7ef306cd3b
A bunch of tweaks to the Users directory
...
- Move user directory from `/directory` to `/users/`
- Defaults to 'weekly' time period
- Don't include deleted topics/posts in the results
- Move heart icon to header instead of on each row
- "Users" instead of "Users found"
2015-03-19 12:29:38 -04:00
3d2d224312
FEATURE: User Directory, with sorting and time period filter
2015-03-18 15:20:34 -04:00
89ea125c73
automatic need only be added once to the hash
2015-03-18 17:47:39 +11:00
0f36774246
group manager can invite members into the group from any restricted topic
2015-03-03 12:18:42 -08:00
1bf4f34049
FIX: topic and post counts are not updated when ownership of a post is changed
2015-03-02 12:13:21 -05:00
7d8dd9d93b
fix some rspec deprecations
2015-02-26 13:05:20 +01:00
83f719fb80
FIX: Cleaned the commit
...
Only changing the code I changed, not other tests.
2015-02-26 01:24:21 +00:00
73068d5fa3
ADD: Spec tests for User Badge triggers
...
NOTE: The DiscourseEvent trigger mechanism is VERY weird.
If there are ANY triggers triggered in the chain, you can't only list the one you're looking for, you have to list all triggers in the order they will come.
Example: line 98-100
:user_created and :user_verified are triggers that are introduced in PR #3237 so if this PR is accepted but not PR #3237 then lines 98-99 need to be removed.
2015-02-26 00:55:17 +00:00
3e2ba5b30b
FIX: If an IP is blocked, don't allow people to login using it
2015-02-25 16:02:40 -05:00
005b8bf7c3
FIX: When creating a SSO user via sync, do not user the IP address.
2015-02-25 14:41:23 -05:00
1c545d4c1e
Allow adding and removing members of groups by username or id
...
As discussed here: https://meta.discourse.org/t/discourse-gem-group-add/25668/2 .
2015-02-25 14:52:13 +00:00
fe578f9944
FEATURE: Allow manual assignment of related post to badge
...
PERF: clean up performance of user badges admin when large number of badges exist
2015-02-25 12:53:01 +11:00
34dc1f9e10
Spec to ensure that SSO respects blocked emails
2015-02-23 17:14:54 -05:00
ca5730018a
FIX: SSO code should respect IP address filters
2015-02-23 16:01:46 -05:00
8186d86f38
FIX: Enforce max length for custom user fields
2015-02-23 13:02:30 -05:00
20c9a312c7
FIX: clicks counter on attachments wasn't always working
2015-02-22 20:47:18 +01:00
17927b2e8b
FIX: don't use flash cause we are not redirecting
...
(we should probably change that though)
2015-02-20 10:28:58 +11:00
b041b3f67f
FIX: bookmark topic was not working intuitively
...
- explicitly call out "clear bookmarks"
- correct keyboard shortcuts
- properly remove bookmarks when toggeling
2015-02-19 10:58:57 +11:00
395654bf24
Fix regression on editing private messages
...
v1.2.0beta9 has introduced a regression in edit of a private topic
(first post). Previously a check for no change in TopicsController was
made but it has been changed without considering that the topic could
be private.
By simply forcing a conversion of `topic.category_id` to integer, the case
where its value is nil is handled correctly as it was previously.
2015-02-18 00:41:16 +01:00
0b45054e2b
FIX: couldn't uncategorize a topic
2015-02-16 10:31:36 +01:00
3ce2077aa8
Migrate unsubscribe keys to the database.
...
This should reduce a lot of the keys in redis.
2015-02-13 14:24:15 -05:00
c4e427cf73
FEATURE: filter screened IP addresses
2015-02-10 19:38:59 +01:00
8d46de4819
Add a spec for the new plugins controller
2015-02-10 12:35:53 -05:00
e8323fa534
FIX: removing a group from a user was not removing primary group
2015-02-09 16:03:09 +11:00
4c8850108a
SECURITY: Don't leak topic title in the redirect
2015-02-04 11:55:39 -08:00
b1f81c0dca
Merge pull request #3080 from riking/misc
...
Miscellaneous fixes from PR#3000
2015-01-30 10:23:17 +11:00
ea7af7a83b
Merge pull request #3135 from longhotsummer/fix-no-user-params
...
FIX: creating a user shouldn't error when optional fields aren't given
2015-01-30 10:12:57 +11:00
85a7b925c7
Miscellaneous fixes from PR#3000
...
FIX: Don't require login to view post raw
FIX: Don't submit read-guidelines for anonymous users (causes
unnecessary 403 errors from ensure_logged_in)
FIX: Don't pass nil to an array serializer
2015-01-29 13:56:32 -08:00
1f40807001
Add extensibility point for whenever a post is created
2015-01-29 12:46:29 -05:00
d99ccf6d27
FIX: creating a user shouldn't error when optional fields aren't provided
...
This fixes a bug where the server would 500 if the only user fields
where optional ones, and the create_user call didn't provide any
values so that params[:user_fields] was nil.
Additionally, don't bother double-checked for required fields, since we
iterate over all fields and will catch any that are required and blank.
2015-01-27 11:48:27 +02:00
f7f5e39f75
FIX: Minor Admin bug with a setting when creating a new group
2015-01-23 20:31:48 +01:00
256519dddf
FEATURE: automatic group membership based on email address
2015-01-23 18:25:43 +01:00
b3a2c0c45b
SECURITY: The SSO `return_path` was an open redirect
...
This security fix needs SSO to be configured, and the user has to go
through the entire auth process before being redirected to the wrong host so
it is probably lower priority for most installs.
2015-01-22 12:20:17 -05:00
e300945879
FEATURE: split group admin in 2 tabs (custom & automatic)
...
FIX: clear the user-selector when adding new members
2015-01-21 20:52:48 +01:00
1ab0d6bd82
FEATURE: Log username changes by staff
...
Also fix the tests for changing username
2015-01-17 02:26:12 -08:00
7a86abd105
Merge pull request #3084 from jmay/group-managers
...
table & model changes for group managers with permission to edit members
2015-01-16 12:02:38 +01:00
c619aed8f9
💄 add username and date-time in exported file name
2015-01-16 01:39:46 +05:30
a2b284a0a4
table & model changes for group managers with permission to edit membership
2015-01-15 11:44:42 -08:00
b94c7922c5
🐎 gzip csv export files
2015-01-14 13:38:37 +05:30
1032fa7262
Merge pull request #3089 from lucianosousa/enhacement/controllers-rspec3
...
controllers with rspec3 syntax
2015-01-12 16:25:31 +01:00
bc73238c8f
controllers with rspec3 syntax
2015-01-09 14:04:02 -03:00
16156bdc1d
removing rspec3 warning
2015-01-09 09:55:58 -03:00
efc717c14a
FEATURE: remove star concept from Discourse
2015-01-07 13:43:27 +11:00
6953923a03
remove |starred| from topnav default options
2015-01-06 16:03:45 -08:00
060cda7772
FIX: proper handling of group memberships
2015-01-05 18:51:45 +01:00
4c166942ad
FEATURE: Invite admin api has an optional param send_email which can prevent sending an email to the invited user. The api will return the password reset url so that the caller can send an email with it instead.
2015-01-02 15:48:54 -05:00
9fcaf090ec
Merge pull request #3068 from fantasticfears/category_slug
...
support setting category slug
2015-01-02 11:55:27 +01:00
bfe95966b4
better filenames for export
2015-01-02 15:30:50 +05:30
35edfb5b91
FIX: Don't truncate groups. @ZogStrIP we need to create a better fix for
...
this in the new year.
2014-12-31 12:58:50 -05:00
78537aad39
FIX: rate limit user posts export
2014-12-31 00:54:23 +05:30
1e166d89ff
support setting category slug
2014-12-30 03:14:54 +08:00
1055fc0919
Merge pull request #3021 from jmay/custom-category-slug
...
optional custom value for category slug (create and update)
2014-12-29 10:34:23 -05:00
267de04e2d
Merge pull request #3061 from techAPJ/patch-1
...
Rename CsvExportLog to UserExport
2014-12-29 12:39:53 +01:00
bfbc49ef6f
FIX: log only 1 'show email' record
2014-12-29 11:50:36 +01:00
68e66f3a25
Rename CsvExportLog to UserExport
2014-12-28 22:31:12 +05:30
9932bea7ce
FEATURE: default emoji override
2014-12-25 17:58:15 +01:00
7c7474aa10
create a new table to maintain csv export log
2014-12-24 16:25:36 +05:30
bb152a5b3f
FEATURE: download user posts archive
2014-12-24 15:13:48 +05:30
5b844f5320
FEATURE: more than 1 site customization can be enabled at once
...
FIX: more robust site customizations
Rewrote site customization to use distributed cache and a much cleaner
css delivery mechanism
2014-12-23 13:03:48 +11:00
45dbdb6896
FEATURE: custom emojis
2014-12-23 01:12:26 +01:00
9bb2ab6265
Merge pull request #3034 from fantasticfears/filter_system_user
...
disable sending email or show presence when forgot system user password
2014-12-19 16:52:01 -05:00
ceca85c9eb
use system user helper and constant when it's referred
2014-12-18 18:21:14 +08:00
ae16186100
FEATURE: post chunk size should not be configurable
...
If people need to configure post chunk size use a plugin
Core only supports out of the box settings, if changed can lead to
severe performance issues.
2014-12-15 10:57:34 +11:00
02ade72ceb
Update username should return a json response
...
- Have update username return json response that contains the updated
username and id. I figured this would be better than just return "OK".
- Add test to verify that the new username is returned.
2014-12-10 09:43:16 -07:00
9937af7ac4
disable sending email or show presence when forgot system user password
2014-12-10 14:17:56 +08:00
1d0eccf710
Have activate user return json
...
- Change activate user from admin controller to return json
- Test that it returns json
- Remove unnessary test from log_out spec
This commit was created so that when you activate a user through the api
it returns a json response.
2014-12-08 11:16:57 -07:00
e9e88c9b82
Remove legacy avatar code
...
- Remove method that was only left around because the
[api](https://github.com/discourse/discourse_api/pull/53 ) called it
- Modify test to use new route instead of legacy route
https://meta.discourse.org/t/legacy-route-for-avatars/22838/2
2014-12-07 06:13:14 -07:00
a61519eebf
Have pick_avatar return json.
...
I'm working on writing a test in the discourse_api gem for uploading
avatars and the pick method needs to return a json response.
I also added a test to make sure json is returned.
2014-12-06 09:26:32 -07:00
efa872e426
optional custom value for category slug (create and update)
2014-12-03 16:23:59 -08:00
a8ff5fe97c
Merge pull request #3002 from jmay/group-membership-api
...
use limit & offset for pagination of group members
2014-12-03 11:11:10 +11:00
f226e4efc0
FIX: don't error out when updating a topic with no changes
2014-12-02 02:16:30 +01:00
bdc92eec70
Have log_out method return json.
...
This commit helps improve the discourse_api experience so that we can
check the json response if it was a success or not. This commit also
checks that a 404 is sent instead of a 500 if a bad user_id is passed
in.
2014-12-01 06:03:25 -07:00
5b90ceb71d
FEATURE: rolls up 1.2.*.* IP ranges when number of entries > 10
2014-11-27 19:29:30 +01:00
013f1a6dd0
FEATURE: allow creating admin and moderator accounts via SSO
2014-11-27 12:39:00 +11:00
c10e3df012
FEATURE: implement SSO provider on Discourse so Auth can be farmed to it
...
FEATURE: pass return_sso_url to SSO endpoints, for easier return
2014-11-26 17:26:27 +11:00
610c2a4d65
checking actual values in the spec, not just counts
2014-11-25 09:12:24 -08:00
adb570fe53
use limit & offset for pagination of group members
2014-11-24 12:12:48 -08:00
7b0ae702e7
FEATURE: log a new staff action when rolling up banned IP addresses
2014-11-24 19:48:54 +01:00
1023191315
FEATURE: roll up function for 123.456.789.* ranges
2014-11-24 17:25:48 +01:00
1c498eb491
FEATURE: API endpoint for inviting an admin
2014-11-24 15:42:56 +11:00
6f8119ebb8
Merge branch 'master' into group-admin-incremental
2014-11-21 10:04:05 -08:00
b8d806ee07
FEATURE: delete all accounts from this IP in the IP lookup modal
2014-11-20 19:59:20 +01:00
50de22801f
API addition: HTTP PATCH support for /groups/xxx: incremental membership changes
2014-11-20 09:29:56 -08:00
aebf36c356
remove /download from csv file url
2014-11-20 00:34:38 +05:30
a036ac7bdc
FIX: users can see the raw email source of their own posts
2014-11-12 14:49:42 +01:00
efc4109902
update specs to remove deprecation warnings
2014-11-07 06:05:44 -08:00
bb2d538194
FEATURE: log impersonations
2014-11-06 10:58:47 +01:00
068d22e9b3
Add API support for querying admin reports by date range
2014-11-05 13:11:37 -05:00
c9eb809dad
FIX: The text to users who signed up when approval was required was
...
misleading.
2014-11-04 15:48:03 -05:00
b09ad87098
FIX: add 'show emails' button from moderators in user admin section
2014-11-03 12:46:08 +01:00
316f1bea04
SECURITY: Don't allow redirects with periods in case you don't control
...
other tlds on the same domain.
2014-10-30 11:31:44 -04:00
865194f409
FIX: cannot show email for pending/inactive users
2014-10-29 01:07:27 +01:00
7d6d8bd0a3
FEATURE: admin end point to sync sso /admin/users/sync_sso
...
Must be admin to invoke (api is fine too), uses same sso payload nonce is ignored
2014-10-28 11:25:21 +11:00
e7f251c105
LOTS of changes to properly handle post/topic revisions
...
FIX: history revision can now properly be hidden
FIX: PostRevision serializer is now entirely dynamic to properly handle
hidden revisions
FIX: default history modal to "side by side" view on mobile
FIX: properly hiden which revision has been hidden
UX: inline category/user/wiki/post_type changes with the revision
details
FEATURE: new '/posts/:post_id/revisions/latest' endpoint to retrieve
latest revision
UX: do not show the hide/show revision button on mobile (no room for
them)
UX: remove CSS transitions on the buttons in the history modal
FIX: PostRevisor now handles all the changes that might create new
revisions
FIX: PostRevision.ensure_consistency! was wrong due to off by 1
mistake...
refactored topic's callbacks for better readability
extracted 'PostRevisionGuardian'
2014-10-27 22:06:43 +01:00
71f211f0b3
FEATURE: Allow users to select a badge with an image to appear on their
...
user card
2014-10-20 16:35:38 -04:00
1cf4a0d604
Rename "User Expansion" to the much clearer "User Card"
2014-10-20 12:11:59 -04:00
92b615b503
reorganize site settings a bit
2014-10-19 23:14:50 -07:00
f8237e2ac0
add spec for raw_email action
2014-10-18 22:36:08 +05:30
f3a67a48a3
Merge pull request #2874 from cpradio/clear-notifications
...
FEATURE: Mark All as Read button for Notifications page
2014-10-16 15:57:19 -04:00
4d465362b5
FEATURE: Allow a user to upload an image for their expansion background.
2014-10-16 15:05:36 -04:00
8f390c979b
FEATURE: Mark All as Read button for Notifications page
...
Added a Mark All as Read button to the top/bottom of the notifications user page
https://meta.discourse.org/t/possibility-to-selectively-or-completely-mark-notifications-as-read/20227
Remove notifications property (no longer used)
2014-10-13 06:31:27 -04:00
5754e8dd0f
FEATURE: auto-close topics based on last post
2014-10-10 18:21:44 +02:00
7e8c4b63f4
FIX: only show agreed abd deferred flags on user's profile
2014-10-09 16:10:16 +02:00
f9a8f6d6ce
FEATURE: Support for a `required` setting on user fields.
2014-10-08 15:10:19 -04:00
0e7be81e60
FIX: badge granted titles were not being revoked when badge was revoked
2014-10-08 10:26:18 +11:00
2fbfc9dffa
FIX: Editing a topic's title should be rate limited too.
2014-10-07 16:46:01 -04:00
1252e7324f
Added easy impersonate route while in development mode
2014-10-07 12:25:50 -04:00
78fd99fc40
Feature: resend invites
2014-10-07 01:43:17 +05:30
Sam
Guo Xiang Tan
Robin Ward
Erick Guan
Neil Lalonde
James Kiesel
Régis Hanol
Arpit Jalan
Jeff Atwood
cpradio
cpradio
Kane York
scossar
Sam Davies
Andy Waite
Leo McArdle
Jude Aakjaer
Jonathan Brachthaeuser
Konstantin Ilchenko
Paul Kaplan
Arthur Neves
Jason W. May
Sigurður Guðbrandsson
Dan Singerman
Loïc Guitaut
Greg Kempe
Luciano Sousa
Blake Erickson
David McClure