Commit Graph

256 Commits

Author SHA1 Message Date
Vinoth Kannan dc292d4598 FIX: Use one-way binding to prevent unnecessary updates in site.periods 2018-12-20 03:39:05 +05:30
Bianca Nenciu 7050ce4638 FIX: Bypass draft check when switching to shared draft. (#6782) 2018-12-19 10:25:33 +01:00
Joffrey JAFFEUX 22cea9ce90
FIX: adusts select-kit position even if not expanded (#6785) 2018-12-17 12:29:51 +01:00
Joffrey JAFFEUX 6ee3900791
FIX: ensures nothing is triggering rendering loop in after render (#6784) 2018-12-17 12:15:03 +01:00
Joffrey JAFFEUX d803dfc14a
FIX: makes more resilient select-kit positioning (#6776) 2018-12-15 16:23:23 +01:00
Joffrey JAFFEUX bcf4a17751
FIX: apply original margin-bottom to fix position placeholder (#6764) 2018-12-13 18:21:12 +01:00
Joffrey JAFFEUX e06a8980fb
FIX: category-drop initial state was incorrect (#6743) 2018-12-10 14:05:00 +01:00
Joffrey JAFFEUX 8da8f5d0f7
FIX: call onSelect plugin callbacks for noop rows (#6682) 2018-11-29 15:56:19 +01:00
Joffrey JAFFEUX 4c7dfed32e
FIX: error with tags enabled and no tags created (#6701) 2018-11-29 10:39:09 +01:00
Penar Musaraj 03deda2147
Upgrade to FontAwesome 5 (take two) (#6673)
* Add missing icons to set

* Revert FA5 revert

 This reverts commit 42572ff

* use new SVG syntax in locales

* Noscript page changes (remove login button, center "powered by" footer text)

* Cast wider net for SVG icons in settings

- include any _icon setting for SVG registry (offers better support for plugin settings)

- let themes store multiple pipe-delimited icons in a setting

- also replaces broken onebox image icon with SVG reference in cooked post processor

* interpolate icons in locales

* Fix composer whisper icon alignment

* Add support for stacked icons

* SECURITY: enforce hostname to match discourse hostname

This ensures that the hostname rails uses for various helpers always matches
the Discourse hostname

* load SVG sprite with pre-initializers

* FIX: enable caching on SVG sprites

* PERF: use JSONP for SVG sprites so they are served from CDN

This avoids needing to deal with CORS for loading of the SVG

Note, added the svg- prefix to the filename so we can quickly tell in
dev tools what the file is

* Add missing SVG sprite JSONP script to CSP

* Upgrade to FA 5.5.0

* Add support for all FA4.7 icons

- adds complete frontend and backend for renamed FA4.7 icons

- improves performance of SvgSprite.bundle and SvgSprite.all_icons

* Fix group avatar flair preview

- adds an endpoint at /svg-sprites/search/:keyword

- adds frontend ajax call that pulls icon in avatar flair preview even when it is not in subset

* Remove FA 4.7 font files
2018-11-26 16:49:57 -05:00
Joffrey JAFFEUX 9911a41f4c
FIX: improves category/tag drops header shortcuts (#6610)
- wont appear when filtering
- can now be selected with keyboard
- fix bugs on click with safari/firefox
2018-11-15 15:21:40 +01:00
Joffrey JAFFEUX c1e82e7442
FIX: category row title (#6597) 2018-11-13 13:35:45 +01:00
Sam 42572ff138 Revert font awesome 5 changes
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
2018-11-08 16:12:18 +11:00
Penar Musaraj 005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs (#6557)
* First take on subsetting svg icons

* FontAwesome 5 svg subset WIP

* Include icons from plugins/badges into svg sprite subset

* add svg icon support to themes

* Add spec for SvgSprite

* Misc. SVG icon fixes

* Use FA5 svgs in local-dates plugin

* CSS adjustments, fix SVG icons in group flair

* Use SVG icons in poll plugin

* Add SVG icons to /wizard
2018-11-07 13:05:43 -05:00
Joffrey JAFFEUX fdad24e2e4
FIX: edit category tags select-kit inputs width were wrong (#6568) 2018-11-06 11:30:12 +01:00
Vinoth Kannan 28cf4d535e UX: Include subcategories in search result of all categories drop down 2018-10-31 23:03:24 +05:30
Penar Musaraj 3c92202654 Set individual future-date-input components as clearable, fixes admin Safari bug (#6522) 2018-10-26 11:34:55 +11:00
Kris c219a5fb1e
Add btn-default class to all default buttons (#6521) 2018-10-24 16:09:36 -04:00
David Taylor 37b7afa522 FIX: Sanitize tags before creation 2018-10-22 10:53:42 +01:00
David Taylor 0dd717e641 Revert "FIX: Sanitize tags before creation"
This reverts commit 18ae8de9e5.
2018-10-19 15:49:05 +01:00
David Taylor 18ae8de9e5 FIX: Sanitize tags before creation 2018-10-19 15:43:31 +01:00
David Taylor 7166d7de9a
FIX: Prevent duplicate tags in tag-choosers (#6512)
* FIX: Prevent duplicate tags in tag-choosers

This reverts 5685b45, which fixes the duplicate tags problem.
The fix introduced by 5685b45 is re-implemented on the server.
2018-10-19 13:44:43 +01:00
David Taylor 9bf522f227
FEATURE: Mixed case tagging (#6454)
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.

- If force_lowercase_tags is disabled, then mixed case tags are allowed.

- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.

- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.

- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.

- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
2018-10-05 10:23:52 +01:00
Kris 07be8e5447 caret icon is redundant on hamburger menu button 2018-10-02 15:06:50 -04:00
Bianca Nenciu 719a433c03 FIX: Sync client & server rules regarding tag names. (#6400) 2018-10-01 21:45:44 -07:00
Kyle Zhao d9bea66365 UX: confirmation before changing group membership in admin (#6426) 2018-10-01 21:34:08 -07:00
Maja Komel 1add11d8c9 FIX: don't send multiple requests when changing category notification (#6435) 2018-10-01 23:41:23 +08:00
Kris 5f042a2c8d Prevent move to new topic tag input from becoming too wide on click 2018-09-20 16:12:08 -04:00
Kris e95d6a12c5 prettier 2018-09-18 13:39:58 -04:00
Kris 8bfb016386 remove trailing spaces 2018-09-18 13:25:50 -04:00
Kris d20a174a6b UX: Lighter style for category and tag dropdown nav 2018-09-18 13:11:00 -04:00
Joffrey JAFFEUX a713c0d366
FIX: ensures onSelect/onDeselect are called
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
Joffrey JAFFEUX 2ff2c49908 Revert "FIX: ensures onSelect/onDeselect are called"
This reverts commit 52eed73294.
2018-09-17 22:14:41 +02:00
Joffrey JAFFEUX 52eed73294
FIX: ensures onSelect/onDeselect are called 2018-09-17 10:36:14 +02:00
Sam b63630d70b use Mixin postfix when importing tags mixin 2018-09-17 10:46:57 +10:00
pmusaraj 0a2efd8ff1 Add async search to tags dropdown, always show selected tag 2018-09-17 10:40:47 +10:00
Joffrey JAFFEUX 38668818a5
FIX: allows forcing unsafe string in select-kit (#6386)
forceEscape will be defaulted to true before next release.
2018-09-12 12:19:04 +02:00
Joffrey JAFFEUX 17087eff2a
FIX: Reset tags on category change (#6363) 2018-09-05 17:18:52 +02:00
Joffrey JAFFEUX 07e11a223c
FIX: prefills username for new message on first post (#6305) 2018-08-23 11:09:35 +02:00
Kris 8c46ecf7f3 UX: Improving tag topic list navigation consistency 2018-08-16 00:02:26 -04:00
Joffrey JAFFEUX 7290765a62
FIX: uses touchstart/mousedown for selected tags (#6268)
It seems to be way more reliable on firefox and safari in the case of hot replaced content not using ember.
2018-08-14 16:16:13 +02:00
Gerhard Schlager ef4b9f98c1 FEATURE: Allow admins to reply without topic bump 2018-08-10 10:48:30 +10:00
Joffrey JAFFEUX 6a2ca60b48
FIX: ember click event not reliably working on fx (#6256) 2018-08-09 22:41:35 +02:00
Joffrey JAFFEUX da1d520d4c
FIX: simplifies mini tag chooser events handling (#6252) 2018-08-09 14:23:28 +02:00
Joffrey JAFFEUX bfcf8ed61b
FIX: prevents focus of input on mobile (#6251) 2018-08-09 14:23:09 +02:00
Joffrey JAFFEUX 523acfcea4
FIX: checks on parent visibility instead of filter itself (#6250) 2018-08-09 10:45:53 +02:00
Joffrey JAFFEUX c301111461
FIX: display select kit body if no choices (#6237) 2018-08-06 11:22:48 -04:00
Joffrey JAFFEUX 066010db7d
FEATURE: introduces list/compact_list components 2018-08-03 16:41:37 -04:00
Joffrey JAFFEUX c6fd506a15
fix eslint 2018-07-30 13:10:20 -04:00
Joffrey JAFFEUX 2c90a2e5c2
FIX: prevents mini-tag-chooser to catch unwanted focus 2018-07-30 13:03:40 -04:00
Joffrey JAFFEUX 73d736c8c3
FIX: popup-menu instantly closing (#6147) 2018-07-23 14:19:36 -04:00
Joffrey JAFFEUX 78419f677d
FIX: multiple select-kit fixes on mobile 2018-07-23 12:19:40 -04:00
Joffrey JAFFEUX 5e521f8ce6 Revert "FIX: various select-kit corrections on mobile"
This reverts commit 78a2324c89.
2018-07-20 15:28:12 -04:00
Joffrey JAFFEUX 78a2324c89
FIX: various select-kit corrections on mobile 2018-07-20 14:46:25 -04:00
Joffrey JAFFEUX 1a78e12f4e
FEATURE: part 2 of dashboard improvements
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports

Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
Sam 818bc10107 FIX: count subcategories in breadcrumbs 2018-07-17 12:06:48 +10:00
Joe d8e51095c9
FIX: mobile topic-timer adjustments 2018-07-04 19:23:09 +08:00
Joe 888a827b93
FIX: removes inline styles applied to "all categories" in category dropdown
"all categories" in the category dropdown gets category-like inline styles when category mode is set to "box"
2018-07-03 12:02:50 +08:00
OsamaSayegh d81f8ea378
fix prettier 2018-06-26 15:31:43 +03:00
OsamaSayegh bfe0178270 FIX: use the correct notification levels titles for PMs 2018-06-26 14:01:52 +02:00
Joffrey JAFFEUX eb9b99e519
FIX: makes select-kit match searches with accents (filter and content) 2018-06-26 12:19:14 +02:00
Joffrey JAFFEUX 666386d4b7
FIX: allows more chars than a-z in select-kit 2018-06-25 12:52:20 +02:00
Joffrey JAFFEUX c722fc5164
FIX: makes sure category and tag drop headers have a title 2018-06-24 22:23:31 +02:00
Joffrey JAFFEUX 2f7960bd2a
DEV: updates prettier and displays linters/prettifiers version in CI 2018-06-20 18:34:49 +02:00
Joffrey JAFFEUX 3fc82bf200
FIX: adds a title to composer actions header 2018-06-18 19:01:37 +02:00
Joffrey JAFFEUX 60ff0e9b8c
missing prettified files 2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX 03a7d532cf
DEV: introduces prettier for es6 files 2018-06-15 17:03:24 +02:00
OsamaSayegh 06777aa47d FIX: use the correct notification levels descriptions for PMs 2018-06-15 14:04:14 +10:00
Joffrey JAFFEUX ee8cda691d
FIX: simplifies and corrects new collection header tag/drop behaviour 2018-05-29 17:34:34 +02:00
Joffrey JAFFEUX a8079ab679
FIX: show none/all on cat/tag drop only when needed 2018-05-29 16:08:31 +02:00
Joffrey JAFFEUX 4b9c713581
FIX: avoids hidding mobile keyboard on each keystroke 2018-05-28 16:18:25 +02:00
Guo Xiang Tan 0b55416742 UX: Don't display `all groups` option if group directory is disabled.a
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
2018-05-28 11:32:55 +08:00
Joffrey JAFFEUX 1be76d066c
FIX: forces boolean when content is only "true" && "false" 2018-05-24 23:41:39 +02:00
Joffrey JAFFEUX a45d8a69f9
FIX: prevents &hellip from being displayed in title attribute 2018-05-23 19:04:26 +02:00
Joffrey JAFFEUX 7232a6e5a9
FIX: do not show composer actions if irrelevant 2018-05-23 18:25:58 +02:00
Guo Xiang Tan 2fecb4b46e FIX: Client not setting `TopicTimer#based_on_last_post`.
https://meta.discourse.org/t/incorrect-message-key-in-temporarily-closed-topic/87773
2018-05-18 16:32:12 +08:00
Sam c475905387 Improvements to new community dashboard
- Limit dashboard to yearly,quarterly,monthly,weekly
- Always prefer UTC full days for reporting
2018-05-09 18:06:13 +10:00
Arpit Jalan c28c5083e0 SECURITY: santize tags when creating new topic via URL 2018-04-15 17:28:27 +05:30
Joffrey JAFFEUX deab0486fa
FIX: apply fa-fw on class instead of icon name 2018-04-12 10:56:32 +02:00
Joffrey JAFFEUX 11c47f57f9
FIX: prevents keyboard from appearing on android when expanding 2018-04-10 16:25:05 +02:00
Guo Xiang Tan c82b2dcc24 Remove admin group management pages. 2018-04-09 15:14:50 +08:00
Joffrey JAFFEUX f0fe16d824
FEATURE: implements minimum selection for select-kit 2018-04-05 16:45:19 +02:00
Joffrey JAFFEUX b1cc368da8
FIX: regression where tag could not be deleted with click 2018-04-04 00:56:45 +02:00
Robin Ward 0188cbb650 UX: New dropdowns work well on mobile for category notifications 2018-04-03 12:09:00 -04:00
Joffrey JAFFEUX d54da517d9
FIX: more resilient focus filter or header 2018-04-02 22:50:20 +02:00
Joffrey JAFFEUX 017f5c1aee
FIX: regression preventing backspace to work on mini-tag-chooser 2018-04-02 22:42:20 +02:00
Joffrey JAFFEUX 5685b45fa6
FIX: manually adds tag if existing but not in returned matches 2018-04-02 18:33:46 +02:00
Joffrey JAFFEUX 8f2b305b9a
FIX: calling incorrect method 2018-04-02 18:02:45 +02:00
Joffrey JAFFEUX a828da33aa
FIX: regression preventing addition of multiple tags in a group 2018-04-02 17:54:40 +02:00
Joffrey JAFFEUX 3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
2018-03-29 13:42:00 +02:00
Guo Xiang Tan 52e75eaee9 UX: Tweaks to group pages. 2018-03-29 17:04:48 +08:00
Guo Xiang Tan 27f06505b1 Allow placeholder to be configured for `combo-box`. 2018-03-29 17:04:48 +08:00
Joffrey JAFFEUX e5dc8ab5c1
FIX: correctly localizes period chooser row title 2018-03-28 13:19:25 +02:00
Joffrey JAFFEUX 15aa712227
fix category-row regressions 2018-03-27 14:11:05 +02:00
Joffrey JAFFEUX f81af74ad8
FIX: makes sure category desc is displayed as row title when possible 2018-03-27 12:25:05 +02:00
Guo Xiang Tan 7edab1c0b9 UX: Add `groups/custom/new` route for admins to create a new group. 2018-03-27 17:39:05 +08:00
Guo Xiang Tan 252e58dfe9 FIX: Could not create topic timers for certain locales.
https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702/2
2018-03-26 10:51:49 +08:00
Robin Ward 38af67eb73 Update the destination category id when a user changes it 2018-03-23 11:12:56 -04:00
Sam 0db13f62eb FIX: unable to remove tags from topics in quick save 2018-03-23 13:55:24 +11:00
Joffrey JAFFEUX cbbeedf53b
FIX: fires onExpand/onCollapse when using arrows 2018-03-22 18:35:46 +01:00