Gerhard Schlager
354014099d
Update copy and remove unused strings
2020-08-26 18:08:41 +02:00
David Taylor
4351fa435e
FIX: Correctly redirect after external login on subfolder sites ( #10529 )
2020-08-26 15:52:21 +01:00
jahan-ggn
ae7ff5eb73
FEATURE: Added sort by username for directory items ( #10482 )
...
* done-sorting-usernames-on-users-page
* sorted-usernames-on-users-page
* spec written
* specs added
2020-08-26 10:14:20 -04:00
Guo Xiang Tan
dbfb2a1e11
Minor follow-up bug fix for 5ff6c10
.
2020-08-26 17:25:28 +08:00
Guo Xiang Tan
5ff6c10320
FIX: Ensure that topic timers belonging to trashed topics are destroyed.
2020-08-26 16:11:10 +08:00
Guo Xiang Tan
3cc761ac44
FIX: Clean up toggle closed topic timer when user is not authorized.
2020-08-26 12:59:05 +08:00
Guo Xiang Tan
5bca1aec48
FIX: Clean up topic_timers when no longer valid.
...
This was causing a bug where the jobs for the topic_timers will keep
getting enqueued over and over again.
2020-08-26 12:18:51 +08:00
Guo Xiang Tan
1e8f216e17
FIX: Ensure autoclose based on last post is executed by system user.
2020-08-26 12:08:46 +08:00
Guo Xiang Tan
ffc5bb7278
Revert "FIX: Topic Timer auto opening closed topics ( #10524 )"
...
This reverts commit 7cfd5f87ff
.
2020-08-26 09:32:11 +08:00
Blake Erickson
7cfd5f87ff
FIX: Topic Timer auto opening closed topics ( #10524 )
...
This commit is addressing an issue where it is possible that there could
be multiple topic timer jobs running to close a topic or a weird race
condition state causing a topic that was just closed to be re-opened.
By removing the logic from the Topic Timer model into the Topic Timer
controller endpoint we isolate the code that is used for setting an
auto-open or an auto-close timer to just that functionality making the
topic timer background jobs safer if multiple are running.
Possibly in the future if we would like this logic back in the model a
refactor will be needed where we actually pass in the auto-close and
auto-open action instead of mixing it with the close and open
action that is currently being passed to the controller.
2020-08-26 11:17:12 +10:00
Kane York
93e136ae0e
UX: show a generic error on upload for XHR status 0 ( #10521 )
...
This indication covers all cases of network errors, not just "cancelled by user".
The post upload component already has its own handling for user-cancelled uploads, but the generic upload component does not.
Tested by stopping my localhost server right before attempting to upload a file.
2020-08-25 12:08:03 -07:00
Penar Musaraj
7277ca6cb6
UX: Add category-title-before to categories-boxes layout
...
Makes it consistent with the other /categories layouts
2020-08-25 13:35:13 -04:00
fzngagan
c363189858
Accounted for the change while reading the fields added specs to confirm working
2020-08-25 09:52:18 -04:00
fzngagan
352ad826c1
FIX: symbols and strings should be treated similarly while saving custom fields
2020-08-25 09:52:18 -04:00
Robin Ward
2523a21fc3
FIX: Server side rendering was broken with new `helperContext()`
2020-08-25 09:16:32 -04:00
Robin Ward
a3fb732b23
REFACTOR: We can reuse `getOwner` for some container stuff
2020-08-25 09:16:32 -04:00
Robin Ward
347a4981a0
REFACTOR: Remove `Discourse` constant from `get-owner`
2020-08-25 09:16:32 -04:00
Robin Ward
185ed80702
REFACTOR: Remove `Discourse` constants from nav-item
2020-08-25 09:16:32 -04:00
Robin Ward
c068098f75
REFACTOR: Remove container from `User` class
2020-08-25 09:16:32 -04:00
Robin Ward
c94ba34882
REFACTOR: Remove `__container__` from Site
2020-08-25 09:16:32 -04:00
Robin Ward
ac498ae2a0
REFACTOR: Remove container from ajax
2020-08-25 09:16:32 -04:00
Robin Ward
df8ae6891c
REFACTOR: Remove constants from `text` helper
2020-08-25 09:16:32 -04:00
Robin Ward
4063cab8c2
REFACTOR: Missed `container`s in `DiscourseURL`
2020-08-25 09:16:32 -04:00
Robin Ward
02e8d84e30
REFACTOR: Remove `Discourse` constant from `showModal`
2020-08-25 09:16:32 -04:00
Robin Ward
98e5e1cd53
REFACTOR: Remove container from `DiscourseURL`
2020-08-25 09:16:32 -04:00
Robin Ward
dae8b9bcfb
FIX: Remove container from utilities
2020-08-25 09:16:32 -04:00
Robin Ward
89d766d089
REFACTOR: Remove container from safari-hacks
2020-08-25 09:16:32 -04:00
Robin Ward
c7c3fd4209
REFACTOR: Remove container from pwa-utils
2020-08-25 09:16:32 -04:00
Robin Ward
ebc0298ea0
REFACTOR: Remove `Discourse.authenticationComplete`
2020-08-25 09:16:32 -04:00
Robin Ward
20e1233f89
REFACTOR: Remove container from raw template helper
2020-08-25 09:16:32 -04:00
Gerhard Schlager
dac0e5b3cc
Merge pull request #10519 from gschlager/get-url
...
Fixes for getURL() in subfolders and basePath in translations
2020-08-25 11:42:50 +02:00
Jarek Radosz
e66f95de3a
FIX: DEV: Lock-on improvements ( #10448 )
...
* DEV: Don't listen for deprecated events
https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMMouseScroll_event
https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event
* DEV: Listen only on the `body` element
* DEV: clearLock after a while if target is missing
* DEV: Bind the callback
* FIX: Use `requestAnimationFrame`
Prevents content jumps
2020-08-25 11:42:00 +02:00
Gerhard Schlager
6c09fd4289
DEV: Remove unused code and translations
2020-08-25 11:41:19 +02:00
Joe
66aa94c515
UX: Timeline should jump to the bottom of the post in single-post topics ( #10503 )
2020-08-25 16:22:07 +08:00
Kris
a92a6b7b10
UX: Minor layout fixes and improved consistency on theme admin
2020-08-24 22:51:58 -04:00
Mark VanLandingham
cef51b3489
DEV: Remove hasBlock from user-info component ( #10415 )
2020-08-24 21:44:01 -05:00
Guo Xiang Tan
9c997ae117
Revert "DEV: allow plugins to send extra silenced message params"
...
This reverts commit c3aeb442d7
.
Broken specs so helping Jeff to revert first.
2020-08-25 09:57:57 +08:00
Jeff Wong
c3aeb442d7
DEV: allow plugins to send extra silenced message params
...
allows plugins to send extra custom message params so that they can
include things such as silence reason and message_body if desired
2020-08-24 18:34:18 -07:00
Krzysztof Kotlarek
7b6f8517bf
FIX: limit number of users addable to group at once ( #10510 )
...
When someone wants to add > 1000 users at once they will hit a timeout.
Therefore, we should introduce limit and inform the user when limit is exceeded.
2020-08-25 08:55:21 +10:00
Neil Lalonde
ed30f49315
FIX: duplicate categories and tags allowed in inputs where they shouldn't be allowed
...
blocklist was renamed to blockedCategories/Tags
2020-08-24 17:37:04 -04:00
Neil Lalonde
52217099ed
FIX: group categories inputs not filled sometimes
...
If you land on the group > manage > categories page or reload it,
the fields will all be blank when there should be categories.
2020-08-24 17:15:37 -04:00
Gerhard Schlager
1959745c2c
FIX: Current title wasn't visible when assigning badge title
2020-08-24 21:39:44 +02:00
Roman Rizzi
dd13304b81
FEATURE: More API scopes ( #10493 )
2020-08-24 12:15:08 -03:00
Joffrey JAFFEUX
b6dd3eca9a
FIX: ensures diversity code is not applied multiple times ( #10517 )
2020-08-24 16:10:47 +02:00
Joffrey JAFFEUX
265d8bc1d7
FIX: close picker on emoji selection when on mobile device ( #10516 )
2020-08-24 15:04:44 +02:00
Joffrey JAFFEUX
c3364b3a6b
UX: improves picker on automatic dark themes ( #10515 )
2020-08-24 15:04:11 +02:00
Joffrey JAFFEUX
226be994da
REFACTOR: rewrite the emoji-picker ( #10464 )
...
The emoji-picker is a specific piece of code as it has very strong performance requirements which are almost not found anywhere else in the app, as a result it was using various hacks to make it work decently even on old browsers.
Following our drop of Internet Explorer, and various new features in Ember and recent browsers we can now take advantage of this to reduce the amount of code needed, this rewrite most importantly does the following:
- use loading="lazy" preventing the full list of emojis to be loaded on opening
- uses InterserctionObserver to find the active section
- limits the use of native event listentes only for hover/click emojis (for performance reason we track click on the whole emoji area and delegate events), everything else is using ember events
- uses popper to position the emoji picker
- no jquery code
2020-08-24 14:20:51 +02:00
David Taylor
9debfed060
FIX: Add cache-busting parameter to ace-editor javascript
...
Long-term we should consider adding the file hash to javascript URLs, so that the URL changes whenever the file changes
2020-08-24 12:29:46 +01:00
David Taylor
ac80109705
DEV: Improve user card styling extensibility ( #10508 )
...
- Add a metadata-row class
- Remove wrapper tags from user-card-after-metadata and user-card-before-badges outlets
- Correct max-height for mobile card
2020-08-24 11:02:40 +01:00
Joffrey JAFFEUX
23b823dd3a
FIX: removes us_pacific-new from the list of available timezones ( #10514 )
2020-08-24 11:04:46 +02:00