5f042a2c8d
Prevent move to new topic tag input from becoming too wide on click
2018-09-20 16:12:08 -04:00
3e17ef0507
Merge pull request #6414 from techAPJ/user-field-unique-key
...
FEATURE: add external details to user fields
2018-09-20 22:29:39 +05:30
e43a05fa10
Timeline back button too tall
2018-09-20 10:28:26 -04:00
87a97cbf4b
Merge branch 'master' into theme-select-mobile
2018-09-20 10:31:41 +02:00
df45e82377
SECURITY: only allow picking of avatars created by self ( #6417 )
...
* SECURITY: only allow picking of avatars created by self
Also adds origin tracking to all uploads including de-duplicated uploads
2018-09-19 22:33:10 -07:00
195bd02fce
FIX: Avoid race condition when enqueuing job.
2018-09-20 11:24:01 +08:00
72be638728
FEATURE: add external details to user fields
2018-09-20 08:10:51 +05:30
dfbc93aa2e
Prevent post date from overflowing with long usernames
2018-09-19 18:53:48 -04:00
681262ddce
FIX: Backup logs were usually missing the first few lines
...
And because of debouncing, the log wasn't always reset at the beginning of a backup or restore.
2018-09-19 20:27:35 +02:00
18d5d51d98
UX: Remove double scrollbars from backup logs
...
* Removes the wrapping, because the log is easier to read without it.
* Fixes the automatic scrolling to the bottom, which didn't work anymore
2018-09-19 20:27:34 +02:00
8d6ccde402
UX: removes bottom margins from inputs in admin controls
2018-09-20 00:32:41 +08:00
2144009520
UX: ensure ac-wrap input height matches other inputs
2018-09-20 00:02:45 +08:00
0010e7ddd2
UX: better padding for multi-select items
2018-09-19 23:56:26 +08:00
026bab116a
UX: label alignment for Firefox / IE
2018-09-19 23:48:48 +08:00
d41f74578a
Fix JS build.
2018-09-19 23:12:34 +08:00
767f27929d
Rename `Jobs::RecoverPostUploads` to rerun the job take 2.
2018-09-19 22:40:32 +08:00
b64436ba09
UX: select-kit filter input size fix
2018-09-19 22:05:56 +08:00
6dbe1d832d
Rename `Jobs::RecoverPostUploads` to rerun the job.
...
Running a migration to destroy the onceoff job doesn't work
because an instance running the old code may execute the job.
2018-09-19 21:59:44 +08:00
0ac64b6d50
UX: radio / checkbox inputs margin fix
2018-09-19 21:22:40 +08:00
8fb50a7e8b
UX: last-seen input alignment fix
2018-09-19 21:20:04 +08:00
9e9fdac023
UX: multi-select items alignment fixes
2018-09-19 21:14:27 +08:00
acd18ff9d8
Fixes typo
2018-09-19 21:08:03 +08:00
e844fa5370
UX: general cleanup of inputs, buttons and select elements - part 1
2018-09-19 20:37:04 +08:00
667e68ec58
Prefer `create` over `create!` when not checking for response.
2018-09-19 18:22:54 +08:00
e0e6dae6a7
minor cleanup to previous commit from code review
2018-09-19 16:07:29 +10:00
5302709343
FIX: in redis readonly raise an exception from DistributedMutex
...
If we detect redis is in readonly we can not correctly get a mutex
raise an exception to notify caller
When getting optimized images avoid the distributed mutex unless
for some reason it is the first call and we need to generate a thumb
In redis readonly no thumbnails will be generated
2018-09-19 15:50:58 +10:00
4a92c5b2d6
`UploadRecovery` should recover attachments too.
2018-09-19 10:44:36 +08:00
4383afb769
Merge pull request #6413 from vinothkannans/log-entity-export
...
FEATURE: Log entity export in staff logs
2018-09-19 03:18:28 +05:30
9281b72308
FEATURE: Log entity export in staff logs
2018-09-19 03:16:45 +05:30
f43b5bb3c1
considerably simplify copy for change owner
2018-09-18 14:15:08 -07:00
e95d6a12c5
prettier
2018-09-18 13:39:58 -04:00
8bfb016386
remove trailing spaces
2018-09-18 13:25:50 -04:00
d20a174a6b
UX: Lighter style for category and tag dropdown nav
2018-09-18 13:11:00 -04:00
4cf3ef53bc
Prevent spinner in tag dropdown from being squished
2018-09-18 11:27:01 -04:00
a713c0d366
FIX: ensures onSelect/onDeselect are called
...
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
7d6b348d0b
SECURITY: correct XSS on long topic titles
2018-09-18 08:54:44 +10:00
0e9841b995
SECURITY: remove admin memory diagnostics routes
2018-09-18 08:35:09 +10:00
2ff2c49908
Revert "FIX: ensures onSelect/onDeselect are called"
...
This reverts commit 52eed73294
2018-09-17 22:14:41 +02:00
7f420b61cb
Removing unneeded theme intro text
2018-09-17 12:00:20 -04:00
6f1b8ad16d
FIX: tag groups page should only be visible to staff
...
No security concern here because nothing private was visible,
and no actions could be taken by non-staff users.
2018-09-17 11:41:18 -04:00
4481836de2
FEATURE: new 'search_ignore_accents' site setting
2018-09-17 10:42:30 +02:00
52eed73294
FIX: ensures onSelect/onDeselect are called
2018-09-17 10:36:14 +02:00
7a0232249a
extract inline JS that's used to store preloaded data ( #6370 )
2018-09-17 16:31:46 +08:00
01913b9dc0
FIX: improves themes/components UI on mobile
2018-09-17 10:05:18 +02:00
7b19ed06c1
reworked specs of existing group behavior
2018-09-17 17:46:43 +10:00
6659417807
FEATURE: match user title when primary group changes
...
When primary group changes and the user's title is the previous primary
group's title, change the title to the new primary group's title
2018-09-17 15:08:39 +10:00
33541c4096
FEATURE: unconditionally omit no-follow for staff
...
Previously TL2 and below staff would have links
no-followed which was never intended
2018-09-17 12:02:20 +10:00
b63630d70b
use Mixin postfix when importing tags mixin
2018-09-17 10:46:57 +10:00
0a2efd8ff1
Add async search to tags dropdown, always show selected tag
2018-09-17 10:40:47 +10:00
e51c676135
refactors trending search report to use SearchLog
2018-09-17 10:19:40 +10:00
8f39cf6bfc
FIX: Permit unpinning an unlisted topic.
2018-09-17 10:03:06 +10:00
f666d72606
extract inline JS for google tag manager
2018-09-17 09:56:00 +10:00
38c70bfda2
extract inline JS for google analytics
2018-09-17 09:56:00 +10:00
5625461c05
clear error if you can contact theme repo again
2018-09-17 09:49:53 +10:00
c9a5438a88
use `woman_artist` emoji
2018-09-17 09:49:53 +10:00
c7d81e2682
FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard
2018-09-17 09:49:53 +10:00
ca28548762
feedback (see commit description for details)
...
* fill blank space when no theme is selected
* animate row's height in themes/components list when selecting, and hide children list
* show warning when you move to a different page and have unsaved changes
* refactor `adminCustomizeThemes.show` controller
* allow collapsing/expanding children lists
* fix a bug when adding components to a theme (changed the way it works slightly)
* a bunch of other minor things
2018-09-17 09:49:53 +10:00
a4f057a589
UX: improvements to admin theme UI
2018-09-17 09:49:53 +10:00
2ef16d0719
button missing no-text class
2018-09-14 20:52:25 -04:00
7e5000b472
change close to delete glyph on associated accounts
2018-09-14 12:01:49 -07:00
acddbe22c6
FIX: Poll modal date selector width
2018-09-14 13:38:58 -04:00
419b14e58b
FIX: correctly keep stylesheet cache entries
...
The intent from day one was to keep MAX_TO_KEEP stylesheets per target
however the DELETE statement did not perform target filtering
This meant we often deleted the wrong stylesheets from the cache
2018-09-14 12:54:11 +10:00
6a2589353b
Merge pull request #6394 from tgxworld/recover_broken_uploads
...
FIX: Onceoff job to recover missing post uploads.
2018-09-13 18:16:56 -07:00
aa1af9fc22
FIX: Onceoff job to recover missing post uploads.
...
This fixes the regression due to 1f636c445b
2018-09-14 09:04:01 +08:00
30619c244c
FIX: don't index urls to local files
2018-09-13 18:53:53 +02:00
a6502ce879
FIX: ensures errors in report initialization fail nicely ( #6392 )
2018-09-13 17:36:55 +02:00
18fcd483f2
FIX: ensures we have a color for reports ( #6396 )
2018-09-13 17:36:39 +02:00
7bf8b0d305
FIX: treats users_(by_type|tl) as other reports ( #6391 )
2018-09-13 17:35:54 +02:00
2ae7d3a118
Merge pull request #6388 from pmusaraj/drafts-second-user-test
...
Add test to ensure a user cannot see drafts stream of another user
2018-09-13 06:53:44 -07:00
5bdf476de7
raise error early in drafts controller
2018-09-13 08:40:57 -04:00
d288462abf
Merge pull request #6393 from techAPJ/bad-json
...
FIX: ignore and log bad json values for custom fields
2018-09-13 15:54:01 +05:30
e364547ff7
FIX: ignore and log bad json values for custom fields
2018-09-13 14:26:30 +05:30
529e4018f0
DEV: Avoid using `send` and make the method public instead.
2018-09-13 16:34:32 +08:00
daa02431df
FIX: remove div used to measure textarea position
...
Also corrects the positioning of autocomplete (when typing @ or emoji)
Previously there were edge conditions where autocomplete would be hundreds
of pixels away due to a bug measuring.
This correct an issue where Firefox ends up having an enormous blank space
at the bottom of topics after editing.
2018-09-13 14:53:32 +10:00
aa614e393c
return 403 when trying drafts of another user
2018-09-12 13:08:02 -04:00
38668818a5
FIX: allows forcing unsafe string in select-kit ( #6386 )
...
forceEscape will be defaulted to true before next release.
2018-09-12 12:19:04 +02:00
3884e99e88
Add extra protection in `Upload#get_from_url`.
...
In case the extension goes missing from the URL.
2018-09-12 00:12:14 -07:00
b3469bea2d
FIX: Uploads not being linked correctly to posts.
...
Regression due to 1f636c445b
2018-09-11 23:50:23 -07:00
d1984a0b4d
FIX: display a correct error when attempting to agree on a deferred flag
...
Previously we would raise a 500 error if a moderator tried to agree on a
flag another moderator deferred.
This can happen cause the UX for flags does not live refresh as flags
are handled
2018-09-12 13:16:59 +10:00
71185c13b5
Merge pull request #6377 from tgxworld/remove_tif_tiff
...
Drop `tif`, `tiff`, `webp` and `bmp` from supported images.
2018-09-12 09:32:32 +08:00
e1b16e445e
Rename `FileHelper.is_image?` -> `FileHelper.is_supported_image?`.
2018-09-12 09:22:28 +08:00
16bd3f2cf2
FIX: use current user color scheme when filling `theme-color` attribute ( #6384 )
...
* FIX: use current user color scheme when filling `meta` attribute `theme-color`
* update manifest.webmanifest colors
2018-09-12 11:04:58 +10:00
a033327b93
Manage qunit via yarn.
2018-09-11 15:07:28 +08:00
e64402cb3b
SECURITY: correct edge case when SSO provides unvalidated emails
2018-09-11 08:24:02 +10:00
1d41f3c3fb
Merge pull request #6380 from discourse/rake-destroy-sub-category
...
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 10:26:04 -06:00
2b7e50cab8
Prevent fade-out from overlapping button in admin nav
2018-09-10 11:25:41 -04:00
84fc7abb73
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 12:52:14 +01:00
d4080c020f
FIX: sets trends to 7 days instead of 3 ( #6379 )
2018-09-10 10:40:19 +02:00
04d26c65e2
Refactor `Upload.get_from_url` to check length of sha1.
2018-09-10 10:10:39 +08:00
2ad882113e
FIX: corrects top-referred and trending-search dates ( #6372 )
2018-09-07 16:49:44 +02:00
9e77fd8fc3
FIX: wrong category links on subfolder install in rss feed for a category topic list
2018-09-07 10:03:30 -04:00
d788555994
DEV: Manage pretender with yarn.
2018-09-07 16:01:49 +08:00
039afe0d2c
Apply prettier.
2018-09-07 15:19:34 +08:00
879067d000
FIX: check admin theme cookie against user selectable
...
previously admin got a free pass and could set theme via cookie to anything
including themes that are not selectable
this refactor ensures that only "preview" gets a free pass, all the rest
goes through the same pipeline
2018-09-07 10:47:28 +10:00
797cbf8653
FIX: Remove user fields when anonymizing user
2018-09-07 00:02:56 +02:00
6c1e70d554
FIX: do no reset tags selection on category selection ( #6369 )
...
We will instead implement a server side solution to this in the future.
2018-09-06 10:35:07 +02:00
56b6a4779d
FIX: make route to tag more robust
...
There are some edge cases where code would fail here, so adding protection
2018-09-06 17:24:32 +10:00
1f636c445b
PERF: Add fast path to find uploads before resorting to `LIKE` query.
...
For a normal upload url
Before
```
Warming up --------------------------------------
264.000 i/100ms
Calculating -------------------------------------
2.754k (± 8.4%) i/s - 13.728k in 5.022066s
```
After
```
Warming up --------------------------------------
341.000 i/100ms
Calculating -------------------------------------
3.435k (±11.6%) i/s - 17.050k in 5.045676s
```
2018-09-06 14:44:24 +08:00
d4b05d7bc5
Always link post to uploads in post process.
...
The operation is cheap anyway so no point skipping.
2018-09-06 14:08:03 +08:00
b6a139b581
Fix broken spec.
2018-09-06 12:41:43 +08:00
Kris
Arpit Jalan
Joffrey JAFFEUX
Sam
Guo Xiang Tan
Gerhard Schlager
Joe
Vinoth Kannan
Jeff Atwood
Neil Lalonde
Régis Hanol
Kyle Zhao
pmusaraj
Bianca Nenciu
OsamaSayegh
Guo Xiang Tan
Blake Erickson
David Taylor