b4ef7dfe9a
DEV: Make spec less brittle.
2018-07-21 09:13:11 +08:00
69450750d1
shorter method name and better specs
2018-07-20 10:13:27 +03:00
b068a8a771
Fix the build.
2018-07-18 14:03:27 +08:00
0c159f17b7
skip failing spec
2018-07-18 14:43:06 +10:00
18f5f646b1
FEATURE: allow selecting a tag when moving posts to a new topic ( #6072 )
2018-07-06 18:21:32 +02:00
7fc8a36529
DEV: Take 2 Queue jobs in tests by default.
...
On my machine this cuts the time taken to run our test suite
from ~11mins to ~9mins.
2018-05-31 16:23:23 +08:00
56e9ff6853
Revert "DEV: Queue jobs in tests by default."
...
Too risky for now
This reverts commit be28154d3b
2018-05-31 15:34:46 +08:00
be28154d3b
DEV: Queue jobs in tests by default.
2018-05-31 14:45:47 +08:00
0ecdf90023
FIX: Validations could prevent moving posts
2018-02-08 13:36:13 +01:00
8ab6689f43
FIX: Preserve original date when moving first post
2018-02-08 12:55:32 +01:00
e8559f222c
FIX: After moving the posts topic timestamp should be updated with newest post
2018-02-02 19:30:52 +05:30
b3094e9954
FIX: incoming and outgoing emails got lost when post was moved
2017-11-24 11:45:36 +01:00
39810e4425
FIX: do not move small post actions
2017-11-23 17:25:53 +01:00
87ec11e298
FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats.
2017-11-17 16:08:46 -05:00
efef422416
FIX: Use default locale for moderator post when posts are moved
2017-09-14 17:17:37 +02:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
984778d3ac
FIX: handle moving first post to a closed/archived topic
2017-07-03 21:21:20 +05:30
5794ff53a1
FIX: Copy custom fields when moving first post of a topic.
...
https://meta.discourse.org/t/transfer-poll-votes-when-moving-a-topic-into-an-existing-one/63678
2017-06-07 19:04:48 +09:00
096177d0d5
confirm we notify on the destination, not source
2017-06-02 11:20:40 -04:00
a7fc93acac
FIX: post mover not clearing reply_to_user_id
2017-06-01 18:00:14 -04:00
934bff43d9
FIX: Copy post actions when moving a topic.
2017-04-06 12:16:22 +08:00
d173473509
Fix randomly failing specs.
2017-03-14 14:43:48 +08:00
8aea3caf00
FIX: Ensure that we only move posts that belong to the original topic.
2017-03-06 15:04:10 +08:00
c531f4ded5
remove rails-observers
...
Rails yanked out observers many many years ago, instead the functionality
was yanked out to a gem that is very lightly maintained.
For example: if we want to upgrade to rails 5 there is no published gem
Internally the usage of observers had quite a few problem.
The series of refactors renamed a bunch of classes to give us more clarity
and removed some magic.
2016-12-22 16:46:53 +11:00
2f6a4cc6de
remove UserActionObserver, replace with after_save and service
...
interestingly there was some left over dead code from when stars
existed in the topic_users table
2016-12-22 16:46:53 +11:00
e5b529f8e1
FIX: Couldn't move posts with deleted replies
2016-08-04 11:56:01 -04:00
5fed886c8f
FIX: Update post replies when we move posts. ( #4324 )
2016-07-13 17:34:21 +02:00
97e4f7f6d3
Enums that are used in tables need to be stable
2016-01-08 20:43:11 +05:30
98eee2b5de
FEATURE: when all posts in a topic are moved, close the topic
2015-12-29 16:01:55 -05:00
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
ffa523a543
FIX: when moving posts, retain creator and date from OP
2015-11-07 15:17:47 +11:00
b3d769ff4f
Update rspec syntax to v3
...
update rspec syntax to v3
change syntax to rspec v3
oops. fix typo
mailers classes with rspec3 syntax
helpers with rspec3 syntax
jobs with rspec3 syntax
serializers with rspec3 syntax
views with rspec3 syntax
support to rspec3 syntax
category spec with rspec3 syntax
2015-01-05 11:59:30 -03:00
1f95cfedc3
[patch] When a post is split out to be a new topic
...
the topic's last_post_user_id is set to the user who split out
the post. But, this should really be the user_id of the last post
of the split out posts.
2014-10-16 12:38:26 -07:00
de76b512c1
fix most deprecations in the specs (still some left)
2014-09-25 17:44:48 +02:00
506dca6d4e
FIX: Moving posts was not updating `reply_count` and
...
`reply_to_post_number` so reply linkage was broken.
2014-08-20 14:15:23 -04:00
96eecf18ef
FIX: moving a post to a topic with a deleted post should use correct post_number. Was getting unique index violation on (topic_id, post_number).
2014-08-20 12:28:53 -04:00
1574485443
Perform the where(...).first to find_by(...) refactoring.
...
This refactoring was automated using the command: bundle exec "ruby refactorings/where_dot_first_to_find_by/app.rb"
2014-05-06 14:41:59 +01:00
c708d6fcb8
FIX: post_mover_spec needs to order posts
2014-03-19 11:05:18 -04:00
6063b52d6a
Support for choosing a destination category when splitting topics.
2013-10-29 15:30:06 -04:00
666264879c
change it so all topics MUST include a category, we store a special uncategorized category to compensate
...
this cleans up a bunch of internals and removes some settings
2013-10-24 12:08:02 +11:00
f99acebdaa
Rails 4 updates
2013-07-24 21:09:18 +02:00
81616a46ba
db consistency check for mismatching topic_ids in user_actions
...
fix up post mover so it remaps user actions as well
move specs for post mover into post_mover_spec
2013-07-17 16:40:56 +10:00
Guo Xiang Tan
OsamaSayegh
Sam
Maja Komel
Gerhard Schlager
Vinoth Kannan
Neil Lalonde
Guo Xiang Tan
Arpit Jalan
David Rodríguez
Robin Ward
Andy Waite
Luciano Sousa
Michael Verdi
Régis Hanol
Louis Rose
Stephan Kaag