dc5eb76551
DEV: Let OmniAuth strategies return auth result. ( #7833 )
2019-07-01 13:13:11 -03:00
f56d86a852
FIX: use normal title instead of fancy title for prefilled composer
2019-07-01 17:55:24 +05:30
7b52a110b8
DEV: removes DOMTokenList polyfill ( #7831 )
...
Creates more issues than it solves especially on IOS, I dont trust it anymore. Will reconsider if this is an issue in the future.
2019-07-01 14:08:38 +02:00
d513c28e3b
FIX: Don't send notification email when user isn't allowed to see topic
2019-07-01 14:03:03 +02:00
997250586c
FEATURE: prefill title for direct messages from topic
...
https://meta.discourse.org/t/default-re-title-title-for-direct-messages-from-topic/121413
2019-07-01 17:14:08 +05:30
af58049eeb
UX: puts tags and categories on same line in search-menu-results ( #7830 )
2019-07-01 13:11:43 +02:00
384f5cea05
FIX: ensures static pages are using absolute path ( #7828 )
2019-07-01 11:25:45 +02:00
11ae5c78db
FEATURE: adds infite scroll on admin users list page ( #7821 )
2019-07-01 11:00:06 +02:00
4f97f85178
DEV: Fix lint. ( #7824 )
2019-06-28 20:24:09 +02:00
aa9b9e1930
UX: improved mobile positioning of topic timer remove button
2019-06-28 14:09:42 -04:00
5bab4f8007
UX: gives each info its own line in search-menu-results ( #7825 )
2019-06-28 11:14:38 +02:00
61438c825a
fix prettier ( #7823 )
2019-06-28 09:36:38 +02:00
b2eb0f4ad6
FEATURE: Export any type of report supporting table mode. ( #7662 )
2019-06-28 08:50:31 +02:00
82f2af8a0d
UX: Move link to show tracked topics, simplify translation
2019-06-27 21:36:24 -04:00
27387b0859
Do not collapse quote notifications
...
This prevents an issue where edits to a post with a quote would trigger push notifications indefinitely.
2019-06-27 18:20:43 -04:00
4ba35472e6
Don't check for second factor when switching to anonymous account ( #7803 )
2019-06-27 15:01:26 -07:00
a61147d838
FEATURE: displays tags in search menu results when enabled ( #7819 )
2019-06-27 19:26:14 +02:00
ed936bcb01
FIX: Fix a navigation bug
...
To reproduce:
1. Visit a url in a new tab such as `/latest?order=views`
2. Click a topic link
3. Click the back button
Before this patch, you would not be sent back to the latest list.
Now, I am somewhat hesitant to delete code like this, but the [original
commit](b2b7f4d905
2019-06-27 09:06:10 -04:00
fe870a1e54
DEV: Respond with error 400 to uploads requested via XHR
...
follow-up to 13f38055
2019-06-27 11:15:35 +02:00
8f7a387aa7
FEATURE: add support for tag group search
...
The behaviour of #TERM in search has been amended
1. We try category or subcategory slugs
2. We try tags
3. We try tag-groups
The term `hello #my-group` will search for all posts tagged with any of
the tags in the tag group `My Group`
Future work may be introducing a slug cache here or caching it in the table
but the assumption is that the number of tag groups will not be huge
2019-06-27 17:53:26 +10:00
9a2eb5c8cb
UX: change icon for video placeholder
2019-06-27 12:27:14 +05:30
5bc5c02af6
FIX: mark topics in sub categories as unread when dismissing parent
...
Previously we would only dismiss the parent category and leave the
child categories unread
2019-06-27 13:26:48 +10:00
88ef5e55fe
FEATURE: add ability to have multiple totp factors ( #7626 )
...
Adds a second factor landing page that centralizes a user's second factor configuration.
This contains both TOTP and Backup, and also allows multiple TOTP tokens to be registered and organized by a name. Access to this page is authenticated via password, and cached for 30 minutes via a secure session.
2019-06-26 16:58:06 -07:00
50e4ecc77e
UX: hide post is unread tooltip after the post is read ( #7813 )
...
Note we can't use `display: none` here because it doesn't work with
animations.
2019-06-26 22:39:57 +03:00
a3bcb8e887
UX: make onebox video placeholder icon grey
2019-06-26 23:40:36 +05:30
168a38dc29
Bump onebox version.
...
- better Twitch placeholder
- CSS for said placeholder
2019-06-26 23:22:29 +05:30
817661aed9
UX: Require a confirmation if approving a post in a closed topic
2019-06-26 12:21:49 -04:00
14a64e7c4c
Move "Hide Post" option up to the top on the review interface
...
If you agree with the post you are likely to want to hide it.
2019-06-26 11:35:59 -04:00
eedec7d79b
FIX: Only include pending/agreed scores in the total score
...
This should prevent posts from being hidden if a previous flag was
rejected and a new one was added.
2019-06-26 11:21:35 -04:00
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
56b76f31dc
fix prettier linting ( #7809 )
2019-06-26 15:26:02 +02:00
dfde59f631
FIX: provides an emoji helper to replace codes by images ( #7802 )
2019-06-26 15:11:04 +02:00
65a6e2c860
Change Widget#attach signature
...
Take a fallback option instead of a list of names
2019-06-26 09:01:25 -04:00
37b8f5d989
Use dasherize instead of replace
2019-06-26 09:01:25 -04:00
d025e188e8
Make the linter happy
2019-06-26 09:01:25 -04:00
70e27641eb
Pass data to description to prevent duplication
2019-06-26 09:01:25 -04:00
8c349101c5
Pass data to text method to prevent duplication
2019-06-26 09:01:25 -04:00
86d5208b31
Pass data to url method to avoid duplication
2019-06-26 09:01:25 -04:00
ac6f7b3625
Remove notificationType argument from text
2019-06-26 09:01:25 -04:00
a3254b8446
Pull invitee accepted notification behaviour into its own class
2019-06-26 09:01:25 -04:00
7c52ba1431
Pull liked consolidated notification behaviour into its own class
2019-06-26 09:01:25 -04:00
42143a874e
Pull custom notification behaviour into its own class
2019-06-26 09:01:25 -04:00
305562bf66
Pull title logic into its own method
2019-06-26 09:01:25 -04:00
d83147d137
Rename "title" variable to more apt "description"
2019-06-26 09:01:25 -04:00
02deaa4bc6
Pull icon choosing into its own method
2019-06-26 09:01:25 -04:00
36d7abed0b
Pull group message summary behaviour into its own class
2019-06-26 09:01:25 -04:00
396e13aaa7
Pull liked notification behaviour in its own class
2019-06-26 09:01:25 -04:00
bd062fcbef
Export DefaultNotificationItem
2019-06-26 09:01:25 -04:00
04a75b1cb3
Change the way notification items are created
...
Look for the specialised version first, before falling back to the
default. This allows the behaviour to be customised based on the type of
notification.
2019-06-26 09:01:25 -04:00
cdf0cd3ecd
`createWidgetFrom` creates a new widget with an arbitrary base class
2019-06-26 09:01:25 -04:00
01a7fd4225
Make `attach` optionally take a list of widget names to try
2019-06-26 09:01:25 -04:00
41129f933d
Rename notification-item to default-notification-item
2019-06-26 09:01:25 -04:00
7e70db3fb7
s/notName/notificationName/g
2019-06-26 09:01:25 -04:00
7c9d62c280
FIX: prevents failure when TL was mutated on internal object ( #7808 )
2019-06-26 14:51:45 +02:00
01de7e1444
FIX: calling action with a string is deprecated ( #7807 )
2019-06-26 12:42:46 +02:00
e64544ae44
icon s/trash/trash-alt ( #7806 )
2019-06-26 12:31:49 +02:00
ea2a9bc4fc
FIX: closes search-menu on escape ( #7804 )
2019-06-26 11:53:39 +02:00
2af4002817
Bump onebox version.
...
- Add a placeholder icon for Twitch onebox preview
- Add CSS for showing fontawesome play icon for placeholder class
2019-06-26 13:40:14 +05:30
333b5a19b2
FIX: do not include uncategorized_category_id in `topic_create_allowed` if posting in uncategorized is disabled
...
Previously users were still allowed to create topic via API even if
uncategorized was disabled.
Not 100% happy with all this special casing, but I guess we have to do
something.
This also splits up a mega spec now that we have fab! into a more easy to
understand structure (I hope)
2019-06-26 17:41:07 +10:00
2eece2c41b
UX: add shortcut for deferring topics ( #7798 )
2019-06-25 07:20:55 +03:00
afb5ec811d
FIX: Don't use DistributedCache to store redis readonly state
...
This can cause unbound CPU usage in some cases, and excessive logging in other cases. This commit moves redis readonly information into the local process, but maintains the DistributedCache for postgres readonly state.
2019-06-25 11:20:34 +08:00
f3e4e6941c
DEV: Correct batch setting of categories
...
followup to #bc03c509
There were 2 problems
1. VALUES was not properly getting multiple results ... we need (1),(2),(3)
not (1,2,3)
2. changes was mistakenly lazy evaluated eg `changed ||=` which meant some
queries were not running
2019-06-25 13:05:43 +10:00
bc03c509ab
FIX: CategoryUser#batch_set ( #7787 )
...
* Remove unused method
* Prefabricate user in category_user_spec.rb
* FIX: Remove notification_level from category_users unique indexes
* FIX: CategoryUser#batch_set wasn't updating pre-existing records
* Improve tests for CategoryUser#batch_set
* FIX: changed was being reported incorrectly
* DEV: Rewrote query to do a bulk insert
* DEV: remove unnecessary parentheses
2019-06-25 12:13:27 +10:00
6de254f642
FIX: iterate when clearing watched words cache
2019-06-24 17:17:56 -07:00
b1ca64487a
FIX: multisite upload urls must have either db name or the word 'short-url'.
2019-06-25 01:19:58 +05:30
9e54e0141e
FIX: mobile overflow for tall fixed modals
2019-06-24 12:24:13 -04:00
c1ca942a77
REFACTOR: removes self pattern from safari-hacks lib ( #7795 )
2019-06-24 11:12:06 +02:00
e064db35d9
REFACTOR: removes self pattern from eyeline lib ( #7796 )
2019-06-24 10:58:59 +02:00
cea3a027f3
FIX: category-chooser search should be scoped to category ( #7794 )
2019-06-24 10:45:30 +02:00
7cabc47945
UX: improves change-timestamp modal datepicker ( #7771 )
2019-06-24 10:24:54 +02:00
ee8669d778
FIX: Ensure :after_auth event is triggered. ( #7791 )
2019-06-21 21:57:49 +03:00
02f6db4e59
FIX: Back button shenanigans when redirecting from `index` routes
...
This is a problem that has long plagued Discourse. The root issue here
is that we have to implement our own link click handler, because
Discourse allows users to create HTML blobs of content with links, and
when those links are clicked they must be handled by the Ember router.
This always involved a certain amount of use of private Ember APIs which
of course evolved over time.
The API has more or less stabilized in the last two years, however we
have hacks in our URLs to handle a dynamic root path, depending on how
forums have set up their filters and in what order.
This patch adds a special case for the root path so we needn't update
the URL ourselves otherwise, which preserves the back button on index
routes. The update call would otherwise insert an extra history event if
a route redirected on transition, breaking the back button.
2019-06-21 14:42:01 -04:00
e51de4cc25
FEATURE: Add endpoint to individually update a theme setting ( #7789 )
...
- also adds a new staff action type called "change theme setting" for easier logging of staff changes to theme settings
2019-06-21 13:49:14 -04:00
2738d11f60
UX: show like icon on archived posts ( #7775 )
2019-06-21 20:47:32 +05:30
1cbe2dd2ce
DEV: adds polyfill to fully support DOMTokenList in IE ( #7765 )
2019-06-21 09:59:28 +02:00
7c86f16aa3
FIX: Support carriage return in `InlineUploads`.
...
Follow up to 8deaef3872
2019-06-21 14:07:06 +08:00
8deaef3872
FIX: Don't replace img tags within anchor tags with markdown format.
...
Follow up to 9a25b0d614
2019-06-21 12:32:02 +08:00
9a25b0d614
FIX: Edge case with anchor tag in `InlineUploads`.
2019-06-21 09:55:56 +08:00
fc026e12a5
FIX: Some toolbar operations weren't triggering the `change` event
...
This would mean that some simple edits to queued posts did not get
saved.
2019-06-20 13:35:12 -04:00
0e26c57afa
FIX: Do not refresh all settings on save for all settings, limit to only a few
...
- Followup to 0e303c7f5d
2019-06-20 10:57:31 -04:00
56b7777705
FIX: 'status' param change not filtering the topics in tag route.
...
Use existing 'filterQueryParams' helper method to set 'queryParams' value for tag route.
2019-06-20 17:27:32 +05:30
53efb7bd24
FIX: BBcode edge case for `InlineUploads`.
2019-06-20 11:47:51 +08:00
f096c994de
FIX: use correct name for selectable_avatars_enabled site setting
2019-06-19 13:18:16 -04:00
34f382b758
FIX: `InlineUploads` should replace attachment links with markdown text.
2019-06-19 11:15:02 +08:00
73a45048a0
FIX: `Upload#short_url` generates incorrect URL when extension is `nil`.
2019-06-19 09:10:50 +08:00
6fec4982d9
FIX: Couldn't modify a widget that wasn't in the registry
2019-06-18 12:28:18 -04:00
03ba1d49fb
DEV: lint file
...
We no longer need that isAppleDevice require
2019-06-18 17:12:55 +10:00
506de13896
FIX: remove temporary hack for fixed iOS bug ( #7773 )
...
A bug where input focus is displaced on modals was fixed in iOS 11.3 update. This hack was causing problems on topic page since hiding main-outlet results in lost read position after opening and closing a modal.
2019-06-18 16:25:29 +10:00
893b50031d
replace subfolder on cdn url conversion between general cdn and s3 ( #7764 )
...
When both a cdn URL and an s3 cdn URL defined, subfolder paths were leaking
through to the s3 cdn URL. If we are replacing the cdn url with the s3_cdn url,
we also need to make sure that the subpath is removed as well, as it appears in
the original cdn url.
The test should give a fairly good gist of the situations - in subfolder
situations where s3_cdn and a cdn is defined:
`asset_path` returns the asset with a subfolder, in the form `{cdn_url}/{subfolder}/{asset_path}`
Currently this is being replaced to `{s3_cdn_url}/{subfolder}/{asset_path}`
I am proposing we change this to: `{s3_cdn_url}/{asset_path}` as it seems like
for s3_cdn urls we should not be carrying around app subfolder pathing anywhere
we are looking up s3 paths.
2019-06-17 11:51:17 -07:00
e6e47f2fb2
SECURITY: Add confirmation screen when logging in via user-api OTP
2019-06-17 16:18:44 +01:00
52387be4a4
SECURITY: Add confirmation screen when logging in via email link
2019-06-17 16:18:37 +01:00
5f6f707080
Revert "Merge pull request from GHSA-hv9p-jfm4-gpr9"
...
This reverts commit b8340c6c8e
2019-06-17 16:17:10 +01:00
b8340c6c8e
Merge pull request from GHSA-hv9p-jfm4-gpr9
...
* SECURITY: Add confirmation screen when logging in via email link
* SECURITY: Add confirmation screen when logging in via user-api OTP
* FIX: Correct translation key in session controller specs
* FIX: Use .email-login class for page
2019-06-17 15:59:41 +01:00
863d8014d0
FIX: respond with 400 error on invalid redirect param
2019-06-17 16:44:30 +05:30
102be5a9e3
DEV: optimize fix for sub-categories not getting pre-filled.
2019-06-17 13:28:08 +05:30
c909033f2b
Add plugin outlets to login/create-account modals ( #7770 )
2019-06-17 16:22:00 +10:00
704c579550
FIX: do not allow unbound membership lookups
...
Previously we would allow looking up membership limits in an unbound way
via the API, this introduces an upper limit of 1000 per page.
2019-06-17 15:32:06 +10:00
fe4f0a4369
FIX: staged users should not be included in TL groups
...
staged users should not be included in any automatic groups cause for all
purposes they do not exist.
2019-06-17 15:10:47 +10:00
48b9e0d749
FIX: sub-categories was not getting selected for pre-filled topics
2019-06-15 13:46:15 +05:30
9cb656250d
FIX: Allow tall tables to scroll vertically on iOS
2019-06-14 14:26:59 -04:00
77c06384c0
Fix the build.
2019-06-14 13:56:35 +08:00
5d16d10a9e
DEV: Fix edge case for `InlineUploads`.
2019-06-14 13:48:03 +08:00
befb074c98
DEV: `InlineUploads` should process CDN upload URLs as well.
2019-06-14 13:14:37 +08:00
41abebcbce
DEV: Support both `http` and `https` for `InlineUploads`.
2019-06-14 12:48:31 +08:00
c9db897777
FIX: Remove onebox src from `Jobs::PullHotlinkedImages`.
...
The test that was added is incorrect because the post was not cooked.
2019-06-14 09:21:25 +08:00
457be89445
DEV: only skip migration if a non seeded upload exists
...
Followup to 667b9801
2019-06-14 09:52:02 +10:00
667b98017a
FIX: do not attempt to migrate pre-existing uploads
...
This makes this job re-runnable just in case cause it will skip creation
of new uploads if an upload already exists
2019-06-14 09:39:22 +10:00
efc05e7224
FIX: remove topic timer info on completion
2019-06-13 17:01:43 +05:30
fbbce235ce
UX: improves change-timestamp modal ( #7766 )
2019-06-13 13:30:33 +02:00
9daed05ad0
Fix the build.
2019-06-13 13:53:43 +08:00
7a0d031bc4
FIX: `InlineUploads` matching on external bbcode img url.
2019-06-13 13:47:36 +08:00
782e583844
FIX: Edge cases with markdown references for `InlineUploads`.
2019-06-13 12:08:01 +08:00
93c552afda
FIX: `InlineUploads` does not correct urls with uppercase extension.
2019-06-13 11:19:33 +08:00
fa2a5f6f56
FEATURE: SKIP_DB_AND_REDIS env var ( #7756 )
...
Sometimes we would like to create a base image without any DB access, this
assists in creating custom base images with custom plugins that already
includes `public/assets`
Following this change set you can run:
```
SPROCKETS_CONCURRENT=1 DONT_PRECOMPILE_CSS=1 SKIP_DB_AND_REDIS=1 RAILS_ENV=production bin/rake assets:precompile
```
Then it is straight forward to create a base image without needing a DB or
Redis.
2019-06-13 12:58:27 +10:00
19ca2d4772
DEV: reset widget clean callback between tests ( #7761 )
2019-06-12 17:49:02 +02:00
13b979cb71
FIX: Performing actions on a particular reviewable was displaying an error
...
It was expecting a method to remove the reviewable from the current
list, only we were not displaying a list.
Instead, we refresh the reviewable model with the latest result.
2019-06-12 10:56:30 -04:00
36e53db300
Fix the build.
2019-06-12 16:44:17 +05:30
7b66f8fb46
DEV: optimize bulk invite process
2019-06-12 16:33:19 +05:30
f0846ea7cf
DEV: Remove unused line.
2019-06-12 17:38:30 +08:00
641521896c
FIX: Cover more edge cases in `InlineUploads`.
2019-06-12 17:06:58 +08:00
0a1b16bb16
FIX: clean up cooked group bio when bio is removed ( #7745 )
2019-06-12 16:18:38 +10:00
73bf880f74
FIX: Correct more edge cases with `InlineUploads`.
2019-06-12 10:44:25 +08:00
ff48fbdfda
FIX: `InlineUploads` raises an error when img tag is invalid.
2019-06-12 10:31:00 +08:00
0ebe5ec1f8
FIX: Check `postStream.gaps` exists before trying `postSteam.gaps.after`
2019-06-11 23:48:21 +01:00
f6e0c79742
FIX: Trigger change event when inserting text
...
This would normally not fire and result in odd behavior in the review
queue when inserting links.
2019-06-11 17:27:34 -04:00
3d7c26c15e
FIX: Memory Leaks w/ Container ( #7750 )
...
Gives instance initializers the ability to add a `teardown` method that
will be called between tests to clean up after themselves.
2019-06-11 18:41:27 +02:00
47095a7fa1
FIX: Memory leak when adding ajax prefilter repeatedly.
2019-06-11 11:50:35 -04:00
c322cccd53
FIX: Memory Leaks when decorating posts ( #7749 )
...
* Remove long-deprecated method
* FIX: Memory Leaks when decorating posts
Previously we'd keep creating mixins dynamically when decorating the
same class.
This code changes the API to recommend an `id` parameter for each
decorator which will avoid leaks. All plugins should be updated to
include this parameter, although if they don't in the meantime it'll
just mean a warning in the console (and a continued leak.)
2019-06-11 17:21:23 +02:00
934adb14d2
FIX: On tag change notify only users watching the tag. ( #7707 )
2019-06-11 18:06:54 +03:00
788f995f30
FIX: skip external urls which has upload url in query string.
...
Add spec tests for post.each_upload_url method. e8fafbc123
2019-06-11 19:55:02 +05:30
e2636f0ec7
FIX: handle array in redirect param
2019-06-11 17:49:09 +05:30
f4fd75aea4
DEV: Rename variable to avoid conflict
2019-06-11 13:02:40 +01:00
f1d5b992bf
DEV: Correct linting error
2019-06-11 12:51:18 +01:00
dc15486f0a
Revert "DEV: resets csrf ajax prefilter only if present ( #7747 )"
...
This reverts commit 6612218a4e
2019-06-11 13:34:25 +02:00
61b587f66e
FIX: Mark ignored posts as 'read', if last visible post is read ( #7739 )
2019-06-11 12:16:28 +01:00
000a35b219
FIX: Do not live-load posts from ignored users
2019-06-11 12:07:14 +01:00
6612218a4e
DEV: resets csrf ajax prefilter only if present ( #7747 )
2019-06-11 12:50:20 +02:00
ebf77f74b7
Revert "DEV: prevents csrf token to leak state between tests ( #7746 )"
...
This reverts commit b29d63a52d
2019-06-11 12:19:49 +02:00
b29d63a52d
DEV: prevents csrf token to leak state between tests ( #7746 )
2019-06-11 11:54:23 +02:00
e6714d3531
Revert "DEV: attempts to prevent session object to be retain in csrf init ( #7743 )"
...
This reverts commit 62c56b6e59
2019-06-11 10:58:32 +02:00
4deb0f6d59
DEV: prevents post-cooked decorators to leak between tests ( #7744 )
2019-06-11 10:02:10 +02:00
62c56b6e59
DEV: attempts to prevent session object to be retain in csrf init ( #7743 )
2019-06-11 09:59:14 +02:00
c407e32368
DEV: should check on object and not length ( #7742 )
2019-06-11 09:45:45 +02:00
e5cace9185
FIX: File size text should not be part of link.
2019-06-11 15:21:06 +08:00
fb0a655e8a
FEATURE: Update pull hotlinked images to use `Upload#short_url`.
2019-06-11 15:17:29 +08:00
9d0fba64c0
FIX: Use attachment format in user export system post take 2.
2019-06-11 12:15:11 +08:00
a046f6ced5
FEATURE: Trigger Discourse events from authenticators. ( #7724 )
2019-06-11 11:28:42 +10:00
d073a7d5a8
DEV: Added commit approved notification type for discourse-code-review
...
We need to reserve ids in core so plugins do not clash.
2019-06-11 11:17:23 +10:00
06d974d55c
FEATURE: Add base62 sha1 to cooked data attribute
...
* FEATURE: Add base62 sha1 to data attribute in `Post#cooked`.
* FIX: Use `Upload#short_url` when quoting an image.
2019-06-11 11:15:45 +10:00
bd538f7437
FIX: Composer preview not caching inline onebox.
2019-06-11 09:14:53 +08:00
9168ffc201
PERF: Use already loaded post when quoting or opening draft.
2019-06-11 08:21:38 +08:00
7b17eb06da
FEATURE: ban any SSO attempts with invalid external id
...
We now treat any external_id of blank string (" " or " " or "", etc) or a
invalid word (none, nil, blank, null) - case insensitive - as invalid.
In this case the client will see "please contact admin" the logs will explain
the reason clearly.
2019-06-11 10:04:26 +10:00
ecebff5060
Only show deprecation warning if the webhook is active
2019-06-10 16:23:12 -04:00
ace6ce0462
FIX: Add 'deleted' to the list of status filters ( #7738 )
2019-06-10 15:43:49 -03:00
bdfa55ee5d
UX: Copyedits on reviewable filters
2019-06-10 13:45:38 -04:00
86f3e74799
DEV: Allow `{{d-button}}` to include a href
2019-06-10 13:24:40 -04:00
8b31b812f8
UX: Use a glyph to indicate a new topic instead of "New Topic:"
...
In the review queue it was easy to miss "New Topic:" so let's try a font
awesome glyph instead.
2019-06-10 12:43:20 -04:00
8c4e16eafd
FIX: In reply to would sometimes have a broken link
2019-06-10 11:33:10 -04:00
af08ab5b7b
Revert "DEV: prevents csrf-token initializer to leak session object ( #7730 )"
...
This reverts commit da5255e560
2019-06-07 18:31:16 +02:00
ebecd0b7d1
Revert "fix tests, crsf token meta is not present on tests ( #7733 )"
...
This reverts commit 240b61e844
2019-06-07 18:31:13 +02:00
bae7b75e23
FIX: Updating a user profile as admin shouldn't change the user's locale
2019-06-07 17:53:46 +02:00
2dce650b72
FIX: prevents screen-track from leaking object ( #7734 )
2019-06-07 17:18:27 +02:00
240b61e844
fix tests, crsf token meta is not present on tests ( #7733 )
2019-06-07 17:11:16 +02:00
dfb66334c1
DEV: prevents global-notice events to leak ( #7732 )
2019-06-07 16:49:59 +02:00
55325679ac
DEV: prevents share-popup to leak events ( #7731 )
2019-06-07 16:48:45 +02:00
da5255e560
DEV: prevents csrf-token initializer to leak session object ( #7730 )
2019-06-07 16:46:55 +02:00
df01249db4
FIX: removes leaking handler in select-kit ( #7729 )
2019-06-07 16:12:22 +02:00
fca90106b9
FIX: select-kit events were sometimes not cleaned up ( #7728 )
2019-06-07 15:20:01 +02:00
54afa314fb
FIX: Do not download emojis in pull_hotlinked_images
2019-06-07 13:00:52 +01:00
d1228f47bb
FIX: Handle missing plural keys on client
2019-06-07 10:24:17 +02:00
cbd4d06da0
PERF: only check for totp record on current user at when needed
...
Previously the check was done a bit too early causing one extra query
per page unconditionally for logged on users
2019-06-07 16:25:04 +10:00
a652d620f6
FIX: safari desktop doesnt support input[time] ( #7719 )
...
This commit attempts to improve the experience by:
- showing time input as disabled on any platform if date hasn't been set
- showing a placeholder --:-- to emphasize the expected format
2019-06-07 15:50:43 +10:00
a0474a0774
FIX: always take the first post in the RSS fee
...
`.posts.first` may be the first post and may not, depending on luck
Also add protection for corrupt topics
2019-06-07 14:57:56 +10:00
ff3a1eae3a
FIX: ensure consistency should handle cases where a topic trashed
...
Followup to c05b6170
2019-06-07 14:57:56 +10:00
ee142c2173
DEV: More improvements to `InlineUploads`.
...
* Convert inline links to short path
```
<link> <link>
<link>
```
to
```
<short_path> <short_path>
<short_path>
```
2019-06-07 11:49:30 +08:00
c05b617067
FIX: ensure_consistency was able to create corrupt category topics
...
- Correct create_category_definition to skip validations and use a
transaction, no longer able to create corrupt topics
- ensure_consistency now clears topic_id if pointing at deleted or missing
topic_id
- Stop creating category definition topics for uncategorized
2019-06-07 11:20:13 +10:00
9db1fef4e3
FIX: add support for custom/plugin notification title attribute
2019-06-07 09:09:16 +08:00
1f73a3ba6d
FIX: round the calculated heat values
...
Views heats like 12135 will become 12000, like ratios like
1.666666666667 will become 1.67.
2019-06-06 15:44:55 -04:00
35da531f1d
FIX: Do not resize images in Onebox while lazy loading.
...
Follow-up to 35d0fd0
2019-06-06 18:36:18 +03:00
9acd851b9a
FIX: correct link to list of watched words
2019-06-06 20:21:54 +05:30
48b6391777
FIX: s/thumb-tack/thumbtack ( #7718 )
2019-06-06 14:43:16 +02:00
c462c2f271
FIX: prevents appEvents to leak ( #7714 )
2019-06-06 12:33:52 +02:00
5377d1672f
DEV: Fix linting issue.
2019-06-06 13:20:16 +03:00
f63b8bb79d
FIX: Periodically ensure consistency of categories. ( #7663 )
2019-06-06 11:30:52 +02:00
782da448a2
FIX: Missing `title` attribute when quoting an image.
2019-06-06 16:45:12 +08:00
2265c5102f
DEV: Remove unnecessary condition.
...
Follow up to 21876d46d6
2019-06-06 15:55:49 +08:00
95db609586
DEV: Support more formats of inline images.
2019-06-06 15:50:56 +08:00
21876d46d6
DEV: Missing loading spinner for staff action logs.
...
Follow up to e0c821ebb0
2019-06-06 15:41:55 +08:00
f00275ded3
FEATURE: Support private attachments when using S3 storage ( #7677 )
...
* Support private uploads in S3
* Use localStore for local avatars
* Add job to update private upload ACL on S3
* Test multisite paths
* update ACL for private uploads in migrate_to_s3 task
2019-06-06 13:27:24 +10:00
e0c821ebb0
FEATURE: Make staff action logs page support infinite loading
2019-06-06 13:02:53 +10:00
b510006ca8
FEATURE: show tags in crawler view of tags page for static site
...
Previously tags page would have an empty page in crawler view
2019-06-06 12:55:37 +10:00
c3a38d2304
DEV: Make groups/new extensible by plugins ( #7642 )
...
* Expose a new plugin outlet. Pass group model to the group-member-dropdown so it can be accessed by plugins
* Added controller tests for group custom fields. update custom fields when updating a group
2019-06-06 12:05:33 +10:00
7bd8f715bc
DEV: Prefer `this.site.notification_types`.
2019-06-06 09:39:59 +08:00
d9d36f241d
DEV: Use `this.site.get("notification_types")` instead.
...
Follow up to fcb7422213
2019-06-06 08:18:25 +08:00
54db23e4ff
UX: Make input caret color match text color
2019-06-05 14:27:27 -04:00
58ff7216ca
UX: Display "Queued Topic" if a Queued Post will create a topic
2019-06-05 14:11:28 -04:00
d902c4eb9f
FEATURE: Can sort reviewable queue
...
Choices are Priority / Created At (and desc versions.)
2019-06-05 13:21:05 -04:00
35d0fd038e
FIX: Add unit to width and height CSS properties.
2019-06-05 19:51:31 +03:00
c0e8950fdb
UX: Shrink oneboxes and other wide content in custom post messages
2019-06-05 12:48:06 -04:00
ea5767e935
FIX: Broken serializer spec with no payload
2019-06-05 12:44:56 -04:00
f1d547c301
FEATURE: Show "in reply to" on the review queue
...
We now show if a queued or flagged post is a reply to another when in
the review queue. It's especially helpful for queued posts where
normally they are linked to the topic where they are created, and you
have no context about the reply.
Note that this will only apply to new queued posts going forward.
Previously queued posts will not show the "in reply to"
2019-06-05 12:34:41 -04:00
be464f753c
UX: Lighten OS icons in recently used devices
2019-06-05 10:56:25 -04:00
ad876880e1
FIX: Ember was raising an error without a `.set` here
2019-06-05 10:23:39 -04:00
0082a57718
REFACTOR: computed lib ( #7702 )
2019-06-05 15:50:22 +02:00
f506843074
REFACTOR: user route ( #7704 )
2019-06-05 13:05:27 +02:00
1178f4865b
REFACTOR: login-method model ( #7703 )
2019-06-05 12:35:41 +02:00
80459d83a4
REFACTOR: discourse-location lib ( #7700 )
2019-06-05 11:46:36 +02:00
faef660631
REFACTOR: invite model ( #7699 )
2019-06-05 11:24:06 +02:00
df6d46b235
FIX: regression and attempts to have clearer naming ( #7701 )
2019-06-05 11:23:30 +02:00
0fd7f74664
REFACTOR: post model ( #7659 )
2019-06-05 11:04:35 +02:00
69f75b2a81
REFACTOR: preferences/account controller ( #7698 )
2019-06-05 10:37:51 +02:00
19e3b3b1bc
PERF: speed up topic poster lookups
...
During profiling looking up topic users popped up as a hot path, this
change more than halved the amount of work it does
It reduces object allocations and method calls and avoids repeate translation
of common terms
2019-06-05 18:28:36 +10:00
ce79a71c5d
typo s/faivcon/favicon ( #7697 )
2019-06-05 09:46:07 +02:00
b9df7a2257
FIX: if favicon is missing due to bad url we would return a 500 on favicons
...
This ensures that the error logging does not corrupt the cache
2019-06-05 16:43:40 +10:00
b2b66d645b
UX: Move archive button in topic controls dropdown (mobile view). ( #7681 )
2019-06-05 11:30:06 +10:00
1cf0b549ab
FIX: don't send post edit notification when hidden tags are changed
...
Create a hidden revision so staff can see the changed, but don't send
notifications to non-staff.
2019-06-04 15:48:15 -04:00
f03a547a89
REFACTOR: topic-entrance component ( #7694 )
2019-06-04 17:50:02 +02:00
6de3824b46
REFACTOR: group model ( #7692 )
2019-06-04 17:41:46 +02:00
68147cedd1
REFACTOR: username-validation mixin ( #7693 )
2019-06-04 17:41:33 +02:00
7b19e63ce7
REFACTOR: badge model ( #7690 )
2019-06-04 17:12:02 +02:00
1bca6fdf51
UX: Z-index fix for preview on iOS
2019-06-04 11:08:49 -04:00
e7fe7010b8
FIX: use hijack for processing bulk invites ( #7679 )
...
FIX: do not store bulk invite CSV file on server
2019-06-04 20:19:46 +05:30
ecc9c76692
FEATURE: dynamically update the topic heat settings monthly ( #7670 )
...
The site settings beginning with "topic views heat" and "topic post like
heat" are set to defaults when installing Discourse, but there has not
been a process or guidance for updating these values based on
community activity.
This feature will update them once a month. The low, medium, and
high settings will be based on the minimums of the 45th, 25th, and
10th percentile topics respectively, so that 45% of topics will have
some "heat".
Disable automatic changes with the automatic_topic_heat_values setting.
2019-06-04 10:34:07 -04:00
e66024bd3b
Update theme component URL
2019-06-04 10:04:27 -04:00
4201329f1e
REFACTOR: topic-from-params route ( #7689 )
2019-06-04 15:51:22 +02:00
87bf0ec7ae
FIX: fix locale key
2019-06-04 13:35:17 +02:00
fcb7422213
DEV: Avoid hard-coding notification types integer in client side code.
...
Co-authored-by: Bianca Nenciu <nenciu.bianca@gmail.com>
2019-06-04 17:30:46 +08:00
9585a16264
FIX: ensures correct i18n key is used ( #7686 )
2019-06-04 11:22:44 +02:00
4283281397
FIX: ensures we have data to compute average ( #7685 )
2019-06-04 11:21:55 +02:00
b79d02ff48
FEATURE: displays average for 2 columns tables which support average
2019-06-04 11:08:26 +02:00
c9a34aa10c
FIX: add title attribute for notifications
2019-06-04 17:02:12 +08:00
33bc8c276d
FIX: default top timeframe was overriding best_periods_for
2019-06-04 10:57:50 +02:00
7da875f52a
FIX: trigger user_updated webhook when avatar changes
2019-06-04 16:46:46 +08:00
497a1d2d9f
FEATURE: uses native date picker on mobile ( #7541 )
2019-06-04 10:44:55 +02:00
c4419b7369
REFACTOR: badge-selector component ( #7683 )
2019-06-04 10:30:56 +02:00
2863e7c181
FIX: fix select badge as user title on badge page ( #7682 )
2019-06-04 18:19:30 +10:00
1991af2abb
DEV: Switch `InlineUploads` to a regexp based implementation.
2019-06-04 15:54:25 +08:00
d93e5fb00d
DEV: Class that converts MD with old attachment links to new MD.
2019-06-04 15:54:25 +08:00
22abad4151
PERF: stop reindexing and skipping deleted posts
2019-06-04 17:53:35 +10:00
74c4f926fc
FIX: drop deleted posts from search index
...
This does two things
1. Our "index grace period" has been wound down to 1 day, there is no point
keeping a bloated index for a week, usually when people delete stuff they
mean for it to be removed
2. We were never dropping deleted posts from the index, only posts from
deleted topics
These changes speed up search a tiny bit and reduce background work.
2019-06-04 17:19:59 +10:00
6428aa5b1f
FIX: search indexer had various cases where it could fail
...
Previous to this fix is a post had the test www.test.com/abc it would fail
to index.
This also simplifies the rules to avoid full url parsing which can be
expensive
2019-06-04 16:21:03 +10:00
bb98785569
DEV: Fix broken `Upload#base62_sha1`.
2019-06-04 14:10:46 +08:00
871fcf1117
PERF: omit user profile and private message stats in web hook serializer.
2019-06-04 08:44:10 +05:30
77300c1d8d
DEV: reindex old data in a more consistent way
...
Previously we were grabbing arbitrary rows in many cases which makes
diagnosing issues in the indexer more complex
2019-06-04 11:47:24 +10:00
55fd3acea0
Revert "FIX: Undefined method when serializing a user"
...
This reverts commit 1fbe078ae04f5c9bb8d3
2019-06-04 09:30:30 +08:00
0c5498c9a4
REFACTOR: exception controller ( #7675 )
2019-06-03 23:34:23 +02:00
d7ff640778
fix the build
2019-06-03 20:42:46 +02:00
b792db9d92
FIX: redirect to top was always redirecting to 'All'
2019-06-03 20:18:14 +02:00
Dan Ungureanu
Arpit Jalan
Joffrey JAFFEUX
Gerhard Schlager
Bianca Nenciu
Kris
Penar Musaraj
Ralph Rooding
Robin Ward
Sam Saffron
Jeff Wong
Osama Sayegh
Daniel Waterworth
David Taylor
Vinoth Kannan
Guo Xiang Tan
Maja Komel
tshenry
Bianca Nenciu
Roman Rizzi
Neil Lalonde
Saurabh Patel
Régis Hanol