David Taylor
aca0b32fda
FEATURE: Allow overriding text size from a different device ( #6955 )
...
This brings the feature in line with the theme selection system
2019-01-28 11:19:50 +00:00
Arpit Jalan
244628ed98
Copy `welcome_message` translation override to `welcome_message_invite_only` ( #6949 )
...
This commit copies `login_required.welcome_message` translation override to `login_required.welcome_message_invite_only` if the `login_required.welcome_message_invite_only` override is blank. This is done so as to ensure that login page customization remains same after [this commit](93eb0a0690
).
2019-01-28 13:59:21 +05:30
Vinoth Kannan
7e4edcfae8
FIX: Convert lightbox html into proper image markdown
2019-01-27 01:21:56 +05:30
Sam Saffron
a72ed6278b
DEV: include comment explaining monkey patch
...
The monkey patch here is very surprising, make a comment explaining why
it is used in the code.
see: https://github.com/rails/rails/issues/35059 for upstream tracking
2019-01-26 07:25:37 +02:00
Simon Cossar
47dbf54960
Update descriptions of public and staff user custom field Site Settings ( #6954 )
2019-01-25 14:47:36 -08:00
Neil Lalonde
cd3a167c63
FIX: javascript error when opening rename tag modal
2019-01-25 17:34:05 -05:00
Kris
94e2b77c5f
Fix theme component name's color when theme is selected
2019-01-25 17:25:12 -05:00
Robin Ward
0f73026c21
FIX: Heisentest
...
These tests were failing for the same reason as:
bee68bba2e
Fix was the same.
2019-01-25 15:25:48 -05:00
Penar Musaraj
84a3da4b18
FIX: match drafts using key when deleting
...
Using "sequence" when removing drafts was buggy, it would remove more than one draft from the stream sometimes.
2019-01-25 13:55:40 -05:00
Joffrey JAFFEUX
0e1862013a
FIX: prevents race condition where the same report is loaded multiple times ( #6953 )
2019-01-25 19:29:45 +01:00
Régis Hanol
db76e5a368
FIX: properly handle attachments in received emails
...
This regressed in 1ac3e547
when we added support for eml attachments.
2019-01-25 19:13:34 +01:00
David Taylor
0fa9c68d47
FIX: Circular argument reference
2019-01-25 17:44:02 +00:00
David Taylor
2e48c43546
FIX: Fix safe mode regression
...
Follow up from a48731e
2019-01-25 17:00:30 +00:00
Robin Ward
78ddc82952
FIX: Respect min_flags_staff_visibility for new flags too
...
There was a situation where if:
* There were new flags to review that met the visibility threshold
AND
* There were old flags that *didn't* meet the threshold
THEN
a pending flags notification would be sent out. This fixes that case.
Staff should not be notified of flags if they do not meet the threshold
and are old.
2019-01-25 11:27:43 -05:00
Joffrey JAFFEUX
85002cf02b
UX: improves copy of various reports ( #6950 )
2019-01-25 16:58:18 +01:00
Joffrey JAFFEUX
7caa28cf45
FIX: ensures ordering set in tags-show queryString works at first load ( #6951 )
2019-01-25 16:48:20 +01:00
David Taylor
d338e54f59
FEATURE: Allow setting font size per-device using a cookie ( #6947 )
2019-01-25 15:06:06 +00:00
Vinoth Kannan
65caf04ddc
clean up unused code
...
Unused PM topic list column 'Users' is removed
2019-01-25 20:13:54 +05:30
David Taylor
a48731e359
FEATURE: Support additional metadata in theme about.json ( #6944 )
...
New `about.json` fields (all optional):
- `authors`: An arbitrary string describing the theme authors
- `theme_version`: An arbitrary string describing the theme version
- `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
- `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
A localized description for a theme can be provided in the language files under the `theme_metadata.description` key
The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
2019-01-25 14:19:01 +00:00
Vinoth Kannan
2d6aa2aea2
FEATURE: Add recipient avatars in PM topic list even if they not yet replied
2019-01-25 19:41:49 +05:30
Joffrey JAFFEUX
f461a9971f
FIX: makes staff_logins show only admins ( #6948 )
2019-01-25 11:28:52 +01:00
Blake Erickson
de47b35b2d
FIX: user_id handling on remove user from group
...
Under some conditions it was possible to pass in a user_id as an
integer, but we would try and parse it as a comma delimited string
resulting in an error. This has been fixed so that we are no longer
mapping the user_id param to user_ids.
2019-01-24 17:40:48 -07:00
Gerhard Schlager
0947fa2bad
Fix specs
...
Follow-up to 7e9da812ea
2019-01-24 22:54:03 +01:00
Gerhard Schlager
45b056b615
FIX: Do not show backups stored in subfolder of bucket
2019-01-24 22:28:03 +01:00
Gerhard Schlager
7e9da812ea
DEV: Multisite tests didn't fail anymore
...
The change in 9ba8bfb1aa
swallowed all exceptions (even syntax errors) which made them appear to pass even if they failed.
2019-01-24 22:28:00 +01:00
Gerhard Schlager
c94a2bc69b
FIX: Raise or log error when deleting of backup fails
2019-01-24 22:26:50 +01:00
Kris
868528f862
Slight shadow adjustment to hide overflow
2019-01-24 14:49:39 -05:00
Robin Ward
96b2585a91
REFACTOR: Remove unncessary stubs from pending flags reminder
...
They seem to be calculated fine by the application, and stubbing
makes the tests more brittle and prone to regression.
2019-01-24 13:45:58 -05:00
Robin Ward
a518950e52
FIX: Use context sensitive "create topic" via keyboard if possible
2019-01-24 13:20:33 -05:00
Kris
8e795d82f9
UX: Bump up notification panel width to accommodate larger text
2019-01-24 12:48:48 -05:00
David Taylor
337545f4f6
DEV: Restore skipped JS test
...
This works for me locally, so the issue has likely been fixed since the test was skipped
2019-01-24 16:58:23 +00:00
Joshua Rosenfeld
cb493b66e0
don't run specs on code-review for now
...
code-review is currently causing failing builds. Remove from testing until it is fixed
2019-01-24 11:48:19 -05:00
Joshua Rosenfeld
1bf3e46537
UX: Improve global notice description
...
Add "non-dismissible" to the site setting description for global notice per https://meta.discourse.org/t/global-notice-whats-the-use-case/107355/5
2019-01-24 10:34:31 -05:00
Penar Musaraj
755b47b4bc
UX: change topic reminder notification icon
2019-01-24 10:07:24 -05:00
Joffrey JAFFEUX
e5765fe1f5
FIX: ensures correct scroll position of textarea after autocomplete ( #6942 )
2019-01-24 15:19:19 +01:00
Régis Hanol
671ff4243f
FIX: discourse-poll-option test wasn't working
2019-01-24 14:55:36 +01:00
Joffrey JAFFEUX
49193ca3bf
FIX: includes staff in staff_logins report ( #6945 )
2019-01-24 14:46:56 +01:00
Vinoth Kannan
c88fd49591
DEV: refactor user preferences path method
2019-01-24 18:39:13 +05:30
Vinoth Kannan
b9bf751b88
FIX: link to the user preferences page is incorrect in user admin page
2019-01-24 18:31:00 +05:30
Joe
dda918f862
UX: removes width constraint in user-card badge section
2019-01-24 20:53:14 +08:00
Angus McLeod
b1297a5f5a
FIX: replaces inline button message with d-button
2019-01-24 13:19:52 +01:00
Arpit Jalan
7ce2d20951
fix the build
2019-01-24 17:22:17 +05:30
Arpit Jalan
fabeba788d
FIX: allow sending PMs to staff via flag even when PMs are disabled ( #6938 )
...
* FIX: allow sending PMs to staff via flag even when PMs are disabled
FIX: allow sending PMs to staff via flag even if the user trust level is insufficient
* Update lib/topic_creator.rb
Co-Authored-By: techAPJ <arpit@techapj.com>
2019-01-24 16:56:59 +05:30
Régis Hanol
cba6bdaf52
UX: use solid circle to indicate selected option in polls
2019-01-24 12:25:37 +01:00
Joffrey JAFFEUX
1f8ff85ff9
FIX: displays user-card when clicking on avatar of post small action ( #6941 )
2019-01-24 10:46:06 +01:00
Joe
22f43abb0e
UX: protection for very wide category-logo images on narrow screens
2019-01-24 17:16:18 +08:00
Rishabh
334bd78516
DEV: Mark discourse-code-review and discourse-yearly-review plugins as official
2019-01-24 13:14:50 +05:30
Kris
12df8c5c82
General style cleanup, removing unused styles
2019-01-23 21:37:39 -05:00
Kris
7d92fa3a5e
Mobile SCSS cleanup and removing unused styles
2019-01-23 14:36:53 -05:00
Daniel
48c9234545
FIX: Lazy Loading: copy only present srcset
...
When showing a lazy-loaded image, copy the `srcset` property only when
it is actually set. `copyImg.srcset = copyImg.srcset` is not actually a
noop but creates an empty `srcset`, changing content security rules on
the image.
2019-01-23 14:04:43 -05:00